resolve: Do not finalize shadowed bindings by petrochenkov · Pull Request #145113 · rust-lang/rust

petrochenkov · 2025-08-08T16:21:51Z

I.e. do not mark them as used, or non-speculatively loaded, or similar.
Previously they were sometimes finalized during early resolution, causing issues like #144793 (comment).

rustbot · 2025-08-08T16:21:54Z

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler-errors · 2025-08-08T18:26:09Z

Looks like this triggers a new unused warning in the stdlib? Is this intentional? We probably should crater this if so.

@bors2 try
@rustbot author

rustbot · 2025-08-08T18:26:12Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

rust-bors · 2025-08-08T18:26:13Z

⌛ Trying commit 5feb92e with merge 8c500c7…

To cancel the try build, run the command @bors try cancel.

resolve: Do not finalize shadowed bindings

petrochenkov · 2025-08-08T19:01:34Z

Looks like this triggers a new unused warning in the stdlib? Is this intentional?

Yes, some new unused items can be detected now.
It shouldn't be common though.

rust-bors · 2025-08-08T20:42:46Z

☀️ Try build successful (CI)
Build commit: 8c500c7 (8c500c7cefd54fd11d57295f3771d576be9ee415, parent: 2886b36df4a646dd8d82fb65bf0c9d8d96c1f71a)

petrochenkov · 2025-08-08T23:18:22Z

We probably should crater this if so.

@craterbot check

craterbot · 2025-08-08T23:18:53Z

👌 Experiment pr-145113 created and queued.
🤖 Automatically detected try build 8c500c7
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-08-08T23:19:26Z

🚧 Experiment pr-145113 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-08-10T01:37:01Z

🎉 Experiment pr-145113 is completed!
📊 15 regressed and 3 fixed (679020 total)
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

petrochenkov · 2025-08-11T16:04:31Z

🎉 Experiment pr-145113 is completed! 📊 15 regressed and 3 fixed (679020 total) 📰 Open the summary report.
⚠️ If you notice any spurious failure please add them to the denylist! ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

A few new unused import lints, as expected.
@rustbot ready

rustbot · 2025-09-25T17:46:16Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

lcnr · 2025-09-26T08:51:40Z

@bors r+ rollup)never

bors · 2025-09-26T08:51:42Z

📌 Commit f89660e has been approved by lcnr

It is now in the queue for this repository.

lcnr · 2025-09-26T08:51:43Z

@bors r+

bors · 2025-09-26T08:51:45Z

💡 This pull request was already approved, no need to approve it again.

There's another pull request that is currently being tested, blocking this pull request: Rollup of 7 pull requests #147054

bors · 2025-09-26T08:51:46Z

📌 Commit f89660e has been approved by lcnr

It is now in the queue for this repository.

resolve: Do not finalize shadowed bindings I.e. do not mark them as used, or non-speculatively loaded, or similar. Previously they were sometimes finalized during early resolution, causing issues like rust-lang#144793 (comment).

Rollup of 7 pull requests Successful merges: - #145113 (resolve: Do not finalize shadowed bindings) - #146523 (Demote both armebv7r-none-* targets.) - #146778 (Use standard attribute logic for allocator shim) - #147016 (fix doc comments to be more standard) - #147027 (Add new `tyalias` intra-doc link disambiguator) - #147031 (mbe: Simplify check_redundant_vis_repetition) - #147046 (Rename `rust.use-lld` to `rust.bootstrap-override-lld`) r? `@ghost` `@rustbot` modify labels: rollup

resolve: Do not finalize shadowed bindings I.e. do not mark them as used, or non-speculatively loaded, or similar. Previously they were sometimes finalized during early resolution, causing issues like rust-lang#144793 (comment).

Rollup of 10 pull requests Successful merges: - #145113 (resolve: Do not finalize shadowed bindings) - #146523 (Demote both armebv7r-none-* targets.) - #146704 (port `#[debugger_visualizer]` to the new attribute system) - #146758 (Stop linking rs{begin,end} objects on x86_64-*-windows-gnu) - #146778 (Use standard attribute logic for allocator shim) - #146849 (Reduce some uses of `LegacyBang`) - #147016 (fix doc comments to be more standard) - #147027 (Add new `tyalias` intra-doc link disambiguator) - #147031 (mbe: Simplify check_redundant_vis_repetition) - #147058 (Ignore more failing ui tests for GCC backend) Failed merges: - #147046 (Rename `rust.use-lld` to `rust.bootstrap-override-lld`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #145113 - petrochenkov:lessfinalize, r=lcnr resolve: Do not finalize shadowed bindings I.e. do not mark them as used, or non-speculatively loaded, or similar. Previously they were sometimes finalized during early resolution, causing issues like #144793 (comment).

Rollup of 10 pull requests Successful merges: - rust-lang/rust#145113 (resolve: Do not finalize shadowed bindings) - rust-lang/rust#146523 (Demote both armebv7r-none-* targets.) - rust-lang/rust#146704 (port `#[debugger_visualizer]` to the new attribute system) - rust-lang/rust#146758 (Stop linking rs{begin,end} objects on x86_64-*-windows-gnu) - rust-lang/rust#146778 (Use standard attribute logic for allocator shim) - rust-lang/rust#146849 (Reduce some uses of `LegacyBang`) - rust-lang/rust#147016 (fix doc comments to be more standard) - rust-lang/rust#147027 (Add new `tyalias` intra-doc link disambiguator) - rust-lang/rust#147031 (mbe: Simplify check_redundant_vis_repetition) - rust-lang/rust#147058 (Ignore more failing ui tests for GCC backend) Failed merges: - rust-lang/rust#147046 (Rename `rust.use-lld` to `rust.bootstrap-override-lld`) r? `@ghost` `@rustbot` modify labels: rollup

resolve: Do not finalize shadowed bindings I.e. do not mark them as used, or non-speculatively loaded, or similar. Previously they were sometimes finalized during early resolution, causing issues like rust-lang#144793 (comment).

Rollup of 10 pull requests Successful merges: - rust-lang/rust#145113 (resolve: Do not finalize shadowed bindings) - rust-lang/rust#146523 (Demote both armebv7r-none-* targets.) - rust-lang/rust#146704 (port `#[debugger_visualizer]` to the new attribute system) - rust-lang/rust#146758 (Stop linking rs{begin,end} objects on x86_64-*-windows-gnu) - rust-lang/rust#146778 (Use standard attribute logic for allocator shim) - rust-lang/rust#146849 (Reduce some uses of `LegacyBang`) - rust-lang/rust#147016 (fix doc comments to be more standard) - rust-lang/rust#147027 (Add new `tyalias` intra-doc link disambiguator) - rust-lang/rust#147031 (mbe: Simplify check_redundant_vis_repetition) - rust-lang/rust#147058 (Ignore more failing ui tests for GCC backend) Failed merges: - rust-lang/rust#147046 (Rename `rust.use-lld` to `rust.bootstrap-override-lld`) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned BoxyUwU Aug 8, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 8, 2025

petrochenkov mentioned this pull request Aug 8, 2025
resolve: Split extern prelude into two scopes #144793
Merged

This comment has been minimized.
Sign in to view

rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2025

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 8, 2025

rust-borsBot added a commit that referenced this pull request Aug 8, 2025
Auto merge of#145113- petrochenkov:lessfinalize, r=<try>
8c500c7
resolve: Do not finalize shadowed bindings

BoxyUwU removed their assignment Aug 8, 2025

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 8, 2025

compiler-errors self-assigned this Aug 9, 2025

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 10, 2025

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2025

petrochenkov force-pushed the lessfinalize branch from 5feb92e to a4b67f7Compare August 11, 2025 16:03

rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) O-unix Operating system: Unix-like labels Aug 11, 2025

petrochenkov force-pushed the lessfinalize branch from 81acd32 to f89660eCompare September 25, 2025 17:46

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 26, 2025

matthiaskrgr mentioned this pull request Sep 26, 2025
Rollup of 7 pull requests #147059
Closed

matthiaskrgr mentioned this pull request Sep 26, 2025
Rollup of 6 pull requests #147064
Closed

This was referenced Sep 26, 2025
Rollup of 11 pull requests #147073
Closed
Rollup of 10 pull requests #147074
Merged

bors merged commit f104ae4 into rust-lang:masterSep 27, 2025
10 checks passed

rustbot added this to the 1.92.0 milestone Sep 27, 2025

matthiaskrgr mentioned this pull request Oct 1, 2025
ICE import.imported_module.get().is_none()#147208
Closed

petrochenkov mentioned this pull request Oct 20, 2025
Should importing a #[macro_export] macro_rules! macro trigger unused_imports? #147823
Open

madsmtm mentioned this pull request Oct 26, 2025
Regression with unused_imports on macro used in documentation #148143
Closed

petrochenkov deleted the lessfinalize branch June 17, 2026 14:55

Uh oh!

Uh oh!

Conversation

petrochenkov commented Aug 8, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 8, 2025

Uh oh!

This comment has been minimized.

compiler-errors commented Aug 8, 2025

Uh oh!

rustbot commented Aug 8, 2025

Uh oh!

rust-borsBot commented Aug 8, 2025

Uh oh!

petrochenkov commented Aug 8, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-borsBot commented Aug 8, 2025

Uh oh!

petrochenkov commented Aug 8, 2025

Uh oh!

craterbot commented Aug 8, 2025

Uh oh!

craterbot commented Aug 8, 2025

Uh oh!

craterbot commented Aug 10, 2025

Uh oh!

petrochenkov commented Aug 11, 2025

Uh oh!

rustbot commented Sep 25, 2025

Uh oh!

lcnr commented Sep 26, 2025

Uh oh!

bors commented Sep 26, 2025

Uh oh!

lcnr commented Sep 26, 2025

Uh oh!

bors commented Sep 26, 2025

Uh oh!

bors commented Sep 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

petrochenkov commented Aug 8, 2025•
edited
Loading

petrochenkov commented Aug 8, 2025•
edited
Loading