Skip to content

chore(ci): upgrade checkout to v5 - #145289

Merged
bors merged 1 commit into
rust-lang:masterfrom
rejected-l:master
Aug 13, 2025
Merged

chore(ci): upgrade checkout to v5#145289
bors merged 1 commit into
rust-lang:masterfrom
rejected-l:master

Conversation

@rejected-l

@rejected-lrejected-l commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

Maintenance update to actions/checkout@v5 to align with the current runner stack (Node 24); nothing else modified.

Release notes: https://github.com/actions/checkout/releases/tag/v5.0.0

@rustbot

rustbot commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added A-CI Area: Our Github Actions CI A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) A-rustc-dev-guide Area: rustc-dev-guide S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 12, 2025
@rustbot

This comment was marked as outdated.

Sign in to view
@bjorn3

bjorn3 commented Aug 12, 2025

Copy link
Copy Markdown
Member

Please make the changes to each tool in a separate PR on their respective repo. Only the root .github/workflows directory is actually tested in this repo and where possible changes to tools should be made in their own repo rather than in this repo.

flip1995
flip1995 reviewed Aug 12, 2025
View reviewed changes

@flip1995flip1995 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What bjorn3 said

Comment threadsrc/tools/clippy/.github/workflows/clippy_dev.yml
@jieyouxujieyouxu added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2025
@rustbotrustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 12, 2025
@rejected-lrejected-l reopened this Aug 12, 2025
@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 12, 2025
@rejected-l

rejected-l commented Aug 12, 2025

Copy link
Copy Markdown
ContributorAuthor

@flip1995@bjorn3

@lnicola

This comment was marked as resolved.

Sign in to view
jieyouxu
jieyouxu requested changes Aug 12, 2025
View reviewed changes
Comment thread.github/workflows/ci.yml
@rejected-l
chore(ci): upgrade checkout to v5
0d72323
chore(ci): upgrade checkout to v5
@jieyouxujieyouxu removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. A-rustc-dev-guide Area: rustc-dev-guide A-compiler-builtins Area: compiler-builtins (https://github.com/rust-lang/compiler-builtins) T-clippy Relevant to the Clippy team. labels Aug 12, 2025
@jieyouxu

This comment was marked as off-topic.

Sign in to view
@jieyouxu

jieyouxu commented Aug 12, 2025

Copy link
Copy Markdown
Member

(Don't have bandwidth atm)
r? infra-ci

@rustbotrustbot assigned jdno and unassigned jieyouxuAug 12, 2025
@Kobzol

Kobzol commented Aug 12, 2025

Copy link
Copy Markdown
Member

No harm in upgrading, I guess.

@bors r+ rollup

@bors

bors commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 0d72323 has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2025
Kobzol added a commit to Kobzol/rust that referenced this pull request Aug 12, 2025
@Kobzol
Rollup merge ofrust-lang#145289- rejected-l:master, r=Kobzol
c05bb73
chore(ci): upgrade checkout to v5
Maintenance update to actions/checkout@v5 to align with the current runner stack (Node 24); nothing else modified.
Release notes: https://github.com/actions/checkout/releases/tag/v5.0.0
@KobzolKobzol mentioned this pull request Aug 12, 2025
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 12, 2025
@jhpratt
Rollup merge ofrust-lang#145289- rejected-l:master, r=Kobzol
581a7ce
chore(ci): upgrade checkout to v5
Maintenance update to actions/checkout@v5 to align with the current runner stack (Node 24); nothing else modified.
Release notes: https://github.com/actions/checkout/releases/tag/v5.0.0
@jhprattjhpratt mentioned this pull request Aug 12, 2025
Closed
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 12, 2025
@jhpratt
Rollup merge ofrust-lang#145289- rejected-l:master, r=Kobzol
8095423
chore(ci): upgrade checkout to v5
Maintenance update to actions/checkout@v5 to align with the current runner stack (Node 24); nothing else modified.
Release notes: https://github.com/actions/checkout/releases/tag/v5.0.0
@jhprattjhpratt mentioned this pull request Aug 12, 2025
Closed
bors added a commit that referenced this pull request Aug 12, 2025
@bors
Auto merge of#145319- jhpratt:rollup-caakzqo, r=jhpratt
e0125ac
Rollup of 7 pull requests
Successful merges:
- #144642 (editorconfig: don't trim trailing whitespace in tests)
- #144955 (search graph: lazily update parent goals)
- #145153 (Handle macros with multiple kinds, and improve errors)
- #145250 (Add regression test for former ICE involving malformed meta items containing interpolated tokens)
- #145269 (Deprecate RUST_TEST_* env variables)
- #145289 (chore(ci): upgrade checkout to v5)
- #145303 (Docs: Link to payload_as_str() from payload().)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Aug 13, 2025
@bors
Auto merge of#145319- jhpratt:rollup-caakzqo, r=jhpratt
87f770e
Rollup of 7 pull requests
Successful merges:
- #144642 (editorconfig: don't trim trailing whitespace in tests)
- #144955 (search graph: lazily update parent goals)
- #145153 (Handle macros with multiple kinds, and improve errors)
- #145250 (Add regression test for former ICE involving malformed meta items containing interpolated tokens)
- #145269 (Deprecate RUST_TEST_* env variables)
- #145289 (chore(ci): upgrade checkout to v5)
- #145303 (Docs: Link to payload_as_str() from payload().)
r? `@ghost`
`@rustbot` modify labels: rollup
@KobzolKobzol mentioned this pull request Aug 13, 2025
Merged
bors added a commit that referenced this pull request Aug 13, 2025
@bors
Auto merge of#145334- Kobzol:rollup-fs5a133, r=Kobzol
1c9952f
Rollup of 11 pull requests
Successful merges:
- #143467 (Add ASCII-related methods from `u8` and `MIN`/`MAX` to `core::ascii::Char`)
- #144519 (Constify `SystemTime` methods)
- #144642 (editorconfig: don't trim trailing whitespace in tests)
- #144870 (Stabilize `path_file_prefix` feature)
- #145269 (Deprecate RUST_TEST_* env variables)
- #145274 (Remove unused `#[must_use]`)
- #145289 (chore(ci): upgrade checkout to v5)
- #145303 (Docs: Link to payload_as_str() from payload().)
- #145308 (Adjust documentation of `dangling`)
- #145320 (Allow cross-compiling the Cranelift dist component)
- #145325 (Add `cast_init` and `cast_uninit` methods for pointers)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 6e14364 into rust-lang:masterAug 13, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 13, 2025
rust-timer added a commit that referenced this pull request Aug 13, 2025
@rust-timer
Unrolled build for#145289
cd1cbb2
Rollup merge of #145289 - rejected-l:master, r=Kobzol
chore(ci): upgrade checkout to v5
Maintenance update to actions/checkout@v5 to align with the current runner stack (Node 24); nothing else modified.
Release notes: https://github.com/actions/checkout/releases/tag/v5.0.0
@reddevilmidzyreddevilmidzy mentioned this pull request Nov 24, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flip1995flip1995flip1995 left review comments
@jieyouxujieyouxujieyouxu requested changes

Assignees

@jdnojdno

Labels

A-CIArea: Our Github Actions CIS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

10 participants

@rejected-l@rustbot@bjorn3@lnicola@jieyouxu@Kobzol@bors@flip1995@wesleywiser@jdno