Skip to content

Rehome tests/ui/issues/ tests to other subdirectories under tests/ui/ - #145332

Closed
Oneirical wants to merge 1 commit into
rust-lang:masterfrom
Oneirical:uncountable-integer-5a
Closed

Rehome tests/ui/issues/ tests to other subdirectories under tests/ui/#145332
Oneirical wants to merge 1 commit into
rust-lang:masterfrom
Oneirical:uncountable-integer-5a

Conversation

@Oneirical

Copy link
Copy Markdown
Contributor

Part of #133895

Methodology:

  1. Refer to the previously written tests/ui/SUMMARY.md
  2. Find an appropriate category for the test, using the original issue thread and the test contents.
  3. Add the issue URL at the bottom (not at the top, as that would mess up stderr line numbers)
  4. Rename the tests to make their purpose clearer

Inspired by the methodology that @Kivooeo was using.

r? @jieyouxu

@rustbot

Copy link
Copy Markdown
Collaborator

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 13, 2025
@rust-log-analyzer

This comment has been minimized.

@Oneirical
Oneiricalforce-pushed the uncountable-integer-5a branch from 41078c1 to 4ca6bb0CompareAugust 13, 2025 16:06
@rust-log-analyzer

This comment has been minimized.

@Oneirical
Oneiricalforce-pushed the uncountable-integer-5a branch from 4ca6bb0 to 5a5d629CompareAugust 14, 2025 01:03
@rust-log-analyzer

This comment has been minimized.

@Oneirical
Oneiricalforce-pushed the uncountable-integer-5a branch from 5a5d629 to 4f8c57dCompareAugust 14, 2025 02:47
@rust-log-analyzer

This comment has been minimized.

@Oneirical
Oneiricalforce-pushed the uncountable-integer-5a branch from 4f8c57d to b70dd3fCompareAugust 14, 2025 03:34
@Oneirical
Oneirical marked this pull request as ready for review August 14, 2025 11:04
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 14, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

@bors

bors commented Aug 15, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #145085) made this pull request unmergeable. Please resolve the merge conflicts.

@jieyouxu

Copy link
Copy Markdown
Member

Intended to be split
@rustbot author

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@Oneirical
Oneiricalforce-pushed the uncountable-integer-5a branch from b70dd3f to a945860CompareAugust 19, 2025 23:05
@rustbot

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Oneirical
Oneiricalforce-pushed the uncountable-integer-5a branch from a945860 to cbffba6CompareAugust 19, 2025 23:20
@rust-log-analyzer

This comment has been minimized.

@Oneirical
Oneiricalforce-pushed the uncountable-integer-5a branch from cbffba6 to 76c8714CompareAugust 19, 2025 23:30
@rust-log-analyzer

This comment has been minimized.

@Oneirical
Oneiricalforce-pushed the uncountable-integer-5a branch from 76c8714 to e8e18cdCompareAugust 20, 2025 01:55
@bors

bors commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #145644) made this pull request unmergeable. Please resolve the merge conflicts.

@Oneirical
Oneiricalforce-pushed the uncountable-integer-5a branch from e8e18cd to 1db10b7CompareAugust 20, 2025 16:55
@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbotrustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 20, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Oneirical@rustbot@rust-log-analyzer@bors@jieyouxu