Skip to content

[rustdoc] Revert "rustdoc search: prefer stable items in search results" - #145389

Merged
bors merged 4 commits into
rust-lang:masterfrom
GuillaumeGomez:unstable-search
Aug 15, 2025
Merged

[rustdoc] Revert "rustdoc search: prefer stable items in search results"#145389
bors merged 4 commits into
rust-lang:masterfrom
GuillaumeGomez:unstable-search

Conversation

@GuillaumeGomez

@GuillaumeGomezGuillaumeGomez commented Aug 14, 2025•
edited by fmease
Loading

Copy link
Copy Markdown
Member

Reverts #141658 and reverts #145349.

Reopens #138067.

r? @fmease

@rustbot

rustbot commented Aug 14, 2025

Copy link
Copy Markdown
Collaborator

fmease is currently at their maximum review capacity.
They may take a while to respond.

@rustbotrustbot added A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 14, 2025
@rustbot

rustbot commented Aug 14, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

@fmease

fmease commented Aug 14, 2025•
edited
Loading

Copy link
Copy Markdown
Member

You gonna want to drop the last commit 76f1e93, right? That's not a revert but remnant from #145386.

@fmease

fmease commented Aug 14, 2025

Copy link
Copy Markdown
Member

r=me with the non-revert commit dropped.

@fmeasefmease mentioned this pull request Aug 14, 2025
Open
@fmeasefmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2025
@GuillaumeGomez

GuillaumeGomez commented Aug 14, 2025

Copy link
Copy Markdown
MemberAuthor

How did it end up there? O.o

@fmease

fmease commented Aug 14, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Aug 14, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit a195cf6 has been approved by fmease

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 14, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 14, 2025
@GuillaumeGomez
Rollup merge ofrust-lang#145389- GuillaumeGomez:unstable-search, r=…
d105953
…fmease
[rustdoc] Revert "rustdoc search: prefer stable items in search results"
Reverts rust-lang#141658 and reverts rust-lang#145349.
Reopens rust-lang#138067.
r? `@fmease`
@GuillaumeGomezGuillaumeGomez mentioned this pull request Aug 14, 2025
Closed
bors added a commit that referenced this pull request Aug 14, 2025
@bors
Auto merge of#145394- GuillaumeGomez:rollup-wrhcycn, r=GuillaumeGomez
3c5ecc5
Rollup of 9 pull requests
Successful merges:
- #118087 (Add Ref/RefMut try_map method)
- #140794 (Add information about group a lint belongs to)
- #144947 (Fix description of unsigned `checked_exact_div`)
- #145005 (strip prefix of temporary file names when it exceeds filesystem name length limit)
- #145233 (cfg_select: Support unbraced expressions)
- #145243 (take attr style into account in diagnostics)
- #145353 (bootstrap: Fix jemalloc 64K page support for aarch64 tools)
- #145379 (bootstrap: Support passing `--timings` to cargo)
- #145389 ([rustdoc] Revert "rustdoc search: prefer stable items in search results")
Failed merges:
- #144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`)
- #145065 (resolve: Introduce `RibKind::Block`)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 15, 2025
@Zalathar
Rollup merge ofrust-lang#145389- GuillaumeGomez:unstable-search, r=…
8677b73
…fmease
[rustdoc] Revert "rustdoc search: prefer stable items in search results"
Reverts rust-lang#141658 and reverts rust-lang#145349.
Reopens rust-lang#138067.
r? ``@fmease``
@ZalatharZalathar mentioned this pull request Aug 15, 2025
Closed
bors added a commit that referenced this pull request Aug 15, 2025
@bors
Auto merge of#145418- Zalathar:rollup-qgoixs3, r=Zalathar
f4b87c1
Rollup of 22 pull requests
Successful merges:
- #118087 (Add Ref/RefMut try_map method)
- #122661 (Change the desugaring of `assert!` for better error output)
- #140740 (Add `-Zindirect-branch-cs-prefix`)
- #142640 (Implement autodiff using intrinsics)
- #143075 (compiler: Allow `extern "interrupt" fn() -> !`)
- #144865 (Fix tail calls to `#[track_caller]` functions)
- #144944 (E0793: Clarify that it applies to unions as well)
- #144947 (Fix description of unsigned `checked_exact_div`)
- #145004 (Couple of minor cleanups)
- #145005 (strip prefix of temporary file names when it exceeds filesystem name length limit)
- #145012 (Tail call diagnostics to include lifetime info)
- #145065 (resolve: Introduce `RibKind::Block`)
- #145120 (llvm: Accept new LLVM lifetime format)
- #145189 (Weekly `cargo update`)
- #145235 (Minor `[const]` tweaks)
- #145275 (fix(compiler/rustc_codegen_llvm): apply `target-cpu` attribute)
- #145322 (Resolve the prelude import in `build_reduced_graph`)
- #145331 (Make std use the edition 2024 prelude)
- #145369 (Do not ICE on private type in field of unresolved struct)
- #145378 (Add `FnContext` in parser for diagnostic)
- #145389 ([rustdoc] Revert "rustdoc search: prefer stable items in search results")
- #145392 (coverage: Remove intermediate data structures from mapping creation)
r? `@ghost`
`@rustbot` modify labels: rollup
@ZalatharZalathar mentioned this pull request Aug 15, 2025
Merged
bors added a commit that referenced this pull request Aug 15, 2025
@bors
Auto merge of#145423- Zalathar:rollup-9jtefpl, r=Zalathar
ba412a6
Rollup of 21 pull requests
Successful merges:
- #118087 (Add Ref/RefMut try_map method)
- #122661 (Change the desugaring of `assert!` for better error output)
- #142640 (Implement autodiff using intrinsics)
- #143075 (compiler: Allow `extern "interrupt" fn() -> !`)
- #144865 (Fix tail calls to `#[track_caller]` functions)
- #144944 (E0793: Clarify that it applies to unions as well)
- #144947 (Fix description of unsigned `checked_exact_div`)
- #145004 (Couple of minor cleanups)
- #145005 (strip prefix of temporary file names when it exceeds filesystem name length limit)
- #145012 (Tail call diagnostics to include lifetime info)
- #145065 (resolve: Introduce `RibKind::Block`)
- #145120 (llvm: Accept new LLVM lifetime format)
- #145189 (Weekly `cargo update`)
- #145235 (Minor `[const]` tweaks)
- #145275 (fix(compiler/rustc_codegen_llvm): apply `target-cpu` attribute)
- #145322 (Resolve the prelude import in `build_reduced_graph`)
- #145331 (Make std use the edition 2024 prelude)
- #145369 (Do not ICE on private type in field of unresolved struct)
- #145378 (Add `FnContext` in parser for diagnostic)
- #145389 ([rustdoc] Revert "rustdoc search: prefer stable items in search results")
- #145392 (coverage: Remove intermediate data structures from mapping creation)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 21d37d0 into rust-lang:masterAug 15, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 15, 2025
rust-timer added a commit that referenced this pull request Aug 15, 2025
@rust-timer
Unrolled build for#145389
fe5ad0e
Rollup merge of #145389 - GuillaumeGomez:unstable-search, r=fmease
[rustdoc] Revert "rustdoc search: prefer stable items in search results"
Reverts #141658 and reverts #145349.
Reopens #138067.
r? ```@fmease```
@GuillaumeGomez
GuillaumeGomez deleted the unstable-search branch August 15, 2025 12:53
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 18, 2025
@bors
Auto merge of #145423 - Zalathar:rollup-9jtefpl, r=Zalathar
2446ebf
Rollup of 21 pull requests
Successful merges:
- rust-lang/rust#118087 (Add Ref/RefMut try_map method)
- rust-lang/rust#122661 (Change the desugaring of `assert!` for better error output)
- rust-lang/rust#142640 (Implement autodiff using intrinsics)
- rust-lang/rust#143075 (compiler: Allow `extern "interrupt" fn() -> !`)
- rust-lang/rust#144865 (Fix tail calls to `#[track_caller]` functions)
- rust-lang/rust#144944 (E0793: Clarify that it applies to unions as well)
- rust-lang/rust#144947 (Fix description of unsigned `checked_exact_div`)
- rust-lang/rust#145004 (Couple of minor cleanups)
- rust-lang/rust#145005 (strip prefix of temporary file names when it exceeds filesystem name length limit)
- rust-lang/rust#145012 (Tail call diagnostics to include lifetime info)
- rust-lang/rust#145065 (resolve: Introduce `RibKind::Block`)
- rust-lang/rust#145120 (llvm: Accept new LLVM lifetime format)
- rust-lang/rust#145189 (Weekly `cargo update`)
- rust-lang/rust#145235 (Minor `[const]` tweaks)
- rust-lang/rust#145275 (fix(compiler/rustc_codegen_llvm): apply `target-cpu` attribute)
- rust-lang/rust#145322 (Resolve the prelude import in `build_reduced_graph`)
- rust-lang/rust#145331 (Make std use the edition 2024 prelude)
- rust-lang/rust#145369 (Do not ICE on private type in field of unresolved struct)
- rust-lang/rust#145378 (Add `FnContext` in parser for diagnostic)
- rust-lang/rust#145389 ([rustdoc] Revert "rustdoc search: prefer stable items in search results")
- rust-lang/rust#145392 (coverage: Remove intermediate data structures from mapping creation)
r? `@ghost`
`@rustbot` modify labels: rollup
@github-actionsgithub-actionsBot mentioned this pull request Aug 18, 2025
Merged
@jieyouxujieyouxu mentioned this pull request Aug 31, 2025
Open
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
@bors
Auto merge of #145423 - Zalathar:rollup-9jtefpl, r=Zalathar
4640daf
Rollup of 21 pull requests
Successful merges:
- rust-lang/rust#118087 (Add Ref/RefMut try_map method)
- rust-lang/rust#122661 (Change the desugaring of `assert!` for better error output)
- rust-lang/rust#142640 (Implement autodiff using intrinsics)
- rust-lang/rust#143075 (compiler: Allow `extern "interrupt" fn() -> !`)
- rust-lang/rust#144865 (Fix tail calls to `#[track_caller]` functions)
- rust-lang/rust#144944 (E0793: Clarify that it applies to unions as well)
- rust-lang/rust#144947 (Fix description of unsigned `checked_exact_div`)
- rust-lang/rust#145004 (Couple of minor cleanups)
- rust-lang/rust#145005 (strip prefix of temporary file names when it exceeds filesystem name length limit)
- rust-lang/rust#145012 (Tail call diagnostics to include lifetime info)
- rust-lang/rust#145065 (resolve: Introduce `RibKind::Block`)
- rust-lang/rust#145120 (llvm: Accept new LLVM lifetime format)
- rust-lang/rust#145189 (Weekly `cargo update`)
- rust-lang/rust#145235 (Minor `[const]` tweaks)
- rust-lang/rust#145275 (fix(compiler/rustc_codegen_llvm): apply `target-cpu` attribute)
- rust-lang/rust#145322 (Resolve the prelude import in `build_reduced_graph`)
- rust-lang/rust#145331 (Make std use the edition 2024 prelude)
- rust-lang/rust#145369 (Do not ICE on private type in field of unresolved struct)
- rust-lang/rust#145378 (Add `FnContext` in parser for diagnostic)
- rust-lang/rust#145389 ([rustdoc] Revert "rustdoc search: prefer stable items in search results")
- rust-lang/rust#145392 (coverage: Remove intermediate data structures from mapping creation)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmeasefmeasefmease approved these changes

Assignees

@fmeasefmease

Labels

A-rustdoc-searchArea: Rustdoc's search featureS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez@rustbot@fmease@bors