Skip to content

cleanup: use run_in_tmpdir in run-make/rustdoc-scrape-examples-paths - #145405

Merged
bors merged 1 commit into
rust-lang:masterfrom
durin42:test-cleanup-tmpdir
Aug 19, 2025
Merged

cleanup: use run_in_tmpdir in run-make/rustdoc-scrape-examples-paths#145405
bors merged 1 commit into
rust-lang:masterfrom
durin42:test-cleanup-tmpdir

Conversation

@durin42

@durin42durin42 commented Aug 14, 2025

Copy link
Copy Markdown
Contributor

We had an issue on our LLVM-head Rust builder where it got stuck with this test failing because it was reusing the tmpdir between runs and something broke the incremental compile. Everything seems to work fine with run_in_tmpdir in this test. tests/run-make/uefi-qemu also uses the same tmpdir across runs, but I don't have the right environment to test that so I didn't try fixing it. That is the only use of std::env::temp_dir left in run-make tests after this fix.

@rustbot

rustbot commented Aug 14, 2025

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 14, 2025
lqd
lqd reviewed Aug 14, 2025
View reviewed changes
Comment threadtests/run-make/rustdoc-scrape-examples-paths/rmake.rs Outdated
Comment threadtests/run-make/rustdoc-scrape-examples-paths/rmake.rs
lqd
lqd reviewed Aug 14, 2025
View reviewed changes
Comment threadtests/run-make/rustdoc-scrape-examples-paths/rmake.rs
@jieyouxu

jieyouxu commented Aug 15, 2025

Copy link
Copy Markdown
Member

r? lqd (since you're reviewing it already)

@rustbotrustbot assigned lqd and unassigned jieyouxuAug 15, 2025
@durin42
durin42force-pushed the test-cleanup-tmpdir branch from 8a79b3d to 91cd947CompareAugust 15, 2025 18:49
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@durin42
durin42force-pushed the test-cleanup-tmpdir branch from 91cd947 to 82c0a8bCompareAugust 15, 2025 19:30
@durin42

durin42 commented Aug 18, 2025

Copy link
Copy Markdown
ContributorAuthor

@rustbot label llvm-main

(I think this will fix our llvm-HEAD CI)

@rustbotrustbot added llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2025
@rustbot

rustbot commented Aug 18, 2025

Copy link
Copy Markdown
Collaborator

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@durin42

durin42 commented Aug 18, 2025

Copy link
Copy Markdown
ContributorAuthor

@rustbot ready

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 18, 2025
@durin42
cleanup: make run-make test use run_in_tmpdir
79d3006
We had an issue on our LLVM-head Rust builder where it got stuck with
this test failing because it was reusing the tmpdir between runs and
something broke the incremental compile. Everything seems to work fine
with run_in_tmpdir in this test. tests/run-make/uefi-qemu also uses the
same tmpdir across runs, but I don't have the right environment to test
that so I didn't try fixing it. That is the only use of
std::env::temp_dir left in run-make tests after this fix.
@durin42
durin42force-pushed the test-cleanup-tmpdir branch from 82c0a8b to 79d3006CompareAugust 18, 2025 19:29
@lqd

lqd commented Aug 18, 2025

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 18, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 79d3006 has been approved by lqd

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 18, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 19, 2025
@Zalathar
Rollup merge ofrust-lang#145405- durin42:test-cleanup-tmpdir, r=lqd
32eabc5
cleanup: use run_in_tmpdir in run-make/rustdoc-scrape-examples-paths
We had an issue on our LLVM-head Rust builder where it got stuck with this test failing because it was reusing the tmpdir between runs and something broke the incremental compile. Everything seems to work fine with run_in_tmpdir in this test. tests/run-make/uefi-qemu also uses the same tmpdir across runs, but I don't have the right environment to test that so I didn't try fixing it. That is the only use of std::env::temp_dir left in run-make tests after this fix.
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 19, 2025
@Zalathar
Rollup merge ofrust-lang#145405- durin42:test-cleanup-tmpdir, r=lqd
b11ef8d
cleanup: use run_in_tmpdir in run-make/rustdoc-scrape-examples-paths
We had an issue on our LLVM-head Rust builder where it got stuck with this test failing because it was reusing the tmpdir between runs and something broke the incremental compile. Everything seems to work fine with run_in_tmpdir in this test. tests/run-make/uefi-qemu also uses the same tmpdir across runs, but I don't have the right environment to test that so I didn't try fixing it. That is the only use of std::env::temp_dir left in run-make tests after this fix.
@ZalatharZalathar mentioned this pull request Aug 19, 2025
Merged
bors added a commit that referenced this pull request Aug 19, 2025
@bors
Auto merge of#145589- Zalathar:rollup-k97wtuq, r=Zalathar
8365fcb
Rollup of 19 pull requests
Successful merges:
- #140956 (`impl PartialEq<{str,String}> for {Path,PathBuf}`)
- #141744 (Stabilize `ip_from`)
- #142681 (Remove the `#[no_sanitize]` attribute in favor of `#[sanitize(xyz = "on|off")]`)
- #142871 (Trivial improve doc for transpose )
- #144252 (Do not copy .rmeta files into the sysroot of the build compiler during check of rustc/std)
- #144476 (rustdoc-search: search backend with partitioned suffix tree)
- #144567 (Fix RISC-V Test Failures in ./x test for Multiple Codegen Cases)
- #144804 (Don't warn on never to any `as` casts as unreachable)
- #144960 ([RTE-513] Ignore sleep_until test on SGX)
- #145013 (overhaul `&mut` suggestions in borrowck errors)
- #145041 (rework GAT borrowck limitation error)
- #145243 (take attr style into account in diagnostics)
- #145405 (cleanup: use run_in_tmpdir in run-make/rustdoc-scrape-examples-paths)
- #145432 (cg_llvm: Small cleanups to `owned_target_machine`)
- #145484 (Remove `LlvmArchiveBuilder` and supporting code/bindings)
- #145557 (Fix uplifting in `Assemble` step)
- #145563 (Remove the `From` derive macro from prelude)
- #145565 (Improve context of bootstrap errors in CI)
- #145584 (interpret: avoid forcing all integer newtypes into memory during clear_provenance)
Failed merges:
- #145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one)
- #145573 (Add an experimental unsafe(force_target_feature) attribute.)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 02848e7 into rust-lang:masterAug 19, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 19, 2025
rust-timer added a commit that referenced this pull request Aug 19, 2025
@rust-timer
Unrolled build for#145405
64f828d
Rollup merge of #145405 - durin42:test-cleanup-tmpdir, r=lqd
cleanup: use run_in_tmpdir in run-make/rustdoc-scrape-examples-paths
We had an issue on our LLVM-head Rust builder where it got stuck with this test failing because it was reusing the tmpdir between runs and something broke the incremental compile. Everything seems to work fine with run_in_tmpdir in this test. tests/run-make/uefi-qemu also uses the same tmpdir across runs, but I don't have the right environment to test that so I didn't try fixing it. That is the only use of std::env::temp_dir left in run-make tests after this fix.
@Zalathar

Zalathar commented Aug 19, 2025

Copy link
Copy Markdown
Member

Bors hasn't noticed that this was merged.

@bors r- retry

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 19, 2025
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 25, 2025
@bors
Auto merge of #145589 - Zalathar:rollup-k97wtuq, r=Zalathar
9932c4b
Rollup of 19 pull requests
Successful merges:
- rust-lang/rust#140956 (`impl PartialEq<{str,String}> for {Path,PathBuf}`)
- rust-lang/rust#141744 (Stabilize `ip_from`)
- rust-lang/rust#142681 (Remove the `#[no_sanitize]` attribute in favor of `#[sanitize(xyz = "on|off")]`)
- rust-lang/rust#142871 (Trivial improve doc for transpose )
- rust-lang/rust#144252 (Do not copy .rmeta files into the sysroot of the build compiler during check of rustc/std)
- rust-lang/rust#144476 (rustdoc-search: search backend with partitioned suffix tree)
- rust-lang/rust#144567 (Fix RISC-V Test Failures in ./x test for Multiple Codegen Cases)
- rust-lang/rust#144804 (Don't warn on never to any `as` casts as unreachable)
- rust-lang/rust#144960 ([RTE-513] Ignore sleep_until test on SGX)
- rust-lang/rust#145013 (overhaul `&mut` suggestions in borrowck errors)
- rust-lang/rust#145041 (rework GAT borrowck limitation error)
- rust-lang/rust#145243 (take attr style into account in diagnostics)
- rust-lang/rust#145405 (cleanup: use run_in_tmpdir in run-make/rustdoc-scrape-examples-paths)
- rust-lang/rust#145432 (cg_llvm: Small cleanups to `owned_target_machine`)
- rust-lang/rust#145484 (Remove `LlvmArchiveBuilder` and supporting code/bindings)
- rust-lang/rust#145557 (Fix uplifting in `Assemble` step)
- rust-lang/rust#145563 (Remove the `From` derive macro from prelude)
- rust-lang/rust#145565 (Improve context of bootstrap errors in CI)
- rust-lang/rust#145584 (interpret: avoid forcing all integer newtypes into memory during clear_provenance)
Failed merges:
- rust-lang/rust#145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one)
- rust-lang/rust#145573 (Add an experimental unsafe(force_target_feature) attribute.)
r? `@ghost`
`@rustbot` modify labels: rollup
@durin42
durin42 deleted the test-cleanup-tmpdir branch October 16, 2025 17:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lqdlqdlqd left review comments

Assignees

@lqdlqd

Labels

A-run-makeArea: port run-make Makefiles to rmake.rsllvm-mainMarks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

7 participants

@durin42@rustbot@jieyouxu@rust-log-analyzer@lqd@bors@Zalathar