Skip to content

Stabilize BTree{Map,Set}::extract_if - #145471

Merged
bors merged 1 commit into
rust-lang:masterfrom
rs-sac:extr
Sep 13, 2025
Merged

Stabilize BTree{Map,Set}::extract_if#145471
bors merged 1 commit into
rust-lang:masterfrom
rs-sac:extr

Conversation

@rs-sac

@rs-sacrs-sac commented Aug 15, 2025

Copy link
Copy Markdown
Contributor

Tracking issue: #70530
FCP completed: #70530 (comment)
Closes: #70530

@rustbot

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 15, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

The Miri subtree was changed

cc @rust-lang/miri

@rs-sac

Copy link
Copy Markdown
ContributorAuthor

@rustbot r? the8472

Comment threadsrc/tools/miri/tests/pass/btreemap.rs Outdated
@bors

bors commented Aug 27, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #145916) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rs-sac

Copy link
Copy Markdown
ContributorAuthor

@the8472 I went back to stabilization only and rebased. Was there anything else necessary?

@the8472the8472 added T-libs-api [DEPRECATED; DO NOT USE] relnotes Marks issues that should be documented in the release notes of the next release. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 12, 2025
@the8472

Copy link
Copy Markdown
Member

already FCP'd, LGTM

@bors r+ rollup

@bors

bors commented Sep 12, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit f8a7f82 has been approved by the8472

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 12, 2025
bors added a commit that referenced this pull request Sep 13, 2025
Stabilize BTree{Map,Set}::extract_if
Tracking issue: #70530
FCP completed: #70530 (comment)Closes: #70530
@bors

bors commented Sep 13, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit f8a7f82 with merge 5835d5f...

@bors

bors commented Sep 13, 2025

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 13, 2025
@rs-sac

Copy link
Copy Markdown
ContributorAuthor

@the8472 It appears that the i686-msvc-1 job inexplicably got stuck for over one hour.

@tgross35

Copy link
Copy Markdown
Member

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 13, 2025
@jhprattjhpratt mentioned this pull request Sep 13, 2025
bors added a commit that referenced this pull request Sep 13, 2025
Rollup of 5 pull requests
Successful merges:
- #144498 (Add --print target-spec-json-schema)
- #145471 (Stabilize BTree{Map,Set}::extract_if)
- #145896 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#3 of Batch #2])
- #146450 (bootstrap: rustdoc-js tests can now be filtered by js files)
- #146456 (Fix panic and incorrectly suggested examples in `format_args` macro.)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 5b37a1e into rust-lang:masterSep 13, 2025
10 of 11 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Sep 13, 2025
rust-timer added a commit that referenced this pull request Sep 13, 2025
Rollup merge of #145471 - rs-sac:extr, r=the8472
Stabilize BTree{Map,Set}::extract_if
Tracking issue: #70530
FCP completed: #70530 (comment)Closes: #70530
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Sep 14, 2025
Rollup of 5 pull requests
Successful merges:
- rust-lang/rust#144498 (Add --print target-spec-json-schema)
- rust-lang/rust#145471 (Stabilize BTree{Map,Set}::extract_if)
- rust-lang/rust#145896 (Rehome 30 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [rust-lang/rust#3 of Batch rust-lang/rust#2])
- rust-lang/rust#146450 (bootstrap: rustdoc-js tests can now be filtered by js files)
- rust-lang/rust#146456 (Fix panic and incorrectly suggested examples in `format_args` macro.)
r? `@ghost`
`@rustbot` modify labels: rollup
@rs-sac
rs-sac deleted the extr branch September 15, 2025 15:47
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
Stabilize BTree{Map,Set}::extract_if
Tracking issue: rust-lang#70530
FCP completed: rust-lang#70530 (comment)Closes: rust-lang#70530
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

relnotesMarks issues that should be documented in the release notes of the next release.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking Issue for {BTreeMap,BTreeSet}::extract_if

6 participants

@rs-sac@rustbot@bors@the8472@tgross35@Mark-Simulacrum