Fix `unicode_data.rs` mention message by Urgau · Pull Request #145486 · rust-lang/rust

Urgau · 2025-08-16T09:43:22Z

The previous message was weirdly formatted, let's render it properly.

rustbot · 2025-08-16T09:43:26Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-08-16T09:43:27Z

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

lqd

Suggestion: we move the command where the comment says to use the tool. Wdyt?

(modulo formatting: I’m on my phone :3)

lqd · 2025-08-16T10:34:45Z

r? lqd r=me with or without the suggestion

Urgau · 2025-08-16T11:01:18Z

Suggestion: we move the command where the comment says to use the tool. Wdyt?

Sure, done.

@bors r=lqd rollup

bors · 2025-08-16T11:01:21Z

📌 Commit e906a59 has been approved by lqd

It is now in the queue for this repository.

Fix `unicode_data.rs` mention message The [previous message](rust-lang#145479 (comment)) was weirdly formatted, let's render it properly.

Rollup of 19 pull requests Successful merges: - #140956 (`impl PartialEq<{str,String}> for {Path,PathBuf}`) - #141744 (Stabilize `ip_from`) - #144804 (Don't warn on never to any `as` casts as unreachable) - #144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #145025 (run spellcheck as a tidy extra check in ci) - #145041 (rework GAT borrowck limitation error) - #145243 (take attr style into account in diagnostics) - #145359 (Fix bug where `rustdoc-js` tester would not pick the right `search.js` file if there is more than one) - #145429 (Couple of codegen_fn_attrs improvements) - #145452 (Do not strip binaries in bootstrap everytime if they are unchanged) - #145486 (Fix `unicode_data.rs` mention message) - #145489 (library: Migrate from `cfg_if` to `cfg_select`) - #145493 (remove `should_render` in `PrintAttribute` derive) - #145500 (Port must_use to the new target checking) - #145505 (Simplify span caches) - #145511 (Rust build fails on OpenBSD after using file_lock feature) - #145516 (Weekly `cargo update`) - #145533 (Reorder `lto` options from most to least optimizing) - #145550 (Avoid using `()` in `derive(From)` output.) r? `@ghost` `@rustbot` modify labels: rollup

Fix `unicode_data.rs` mention message The [previous message](rust-lang#145479 (comment)) was weirdly formatted, let's render it properly.

Rollup of 33 pull requests Successful merges: - #139345 (Extend `QueryStability` to handle `IntoIterator` implementations) - #140740 (Add `-Zindirect-branch-cs-prefix`) - #142079 (nll-relate: improve hr opaque types support) - #142938 (implement std::fs::set_permissions_nofollow on unix) - #144767 (Correct some grammar in integer documentation) - #144906 (Require approval from t-infra instead of t-release on tier bumps) - #144983 (Rehome 37 `tests/ui/issues/` tests to other subdirectories under `tests/ui/`) - #145025 (run spellcheck as a tidy extra check in ci) - #145166 (suggest using `pub(crate)` for E0364) - #145255 (dec2flt: Provide more valid inputs examples) - #145306 (Add tracing to various miscellaneous functions) - #145336 (Hide docs for `core::unicode`) - #145429 (Couple of codegen_fn_attrs improvements) - #145452 (Do not strip binaries in bootstrap everytime if they are unchanged) - #145464 (Stabilize `const_pathbuf_osstring_new` feature) - #145474 (Properly recover from parenthesized use-bounds (precise capturing lists) plus small cleanups) - #145486 (Fix `unicode_data.rs` mention message) - #145493 (remove `should_render` in `PrintAttribute` derive) - #145505 (Simplify span caches) - #145510 (Visit and print async_fut local for async drop.) - #145511 (Rust build fails on OpenBSD after using file_lock feature) - #145532 (resolve: debug for block module) - #145533 (Reorder `lto` options from most to least optimizing) - #145537 (Do not consider a `T: !Sized` candidate to satisfy a `T: !MetaSized` obligation.) - #145538 (bufreader::Buffer::backshift: don't move the uninit bytes) - #145542 (triagebot: Don't warn no-mentions on subtree updates) - #145549 (Update rust maintainers in openharmony.md) - #145550 (Avoid using `()` in `derive(From)` output.) - #145556 (Allow stability attributes on extern crates) - #145560 (Remove unused `PartialOrd`/`Ord` from bootstrap) - #145568 (ignore frontmatters in `TokenStream::new`) - #145571 (remove myself from some adhoc-groups and pings) - #145576 (Add change tracker entry for `--timings`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - #145338 (actually provide the correct args to coroutine witnesses) - #145429 (Couple of codegen_fn_attrs improvements) - #145452 (Do not strip binaries in bootstrap everytime if they are unchanged) - #145464 (Stabilize `const_pathbuf_osstring_new` feature) - #145474 (Properly recover from parenthesized use-bounds (precise capturing lists) plus small cleanups) - #145486 (Fix `unicode_data.rs` mention message) - #145490 (Trace some basic I/O operations in bootstrap) - #145493 (remove `should_render` in `PrintAttribute` derive) - #145500 (Port must_use to the new target checking) - #145505 (Simplify span caches) - #145510 (Visit and print async_fut local for async drop.) - #145511 (Rust build fails on OpenBSD after using file_lock feature) - #145532 (resolve: debug for block module) - #145533 (Reorder `lto` options from most to least optimizing) - #145537 (Do not consider a `T: !Sized` candidate to satisfy a `T: !MetaSized` obligation.) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #145486 - Urgau:unicode-mention, r=lqd Fix `unicode_data.rs` mention message The [previous message](#145479 (comment)) was weirdly formatted, let's render it properly.

Rollup of 15 pull requests Successful merges: - rust-lang/rust#145338 (actually provide the correct args to coroutine witnesses) - rust-lang/rust#145429 (Couple of codegen_fn_attrs improvements) - rust-lang/rust#145452 (Do not strip binaries in bootstrap everytime if they are unchanged) - rust-lang/rust#145464 (Stabilize `const_pathbuf_osstring_new` feature) - rust-lang/rust#145474 (Properly recover from parenthesized use-bounds (precise capturing lists) plus small cleanups) - rust-lang/rust#145486 (Fix `unicode_data.rs` mention message) - rust-lang/rust#145490 (Trace some basic I/O operations in bootstrap) - rust-lang/rust#145493 (remove `should_render` in `PrintAttribute` derive) - rust-lang/rust#145500 (Port must_use to the new target checking) - rust-lang/rust#145505 (Simplify span caches) - rust-lang/rust#145510 (Visit and print async_fut local for async drop.) - rust-lang/rust#145511 (Rust build fails on OpenBSD after using file_lock feature) - rust-lang/rust#145532 (resolve: debug for block module) - rust-lang/rust#145533 (Reorder `lto` options from most to least optimizing) - rust-lang/rust#145537 (Do not consider a `T: !Sized` candidate to satisfy a `T: !MetaSized` obligation.) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - rust-lang#145338 (actually provide the correct args to coroutine witnesses) - rust-lang#145429 (Couple of codegen_fn_attrs improvements) - rust-lang#145452 (Do not strip binaries in bootstrap everytime if they are unchanged) - rust-lang#145464 (Stabilize `const_pathbuf_osstring_new` feature) - rust-lang#145474 (Properly recover from parenthesized use-bounds (precise capturing lists) plus small cleanups) - rust-lang#145486 (Fix `unicode_data.rs` mention message) - rust-lang#145490 (Trace some basic I/O operations in bootstrap) - rust-lang#145493 (remove `should_render` in `PrintAttribute` derive) - rust-lang#145500 (Port must_use to the new target checking) - rust-lang#145505 (Simplify span caches) - rust-lang#145510 (Visit and print async_fut local for async drop.) - rust-lang#145511 (Rust build fails on OpenBSD after using file_lock feature) - rust-lang#145532 (resolve: debug for block module) - rust-lang#145533 (Reorder `lto` options from most to least optimizing) - rust-lang#145537 (Do not consider a `T: !Sized` candidate to satisfy a `T: !MetaSized` obligation.) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 15 pull requests Successful merges: - rust-lang/rust#145338 (actually provide the correct args to coroutine witnesses) - rust-lang/rust#145429 (Couple of codegen_fn_attrs improvements) - rust-lang/rust#145452 (Do not strip binaries in bootstrap everytime if they are unchanged) - rust-lang/rust#145464 (Stabilize `const_pathbuf_osstring_new` feature) - rust-lang/rust#145474 (Properly recover from parenthesized use-bounds (precise capturing lists) plus small cleanups) - rust-lang/rust#145486 (Fix `unicode_data.rs` mention message) - rust-lang/rust#145490 (Trace some basic I/O operations in bootstrap) - rust-lang/rust#145493 (remove `should_render` in `PrintAttribute` derive) - rust-lang/rust#145500 (Port must_use to the new target checking) - rust-lang/rust#145505 (Simplify span caches) - rust-lang/rust#145510 (Visit and print async_fut local for async drop.) - rust-lang/rust#145511 (Rust build fails on OpenBSD after using file_lock feature) - rust-lang/rust#145532 (resolve: debug for block module) - rust-lang/rust#145533 (Reorder `lto` options from most to least optimizing) - rust-lang/rust#145537 (Do not consider a `T: !Sized` candidate to satisfy a `T: !MetaSized` obligation.) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned Mark-Simulacrum Aug 16, 2025

rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2025

lqd reviewed Aug 16, 2025
View reviewed changes

Comment threadtriagebot.toml Outdated
Comment threadtriagebot.toml Outdated

rustbot assigned lqd and unassigned Mark-Simulacrum Aug 16, 2025

Fix unicode_data.rs mention message
e906a59

Urgau force-pushed the unicode-mention branch from 550bf65 to e906a59Compare August 16, 2025 10:55

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 16, 2025

jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 17, 2025
Rollup merge ofrust-lang#145486- Urgau:unicode-mention, r=lqd
8f70617
Fix `unicode_data.rs` mention message The [previous message](rust-lang#145479 (comment)) was weirdly formatted, let's render it properly.

jhpratt mentioned this pull request Aug 17, 2025
Manual rollup of 19 pull requests #145545
Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 17, 2025
Rollup merge ofrust-lang#145486- Urgau:unicode-mention, r=lqd
506998b
Fix `unicode_data.rs` mention message The [previous message](rust-lang#145479 (comment)) was weirdly formatted, let's render it properly.

jhpratt mentioned this pull request Aug 17, 2025
Rollup of 19 pull requests #145546
Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 18, 2025
Rollup merge ofrust-lang#145486- Urgau:unicode-mention, r=lqd
e70734f
Fix `unicode_data.rs` mention message The [previous message](rust-lang#145479 (comment)) was weirdly formatted, let's render it properly.

Zalathar mentioned this pull request Aug 18, 2025
Rollup of 19 pull requests #145552
Closed

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 18, 2025
Rollup merge ofrust-lang#145486- Urgau:unicode-mention, r=lqd
2442848
Fix `unicode_data.rs` mention message The [previous message](rust-lang#145479 (comment)) was weirdly formatted, let's render it properly.

Zalathar mentioned this pull request Aug 18, 2025
Rollup of 18 pull requests #145566
Closed

jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 18, 2025
Rollup merge ofrust-lang#145486- Urgau:unicode-mention, r=lqd
ae25df7
Fix `unicode_data.rs` mention message The [previous message](rust-lang#145479 (comment)) was weirdly formatted, let's render it properly.

jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 18, 2025
Rollup merge ofrust-lang#145486- Urgau:unicode-mention, r=lqd
32c45a4
Fix `unicode_data.rs` mention message The [previous message](rust-lang#145479 (comment)) was weirdly formatted, let's render it properly.

jhpratt mentioned this pull request Aug 18, 2025
Rollup of 33 pull requests #145588
Closed

jieyouxu mentioned this pull request Aug 19, 2025
Rollup of 15 pull requests #145600
Merged

bors merged commit 32c20b9 into rust-lang:masterAug 19, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 19, 2025

rust-timer added a commit that referenced this pull request Aug 19, 2025
Unrolled build for#145486
52b62cc
Rollup merge of #145486 - Urgau:unicode-mention, r=lqd Fix `unicode_data.rs` mention message The [previous message](#145479 (comment)) was weirdly formatted, let's render it properly.

Navigation Menu

Uh oh!

Uh oh!

Fix `unicode_data.rs` mention message - #145486

Fix `unicode_data.rs` mention message#145486
bors merged 1 commit into
rust-lang:masterfrom
Urgau:unicode-mention

Urgau commented Aug 16, 2025

Uh oh!

rustbot commented Aug 16, 2025

Uh oh!

rustbot commented Aug 16, 2025

Uh oh!

lqd left a comment

Uh oh!

Uh oh!

Uh oh!

lqd commented Aug 16, 2025

Uh oh!

Urgau commented Aug 16, 2025

Uh oh!

bors commented Aug 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

Urgau commented Aug 16, 2025

Uh oh!

rustbot commented Aug 16, 2025

Uh oh!

rustbot commented Aug 16, 2025

Uh oh!

lqd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lqd commented Aug 16, 2025

Uh oh!

Urgau commented Aug 16, 2025

Uh oh!

bors commented Aug 16, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants