Skip to content

rustdoc-search: GUI tests check for // in URL - #145669

Merged
bors merged 1 commit into
rust-lang:masterfrom
notriddle:test-js-search-scripts-path
Aug 23, 2025
Merged

rustdoc-search: GUI tests check for // in URL#145669
bors merged 1 commit into
rust-lang:masterfrom
notriddle:test-js-search-scripts-path

Conversation

@notriddle

@notriddlenotriddle commented Aug 20, 2025

Copy link
Copy Markdown
Contributor

Follow up #145650

When this fails, you get output that looks like:

/home/user/rust/tests/rustdoc-gui/search-result-impl-disambiguation.goml search-result-impl-disambiguation... FAILED
[ERROR] `tests/rustdoc-gui/utils.goml` around line 49
from `tests/rustdoc-gui/search-result-impl-disambiguation.goml` line 25: JS errors occurred: Event: Event

Making the error message more informative requires patching browser-ui-test.

@rustbot

rustbot commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added A-rustdoc-search Area: Rustdoc's search feature S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Aug 20, 2025
@rustbot

rustbot commented Aug 20, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred in GUI tests.

cc @GuillaumeGomez

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

@GuillaumeGomez

GuillaumeGomez commented Aug 20, 2025

Copy link
Copy Markdown
Member

Thanks! r=me once #145650 has been merged and you rebased.

@fmeasefmease added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 20, 2025
@lolbinarycatlolbinarycat mentioned this pull request Aug 20, 2025
Closed
@notriddle
rustdoc-search: GUI tests check for // in URL
53b775d
When this fails, you get output that looks like:
/home/user/rust/tests/rustdoc-gui/search-result-impl-disambiguation.goml search-result-impl-disambiguation... FAILED
[ERROR] `tests/rustdoc-gui/utils.goml` around line 49
from `tests/rustdoc-gui/search-result-impl-disambiguation.goml` line 25: JS errors occurred: Event: Event
Making the error message more informative requires patching browser-ui-test.
@notriddle
notriddleforce-pushed the test-js-search-scripts-path branch from 345789b to 53b775dCompareAugust 21, 2025 16:25
@rustbot

rustbot commented Aug 21, 2025

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@GuillaumeGomez

GuillaumeGomez commented Aug 21, 2025

Copy link
Copy Markdown
Member

Why was the CI cancelled btw? Well anyway, if ready, r=me.

@GuillaumeGomezGuillaumeGomez mentioned this pull request Aug 21, 2025
Merged
@fmease

fmease commented Aug 21, 2025

Copy link
Copy Markdown
Member

GH outage I believe

@GuillaumeGomez

GuillaumeGomez commented Aug 21, 2025

Copy link
Copy Markdown
Member

Then most definitely r=me. =D

@bors r+ rollup

@bors

bors commented Aug 21, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 53b775d has been approved by GuillaumeGomez

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Aug 21, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Aug 22, 2025
@jhpratt
Rollup merge ofrust-lang#145669- notriddle:test-js-search-scripts-p…
2529559
…ath, r=GuillaumeGomez
rustdoc-search: GUI tests check for `//` in URL
Follow up rust-lang#145650
When this fails, you get output that looks like:
/home/user/rust/tests/rustdoc-gui/search-result-impl-disambiguation.goml search-result-impl-disambiguation... FAILED
[ERROR] `tests/rustdoc-gui/utils.goml` around line 49
from `tests/rustdoc-gui/search-result-impl-disambiguation.goml` line 25: JS errors occurred: Event: Event
Making the error message more informative requires patching browser-ui-test.
@jhprattjhpratt mentioned this pull request Aug 22, 2025
Closed
bors added a commit that referenced this pull request Aug 23, 2025
@bors
Auto merge of#145764- jhpratt:rollup-uzej5kg, r=jhpratt
e7978bd
Rollup of 20 pull requests
Successful merges:
- #132087 (Fix overly restrictive lifetime in `core::panic::Location::file` return type)
- #137396 (Recover `param: Ty = EXPR`)
- #142185 (Convert moves of references to copies in ReferencePropagation)
- #144443 (Make target pointer width in target json an integer)
- #144648 (Implementation: `#[feature(nonpoison_rwlock)]`)
- #144897 (print raw lifetime idents with r#)
- #145218 ([Debuginfo] improve enum value formatting in LLDB for better readability)
- #145380 (Add codegen-llvm regression tests)
- #145573 (Add an experimental unsafe(force_target_feature) attribute.)
- #145597 (resolve: Remove `ScopeSet::Late`)
- #145641 (On E0277, point at type that doesn't implement bound)
- #145669 (rustdoc-search: GUI tests check for `//` in URL)
- #145695 (Introduce ProjectionElem::try_map.)
- #145710 (Fix the ABI parameter inconsistency issue in debug.rs for LoongArch64)
- #145726 (Experiment: Reborrow trait)
- #145731 (Make raw pointers work in type-based search)
- #145736 (triagebot: Update style team reviewers)
- #145738 (Uplift rustc_mir_transform::coverage::counters::union_find to rustc_data_structures.)
- #145743 (doc: fix some typos in comment)
- #145745 (tests: Ignore basic-stepping.rs on LoongArch)
Failed merges:
- #145670 (port `sanitize` attribute to the new parsing infrastructure)
r? `@ghost`
`@rustbot` modify labels: rollup
@jhprattjhpratt mentioned this pull request Aug 23, 2025
Merged
bors added a commit that referenced this pull request Aug 23, 2025
@bors
Auto merge of#145773- jhpratt:rollup-kocqnzv, r=jhpratt
8df154b
Rollup of 28 pull requests
Successful merges:
- #132087 (Fix overly restrictive lifetime in `core::panic::Location::file` return type)
- #137396 (Recover `param: Ty = EXPR`)
- #137457 (Fix host code appearing in Wasm binaries)
- #142185 (Convert moves of references to copies in ReferencePropagation)
- #144648 (Implementation: `#[feature(nonpoison_rwlock)]`)
- #144897 (print raw lifetime idents with r#)
- #145218 ([Debuginfo] improve enum value formatting in LLDB for better readability)
- #145380 (Add codegen-llvm regression tests)
- #145573 (Add an experimental unsafe(force_target_feature) attribute.)
- #145597 (resolve: Remove `ScopeSet::Late`)
- #145633 (Fix some typos in LocalKey documentation)
- #145641 (On E0277, point at type that doesn't implement bound)
- #145669 (rustdoc-search: GUI tests check for `//` in URL)
- #145695 (Introduce ProjectionElem::try_map.)
- #145710 (Fix the ABI parameter inconsistency issue in debug.rs for LoongArch64)
- #145726 (Experiment: Reborrow trait)
- #145731 (Make raw pointers work in type-based search)
- #145736 (triagebot: Update style team reviewers)
- #145738 (Uplift rustc_mir_transform::coverage::counters::union_find to rustc_data_structures.)
- #145742 (rustdoc js: Even more typechecking improvments )
- #145743 (doc: fix some typos in comment)
- #145745 (tests: Ignore basic-stepping.rs on LoongArch)
- #145747 (Refactor lint buffering to avoid requiring a giant enum)
- #145751 (fix(lexer): Allow '-' in the frontmatter infostring continue set)
- #145761 (Add aarch64_be-unknown-hermit target)
- #145762 (convert strings to symbols in attr diagnostics)
- #145763 (Ship LLVM tools for the correct target when cross-compiling)
- #145765 (Revert suggestions for missing methods in tuples)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 77f980f into rust-lang:masterAug 23, 2025
8 of 10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 23, 2025
rust-timer added a commit that referenced this pull request Aug 23, 2025
@rust-timer
Unrolled build for#145669
ec6b050
Rollup merge of #145669 - notriddle:test-js-search-scripts-path, r=GuillaumeGomez
rustdoc-search: GUI tests check for `//` in URL
Follow up #145650
When this fails, you get output that looks like:
/home/user/rust/tests/rustdoc-gui/search-result-impl-disambiguation.goml search-result-impl-disambiguation... FAILED
[ERROR] `tests/rustdoc-gui/utils.goml` around line 49
from `tests/rustdoc-gui/search-result-impl-disambiguation.goml` line 25: JS errors occurred: Event: Event
Making the error message more informative requires patching browser-ui-test.
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Aug 24, 2025
@bors
Auto merge of #145773 - jhpratt:rollup-kocqnzv, r=jhpratt
777dbcd
Rollup of 28 pull requests
Successful merges:
- rust-lang/rust#132087 (Fix overly restrictive lifetime in `core::panic::Location::file` return type)
- rust-lang/rust#137396 (Recover `param: Ty = EXPR`)
- rust-lang/rust#137457 (Fix host code appearing in Wasm binaries)
- rust-lang/rust#142185 (Convert moves of references to copies in ReferencePropagation)
- rust-lang/rust#144648 (Implementation: `#[feature(nonpoison_rwlock)]`)
- rust-lang/rust#144897 (print raw lifetime idents with r#)
- rust-lang/rust#145218 ([Debuginfo] improve enum value formatting in LLDB for better readability)
- rust-lang/rust#145380 (Add codegen-llvm regression tests)
- rust-lang/rust#145573 (Add an experimental unsafe(force_target_feature) attribute.)
- rust-lang/rust#145597 (resolve: Remove `ScopeSet::Late`)
- rust-lang/rust#145633 (Fix some typos in LocalKey documentation)
- rust-lang/rust#145641 (On E0277, point at type that doesn't implement bound)
- rust-lang/rust#145669 (rustdoc-search: GUI tests check for `//` in URL)
- rust-lang/rust#145695 (Introduce ProjectionElem::try_map.)
- rust-lang/rust#145710 (Fix the ABI parameter inconsistency issue in debug.rs for LoongArch64)
- rust-lang/rust#145726 (Experiment: Reborrow trait)
- rust-lang/rust#145731 (Make raw pointers work in type-based search)
- rust-lang/rust#145736 (triagebot: Update style team reviewers)
- rust-lang/rust#145738 (Uplift rustc_mir_transform::coverage::counters::union_find to rustc_data_structures.)
- rust-lang/rust#145742 (rustdoc js: Even more typechecking improvments )
- rust-lang/rust#145743 (doc: fix some typos in comment)
- rust-lang/rust#145745 (tests: Ignore basic-stepping.rs on LoongArch)
- rust-lang/rust#145747 (Refactor lint buffering to avoid requiring a giant enum)
- rust-lang/rust#145751 (fix(lexer): Allow '-' in the frontmatter infostring continue set)
- rust-lang/rust#145761 (Add aarch64_be-unknown-hermit target)
- rust-lang/rust#145762 (convert strings to symbols in attr diagnostics)
- rust-lang/rust#145763 (Ship LLVM tools for the correct target when cross-compiling)
- rust-lang/rust#145765 (Revert suggestions for missing methods in tuples)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 25, 2025
@bors
Auto merge of #145773 - jhpratt:rollup-kocqnzv, r=jhpratt
2ff60be
Rollup of 28 pull requests
Successful merges:
- rust-lang/rust#132087 (Fix overly restrictive lifetime in `core::panic::Location::file` return type)
- rust-lang/rust#137396 (Recover `param: Ty = EXPR`)
- rust-lang/rust#137457 (Fix host code appearing in Wasm binaries)
- rust-lang/rust#142185 (Convert moves of references to copies in ReferencePropagation)
- rust-lang/rust#144648 (Implementation: `#[feature(nonpoison_rwlock)]`)
- rust-lang/rust#144897 (print raw lifetime idents with r#)
- rust-lang/rust#145218 ([Debuginfo] improve enum value formatting in LLDB for better readability)
- rust-lang/rust#145380 (Add codegen-llvm regression tests)
- rust-lang/rust#145573 (Add an experimental unsafe(force_target_feature) attribute.)
- rust-lang/rust#145597 (resolve: Remove `ScopeSet::Late`)
- rust-lang/rust#145633 (Fix some typos in LocalKey documentation)
- rust-lang/rust#145641 (On E0277, point at type that doesn't implement bound)
- rust-lang/rust#145669 (rustdoc-search: GUI tests check for `//` in URL)
- rust-lang/rust#145695 (Introduce ProjectionElem::try_map.)
- rust-lang/rust#145710 (Fix the ABI parameter inconsistency issue in debug.rs for LoongArch64)
- rust-lang/rust#145726 (Experiment: Reborrow trait)
- rust-lang/rust#145731 (Make raw pointers work in type-based search)
- rust-lang/rust#145736 (triagebot: Update style team reviewers)
- rust-lang/rust#145738 (Uplift rustc_mir_transform::coverage::counters::union_find to rustc_data_structures.)
- rust-lang/rust#145742 (rustdoc js: Even more typechecking improvments )
- rust-lang/rust#145743 (doc: fix some typos in comment)
- rust-lang/rust#145745 (tests: Ignore basic-stepping.rs on LoongArch)
- rust-lang/rust#145747 (Refactor lint buffering to avoid requiring a giant enum)
- rust-lang/rust#145751 (fix(lexer): Allow '-' in the frontmatter infostring continue set)
- rust-lang/rust#145761 (Add aarch64_be-unknown-hermit target)
- rust-lang/rust#145762 (convert strings to symbols in attr diagnostics)
- rust-lang/rust#145763 (Ship LLVM tools for the correct target when cross-compiling)
- rust-lang/rust#145765 (Revert suggestions for missing methods in tuples)
r? `@ghost`
`@rustbot` modify labels: rollup
@notriddle
notriddle deleted the test-js-search-scripts-path branch August 25, 2025 16:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomezGuillaumeGomezGuillaumeGomez approved these changes

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

A-rustdoc-searchArea: Rustdoc's search featureS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.T-rustdoc-frontendRelevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

5 participants

@notriddle@rustbot@GuillaumeGomez@fmease@bors