Skip to content

Instantiate higher-ranked binder with erased when checking IntoIterator predicate for query instability - #145672

Merged
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:query-instab-ice
Aug 22, 2025
Merged

Instantiate higher-ranked binder with erased when checking IntoIterator predicate for query instability#145672
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:query-instab-ice

Conversation

@compiler-errors

Copy link
Copy Markdown
Contributor

Fixes#145652 which was introduced by #139345 because we were skipping a binder before calling Instance::try_resolve.

r? lcnr

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 20, 2025
@lcnr

lcnr commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

woops

@bors r+ rollup

@bors

bors commented Aug 21, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit d18d94d has been approved by lcnr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2025
@jhprattjhpratt mentioned this pull request Aug 21, 2025
bors added a commit that referenced this pull request Aug 21, 2025
Rollup of 16 pull requests
Successful merges:
- #137494 (libstd: init(): dup() subsequent /dev/nulls instead of opening them again)
- #144541 (c-variadic: multiple ABIs in the same program for arm)
- #144613 (aarch64-nintendo-switch-freestanding - Enable CPU features that are always available in a live system (crypto instructions, plus explicit NEON).)
- #144780 (Add a method to dump MIR in the middle of MIR building)
- #145137 (Consolidate panicking functions in `slice/index.rs`)
- #145507 (Refactor attribute parsing to improve ergonomics and some diagnostics)
- #145604 (Gate static closures behind a parser feature)
- #145648 (Add two tidy dependency checks)
- #145661 (update some s390x codegen tests)
- #145672 (Instantiate higher-ranked binder with erased when checking `IntoIterator` predicate for query instability)
- #145689 (Migrate `panic_unwind` to use `cfg_select!`)
- #145700 (Handle `ReEarlyParam` in `type_name`.)
- #145703 (Remove MIPS targets from CI LLVM platforms)
- #145704 (ci: don't cleanup windows disk)
- #145705 (remove an `as` cast in prefetch codegen)
- #145712 (Update outdated link in bound region comments)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 268ef7b into rust-lang:masterAug 22, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 22, 2025
rust-timer added a commit that referenced this pull request Aug 22, 2025
Rollup merge of #145672 - compiler-errors:query-instab-ice, r=lcnr
Instantiate higher-ranked binder with erased when checking `IntoIterator` predicate for query instability
Fixes#145652 which was introduced by #139345 because we were skipping a binder before calling `Instance::try_resolve`.
r? lcnr
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Aug 22, 2025
Rollup of 16 pull requests
Successful merges:
- rust-lang/rust#137494 (libstd: init(): dup() subsequent /dev/nulls instead of opening them again)
- rust-lang/rust#144541 (c-variadic: multiple ABIs in the same program for arm)
- rust-lang/rust#144613 (aarch64-nintendo-switch-freestanding - Enable CPU features that are always available in a live system (crypto instructions, plus explicit NEON).)
- rust-lang/rust#144780 (Add a method to dump MIR in the middle of MIR building)
- rust-lang/rust#145137 (Consolidate panicking functions in `slice/index.rs`)
- rust-lang/rust#145507 (Refactor attribute parsing to improve ergonomics and some diagnostics)
- rust-lang/rust#145604 (Gate static closures behind a parser feature)
- rust-lang/rust#145648 (Add two tidy dependency checks)
- rust-lang/rust#145661 (update some s390x codegen tests)
- rust-lang/rust#145672 (Instantiate higher-ranked binder with erased when checking `IntoIterator` predicate for query instability)
- rust-lang/rust#145689 (Migrate `panic_unwind` to use `cfg_select!`)
- rust-lang/rust#145700 (Handle `ReEarlyParam` in `type_name`.)
- rust-lang/rust#145703 (Remove MIPS targets from CI LLVM platforms)
- rust-lang/rust#145704 (ci: don't cleanup windows disk)
- rust-lang/rust#145705 (remove an `as` cast in prefetch codegen)
- rust-lang/rust#145712 (Update outdated link in bound region comments)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE has escaping bound vars, so it cannot be wrapped in a dummy binder.

4 participants

@compiler-errors@lcnr@bors@rustbot