Add `From` impls for wrapper types by Jules-Bertholet · Pull Request #146013 · rust-lang/rust

Jules-Bertholet · 2025-08-29T20:08:22Z

~~From<T: Copy> for ManuallyDrop<T>~~
From<T: UnwindSafe> for AssertUnwindSafe<T>
From<T> for LazyCell<T, F>
From<T> for LazyLock<T, F>
From<T> for ThinBox<T> (unstable)
From<T> for UniqueRc<T> (unstable)
From<T> for UniqueArc<T> (unstable)

@rustbot label T-libs-api needs-fcp

Also needs a crater run, as the insta-stable impls are technically breaking changes.

rustbot · 2025-08-29T20:08:27Z

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Kivooeo · 2025-08-29T20:49:26Z

@rustbot label +needs-crater

rustbot · 2025-08-29T20:49:42Z

Error: Label needs-crater can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

tgross35 · 2025-08-30T00:34:46Z

@bors try

Add `From` impls for wrapper types

rust-bors · 2025-08-30T02:51:00Z

☀️ Try build successful (CI)
Build commit: 804fff1 (804fff1ae95da9d03bd44eee27f258020a575dab, parent: fe55364329579d361b1ab565728bc033a7dba07e)

tgross35 · 2025-08-30T02:57:40Z

@craterbot check

craterbot · 2025-08-30T02:58:32Z

👌 Experiment pr-146013 created and queued.
🤖 Automatically detected try build 804fff1
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-09-05T15:32:59Z

🚧 Experiment pr-146013 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

craterbot · 2025-09-07T07:02:50Z

🎉 Experiment pr-146013 is completed!
📊 1312 regressed and 1466 fixed (691117 total)
📊 2007 spurious results on the retry-regessed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-146013/retry-regressed-list.txt↩

Jules-Bertholet · 2025-09-07T14:25:15Z

I haven't been able to review all the regressions yet. But from the few I spot-checked: most are spurious (filesystem errors), but a few are not. All the real regressions I saw were due to the ManuallyDrop impl. And, upon reflection, that one as well as the AssertUnwindSafe impl seem dubious, so I removed the former and restricted the latter.

craterbot · 2025-09-07T16:18:11Z

👌 Experiment pr-146013-retry-1 created and queued.
🤖 Automatically detected try build 804fff1
⚠️ Try build based on commit b38c598, but latest commit is 677f02a. Did you forget to make a new try build?
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

- `From<T> for ThinBox<T>` - `From<T> for UniqueRc<T>` - `From<T> for UniqueArc<T>` - `From<T: UnwindSafe> for AssertUnwindSafe<T>` - `From<T> for LazyCell<T, F>` - `From<T> for LazyLock<T, F>`

rustbot · 2026-03-15T02:11:14Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Jules-Bertholet · 2026-03-15T02:14:44Z

@rustbot ready

Mark-Simulacrum

@bors r+

View changes since this review

rust-bors · 2026-03-16T21:31:49Z

📋 This PR cannot be approved because it currently has the following label: S-waiting-on-fcp.

Mark-Simulacrum · 2026-03-16T21:32:12Z

@bors r+

rust-bors · 2026-03-16T21:32:15Z

📌 Commit c5c1d94 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rustbot

Add `From` impls for wrapper types - ~`From<T: Copy> for ManuallyDrop<T>`~ - `From<T: UnwindSafe> for AssertUnwindSafe<T>` - `From<T> for LazyCell<T, F>` - `From<T> for LazyLock<T, F>` - `From<T> for ThinBox<T>` (unstable) - `From<T> for UniqueRc<T>` (unstable) - `From<T> for UniqueArc<T>` (unstable) @rustbot label T-libs-api needs-fcp Also needs a crater run, as the insta-stable impls are technically breaking changes.

@rustbot

…rk-Simulacrum Add `From` impls for wrapper types - ~`From<T: Copy> for ManuallyDrop<T>`~ - `From<T: UnwindSafe> for AssertUnwindSafe<T>` - `From<T> for LazyCell<T, F>` - `From<T> for LazyLock<T, F>` - `From<T> for ThinBox<T>` (unstable) - `From<T> for UniqueRc<T>` (unstable) - `From<T> for UniqueArc<T>` (unstable) @rustbot label T-libs-api needs-fcp Also needs a crater run, as the insta-stable impls are technically breaking changes.

jhpratt · 2026-03-17T01:02:45Z

yielding to encompassing rollup

@bors yield

rust-bors · 2026-03-17T01:02:47Z

Auto build was cancelled. Cancelled workflows:

https://github.com/rust-lang/rust/actions/runs/23173207430

The next pull request likely to be tested is #153977.

Rollup of 5 pull requests Successful merges: - #146013 (Add `From` impls for wrapper types) - #153966 (suggest valid features when target feature is invalid) - #153372 (Fix LegacyKeyValueFormat report from docker build: x86_64-gnu) - #153738 (Don't look for non-type-level assoc consts when checking trait object types) - #153921 (Suppress self-referential associated type constraint suggestion)

rust-bors · 2026-03-17T07:31:22Z

☀️ Test successful - CI
Approved by: Mark-Simulacrum
Duration: 3h 16m 23s
Pushing 6bdc342 to main...

github-actions · 2026-03-17T07:34:32Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3645249 (parent) -> 6bdc342 (this PR)

Test differences

Show 126 test diffs

126 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 6bdc342ddb05b520a1f741aabf002319b44d2475 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-x86_64-apple: 2h 13m -> 1h 48m (-18.7%)
i686-gnu-2: 1h 28m -> 1h 42m (+15.9%)
aarch64-apple: 2h 45m -> 3h 8m (+13.6%)
dist-aarch64-apple: 2h -> 1h 44m (-13.1%)
x86_64-gnu-aux: 2h 6m -> 2h 21m (+12.4%)
i686-gnu-nopt-1: 2h 10m -> 2h 27m (+12.4%)
dist-i586-gnu-i586-i686-musl: 1h 36m -> 1h 24m (-11.8%)
i686-gnu-1: 2h 8m -> 2h 22m (+10.9%)
dist-x86_64-musl: 2h 3m -> 2h 16m (+10.4%)
x86_64-mingw-1: 3h 12m -> 2h 52m (-10.2%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-03-17T08:21:19Z

Finished benchmarking commit (6bdc342): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.7%, secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	5.7%	[3.1%, 10.2%]	3
Regressions ❌ (secondary)	0.9%	[0.9%, 0.9%]	1
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-0.9%	[-0.9%, -0.9%]	1
All ❌✅ (primary)	3.7%	[-2.1%, 10.2%]	4

Cycles

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[2.1%, 2.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 482.068s -> 481.948s (-0.02%)
Artifact size: 394.83 MiB -> 396.84 MiB (0.51%)

rustbot assigned Mark-Simulacrum Aug 29, 2025

This comment has been minimized.
Sign in to view

rust-borsBot added a commit that referenced this pull request Aug 30, 2025
Auto merge of#146013- Jules-Bertholet:from-wrapper, r=<try>
804fff1
Add `From` impls for wrapper types

tgross35 added I-libs-api-nominated [DEPRECATED; DO NOT USE] and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Aug 30, 2025

craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 30, 2025

craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Sep 7, 2025

This comment was marked as resolved.
Sign in to view

Add From impls for wrapper types
c5c1d94
- `From<T> for ThinBox<T>` - `From<T> for UniqueRc<T>` - `From<T> for UniqueArc<T>` - `From<T: UnwindSafe> for AssertUnwindSafe<T>` - `From<T> for LazyCell<T, F>` - `From<T> for LazyLock<T, F>`

Jules-Bertholet force-pushed the from-wrapper branch from 0ae1c5d to c5c1d94Compare March 15, 2026 02:11

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 15, 2026

Mark-Simulacrum approved these changes Mar 16, 2026
View reviewed changes

Mark-Simulacrum removed the S-waiting-on-fcp Status: PR is in FCP and is awaiting for FCP to complete. label Mar 16, 2026

rust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2026

This comment has been minimized.
Sign in to view

jhpratt mentioned this pull request Mar 17, 2026
Rollup of 5 pull requests #153977
Closed

This comment has been minimized.
Sign in to view

rust-borsBot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 17, 2026

rust-borsBot merged commit 6bdc342 into rust-lang:mainMar 17, 2026
12 checks passed

rustbot added this to the 1.96.0 milestone Mar 17, 2026

rust-borsBot mentioned this pull request Mar 17, 2026
Implement immediate-abort by hooking #[rustc_panic_entrypoint] and lint for functions that look like a panic entrypoint #150497
Open

Jules-Bertholet deleted the from-wrapper branch March 17, 2026 12:51

Uh oh!

Uh oh!

Conversation

Jules-Bertholet commented Aug 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 29, 2025

Uh oh!

Kivooeo commented Aug 29, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 29, 2025

Uh oh!

This comment has been minimized.

tgross35 commented Aug 30, 2025

Uh oh!

This comment has been minimized.

rust-borsBot commented Aug 30, 2025

Uh oh!

tgross35 commented Aug 30, 2025

Uh oh!

craterbot commented Aug 30, 2025

Uh oh!

craterbot commented Sep 5, 2025

Uh oh!

craterbot commented Sep 7, 2025

Footnotes

Uh oh!

Jules-Bertholet commented Sep 7, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

craterbot commented Sep 7, 2025

Uh oh!

rustbot commented Mar 15, 2026

Uh oh!

Jules-Bertholet commented Mar 15, 2026

Uh oh!

Mark-Simulacrum left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-borsBot commented Mar 16, 2026

Uh oh!

Mark-Simulacrum commented Mar 16, 2026

Uh oh!

rust-borsBot commented Mar 16, 2026

Uh oh!

This comment has been minimized.

jhpratt commented Mar 17, 2026

Uh oh!

rust-borsBot commented Mar 17, 2026

Uh oh!

This comment has been minimized.

rust-borsBot commented Mar 17, 2026

Uh oh!

Uh oh!

github-actionsBot commented Mar 17, 2026

Test differences

Job duration changes

Uh oh!

rust-timer commented Mar 17, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Jules-Bertholet commented Aug 29, 2025•
edited
Loading

Kivooeo commented Aug 29, 2025•
edited
Loading

Jules-Bertholet commented Sep 7, 2025•
edited
Loading

Mark-Simulacrum left a comment •
edited by rustbot
Loading