Skip to content

Remove dead code stemming from an old effects desugaring - #146102

Merged
bors merged 1 commit into
rust-lang:masterfrom
fmease:rm-dead-eff-code-iii
Sep 2, 2025
Merged

Remove dead code stemming from an old effects desugaring#146102
bors merged 1 commit into
rust-lang:masterfrom
fmease:rm-dead-eff-code-iii

Conversation

@fmease

@fmeasefmease commented Sep 1, 2025

Copy link
Copy Markdown
Member

CC #132374, #133443.

r? fee1-dead

@rustbotrustbot added A-rustdoc-json Area: Rustdoc JSON backend S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 1, 2025
@rustbot

rustbot commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator

This PR changes rustc_public

cc @oli-obk, @celinval, @ouz-a

@fee1-dead

fee1-dead commented Sep 1, 2025

Copy link
Copy Markdown
Member

r=me when green

@bors rollup

@fmease

fmease commented Sep 1, 2025

Copy link
Copy Markdown
MemberAuthor

@bors r=fee1-dead

@bors

bors commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 6fc0cf4 has been approved by fee1-dead

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 1, 2025
fmease added a commit to fmease/rust that referenced this pull request Sep 1, 2025
@fmease
Rollup merge ofrust-lang#146102- fmease:rm-dead-eff-code-iii, r=fee…
8e5671f
…1-dead
Remove dead code stemming from an old effects desugaring
CC rust-lang#132374, rust-lang#133443.
r? fee1-dead
@fmeasefmease mentioned this pull request Sep 1, 2025
Closed
bors added a commit that referenced this pull request Sep 2, 2025
@bors
Auto merge of#146104- fmease:rollup-xhh06pd, r=fmease
8240e32
Rollup of 10 pull requests
Successful merges:
- #144066 (stabilize c-style varargs for sysv64, win64, efiapi, aapcs)
- #145783 (add span to struct pattern rest (..))
- #145961 (resolve: Avoid a regression from splitting prelude into two scopes)
- #145962 (Ensure we emit an allocator shim when only some crate types need one)
- #146064 (Add compiler error when trying to use concat metavar expr in repetitions)
- #146067 (alloc: make Cow From impls const)
- #146070 (rustdoc-search: skip loading unneeded fnData)
- #146089 (fix a constness ordering bug in rustfmt)
- #146094 (Make `Parser::parse_for_head` public for rustfmt usage)
- #146102 (Remove dead code stemming from an old effects desugaring)
r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Sep 2, 2025
@jhpratt
Rollup merge ofrust-lang#146102- fmease:rm-dead-eff-code-iii, r=fee…
ef60f50
…1-dead
Remove dead code stemming from an old effects desugaring
CC rust-lang#132374, rust-lang#133443.
r? fee1-dead
@jhprattjhpratt mentioned this pull request Sep 2, 2025
Closed
bors added a commit that referenced this pull request Sep 2, 2025
@bors
Auto merge of#146107- jhpratt:rollup-f85ejmy, r=jhpratt
0e00ef4
Rollup of 9 pull requests
Successful merges:
- #145783 (add span to struct pattern rest (..))
- #145961 (resolve: Avoid a regression from splitting prelude into two scopes)
- #145962 (Ensure we emit an allocator shim when only some crate types need one)
- #146064 (Add compiler error when trying to use concat metavar expr in repetitions)
- #146067 (alloc: make Cow From impls const)
- #146070 (rustdoc-search: skip loading unneeded fnData)
- #146089 (fix a constness ordering bug in rustfmt)
- #146094 (Make `Parser::parse_for_head` public for rustfmt usage)
- #146102 (Remove dead code stemming from an old effects desugaring)
r? `@ghost`
`@rustbot` modify labels: rollup
@GuillaumeGomezGuillaumeGomez mentioned this pull request Sep 2, 2025
Merged
bors added a commit that referenced this pull request Sep 2, 2025
@bors
Auto merge of#146125- GuillaumeGomez:rollup-ld81n7e, r=GuillaumeGomez
94722ca
Rollup of 14 pull requests
Successful merges:
- #144066 (stabilize c-style varargs for sysv64, win64, efiapi, aapcs)
- #145783 (add span to struct pattern rest (..))
- #146034 (Update target spec metadata of Arm64EC Windows and Trusty targets)
- #146064 (Add compiler error when trying to use concat metavar expr in repetitions)
- #146070 (rustdoc-search: skip loading unneeded fnData)
- #146088 (constify impl Try for ControlFlow)
- #146089 (fix a constness ordering bug in rustfmt)
- #146091 (fix rustdoc `render_call_locations` panicking because of default span `DUMMY_SP` pointing at non local-source file)
- #146094 (Make `Parser::parse_for_head` public for rustfmt usage)
- #146102 (Remove dead code stemming from an old effects desugaring)
- #146115 (Add maintainer for VxWorks)
- #146116 (Adjust issue-118306.rs test after LLVM change)
- #146117 (Fix search index generation)
- #146118 (improve process::abort rendering in Miri backtraces)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 07f7d86 into rust-lang:masterSep 2, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Sep 2, 2025
@fmease
fmease deleted the rm-dead-eff-code-iii branch September 2, 2025 19:32
rust-timer added a commit that referenced this pull request Sep 2, 2025
@rust-timer
Unrolled build for#146102
ca00a69
Rollup merge of #146102 - fmease:rm-dead-eff-code-iii, r=fee1-dead
Remove dead code stemming from an old effects desugaring
CC #132374, #133443.
r? fee1-dead
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Sep 3, 2025
@bors
Auto merge of #146125 - GuillaumeGomez:rollup-ld81n7e, r=GuillaumeGomez
00c9e51
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#144066 (stabilize c-style varargs for sysv64, win64, efiapi, aapcs)
- rust-lang/rust#145783 (add span to struct pattern rest (..))
- rust-lang/rust#146034 (Update target spec metadata of Arm64EC Windows and Trusty targets)
- rust-lang/rust#146064 (Add compiler error when trying to use concat metavar expr in repetitions)
- rust-lang/rust#146070 (rustdoc-search: skip loading unneeded fnData)
- rust-lang/rust#146088 (constify impl Try for ControlFlow)
- rust-lang/rust#146089 (fix a constness ordering bug in rustfmt)
- rust-lang/rust#146091 (fix rustdoc `render_call_locations` panicking because of default span `DUMMY_SP` pointing at non local-source file)
- rust-lang/rust#146094 (Make `Parser::parse_for_head` public for rustfmt usage)
- rust-lang/rust#146102 (Remove dead code stemming from an old effects desugaring)
- rust-lang/rust#146115 (Add maintainer for VxWorks)
- rust-lang/rust#146116 (Adjust issue-118306.rs test after LLVM change)
- rust-lang/rust#146117 (Fix search index generation)
- rust-lang/rust#146118 (improve process::abort rendering in Miri backtraces)
r? `@ghost`
`@rustbot` modify labels: rollup
rust-cloud-vmsBot pushed a commit to makai410/rustc_public that referenced this pull request Oct 12, 2025
@bors
Auto merge of #146125 - GuillaumeGomez:rollup-ld81n7e, r=GuillaumeGomez
2733d61
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#144066 (stabilize c-style varargs for sysv64, win64, efiapi, aapcs)
- rust-lang/rust#145783 (add span to struct pattern rest (..))
- rust-lang/rust#146034 (Update target spec metadata of Arm64EC Windows and Trusty targets)
- rust-lang/rust#146064 (Add compiler error when trying to use concat metavar expr in repetitions)
- rust-lang/rust#146070 (rustdoc-search: skip loading unneeded fnData)
- rust-lang/rust#146088 (constify impl Try for ControlFlow)
- rust-lang/rust#146089 (fix a constness ordering bug in rustfmt)
- rust-lang/rust#146091 (fix rustdoc `render_call_locations` panicking because of default span `DUMMY_SP` pointing at non local-source file)
- rust-lang/rust#146094 (Make `Parser::parse_for_head` public for rustfmt usage)
- rust-lang/rust#146102 (Remove dead code stemming from an old effects desugaring)
- rust-lang/rust#146115 (Add maintainer for VxWorks)
- rust-lang/rust#146116 (Adjust issue-118306.rs test after LLVM change)
- rust-lang/rust#146117 (Fix search index generation)
- rust-lang/rust#146118 (improve process::abort rendering in Miri backtraces)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
@GuillaumeGomez
Rollup merge ofrust-lang#146102- fmease:rm-dead-eff-code-iii, r=fee…
a99ac37
…1-dead
Remove dead code stemming from an old effects desugaring
CC rust-lang#132374, rust-lang#133443.
r? fee1-dead
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
@bors
Auto merge ofrust-lang#146125- GuillaumeGomez:rollup-ld81n7e, r=Gui…
13e3be7
…llaumeGomez
Rollup of 14 pull requests
Successful merges:
- rust-lang#144066 (stabilize c-style varargs for sysv64, win64, efiapi, aapcs)
- rust-lang#145783 (add span to struct pattern rest (..))
- rust-lang#146034 (Update target spec metadata of Arm64EC Windows and Trusty targets)
- rust-lang#146064 (Add compiler error when trying to use concat metavar expr in repetitions)
- rust-lang#146070 (rustdoc-search: skip loading unneeded fnData)
- rust-lang#146088 (constify impl Try for ControlFlow)
- rust-lang#146089 (fix a constness ordering bug in rustfmt)
- rust-lang#146091 (fix rustdoc `render_call_locations` panicking because of default span `DUMMY_SP` pointing at non local-source file)
- rust-lang#146094 (Make `Parser::parse_for_head` public for rustfmt usage)
- rust-lang#146102 (Remove dead code stemming from an old effects desugaring)
- rust-lang#146115 (Add maintainer for VxWorks)
- rust-lang#146116 (Adjust issue-118306.rs test after LLVM change)
- rust-lang#146117 (Fix search index generation)
- rust-lang#146118 (improve process::abort rendering in Miri backtraces)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@GuillaumeGomez
Rollup merge ofrust-lang#146102- fmease:rm-dead-eff-code-iii, r=fee…
fd2dedd
…1-dead
Remove dead code stemming from an old effects desugaring
CC rust-lang#132374, rust-lang#133443.
r? fee1-dead
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@bors
Auto merge ofrust-lang#146125- GuillaumeGomez:rollup-ld81n7e, r=Gui…
1b19af4
…llaumeGomez
Rollup of 14 pull requests
Successful merges:
- rust-lang#144066 (stabilize c-style varargs for sysv64, win64, efiapi, aapcs)
- rust-lang#145783 (add span to struct pattern rest (..))
- rust-lang#146034 (Update target spec metadata of Arm64EC Windows and Trusty targets)
- rust-lang#146064 (Add compiler error when trying to use concat metavar expr in repetitions)
- rust-lang#146070 (rustdoc-search: skip loading unneeded fnData)
- rust-lang#146088 (constify impl Try for ControlFlow)
- rust-lang#146089 (fix a constness ordering bug in rustfmt)
- rust-lang#146091 (fix rustdoc `render_call_locations` panicking because of default span `DUMMY_SP` pointing at non local-source file)
- rust-lang#146094 (Make `Parser::parse_for_head` public for rustfmt usage)
- rust-lang#146102 (Remove dead code stemming from an old effects desugaring)
- rust-lang#146115 (Add maintainer for VxWorks)
- rust-lang#146116 (Adjust issue-118306.rs test after LLVM change)
- rust-lang#146117 (Fix search index generation)
- rust-lang#146118 (improve process::abort rendering in Miri backtraces)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Nov 16, 2025
@bors
Auto merge of #146125 - GuillaumeGomez:rollup-ld81n7e, r=GuillaumeGomez
4661d6d
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#144066 (stabilize c-style varargs for sysv64, win64, efiapi, aapcs)
- rust-lang/rust#145783 (add span to struct pattern rest (..))
- rust-lang/rust#146034 (Update target spec metadata of Arm64EC Windows and Trusty targets)
- rust-lang/rust#146064 (Add compiler error when trying to use concat metavar expr in repetitions)
- rust-lang/rust#146070 (rustdoc-search: skip loading unneeded fnData)
- rust-lang/rust#146088 (constify impl Try for ControlFlow)
- rust-lang/rust#146089 (fix a constness ordering bug in rustfmt)
- rust-lang/rust#146091 (fix rustdoc `render_call_locations` panicking because of default span `DUMMY_SP` pointing at non local-source file)
- rust-lang/rust#146094 (Make `Parser::parse_for_head` public for rustfmt usage)
- rust-lang/rust#146102 (Remove dead code stemming from an old effects desugaring)
- rust-lang/rust#146115 (Add maintainer for VxWorks)
- rust-lang/rust#146116 (Adjust issue-118306.rs test after LLVM change)
- rust-lang/rust#146117 (Fix search index generation)
- rust-lang/rust#146118 (improve process::abort rendering in Miri backtraces)
r? `@ghost`
`@rustbot` modify labels: rollup
@fmeasefmease added PG-const-traits Project group: Const traits C-cleanup Category: PRs that clean code up or issues documenting cleanup. F-effects `#![feature(effects)]` labels Nov 24, 2025
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Mar 27, 2026
@bors
Auto merge of #146125 - GuillaumeGomez:rollup-ld81n7e, r=GuillaumeGomez
e47a8d2
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#144066 (stabilize c-style varargs for sysv64, win64, efiapi, aapcs)
- rust-lang/rust#145783 (add span to struct pattern rest (..))
- rust-lang/rust#146034 (Update target spec metadata of Arm64EC Windows and Trusty targets)
- rust-lang/rust#146064 (Add compiler error when trying to use concat metavar expr in repetitions)
- rust-lang/rust#146070 (rustdoc-search: skip loading unneeded fnData)
- rust-lang/rust#146088 (constify impl Try for ControlFlow)
- rust-lang/rust#146089 (fix a constness ordering bug in rustfmt)
- rust-lang/rust#146091 (fix rustdoc `render_call_locations` panicking because of default span `DUMMY_SP` pointing at non local-source file)
- rust-lang/rust#146094 (Make `Parser::parse_for_head` public for rustfmt usage)
- rust-lang/rust#146102 (Remove dead code stemming from an old effects desugaring)
- rust-lang/rust#146115 (Add maintainer for VxWorks)
- rust-lang/rust#146116 (Adjust issue-118306.rs test after LLVM change)
- rust-lang/rust#146117 (Fix search index generation)
- rust-lang/rust#146118 (improve process::abort rendering in Miri backtraces)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@fee1-deadfee1-dead

Labels

A-rustdoc-jsonArea: Rustdoc JSON backendC-cleanupCategory: PRs that clean code up or issues documenting cleanup.F-effects`#![feature(effects)]`PG-const-traitsProject group: Const traitsS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

4 participants

@fmease@rustbot@fee1-dead@bors