Skip to content

feat: non-panicking Vec::try_remove - #146293

Merged
bors merged 1 commit into
rust-lang:masterfrom
BenjaminBrienen:try_remove
Sep 25, 2025
Merged

feat: non-panicking Vec::try_remove#146293
bors merged 1 commit into
rust-lang:masterfrom
BenjaminBrienen:try_remove

Conversation

@BenjaminBrienen

@BenjaminBrienenBenjaminBrienen commented Sep 7, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

if index < my_vector.len() { Some(my_vector.remove(index)) } else { None } is annoying to write and non-panicking functions are broadly useful.

APC: rust-lang/libs-team#649

Tracking issue: #146954

@rustbot

rustbot commented Sep 7, 2025

Copy link
Copy Markdown
Collaborator

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 7, 2025
@BenjaminBrienenBenjaminBrienen changed the title feat: non-panicking Vec::try_removefeat: non-panicking Vec::try_removeSep 7, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@BenjaminBrienen

BenjaminBrienen commented Sep 7, 2025

Copy link
Copy Markdown
ContributorAuthor

Looks like I inadvertently repeated #77480

I'd still like to reopen the discussion about this.

folkertdev
folkertdev reviewed Sep 7, 2025
View reviewed changes

@folkertdevfolkertdev left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additions to the standard library APIs will need an ACP first, see https://github.com/rust-lang/libs-team/issues > new issue > Api Change Proposal

View changes since this review

Comment threadlibrary/alloc/src/vec/mod.rs Outdated
Comment threadlibrary/alloc/src/vec/mod.rs
@rustbot

This comment has been minimized.

Sign in to view
@BenjaminBrienen
BenjaminBrienenforce-pushed the try_remove branch 2 times, most recently from 5bf4f7d to c2ffa8aCompareSeptember 7, 2025 11:19
@BenjaminBrienen

BenjaminBrienen commented Sep 7, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Additions to the standard library APIs will need an ACP first, see https://github.com/rust-lang/libs-team/issues > new issue > Api Change Proposal

View changes since this review

Added the tracking issue to the description. Is that sufficient?

Edit: added an ACP

@tgross35tgross35 added the S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. label Sep 7, 2025
@workingjubilee

workingjubilee commented Sep 9, 2025

Copy link
Copy Markdown
Member

r? libs

@BenjaminBrienenBenjaminBrienen mentioned this pull request Sep 24, 2025
Open
3 tasks
joboet
joboet approved these changes Sep 24, 2025
View reviewed changes

@joboetjoboet left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a small nit, but after that this looks good to go.

View changes since this review

Comment threadlibrary/alloc/src/vec/mod.rs Outdated
@joboetjoboet removed the S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. label Sep 24, 2025
@joboetjoboet assigned joboet and unassigned ibraheemdevSep 24, 2025
@joboet

joboet commented Sep 24, 2025

Copy link
Copy Markdown
Member

Oh, and could you squash the commits, please?

@rustbot

rustbot commented Sep 24, 2025

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

joboet
joboet reviewed Sep 24, 2025
View reviewed changes
Comment threadlibrary/alloc/src/vec/mod.rs Outdated
@BenjaminBrienen
feature: Implement vec_try_remove
5673449
Vec::try_remove is a non-panicking version of Vec::remove
@joboet

joboet commented Sep 25, 2025

Copy link
Copy Markdown
Member

Great, thank you!
@bors r+ rollup

@bors

bors commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 5673449 has been approved by joboet

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 25, 2025
@matthiaskrgr
Rollup merge ofrust-lang#146293- BenjaminBrienen:try_remove, r=joboet
2a441fe
feat: non-panicking `Vec::try_remove`
`if index < my_vector.len() { Some(my_vector.remove(index)) } else { None }` is annoying to write and non-panicking functions are broadly useful.
APC: rust-lang/libs-team#649
Tracking issue: rust-lang#146954
This was referenced Sep 25, 2025
Closed
Merged
bors added a commit that referenced this pull request Sep 25, 2025
@bors
Auto merge of#147037- matthiaskrgr:rollup-xtgqzuu, r=matthiaskrgr
7ac0330
Rollup of 8 pull requests
Successful merges:
- #116882 (rustdoc: hide `#[repr]` if it isn't part of the public ABI)
- #135771 ([rustdoc] Add support for associated items in "jump to def" feature)
- #141032 (avoid violating `slice::from_raw_parts` safety contract in `Vec::extract_if`)
- #142401 (Add proper name mangling for pattern types)
- #146293 (feat: non-panicking `Vec::try_remove`)
- #146859 (BTreeMap: Don't leak allocators when initializing nodes)
- #146924 (Add doc for `NonZero*` const creation)
- #146933 (Make `render_example_with_highlighting` return an `impl fmt::Display`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit fea9196 into rust-lang:masterSep 25, 2025
10 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Sep 25, 2025
rust-timer added a commit that referenced this pull request Sep 25, 2025
@rust-timer
Unrolled build for#146293
f41202a
Rollup merge of #146293 - BenjaminBrienen:try_remove, r=joboet
feat: non-panicking `Vec::try_remove`
`if index < my_vector.len() { Some(my_vector.remove(index)) } else { None }` is annoying to write and non-panicking functions are broadly useful.
APC: rust-lang/libs-team#649
Tracking issue: #146954
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Sep 26, 2025
@bors
Auto merge of #147037 - matthiaskrgr:rollup-xtgqzuu, r=matthiaskrgr
3333c7e
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#116882 (rustdoc: hide `#[repr]` if it isn't part of the public ABI)
- rust-lang/rust#135771 ([rustdoc] Add support for associated items in "jump to def" feature)
- rust-lang/rust#141032 (avoid violating `slice::from_raw_parts` safety contract in `Vec::extract_if`)
- rust-lang/rust#142401 (Add proper name mangling for pattern types)
- rust-lang/rust#146293 (feat: non-panicking `Vec::try_remove`)
- rust-lang/rust#146859 (BTreeMap: Don't leak allocators when initializing nodes)
- rust-lang/rust#146924 (Add doc for `NonZero*` const creation)
- rust-lang/rust#146933 (Make `render_example_with_highlighting` return an `impl fmt::Display`)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
@matthiaskrgr
Rollup merge ofrust-lang#146293- BenjaminBrienen:try_remove, r=joboet
c2cf319
feat: non-panicking `Vec::try_remove`
`if index < my_vector.len() { Some(my_vector.remove(index)) } else { None }` is annoying to write and non-panicking functions are broadly useful.
APC: rust-lang/libs-team#649
Tracking issue: rust-lang#146954
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
@bors
Auto merge ofrust-lang#147037- matthiaskrgr:rollup-xtgqzuu, r=matth…
0915c6f
…iaskrgr
Rollup of 8 pull requests
Successful merges:
- rust-lang#116882 (rustdoc: hide `#[repr]` if it isn't part of the public ABI)
- rust-lang#135771 ([rustdoc] Add support for associated items in "jump to def" feature)
- rust-lang#141032 (avoid violating `slice::from_raw_parts` safety contract in `Vec::extract_if`)
- rust-lang#142401 (Add proper name mangling for pattern types)
- rust-lang#146293 (feat: non-panicking `Vec::try_remove`)
- rust-lang#146859 (BTreeMap: Don't leak allocators when initializing nodes)
- rust-lang#146924 (Add doc for `NonZero*` const creation)
- rust-lang#146933 (Make `render_example_with_highlighting` return an `impl fmt::Display`)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
@bors
Auto merge of #147037 - matthiaskrgr:rollup-xtgqzuu, r=matthiaskrgr
968693f
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#116882 (rustdoc: hide `#[repr]` if it isn't part of the public ABI)
- rust-lang/rust#135771 ([rustdoc] Add support for associated items in "jump to def" feature)
- rust-lang/rust#141032 (avoid violating `slice::from_raw_parts` safety contract in `Vec::extract_if`)
- rust-lang/rust#142401 (Add proper name mangling for pattern types)
- rust-lang/rust#146293 (feat: non-panicking `Vec::try_remove`)
- rust-lang/rust#146859 (BTreeMap: Don't leak allocators when initializing nodes)
- rust-lang/rust#146924 (Add doc for `NonZero*` const creation)
- rust-lang/rust#146933 (Make `render_example_with_highlighting` return an `impl fmt::Display`)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
@bors
Auto merge of #147037 - matthiaskrgr:rollup-xtgqzuu, r=matthiaskrgr
7e272c0
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#116882 (rustdoc: hide `#[repr]` if it isn't part of the public ABI)
- rust-lang/rust#135771 ([rustdoc] Add support for associated items in "jump to def" feature)
- rust-lang/rust#141032 (avoid violating `slice::from_raw_parts` safety contract in `Vec::extract_if`)
- rust-lang/rust#142401 (Add proper name mangling for pattern types)
- rust-lang/rust#146293 (feat: non-panicking `Vec::try_remove`)
- rust-lang/rust#146859 (BTreeMap: Don't leak allocators when initializing nodes)
- rust-lang/rust#146924 (Add doc for `NonZero*` const creation)
- rust-lang/rust#146933 (Make `render_example_with_highlighting` return an `impl fmt::Display`)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@folkertdevfolkertdevfolkertdev left review comments
@joboetjoboetjoboet approved these changes

Assignees

@joboetjoboet

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

9 participants

@BenjaminBrienen@rustbot@rust-log-analyzer@workingjubilee@joboet@bors@folkertdev@tgross35@ibraheemdev