Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation - #146458

Merged
bors merged 1 commit into
rust-lang:masterfrom
Hayden602:bootstrap
Sep 18, 2025
Merged

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation#146458
bors merged 1 commit into
rust-lang:masterfrom
Hayden602:bootstrap

Conversation

@Hayden602

@Hayden602Hayden602 commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

Add the option to use the parallel compiler when building Rust code in bootstrap.

@rustbot

Copy link
Copy Markdown
Collaborator

This PR modifies bootstrap.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 12, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Hayden602
Hayden602force-pushed the bootstrap branch 2 times, most recently from ebc3e15 to 7c0230fCompareSeptember 12, 2025 07:13
@Hayden602

Copy link
Copy Markdown
ContributorAuthor

r? @SparrowLii@Kobzol
Hi,I’ve finished handling the issue regarding enabling parallel front end in bootstrap. Please help review if it looks appropriate. Thank you.

@rustbotrustbot assigned SparrowLii and unassigned clubby789Sep 12, 2025

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Could you please add an Info level entry to the change_tracker.rs file?

View changes since this review

Comment threadbootstrap.example.toml Outdated
# Trigger a `DebugBreak` after an internal compiler error during bootstrap on Windows
#rust.break-on-ice = true

# Set the number of threads used during rustc compilation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Set the number of threads used during rustc compilation
# Set the number of threads for the compiler frontend used during rustc compilation (passed to `-Zthreads`).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change also isn't limited to what is "used during rustc compilation", right? Tools, std, etc will get -Zthreads as well it seems?

Comment threadsrc/bootstrap/src/core/builder/cargo.rs Outdated
Comment threadbootstrap.example.toml
Comment threadbootstrap.example.toml Outdated

# Set the number of threads used during rustc compilation
# The valid options are:
# 1 - Use non-parallel compilation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's only in the frontend, so it's not "non-parallel compilation"

@fmeasefmease changed the title Add parallel-frontend-threads to bootstrap.toml and enable multi-thre…Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilationSep 12, 2025
@Hayden602
Hayden602force-pushed the bootstrap branch 2 times, most recently from 264a516 to b5ebe58CompareSeptember 15, 2025 06:23
@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Comment threadsrc/bootstrap/src/utils/change_tracker.rs Outdated

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As lqd said, it's not only the compilation of rustc (the compiler), but pretty much all Rust code built by bootstrap. Left three suggestions, if you accept them, and then squash the commits, I think we can go ahead and merge this :) Thanks!

View changes since this review

Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment on lines +864 to +865
# 0 - Set the number of threads according to the detected number of threads of the host system
# 0 - Set the number of threads according to the detected number of threads of the host system

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equal lines.

@Kobzol

Copy link
Copy Markdown
Member

Thank you!

@bors r+ rollup

@bors

bors commented Sep 17, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 929c933 has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2025
bors added a commit that referenced this pull request Sep 17, 2025
Rollup of 7 pull requests
Successful merges:
- #146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- #146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- #146536 (clean up several trait related UI tests)
- #146598 (Make llvm_enzyme a regular cargo feature)
- #146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- #146654 (Do not use `git -C dir`)
- #146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 0a2be63 into rust-lang:masterSep 18, 2025
10 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Sep 18, 2025
rust-timer added a commit that referenced this pull request Sep 18, 2025
Rollup merge of #146458 - Hayden602:bootstrap, r=Kobzol
Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation
Add the option to use the parallel compiler when building Rust code in bootstrap.
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
…zelmann
Rollup of 7 pull requests
Successful merges:
- rust-lang#146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- rust-lang#146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- rust-lang#146536 (clean up several trait related UI tests)
- rust-lang#146598 (Make llvm_enzyme a regular cargo feature)
- rust-lang#146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- rust-lang#146654 (Do not use `git -C dir`)
- rust-lang#146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- rust-lang/rust#146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- rust-lang/rust#146536 (clean up several trait related UI tests)
- rust-lang/rust#146598 (Make llvm_enzyme a regular cargo feature)
- rust-lang/rust#146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- rust-lang/rust#146654 (Do not use `git -C dir`)
- rust-lang/rust#146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@Hayden602@rustbot@rust-log-analyzer@Kobzol@bors@lqd@klensy@clubby789@SparrowLii
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation - #146458

Merged
bors merged 1 commit into
rust-lang:masterfrom
Hayden602:bootstrap
Sep 18, 2025
Merged

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation#146458
bors merged 1 commit into
rust-lang:masterfrom
Hayden602:bootstrap

Conversation

@Hayden602

@Hayden602Hayden602 commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

Add the option to use the parallel compiler when building Rust code in bootstrap.

@rustbot

Copy link
Copy Markdown
Collaborator

This PR modifies bootstrap.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 12, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Hayden602
Hayden602force-pushed the bootstrap branch 2 times, most recently from ebc3e15 to 7c0230fCompareSeptember 12, 2025 07:13
@Hayden602

Copy link
Copy Markdown
ContributorAuthor

r? @SparrowLii@Kobzol
Hi,I’ve finished handling the issue regarding enabling parallel front end in bootstrap. Please help review if it looks appropriate. Thank you.

@rustbotrustbot assigned SparrowLii and unassigned clubby789Sep 12, 2025

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Could you please add an Info level entry to the change_tracker.rs file?

View changes since this review

Comment threadbootstrap.example.toml Outdated
# Trigger a `DebugBreak` after an internal compiler error during bootstrap on Windows
#rust.break-on-ice = true

# Set the number of threads used during rustc compilation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Set the number of threads used during rustc compilation
# Set the number of threads for the compiler frontend used during rustc compilation (passed to `-Zthreads`).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change also isn't limited to what is "used during rustc compilation", right? Tools, std, etc will get -Zthreads as well it seems?

Comment threadsrc/bootstrap/src/core/builder/cargo.rs Outdated
Comment threadbootstrap.example.toml
Comment threadbootstrap.example.toml Outdated

# Set the number of threads used during rustc compilation
# The valid options are:
# 1 - Use non-parallel compilation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's only in the frontend, so it's not "non-parallel compilation"

@fmeasefmease changed the title Add parallel-frontend-threads to bootstrap.toml and enable multi-thre…Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilationSep 12, 2025
@Hayden602
Hayden602force-pushed the bootstrap branch 2 times, most recently from 264a516 to b5ebe58CompareSeptember 15, 2025 06:23
@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Comment threadsrc/bootstrap/src/utils/change_tracker.rs Outdated

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As lqd said, it's not only the compilation of rustc (the compiler), but pretty much all Rust code built by bootstrap. Left three suggestions, if you accept them, and then squash the commits, I think we can go ahead and merge this :) Thanks!

View changes since this review

Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment on lines +864 to +865
# 0 - Set the number of threads according to the detected number of threads of the host system
# 0 - Set the number of threads according to the detected number of threads of the host system

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equal lines.

@Kobzol

Copy link
Copy Markdown
Member

Thank you!

@bors r+ rollup

@bors

bors commented Sep 17, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 929c933 has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2025
bors added a commit that referenced this pull request Sep 17, 2025
Rollup of 7 pull requests
Successful merges:
- #146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- #146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- #146536 (clean up several trait related UI tests)
- #146598 (Make llvm_enzyme a regular cargo feature)
- #146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- #146654 (Do not use `git -C dir`)
- #146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 0a2be63 into rust-lang:masterSep 18, 2025
10 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Sep 18, 2025
rust-timer added a commit that referenced this pull request Sep 18, 2025
Rollup merge of #146458 - Hayden602:bootstrap, r=Kobzol
Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation
Add the option to use the parallel compiler when building Rust code in bootstrap.
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
…zelmann
Rollup of 7 pull requests
Successful merges:
- rust-lang#146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- rust-lang#146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- rust-lang#146536 (clean up several trait related UI tests)
- rust-lang#146598 (Make llvm_enzyme a regular cargo feature)
- rust-lang#146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- rust-lang#146654 (Do not use `git -C dir`)
- rust-lang#146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- rust-lang/rust#146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- rust-lang/rust#146536 (clean up several trait related UI tests)
- rust-lang/rust#146598 (Make llvm_enzyme a regular cargo feature)
- rust-lang/rust#146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- rust-lang/rust#146654 (Do not use `git -C dir`)
- rust-lang/rust#146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@Hayden602@rustbot@rust-log-analyzer@Kobzol@bors@lqd@klensy@clubby789@SparrowLii
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation - #146458

Merged
bors merged 1 commit into
rust-lang:masterfrom
Hayden602:bootstrap
Sep 18, 2025
Merged

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation#146458
bors merged 1 commit into
rust-lang:masterfrom
Hayden602:bootstrap

Conversation

@Hayden602

@Hayden602Hayden602 commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

Add the option to use the parallel compiler when building Rust code in bootstrap.

@rustbot

Copy link
Copy Markdown
Collaborator

This PR modifies bootstrap.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 12, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Hayden602
Hayden602force-pushed the bootstrap branch 2 times, most recently from ebc3e15 to 7c0230fCompareSeptember 12, 2025 07:13
@Hayden602

Copy link
Copy Markdown
ContributorAuthor

r? @SparrowLii@Kobzol
Hi,I’ve finished handling the issue regarding enabling parallel front end in bootstrap. Please help review if it looks appropriate. Thank you.

@rustbotrustbot assigned SparrowLii and unassigned clubby789Sep 12, 2025

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Could you please add an Info level entry to the change_tracker.rs file?

View changes since this review

Comment threadbootstrap.example.toml Outdated
# Trigger a `DebugBreak` after an internal compiler error during bootstrap on Windows
#rust.break-on-ice = true

# Set the number of threads used during rustc compilation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Set the number of threads used during rustc compilation
# Set the number of threads for the compiler frontend used during rustc compilation (passed to `-Zthreads`).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change also isn't limited to what is "used during rustc compilation", right? Tools, std, etc will get -Zthreads as well it seems?

Comment threadsrc/bootstrap/src/core/builder/cargo.rs Outdated
Comment threadbootstrap.example.toml
Comment threadbootstrap.example.toml Outdated

# Set the number of threads used during rustc compilation
# The valid options are:
# 1 - Use non-parallel compilation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's only in the frontend, so it's not "non-parallel compilation"

@fmeasefmease changed the title Add parallel-frontend-threads to bootstrap.toml and enable multi-thre…Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilationSep 12, 2025
@Hayden602
Hayden602force-pushed the bootstrap branch 2 times, most recently from 264a516 to b5ebe58CompareSeptember 15, 2025 06:23
@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Comment threadsrc/bootstrap/src/utils/change_tracker.rs Outdated

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As lqd said, it's not only the compilation of rustc (the compiler), but pretty much all Rust code built by bootstrap. Left three suggestions, if you accept them, and then squash the commits, I think we can go ahead and merge this :) Thanks!

View changes since this review

Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment on lines +864 to +865
# 0 - Set the number of threads according to the detected number of threads of the host system
# 0 - Set the number of threads according to the detected number of threads of the host system

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equal lines.

@Kobzol

Copy link
Copy Markdown
Member

Thank you!

@bors r+ rollup

@bors

bors commented Sep 17, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 929c933 has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2025
bors added a commit that referenced this pull request Sep 17, 2025
Rollup of 7 pull requests
Successful merges:
- #146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- #146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- #146536 (clean up several trait related UI tests)
- #146598 (Make llvm_enzyme a regular cargo feature)
- #146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- #146654 (Do not use `git -C dir`)
- #146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 0a2be63 into rust-lang:masterSep 18, 2025
10 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Sep 18, 2025
rust-timer added a commit that referenced this pull request Sep 18, 2025
Rollup merge of #146458 - Hayden602:bootstrap, r=Kobzol
Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation
Add the option to use the parallel compiler when building Rust code in bootstrap.
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
…zelmann
Rollup of 7 pull requests
Successful merges:
- rust-lang#146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- rust-lang#146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- rust-lang#146536 (clean up several trait related UI tests)
- rust-lang#146598 (Make llvm_enzyme a regular cargo feature)
- rust-lang#146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- rust-lang#146654 (Do not use `git -C dir`)
- rust-lang#146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- rust-lang/rust#146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- rust-lang/rust#146536 (clean up several trait related UI tests)
- rust-lang/rust#146598 (Make llvm_enzyme a regular cargo feature)
- rust-lang/rust#146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- rust-lang/rust#146654 (Do not use `git -C dir`)
- rust-lang/rust#146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@Hayden602@rustbot@rust-log-analyzer@Kobzol@bors@lqd@klensy@clubby789@SparrowLii
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation - #146458

Merged
bors merged 1 commit into
rust-lang:masterfrom
Hayden602:bootstrap
Sep 18, 2025
Merged

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation#146458
bors merged 1 commit into
rust-lang:masterfrom
Hayden602:bootstrap

Conversation

@Hayden602

@Hayden602Hayden602 commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

Add the option to use the parallel compiler when building Rust code in bootstrap.

@rustbot

Copy link
Copy Markdown
Collaborator

This PR modifies bootstrap.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 12, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Hayden602
Hayden602force-pushed the bootstrap branch 2 times, most recently from ebc3e15 to 7c0230fCompareSeptember 12, 2025 07:13
@Hayden602

Copy link
Copy Markdown
ContributorAuthor

r? @SparrowLii@Kobzol
Hi,I’ve finished handling the issue regarding enabling parallel front end in bootstrap. Please help review if it looks appropriate. Thank you.

@rustbotrustbot assigned SparrowLii and unassigned clubby789Sep 12, 2025

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Could you please add an Info level entry to the change_tracker.rs file?

View changes since this review

Comment threadbootstrap.example.toml Outdated
# Trigger a `DebugBreak` after an internal compiler error during bootstrap on Windows
#rust.break-on-ice = true

# Set the number of threads used during rustc compilation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Set the number of threads used during rustc compilation
# Set the number of threads for the compiler frontend used during rustc compilation (passed to `-Zthreads`).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change also isn't limited to what is "used during rustc compilation", right? Tools, std, etc will get -Zthreads as well it seems?

Comment threadsrc/bootstrap/src/core/builder/cargo.rs Outdated
Comment threadbootstrap.example.toml
Comment threadbootstrap.example.toml Outdated

# Set the number of threads used during rustc compilation
# The valid options are:
# 1 - Use non-parallel compilation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's only in the frontend, so it's not "non-parallel compilation"

@fmeasefmease changed the title Add parallel-frontend-threads to bootstrap.toml and enable multi-thre…Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilationSep 12, 2025
@Hayden602
Hayden602force-pushed the bootstrap branch 2 times, most recently from 264a516 to b5ebe58CompareSeptember 15, 2025 06:23
@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Comment threadsrc/bootstrap/src/utils/change_tracker.rs Outdated

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As lqd said, it's not only the compilation of rustc (the compiler), but pretty much all Rust code built by bootstrap. Left three suggestions, if you accept them, and then squash the commits, I think we can go ahead and merge this :) Thanks!

View changes since this review

Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment on lines +864 to +865
# 0 - Set the number of threads according to the detected number of threads of the host system
# 0 - Set the number of threads according to the detected number of threads of the host system

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equal lines.

@Kobzol

Copy link
Copy Markdown
Member

Thank you!

@bors r+ rollup

@bors

bors commented Sep 17, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 929c933 has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2025
bors added a commit that referenced this pull request Sep 17, 2025
Rollup of 7 pull requests
Successful merges:
- #146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- #146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- #146536 (clean up several trait related UI tests)
- #146598 (Make llvm_enzyme a regular cargo feature)
- #146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- #146654 (Do not use `git -C dir`)
- #146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 0a2be63 into rust-lang:masterSep 18, 2025
10 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Sep 18, 2025
rust-timer added a commit that referenced this pull request Sep 18, 2025
Rollup merge of #146458 - Hayden602:bootstrap, r=Kobzol
Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation
Add the option to use the parallel compiler when building Rust code in bootstrap.
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
…zelmann
Rollup of 7 pull requests
Successful merges:
- rust-lang#146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- rust-lang#146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- rust-lang#146536 (clean up several trait related UI tests)
- rust-lang#146598 (Make llvm_enzyme a regular cargo feature)
- rust-lang#146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- rust-lang#146654 (Do not use `git -C dir`)
- rust-lang#146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- rust-lang/rust#146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- rust-lang/rust#146536 (clean up several trait related UI tests)
- rust-lang/rust#146598 (Make llvm_enzyme a regular cargo feature)
- rust-lang/rust#146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- rust-lang/rust#146654 (Do not use `git -C dir`)
- rust-lang/rust#146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@Hayden602@rustbot@rust-log-analyzer@Kobzol@bors@lqd@klensy@clubby789@SparrowLii
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation - #146458

Merged
bors merged 1 commit into
rust-lang:masterfrom
Hayden602:bootstrap
Sep 18, 2025
Merged

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation#146458
bors merged 1 commit into
rust-lang:masterfrom
Hayden602:bootstrap

Conversation

@Hayden602

@Hayden602Hayden602 commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

Add the option to use the parallel compiler when building Rust code in bootstrap.

@rustbot

Copy link
Copy Markdown
Collaborator

This PR modifies bootstrap.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 12, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Hayden602
Hayden602force-pushed the bootstrap branch 2 times, most recently from ebc3e15 to 7c0230fCompareSeptember 12, 2025 07:13
@Hayden602

Copy link
Copy Markdown
ContributorAuthor

r? @SparrowLii@Kobzol
Hi,I’ve finished handling the issue regarding enabling parallel front end in bootstrap. Please help review if it looks appropriate. Thank you.

@rustbotrustbot assigned SparrowLii and unassigned clubby789Sep 12, 2025

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Could you please add an Info level entry to the change_tracker.rs file?

View changes since this review

Comment threadbootstrap.example.toml Outdated
# Trigger a `DebugBreak` after an internal compiler error during bootstrap on Windows
#rust.break-on-ice = true

# Set the number of threads used during rustc compilation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Set the number of threads used during rustc compilation
# Set the number of threads for the compiler frontend used during rustc compilation (passed to `-Zthreads`).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change also isn't limited to what is "used during rustc compilation", right? Tools, std, etc will get -Zthreads as well it seems?

Comment threadsrc/bootstrap/src/core/builder/cargo.rs Outdated
Comment threadbootstrap.example.toml
Comment threadbootstrap.example.toml Outdated

# Set the number of threads used during rustc compilation
# The valid options are:
# 1 - Use non-parallel compilation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's only in the frontend, so it's not "non-parallel compilation"

@fmeasefmease changed the title Add parallel-frontend-threads to bootstrap.toml and enable multi-thre…Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilationSep 12, 2025
@Hayden602
Hayden602force-pushed the bootstrap branch 2 times, most recently from 264a516 to b5ebe58CompareSeptember 15, 2025 06:23
@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Comment threadsrc/bootstrap/src/utils/change_tracker.rs Outdated

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As lqd said, it's not only the compilation of rustc (the compiler), but pretty much all Rust code built by bootstrap. Left three suggestions, if you accept them, and then squash the commits, I think we can go ahead and merge this :) Thanks!

View changes since this review

Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment on lines +864 to +865
# 0 - Set the number of threads according to the detected number of threads of the host system
# 0 - Set the number of threads according to the detected number of threads of the host system

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equal lines.

@Kobzol

Copy link
Copy Markdown
Member

Thank you!

@bors r+ rollup

@bors

bors commented Sep 17, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 929c933 has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2025
bors added a commit that referenced this pull request Sep 17, 2025
Rollup of 7 pull requests
Successful merges:
- #146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- #146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- #146536 (clean up several trait related UI tests)
- #146598 (Make llvm_enzyme a regular cargo feature)
- #146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- #146654 (Do not use `git -C dir`)
- #146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 0a2be63 into rust-lang:masterSep 18, 2025
10 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Sep 18, 2025
rust-timer added a commit that referenced this pull request Sep 18, 2025
Rollup merge of #146458 - Hayden602:bootstrap, r=Kobzol
Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation
Add the option to use the parallel compiler when building Rust code in bootstrap.
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
…zelmann
Rollup of 7 pull requests
Successful merges:
- rust-lang#146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- rust-lang#146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- rust-lang#146536 (clean up several trait related UI tests)
- rust-lang#146598 (Make llvm_enzyme a regular cargo feature)
- rust-lang#146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- rust-lang#146654 (Do not use `git -C dir`)
- rust-lang#146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- rust-lang/rust#146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- rust-lang/rust#146536 (clean up several trait related UI tests)
- rust-lang/rust#146598 (Make llvm_enzyme a regular cargo feature)
- rust-lang/rust#146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- rust-lang/rust#146654 (Do not use `git -C dir`)
- rust-lang/rust#146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@Hayden602@rustbot@rust-log-analyzer@Kobzol@bors@lqd@klensy@clubby789@SparrowLii
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation - #146458

Merged
bors merged 1 commit into
rust-lang:masterfrom
Hayden602:bootstrap
Sep 18, 2025
Merged

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation#146458
bors merged 1 commit into
rust-lang:masterfrom
Hayden602:bootstrap

Conversation

@Hayden602

@Hayden602Hayden602 commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

Add the option to use the parallel compiler when building Rust code in bootstrap.

@rustbot

Copy link
Copy Markdown
Collaborator

This PR modifies bootstrap.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 12, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Hayden602
Hayden602force-pushed the bootstrap branch 2 times, most recently from ebc3e15 to 7c0230fCompareSeptember 12, 2025 07:13
@Hayden602

Copy link
Copy Markdown
ContributorAuthor

r? @SparrowLii@Kobzol
Hi,I’ve finished handling the issue regarding enabling parallel front end in bootstrap. Please help review if it looks appropriate. Thank you.

@rustbotrustbot assigned SparrowLii and unassigned clubby789Sep 12, 2025

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Could you please add an Info level entry to the change_tracker.rs file?

View changes since this review

Comment threadbootstrap.example.toml Outdated
# Trigger a `DebugBreak` after an internal compiler error during bootstrap on Windows
#rust.break-on-ice = true

# Set the number of threads used during rustc compilation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Set the number of threads used during rustc compilation
# Set the number of threads for the compiler frontend used during rustc compilation (passed to `-Zthreads`).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change also isn't limited to what is "used during rustc compilation", right? Tools, std, etc will get -Zthreads as well it seems?

Comment threadsrc/bootstrap/src/core/builder/cargo.rs Outdated
Comment threadbootstrap.example.toml
Comment threadbootstrap.example.toml Outdated

# Set the number of threads used during rustc compilation
# The valid options are:
# 1 - Use non-parallel compilation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's only in the frontend, so it's not "non-parallel compilation"

@fmeasefmease changed the title Add parallel-frontend-threads to bootstrap.toml and enable multi-thre…Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilationSep 12, 2025
@Hayden602
Hayden602force-pushed the bootstrap branch 2 times, most recently from 264a516 to b5ebe58CompareSeptember 15, 2025 06:23
@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Comment threadsrc/bootstrap/src/utils/change_tracker.rs Outdated

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As lqd said, it's not only the compilation of rustc (the compiler), but pretty much all Rust code built by bootstrap. Left three suggestions, if you accept them, and then squash the commits, I think we can go ahead and merge this :) Thanks!

View changes since this review

Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment on lines +864 to +865
# 0 - Set the number of threads according to the detected number of threads of the host system
# 0 - Set the number of threads according to the detected number of threads of the host system

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equal lines.

@Kobzol

Copy link
Copy Markdown
Member

Thank you!

@bors r+ rollup

@bors

bors commented Sep 17, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 929c933 has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2025
bors added a commit that referenced this pull request Sep 17, 2025
Rollup of 7 pull requests
Successful merges:
- #146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- #146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- #146536 (clean up several trait related UI tests)
- #146598 (Make llvm_enzyme a regular cargo feature)
- #146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- #146654 (Do not use `git -C dir`)
- #146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 0a2be63 into rust-lang:masterSep 18, 2025
10 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Sep 18, 2025
rust-timer added a commit that referenced this pull request Sep 18, 2025
Rollup merge of #146458 - Hayden602:bootstrap, r=Kobzol
Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation
Add the option to use the parallel compiler when building Rust code in bootstrap.
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
…zelmann
Rollup of 7 pull requests
Successful merges:
- rust-lang#146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- rust-lang#146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- rust-lang#146536 (clean up several trait related UI tests)
- rust-lang#146598 (Make llvm_enzyme a regular cargo feature)
- rust-lang#146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- rust-lang#146654 (Do not use `git -C dir`)
- rust-lang#146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- rust-lang/rust#146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- rust-lang/rust#146536 (clean up several trait related UI tests)
- rust-lang/rust#146598 (Make llvm_enzyme a regular cargo feature)
- rust-lang/rust#146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- rust-lang/rust#146654 (Do not use `git -C dir`)
- rust-lang/rust#146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@Hayden602@rustbot@rust-log-analyzer@Kobzol@bors@lqd@klensy@clubby789@SparrowLii
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation - #146458

Merged
bors merged 1 commit into
rust-lang:masterfrom
Hayden602:bootstrap
Sep 18, 2025
Merged

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation#146458
bors merged 1 commit into
rust-lang:masterfrom
Hayden602:bootstrap

Conversation

@Hayden602

@Hayden602Hayden602 commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

Add the option to use the parallel compiler when building Rust code in bootstrap.

@rustbot

Copy link
Copy Markdown
Collaborator

This PR modifies bootstrap.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 12, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Hayden602
Hayden602force-pushed the bootstrap branch 2 times, most recently from ebc3e15 to 7c0230fCompareSeptember 12, 2025 07:13
@Hayden602

Copy link
Copy Markdown
ContributorAuthor

r? @SparrowLii@Kobzol
Hi,I’ve finished handling the issue regarding enabling parallel front end in bootstrap. Please help review if it looks appropriate. Thank you.

@rustbotrustbot assigned SparrowLii and unassigned clubby789Sep 12, 2025

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Could you please add an Info level entry to the change_tracker.rs file?

View changes since this review

Comment threadbootstrap.example.toml Outdated
# Trigger a `DebugBreak` after an internal compiler error during bootstrap on Windows
#rust.break-on-ice = true

# Set the number of threads used during rustc compilation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Set the number of threads used during rustc compilation
# Set the number of threads for the compiler frontend used during rustc compilation (passed to `-Zthreads`).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change also isn't limited to what is "used during rustc compilation", right? Tools, std, etc will get -Zthreads as well it seems?

Comment threadsrc/bootstrap/src/core/builder/cargo.rs Outdated
Comment threadbootstrap.example.toml
Comment threadbootstrap.example.toml Outdated

# Set the number of threads used during rustc compilation
# The valid options are:
# 1 - Use non-parallel compilation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's only in the frontend, so it's not "non-parallel compilation"

@fmeasefmease changed the title Add parallel-frontend-threads to bootstrap.toml and enable multi-thre…Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilationSep 12, 2025
@Hayden602
Hayden602force-pushed the bootstrap branch 2 times, most recently from 264a516 to b5ebe58CompareSeptember 15, 2025 06:23
@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Comment threadsrc/bootstrap/src/utils/change_tracker.rs Outdated

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As lqd said, it's not only the compilation of rustc (the compiler), but pretty much all Rust code built by bootstrap. Left three suggestions, if you accept them, and then squash the commits, I think we can go ahead and merge this :) Thanks!

View changes since this review

Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment on lines +864 to +865
# 0 - Set the number of threads according to the detected number of threads of the host system
# 0 - Set the number of threads according to the detected number of threads of the host system

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equal lines.

@Kobzol

Copy link
Copy Markdown
Member

Thank you!

@bors r+ rollup

@bors

bors commented Sep 17, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 929c933 has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2025
bors added a commit that referenced this pull request Sep 17, 2025
Rollup of 7 pull requests
Successful merges:
- #146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- #146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- #146536 (clean up several trait related UI tests)
- #146598 (Make llvm_enzyme a regular cargo feature)
- #146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- #146654 (Do not use `git -C dir`)
- #146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 0a2be63 into rust-lang:masterSep 18, 2025
10 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Sep 18, 2025
rust-timer added a commit that referenced this pull request Sep 18, 2025
Rollup merge of #146458 - Hayden602:bootstrap, r=Kobzol
Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation
Add the option to use the parallel compiler when building Rust code in bootstrap.
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
…zelmann
Rollup of 7 pull requests
Successful merges:
- rust-lang#146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- rust-lang#146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- rust-lang#146536 (clean up several trait related UI tests)
- rust-lang#146598 (Make llvm_enzyme a regular cargo feature)
- rust-lang#146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- rust-lang#146654 (Do not use `git -C dir`)
- rust-lang#146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- rust-lang/rust#146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- rust-lang/rust#146536 (clean up several trait related UI tests)
- rust-lang/rust#146598 (Make llvm_enzyme a regular cargo feature)
- rust-lang/rust#146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- rust-lang/rust#146654 (Do not use `git -C dir`)
- rust-lang/rust#146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@Hayden602@rustbot@rust-log-analyzer@Kobzol@bors@lqd@klensy@clubby789@SparrowLii
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation - #146458

Merged
bors merged 1 commit into
rust-lang:masterfrom
Hayden602:bootstrap
Sep 18, 2025
Merged

Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation#146458
bors merged 1 commit into
rust-lang:masterfrom
Hayden602:bootstrap

Conversation

@Hayden602

@Hayden602Hayden602 commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

Add the option to use the parallel compiler when building Rust code in bootstrap.

@rustbot

Copy link
Copy Markdown
Collaborator

This PR modifies bootstrap.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 12, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@Hayden602
Hayden602force-pushed the bootstrap branch 2 times, most recently from ebc3e15 to 7c0230fCompareSeptember 12, 2025 07:13
@Hayden602

Copy link
Copy Markdown
ContributorAuthor

r? @SparrowLii@Kobzol
Hi,I’ve finished handling the issue regarding enabling parallel front end in bootstrap. Please help review if it looks appropriate. Thank you.

@rustbotrustbot assigned SparrowLii and unassigned clubby789Sep 12, 2025

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good! Could you please add an Info level entry to the change_tracker.rs file?

View changes since this review

Comment threadbootstrap.example.toml Outdated
# Trigger a `DebugBreak` after an internal compiler error during bootstrap on Windows
#rust.break-on-ice = true

# Set the number of threads used during rustc compilation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Set the number of threads used during rustc compilation
# Set the number of threads for the compiler frontend used during rustc compilation (passed to `-Zthreads`).

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change also isn't limited to what is "used during rustc compilation", right? Tools, std, etc will get -Zthreads as well it seems?

Comment threadsrc/bootstrap/src/core/builder/cargo.rs Outdated
Comment threadbootstrap.example.toml
Comment threadbootstrap.example.toml Outdated

# Set the number of threads used during rustc compilation
# The valid options are:
# 1 - Use non-parallel compilation

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's only in the frontend, so it's not "non-parallel compilation"

@fmeasefmease changed the title Add parallel-frontend-threads to bootstrap.toml and enable multi-thre…Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilationSep 12, 2025
@Hayden602
Hayden602force-pushed the bootstrap branch 2 times, most recently from 264a516 to b5ebe58CompareSeptember 15, 2025 06:23
@rustbot

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Comment threadsrc/bootstrap/src/utils/change_tracker.rs Outdated

@KobzolKobzol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As lqd said, it's not only the compilation of rustc (the compiler), but pretty much all Rust code built by bootstrap. Left three suggestions, if you accept them, and then squash the commits, I think we can go ahead and merge this :) Thanks!

View changes since this review

Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment threadbootstrap.example.toml Outdated
Comment on lines +864 to +865
# 0 - Set the number of threads according to the detected number of threads of the host system
# 0 - Set the number of threads according to the detected number of threads of the host system

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Equal lines.

@Kobzol

Copy link
Copy Markdown
Member

Thank you!

@bors r+ rollup

@bors

bors commented Sep 17, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 929c933 has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 17, 2025
bors added a commit that referenced this pull request Sep 17, 2025
Rollup of 7 pull requests
Successful merges:
- #146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- #146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- #146536 (clean up several trait related UI tests)
- #146598 (Make llvm_enzyme a regular cargo feature)
- #146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- #146654 (Do not use `git -C dir`)
- #146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 0a2be63 into rust-lang:masterSep 18, 2025
10 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Sep 18, 2025
rust-timer added a commit that referenced this pull request Sep 18, 2025
Rollup merge of #146458 - Hayden602:bootstrap, r=Kobzol
Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation
Add the option to use the parallel compiler when building Rust code in bootstrap.
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
…zelmann
Rollup of 7 pull requests
Successful merges:
- rust-lang#146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- rust-lang#146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- rust-lang#146536 (clean up several trait related UI tests)
- rust-lang#146598 (Make llvm_enzyme a regular cargo feature)
- rust-lang#146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- rust-lang#146654 (Do not use `git -C dir`)
- rust-lang#146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#146458 (Add parallel-frontend-threads to bootstrap.toml and enable multi-threaded parallel compilation)
- rust-lang/rust#146485 (Remove unsized arg handling in `ArgAbiBuilderMethods::store_fn_arg` implementations)
- rust-lang/rust#146536 (clean up several trait related UI tests)
- rust-lang/rust#146598 (Make llvm_enzyme a regular cargo feature)
- rust-lang/rust#146647 (Move `#[rustc_coherence_is_core]` to the `crate_level` file)
- rust-lang/rust#146654 (Do not use `git -C dir`)
- rust-lang/rust#146681 (Add space after brace in `Box<[T]>::new_uninit_slice` example)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@Hayden602@rustbot@rust-log-analyzer@Kobzol@bors@lqd@klensy@clubby789@SparrowLii