Skip to content

Port #[register_tool] to the new attribute system - #146702

Closed
jdonszelmann wants to merge 3 commits into
rust-lang:mainfrom
jdonszelmann:register-tool
Closed

Port #[register_tool] to the new attribute system#146702
jdonszelmann wants to merge 3 commits into
rust-lang:mainfrom
jdonszelmann:register-tool

Conversation

@jdonszelmann

@jdonszelmannjdonszelmann commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

@rustbot blocked on #146652

@rustbotrustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Sep 18, 2025
@jdonszelmannjdonszelmann mentioned this pull request Sep 18, 2025
Open
9 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

bors commented Sep 22, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #146862) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

bors commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #147019) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

rust-log-analyzer commented Sep 27, 2025

Copy link
Copy Markdown
Collaborator

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] rustc_parse test:false 17.333
error: unused import: `LimitInvalid`
--> compiler/rustc_attr_parsing/src/attributes/crate_level.rs:2:54
|
2 | use crate::session_diagnostics::{ExpectedSingleWord, LimitInvalid};
| ^^^^^^^^^^^^
|
= note: `-D unused-imports` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(unused_imports)]`

@bors

bors commented Oct 5, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #147345) made this pull request unmergeable. Please resolve the merge conflicts.

@JonathanBrouwerJonathanBrouwer mentioned this pull request Feb 22, 2026
Merged
@JonathanBrouwer

JonathanBrouwer commented Feb 22, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Replaced by #152988

@rustbotrustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 22, 2026
jhpratt added a commit to jhpratt/rust that referenced this pull request Feb 23, 2026
@jhpratt
Rollup merge ofrust-lang#152988- JonathanBrouwer:register-tool, r=j…
66173bb
…donszelmann
Port `#[register_tool]` to the new attribute system
For rust-lang#131229 (comment)
Rebase of rust-lang#146702
r? @jdonszelmann
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 24, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#152988- JonathanBrouwer:register-tool, r=j…
055ae14
…donszelmann
Port `#[register_tool]` to the new attribute system
For rust-lang#131229 (comment)
Rebase of rust-lang#146702
r? @jdonszelmann
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 24, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#152988- JonathanBrouwer:register-tool, r=j…
4288d87
…donszelmann
Port `#[register_tool]` to the new attribute system
For rust-lang#131229 (comment)
Rebase of rust-lang#146702
r? @jdonszelmann
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 24, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#152988- JonathanBrouwer:register-tool, r=j…
ce244ea
…donszelmann
Port `#[register_tool]` to the new attribute system
For rust-lang#131229 (comment)
Rebase of rust-lang#146702
r? @jdonszelmann
rust-timer added a commit that referenced this pull request Feb 24, 2026
@rust-timer
Unrolled build for#152988
fcdc5dd
Rollup merge of #152988 - JonathanBrouwer:register-tool, r=jdonszelmann
Port `#[register_tool]` to the new attribute system
For #131229 (comment)
Rebase of #146702
r? @jdonszelmann
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Mar 2, 2026
@JonathanBrouwer
Rollup merge of #152988 - JonathanBrouwer:register-tool, r=jdonszelmann
841c556
Port `#[register_tool]` to the new attribute system
For rust-lang/rust#131229 (comment)
Rebase of rust-lang/rust#146702
r? @jdonszelmann
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-blockedStatus: Blocked on something else such as an RFC or other implementation work.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jdonszelmann@rust-log-analyzer@bors@JonathanBrouwer@rustbot