std: Add Motor OS std library port by lasiotus · Pull Request #147000 · rust-lang/rust

lasiotus · 2025-09-24T19:36:16Z

Motor OS was added as a no-std Tier-3 target in
PR 146848 as x86_64-unknown-motor.

This PR adds the std library for Motor OS.

While the PR may seem large, all it does is proxy
std pal calls to moto-rt. Where there is some non-trivial
code (e.g. thread::spawn), it is quite similar, often
identical, to what other platforms do.

rustbot · 2025-09-24T19:36:20Z

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

rustbot · 2025-09-24T19:36:22Z

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tgross35 · 2025-09-24T20:55:55Z

Is there any notable std functionality that isn't supported on this platform? Just skimming it, it seems like things are pretty complete (threads, systemtime, process, etc)

Nominating for libs as this adds a new std target.

@rustbot label +I-libs-nominated

lasiotus · 2025-09-24T21:15:22Z

Is there any notable std functionality that isn't supported on this platform? Just skimming it, it seems like things are pretty complete (threads, systemtime, process, etc)

I believe all major pieces are supported/implemented, including networking. Some specific things are not (yet) fully implemented, like FS links, or DNS lookup (at the moment, only "localhost" resolves to an IP address). On the other hand, tokio is ported via a mio port, which was not completely trivial...

bors · 2025-09-25T18:48:13Z

☔ The latest upstream changes (presumably #147019) made this pull request unmergeable. Please resolve the merge conflicts.

Amanieu · 2025-10-01T16:12:58Z

We discussed this in the @rust-lang/libs meeting and are happy to add std support for this target because it supports all major functionality of std.

lasiotus · 2025-10-02T15:58:56Z

We discussed this in the @rust-lang/libs meeting and are happy to add std support for this target because it supports all major functionality of std.

Thanks, Amanieu!

@tgross35 Trevor, how can I improve this PR to make it mergeable?

tgross35 · 2025-10-02T18:59:00Z

It's on my list, I just haven't had a chance to do a thorough review yet (probably later this week)

Rollup of 7 pull requests Successful merges: - #147000 (std: Add Motor OS std library port) - #147732 (remove duplicate inline macro) - #147738 (Don't highlight `let` expressions as having type `bool` in let-chain error messages) - #147739 (Fix whitespace in rustfmt-excluded clippy file) - #147744 (miri subtree update) - #147751 (Use `bit_set::Word` in a couple more places.) - #147752 (style-guide: fix typo for empty struct advice) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 9 pull requests Successful merges: - #144438 (Guard HIR lowered contracts with `contract_checks`) - #147000 (std: Add Motor OS std library port) - #147576 (Fix ICE on offsetted ZST pointer) - #147732 (remove duplicate inline macro) - #147738 (Don't highlight `let` expressions as having type `bool` in let-chain error messages) - #147744 (miri subtree update) - #147751 (Use `bit_set::Word` in a couple more places.) - #147752 (style-guide: fix typo for empty struct advice) - #147773 (`is_ascii` on an empty string or slice returns true) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #147000 - moturus:motor-os_stdlib_pr, r=tgross35 std: Add Motor OS std library port Motor OS was added as a no-std Tier-3 target in [PR 146848](#146848) as x86_64-unknown-motor. This PR adds the std library for Motor OS. While the PR may seem large, all it does is proxy std pal calls to [moto-rt](https://crates.io/crates/moto-rt). Where there is some non-trivial code (e.g. thread::spawn), it is quite similar, often identical, to what other platforms do.

thaliaarchi · 2025-10-16T23:07:20Z

+impl OsStringExt for OsString {
+ #[inline]
+ fn as_str(&self) -> &str {
+ self.to_str().unwrap()


If Motor OS strings are guaranteed UTF-8, why not do str::from_utf8_unchecked(self.as_encoded_bytes())?
Shouldn't this be into_string; otherwise it's redundant to OsStrExt?

But I suppose we can't rely on OS strings remaining UTF-8, since there's no UTF-8-guaranteed variant of OsString. (The user could push arbitrary bytes)

Maybe this is an argument for a UTF-8 OsString, but I'd also never heard of Motor OS, so maybe it's not worth the extra implementation cost.

Maybe this is an argument for a UTF-8 OsString, but [...] maybe it's not worth the extra implementation cost.
Yes, OsString currently is not platform specific in Rust, but just bytes. So while Motor OS is very much Rust-first, and Rust strings are UTF-8, there is no guarantee that bytes in OsString are actually UTF-8, so unwrap() seems appropriate here.
I'd also never heard of Motor OS [...]
Feel free to play around and post your impressions on Motor OS github (I'll need to update the building instructions doc, now that this PR is in).

I wrote more about my thoughts on this in #147797

Update the docs to reflect that [Motor OS std library PR](rust-lang#147000) has been merged.

docs: update Motor OS target docs Update the docs to reflect that [Motor OS std library PR](rust-lang#147000) has been merged.

Rollup merge of #147824 - moturus:motor-os-docs, r=Urgau docs: update Motor OS target docs Update the docs to reflect that [Motor OS std library PR](#147000) has been merged.

motor: Add new `set_times` stubs Motor OS `std` support (rust-lang#147000) and `set_times`/`set_times_nofollow` (rust-lang#147468) were merged around the same time, so Motor OS is missing this API and currently fails to build. cc `@lasiotus`

Rollup merge of #147930 - thaliaarchi:motor-set-times, r=joboet motor: Add new `set_times` stubs Motor OS `std` support (#147000) and `set_times`/`set_times_nofollow` (#147468) were merged around the same time, so Motor OS is missing this API and currently fails to build. cc `@lasiotus`

Rollup of 9 pull requests Successful merges: - rust-lang/rust#144438 (Guard HIR lowered contracts with `contract_checks`) - rust-lang/rust#147000 (std: Add Motor OS std library port) - rust-lang/rust#147576 (Fix ICE on offsetted ZST pointer) - rust-lang/rust#147732 (remove duplicate inline macro) - rust-lang/rust#147738 (Don't highlight `let` expressions as having type `bool` in let-chain error messages) - rust-lang/rust#147744 (miri subtree update) - rust-lang/rust#147751 (Use `bit_set::Word` in a couple more places.) - rust-lang/rust#147752 (style-guide: fix typo for empty struct advice) - rust-lang/rust#147773 (`is_ascii` on an empty string or slice returns true) r? `@ghost` `@rustbot` modify labels: rollup

…ss35 std: Add Motor OS std library port Motor OS was added as a no-std Tier-3 target in [PR 146848](rust-lang#146848) as x86_64-unknown-motor. This PR adds the std library for Motor OS. While the PR may seem large, all it does is proxy std pal calls to [moto-rt](https://crates.io/crates/moto-rt). Where there is some non-trivial code (e.g. thread::spawn), it is quite similar, often identical, to what other platforms do.

motor: Add new `set_times` stubs Motor OS `std` support (rust-lang#147000) and `set_times`/`set_times_nofollow` (rust-lang#147468) were merged around the same time, so Motor OS is missing this API and currently fails to build. cc `@lasiotus`

Rollup of 9 pull requests Successful merges: - rust-lang/rust#144438 (Guard HIR lowered contracts with `contract_checks`) - rust-lang/rust#147000 (std: Add Motor OS std library port) - rust-lang/rust#147576 (Fix ICE on offsetted ZST pointer) - rust-lang/rust#147732 (remove duplicate inline macro) - rust-lang/rust#147738 (Don't highlight `let` expressions as having type `bool` in let-chain error messages) - rust-lang/rust#147744 (miri subtree update) - rust-lang/rust#147751 (Use `bit_set::Word` in a couple more places.) - rust-lang/rust#147752 (style-guide: fix typo for empty struct advice) - rust-lang/rust#147773 (`is_ascii` on an empty string or slice returns true) r? `@ghost` `@rustbot` modify labels: rollup

docs: update Motor OS target docs Update the docs to reflect that [Motor OS std library PR](rust-lang/rust#147000) has been merged.

Rollup of 9 pull requests Successful merges: - rust-lang/rust#144438 (Guard HIR lowered contracts with `contract_checks`) - rust-lang/rust#147000 (std: Add Motor OS std library port) - rust-lang/rust#147576 (Fix ICE on offsetted ZST pointer) - rust-lang/rust#147732 (remove duplicate inline macro) - rust-lang/rust#147738 (Don't highlight `let` expressions as having type `bool` in let-chain error messages) - rust-lang/rust#147744 (miri subtree update) - rust-lang/rust#147751 (Use `bit_set::Word` in a couple more places.) - rust-lang/rust#147752 (style-guide: fix typo for empty struct advice) - rust-lang/rust#147773 (`is_ascii` on an empty string or slice returns true) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned tgross35 Sep 24, 2025

rustbot added the I-libs-nominated Nominated for discussion during a libs team meeting. label Sep 24, 2025

tgross35 requested changes Sep 25, 2025
View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2025

bjorn3 reviewed Sep 25, 2025
View reviewed changes

Comment threadlibrary/std/src/sys/pal/motor/os.rs Outdated

bjorn3 reviewed Sep 25, 2025
View reviewed changes

Comment threadlibrary/std/src/sys/pal/motor/os.rs Outdated

lasiotus force-pushed the motor-os_stdlib_pr branch from e2e23a1 to f3884e2Compare September 26, 2025 19:59

This comment has been minimized.
Sign in to view

lasiotus force-pushed the motor-os_stdlib_pr branch from f3884e2 to d8da6c0Compare September 26, 2025 20:41

lasiotus requested a review from tgross35 September 26, 2025 21:38

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 26, 2025

lasiotus requested a review from bjorn3 September 26, 2025 21:38

Amanieu removed the I-libs-nominated Nominated for discussion during a libs team meeting. label Oct 1, 2025

tgross35 requested changes Oct 3, 2025
View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2025

matthiaskrgr mentioned this pull request Oct 16, 2025
Rollup of 7 pull requests #147775
Closed

matthiaskrgr mentioned this pull request Oct 16, 2025
Rollup of 9 pull requests #147782
Merged

bors merged commit 91f48d8 into rust-lang:masterOct 16, 2025
10 checks passed

rustbot added this to the 1.92.0 milestone Oct 16, 2025

thaliaarchi reviewed Oct 16, 2025
View reviewed changes

This was referenced Oct 16, 2025
Tracking Issue for restructuring std::sys#117276
Open
motor: Use UTF-8 guarantee for OS strings #147797
Closed

lasiotus deleted the motor-os_stdlib_pr branch October 17, 2025 18:45

lasiotus mentioned this pull request Oct 17, 2025
read_buf and RtVdsoVtable provenance moturus/motor-os#27
Closed

lasiotus added a commit to moturus/rust that referenced this pull request Oct 17, 2025
docs: update Motor OS target docs
4329332
Update the docs to reflect that [Motor OS std library PR](rust-lang#147000) has been merged.

lasiotus mentioned this pull request Oct 17, 2025
docs: update Motor OS target docs #147824
Merged

lasiotus added a commit to moturus/rust that referenced this pull request Oct 17, 2025
docs: update Motor OS target docs
a274efc
Update the docs to reflect that [Motor OS std library PR](rust-lang#147000) has been merged.

lasiotus added a commit to moturus/rust that referenced this pull request Oct 17, 2025
docs: update Motor OS target docs
2e33760
Update the docs to reflect that [Motor OS std library PR](rust-lang#147000) has been merged.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 18, 2025
Rollup merge ofrust-lang#147824- moturus:motor-os-docs, r=Urgau
706f5fb
docs: update Motor OS target docs Update the docs to reflect that [Motor OS std library PR](rust-lang#147000) has been merged.

rust-timer added a commit that referenced this pull request Oct 18, 2025
Unrolled build for#147824
b77d45f
Rollup merge of #147824 - moturus:motor-os-docs, r=Urgau docs: update Motor OS target docs Update the docs to reflect that [Motor OS std library PR](#147000) has been merged.

thaliaarchi mentioned this pull request Oct 21, 2025
motor: Add new set_times stubs #147930
Merged

Uh oh!

Uh oh!

Conversation

lasiotus commented Sep 24, 2025

Uh oh!

rustbot commented Sep 24, 2025

Uh oh!

rustbot commented Sep 24, 2025

Uh oh!

tgross35 commented Sep 24, 2025

Uh oh!

lasiotus commented Sep 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bors commented Sep 25, 2025

Uh oh!

This comment has been minimized.

Amanieu commented Oct 1, 2025

Uh oh!

lasiotus commented Oct 2, 2025

Uh oh!

tgross35 commented Oct 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

thaliaarchiOct 16, 2025

Choose a reason for hiding this comment

Uh oh!

thaliaarchiOct 16, 2025

Choose a reason for hiding this comment

Uh oh!

thaliaarchiOct 16, 2025

Choose a reason for hiding this comment

Uh oh!

lasiotusOct 17, 2025

Choose a reason for hiding this comment

Uh oh!

thaliaarchiOct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants