Skip to content

Use LLVMDisposeTargetMachine - #147015

Merged
bors merged 1 commit into
rust-lang:masterfrom
Zalathar:dispose-tm
Sep 25, 2025
Merged

Use LLVMDisposeTargetMachine#147015
bors merged 1 commit into
rust-lang:masterfrom
Zalathar:dispose-tm

Conversation

@Zalathar

@ZalatharZalathar commented Sep 25, 2025

Copy link
Copy Markdown
Member

After bumping the minimum LLVM version to 20 (#145071), we no longer need to run any custom code when disposing of a TargetMachine, so we can just use the upstream LLVM-C function.

@rustbotrustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 25, 2025
@rustbot

rustbot commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@lqd

lqd commented Sep 25, 2025

Copy link
Copy Markdown
Member

Nice find! r=me when green.

r? lqd

@rustbotrustbot assigned lqd and unassigned BoxyUwUSep 25, 2025
@Zalathar

Zalathar commented Sep 25, 2025

Copy link
Copy Markdown
MemberAuthor

@bors r=lqd rollup

@bors

bors commented Sep 25, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 85018f0 has been approved by lqd

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2025
@ZalatharZalathar mentioned this pull request Sep 25, 2025
Merged
bors added a commit that referenced this pull request Sep 25, 2025
@bors
Auto merge of#147019- Zalathar:rollup-boxzbmo, r=Zalathar
6f34f4e
Rollup of 14 pull requests
Successful merges:
- #145067 (RawVecInner: add missing `unsafe` to unsafe fns)
- #145277 (Do not materialise X in [X; 0] when X is unsizing a const)
- #145973 (Add `std` support for `armv7a-vex-v5`)
- #146667 (Add an attribute to check the number of lanes in a SIMD vector after monomorphization)
- #146735 (unstably constify float mul_add methods)
- #146737 (f16_f128: enable some more tests in Miri)
- #146766 (Add attributes for #[global_allocator] functions)
- #146905 (llvm: update remarks support on LLVM 22)
- #146982 (Remove erroneous normalization step in `tests/run-make/linker-warning`)
- #147005 (Small string formatting cleanup)
- #147007 (Explicitly note `&[SocketAddr]` impl of `ToSocketAddrs`)
- #147008 (bootstrap.py: Respect build.jobs while building bootstrap tool)
- #147013 (rustdoc: Fix documentation for `--doctest-build-arg`)
- #147015 (Use `LLVMDisposeTargetMachine`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 59866ef into rust-lang:masterSep 25, 2025
10 checks passed
rust-timer added a commit that referenced this pull request Sep 25, 2025
@rust-timer
Unrolled build for#147015
f8906ed
Rollup merge of #147015 - Zalathar:dispose-tm, r=lqd
Use `LLVMDisposeTargetMachine`
After bumping the minimum LLVM version to 20 (#145071), we no longer need to run any custom code when disposing of a TargetMachine, so we can just use the upstream LLVM-C function.
@rustbotrustbot added this to the 1.92.0 milestone Sep 25, 2025
@Zalathar
Zalathar deleted the dispose-tm branch September 25, 2025 23:03
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Sep 26, 2025
@bors
Auto merge of #147019 - Zalathar:rollup-boxzbmo, r=Zalathar
1e67c4a
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#145067 (RawVecInner: add missing `unsafe` to unsafe fns)
- rust-lang/rust#145277 (Do not materialise X in [X; 0] when X is unsizing a const)
- rust-lang/rust#145973 (Add `std` support for `armv7a-vex-v5`)
- rust-lang/rust#146667 (Add an attribute to check the number of lanes in a SIMD vector after monomorphization)
- rust-lang/rust#146735 (unstably constify float mul_add methods)
- rust-lang/rust#146737 (f16_f128: enable some more tests in Miri)
- rust-lang/rust#146766 (Add attributes for #[global_allocator] functions)
- rust-lang/rust#146905 (llvm: update remarks support on LLVM 22)
- rust-lang/rust#146982 (Remove erroneous normalization step in `tests/run-make/linker-warning`)
- rust-lang/rust#147005 (Small string formatting cleanup)
- rust-lang/rust#147007 (Explicitly note `&[SocketAddr]` impl of `ToSocketAddrs`)
- rust-lang/rust#147008 (bootstrap.py: Respect build.jobs while building bootstrap tool)
- rust-lang/rust#147013 (rustdoc: Fix documentation for `--doctest-build-arg`)
- rust-lang/rust#147015 (Use `LLVMDisposeTargetMachine`)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
@bors
Auto merge ofrust-lang#147019- Zalathar:rollup-boxzbmo, r=Zalathar
c5cdb3d
Rollup of 14 pull requests
Successful merges:
- rust-lang#145067 (RawVecInner: add missing `unsafe` to unsafe fns)
- rust-lang#145277 (Do not materialise X in [X; 0] when X is unsizing a const)
- rust-lang#145973 (Add `std` support for `armv7a-vex-v5`)
- rust-lang#146667 (Add an attribute to check the number of lanes in a SIMD vector after monomorphization)
- rust-lang#146735 (unstably constify float mul_add methods)
- rust-lang#146737 (f16_f128: enable some more tests in Miri)
- rust-lang#146766 (Add attributes for #[global_allocator] functions)
- rust-lang#146905 (llvm: update remarks support on LLVM 22)
- rust-lang#146982 (Remove erroneous normalization step in `tests/run-make/linker-warning`)
- rust-lang#147005 (Small string formatting cleanup)
- rust-lang#147007 (Explicitly note `&[SocketAddr]` impl of `ToSocketAddrs`)
- rust-lang#147008 (bootstrap.py: Respect build.jobs while building bootstrap tool)
- rust-lang#147013 (rustdoc: Fix documentation for `--doctest-build-arg`)
- rust-lang#147015 (Use `LLVMDisposeTargetMachine`)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_gcc that referenced this pull request Dec 21, 2025
@bors
Auto merge of #147019 - Zalathar:rollup-boxzbmo, r=Zalathar
aff3754
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#145067 (RawVecInner: add missing `unsafe` to unsafe fns)
- rust-lang/rust#145277 (Do not materialise X in [X; 0] when X is unsizing a const)
- rust-lang/rust#145973 (Add `std` support for `armv7a-vex-v5`)
- rust-lang/rust#146667 (Add an attribute to check the number of lanes in a SIMD vector after monomorphization)
- rust-lang/rust#146735 (unstably constify float mul_add methods)
- rust-lang/rust#146737 (f16_f128: enable some more tests in Miri)
- rust-lang/rust#146766 (Add attributes for #[global_allocator] functions)
- rust-lang/rust#146905 (llvm: update remarks support on LLVM 22)
- rust-lang/rust#146982 (Remove erroneous normalization step in `tests/run-make/linker-warning`)
- rust-lang/rust#147005 (Small string formatting cleanup)
- rust-lang/rust#147007 (Explicitly note `&[SocketAddr]` impl of `ToSocketAddrs`)
- rust-lang/rust#147008 (bootstrap.py: Respect build.jobs while building bootstrap tool)
- rust-lang/rust#147013 (rustdoc: Fix documentation for `--doctest-build-arg`)
- rust-lang/rust#147015 (Use `LLVMDisposeTargetMachine`)
r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
@bors
Auto merge of #147019 - Zalathar:rollup-boxzbmo, r=Zalathar
505f919
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#145067 (RawVecInner: add missing `unsafe` to unsafe fns)
- rust-lang/rust#145277 (Do not materialise X in [X; 0] when X is unsizing a const)
- rust-lang/rust#145973 (Add `std` support for `armv7a-vex-v5`)
- rust-lang/rust#146667 (Add an attribute to check the number of lanes in a SIMD vector after monomorphization)
- rust-lang/rust#146735 (unstably constify float mul_add methods)
- rust-lang/rust#146737 (f16_f128: enable some more tests in Miri)
- rust-lang/rust#146766 (Add attributes for #[global_allocator] functions)
- rust-lang/rust#146905 (llvm: update remarks support on LLVM 22)
- rust-lang/rust#146982 (Remove erroneous normalization step in `tests/run-make/linker-warning`)
- rust-lang/rust#147005 (Small string formatting cleanup)
- rust-lang/rust#147007 (Explicitly note `&[SocketAddr]` impl of `ToSocketAddrs`)
- rust-lang/rust#147008 (bootstrap.py: Respect build.jobs while building bootstrap tool)
- rust-lang/rust#147013 (rustdoc: Fix documentation for `--doctest-build-arg`)
- rust-lang/rust#147015 (Use `LLVMDisposeTargetMachine`)
r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #147019 - Zalathar:rollup-boxzbmo, r=Zalathar
f7448db
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#145067 (RawVecInner: add missing `unsafe` to unsafe fns)
- rust-lang/rust#145277 (Do not materialise X in [X; 0] when X is unsizing a const)
- rust-lang/rust#145973 (Add `std` support for `armv7a-vex-v5`)
- rust-lang/rust#146667 (Add an attribute to check the number of lanes in a SIMD vector after monomorphization)
- rust-lang/rust#146735 (unstably constify float mul_add methods)
- rust-lang/rust#146737 (f16_f128: enable some more tests in Miri)
- rust-lang/rust#146766 (Add attributes for #[global_allocator] functions)
- rust-lang/rust#146905 (llvm: update remarks support on LLVM 22)
- rust-lang/rust#146982 (Remove erroneous normalization step in `tests/run-make/linker-warning`)
- rust-lang/rust#147005 (Small string formatting cleanup)
- rust-lang/rust#147007 (Explicitly note `&[SocketAddr]` impl of `ToSocketAddrs`)
- rust-lang/rust#147008 (bootstrap.py: Respect build.jobs while building bootstrap tool)
- rust-lang/rust#147013 (rustdoc: Fix documentation for `--doctest-build-arg`)
- rust-lang/rust#147015 (Use `LLVMDisposeTargetMachine`)
r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #147019 - Zalathar:rollup-boxzbmo, r=Zalathar
df2351a
Rollup of 14 pull requests
Successful merges:
- rust-lang/rust#145067 (RawVecInner: add missing `unsafe` to unsafe fns)
- rust-lang/rust#145277 (Do not materialise X in [X; 0] when X is unsizing a const)
- rust-lang/rust#145973 (Add `std` support for `armv7a-vex-v5`)
- rust-lang/rust#146667 (Add an attribute to check the number of lanes in a SIMD vector after monomorphization)
- rust-lang/rust#146735 (unstably constify float mul_add methods)
- rust-lang/rust#146737 (f16_f128: enable some more tests in Miri)
- rust-lang/rust#146766 (Add attributes for #[global_allocator] functions)
- rust-lang/rust#146905 (llvm: update remarks support on LLVM 22)
- rust-lang/rust#146982 (Remove erroneous normalization step in `tests/run-make/linker-warning`)
- rust-lang/rust#147005 (Small string formatting cleanup)
- rust-lang/rust#147007 (Explicitly note `&[SocketAddr]` impl of `ToSocketAddrs`)
- rust-lang/rust#147008 (bootstrap.py: Respect build.jobs while building bootstrap tool)
- rust-lang/rust#147013 (rustdoc: Fix documentation for `--doctest-build-arg`)
- rust-lang/rust#147015 (Use `LLVMDisposeTargetMachine`)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lqdlqd

Labels

A-LLVMArea: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Zalathar@rustbot@lqd@bors@BoxyUwU