Skip to content

Use MirPatch in simplify_branches. - #147131

Merged
bors merged 1 commit into
rust-lang:masterfrom
cjgillot:patch-branches
Sep 30, 2025
Merged

Use MirPatch in simplify_branches.#147131
bors merged 1 commit into
rust-lang:masterfrom
cjgillot:patch-branches

Conversation

@cjgillot

@cjgillotcjgillot commented Sep 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

This allows to avoid clearing the CFG cache if we don't perform any change.

r? @ghost for perf

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 28, 2025
@cjgillot

cjgillot commented Sep 28, 2025

Copy link
Copy Markdown
ContributorAuthor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot added a commit that referenced this pull request Sep 28, 2025
@rust-bors
Auto merge of#147131- cjgillot:patch-branches, r=<try>
0e126a7
Use MirPatch in simplify_branches.
@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 28, 2025
@rust-bors

rust-borsBot commented Sep 28, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 0e126a7 (0e126a774c708007b8130681b246a072de097971, parent: c8905eaa66e0c35a33626e974b9ce6955c739b5b)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Sep 28, 2025

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (0e126a7): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		0.0%[0.0%, 0.0%]1
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (primary 0.7%, secondary -0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		2.1%[1.1%, 2.7%]3
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-3.6%[-3.6%, -3.6%]1
Improvements ✅
(secondary)		-0.8%[-0.8%, -0.8%]1
All ❌✅ (primary)0.7%[-3.6%, 2.7%]4

Cycles

Results (secondary 2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		2.8%[2.5%, 3.4%]3
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.874s -> 470.61s (-0.06%)
Artifact size: 387.66 MiB -> 387.68 MiB (0.01%)

@rustbotrustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 28, 2025
@cjgillot
cjgillot marked this pull request as ready for review September 28, 2025 23:51
@rustbot

rustbot commented Sep 28, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 28, 2025
@cjgillot

cjgillot commented Sep 28, 2025

Copy link
Copy Markdown
ContributorAuthor

r? compiler

@davidtwco

davidtwco commented Sep 29, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 599e8db has been approved by davidtwco

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Sep 29, 2025
@matthiaskrgr
Rollup merge ofrust-lang#147131- cjgillot:patch-branches, r=davidtwco
73091b0
Use MirPatch in simplify_branches.
This allows to avoid clearing the CFG cache if we don't perform any change.
r? `@ghost` for perf
@matthiaskrgrmatthiaskrgr mentioned this pull request Sep 29, 2025
Closed
bors added a commit that referenced this pull request Sep 29, 2025
@bors
Auto merge of#147158- matthiaskrgr:rollup-rc03jo1, r=matthiaskrgr
3a1d3f2
Rollup of 6 pull requests
Successful merges:
- #143613 (Fix backtraces with `-C panic=abort` on linux; emit unwind tables by default)
- #146937 (std: implement `hostname`)
- #147040 (mbe: macro_check: Fix function comments referencing non-existent parameters)
- #147131 (Use MirPatch in simplify_branches.)
- #147133 (Remove one loop in `extract_cfg_from_attrs`)
- #147150 (Emit allocator attributes for allocator shim)
r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgrmatthiaskrgr mentioned this pull request Sep 29, 2025
Merged
bors added a commit that referenced this pull request Sep 29, 2025
@bors
Auto merge of#147162- matthiaskrgr:rollup-4bv1xzb, r=matthiaskrgr
29b7717
Rollup of 5 pull requests
Successful merges:
- #146937 (std: implement `hostname`)
- #147040 (mbe: macro_check: Fix function comments referencing non-existent parameters)
- #147131 (Use MirPatch in simplify_branches.)
- #147133 (Remove one loop in `extract_cfg_from_attrs`)
- #147150 (Emit allocator attributes for allocator shim)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit fdb965f into rust-lang:masterSep 30, 2025
11 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Sep 30, 2025
rust-timer added a commit that referenced this pull request Sep 30, 2025
@rust-timer
Unrolled build for#147131
efef016
Rollup merge of #147131 - cjgillot:patch-branches, r=davidtwco
Use MirPatch in simplify_branches.
This allows to avoid clearing the CFG cache if we don't perform any change.
r? ``@ghost`` for perf
@cjgillot
cjgillot deleted the patch-branches branch September 30, 2025 09:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwcodavidtwcodavidtwco approved these changes

Assignees

@davidtwcodavidtwco

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

5 participants

@cjgillot@rust-timer@rustbot@davidtwco@bors