Do two passes of `handle_opaque_type_uses_next` by jackh726 · Pull Request #147249 · rust-lang/rust

jackh726 · 2025-10-01T23:33:24Z

Fixesrust-lang/trait-system-refactor-initiative#240

Also did a little bit of cleanup, can squash the commits if decided.

r? lcnr

…pre-fallback where we equate hidden types but do not report errors

rustbot · 2025-10-02T21:20:18Z

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jackh726 · 2025-10-03T20:59:04Z

@lcnr I fixed your first three comments. The rename from first_pass to error_on_missing_defining_use kind of just made me realize that assert!(prev.is_none) is just kind of not needed, so I added a comment explaining as such. Your last comment, I do have strongish feelings about, replied on that. Curious on your thoughts.

…ve the assert in favor over a comment, and change to & for &mut

lcnr · 2025-10-07T08:08:48Z

+ // We do actually need to check this the second pass (we can't just
+ // store this), because we can go from `UnconstrainedHiddenType` to
+ // `HasDefiningUse` (because of fallback)


we can also just go from no uses to a defining use due to fallback, e.g. if you have soem ?will_fallback: Trait<opaque> goal

That is UnconstrainedHiddleType?

it could also be None. Maybe not with this specific example, but certainly with ?will_fallback: RequiresSend<fn_ptr_to_opaque>

lcnr

please also/instead add the more minimized tests from rust-lang/trait-system-refactor-initiative#240

View changes since this review

jackh726 · 2025-10-12T17:19:29Z

please also/instead add the more minimized tests from rust-lang/trait-system-refactor-initiative#240

Done. Just put each minimization in the same test file.

lcnr

nits, then r=me

View changes since this review

…inimizations. Update comment and test.

jackh726 · 2025-10-14T03:09:57Z

@bors r=lcnr

bors · 2025-10-14T03:10:00Z

📌 Commit d51f09e has been approved by lcnr

It is now in the queue for this repository.

Do two passes of `handle_opaque_type_uses_next` Fixesrust-lang/trait-system-refactor-initiative#240 Also did a little bit of cleanup, can squash the commits if decided. r? lcnr

Rollup of 11 pull requests Successful merges: - #146277 (Enable `u64` limbs in `core::num::bignum`) - #146976 (constify basic Clone impls) - #147249 (Do two passes of `handle_opaque_type_uses_next`) - #147266 (fix 2 search graph bugs) - #147468 (Implement fs api set_times and set_times_nofollow) - #147497 (`proc_macro` cleanups (3/N)) - #147594 (std: implement `pal::os::exit` for VEXos) - #147596 (Adjust the Arm targets in CI to reflect latest changes) - #147607 (GVN: Invalidate derefs at loop headers) - #147620 (Avoid redundant UB check in RangeFrom slice indexing) - #147647 (Hide vendoring and copyright in GHA group) r? `@ghost` `@rustbot` modify labels: rollup

Do two passes of `handle_opaque_type_uses_next` Fixesrust-lang/trait-system-refactor-initiative#240 Also did a little bit of cleanup, can squash the commits if decided. r? lcnr

Rollup of 12 pull requests Successful merges: - #146277 (Enable `u64` limbs in `core::num::bignum`) - #146976 (constify basic Clone impls) - #147249 (Do two passes of `handle_opaque_type_uses_next`) - #147266 (fix 2 search graph bugs) - #147497 (`proc_macro` cleanups (3/N)) - #147546 (Suppress unused_parens for labeled break) - #147548 (Fix ICE for never pattern as closure parameters) - #147594 (std: implement `pal::os::exit` for VEXos) - #147596 (Adjust the Arm targets in CI to reflect latest changes) - #147607 (GVN: Invalidate derefs at loop headers) - #147620 (Avoid redundant UB check in RangeFrom slice indexing) - #147647 (Hide vendoring and copyright in GHA group) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #147249 - jackh726:opaque-type-fallback, r=lcnr Do two passes of `handle_opaque_type_uses_next` Fixesrust-lang/trait-system-refactor-initiative#240 Also did a little bit of cleanup, can squash the commits if decided. r? lcnr

Zalathar · 2025-10-15T00:15:09Z

Bors hasn't noticed that this was merged.

@bors r-

Rollup of 12 pull requests Successful merges: - rust-lang#146277 (Enable `u64` limbs in `core::num::bignum`) - rust-lang#146976 (constify basic Clone impls) - rust-lang#147249 (Do two passes of `handle_opaque_type_uses_next`) - rust-lang#147266 (fix 2 search graph bugs) - rust-lang#147497 (`proc_macro` cleanups (3/N)) - rust-lang#147546 (Suppress unused_parens for labeled break) - rust-lang#147548 (Fix ICE for never pattern as closure parameters) - rust-lang#147594 (std: implement `pal::os::exit` for VEXos) - rust-lang#147596 (Adjust the Arm targets in CI to reflect latest changes) - rust-lang#147607 (GVN: Invalidate derefs at loop headers) - rust-lang#147620 (Avoid redundant UB check in RangeFrom slice indexing) - rust-lang#147647 (Hide vendoring and copyright in GHA group) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned lcnr Oct 1, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 1, 2025

lcnr reviewed Oct 2, 2025
View reviewed changes

Comment threadtests/ui/traits/next-solver/opaques/hidden-types-equate-before-fallback.rs

jackh726 added 4 commits October 2, 2025 21:06

When computing opaque types in the next solver, take an initial pass …
db3c9b6
…pre-fallback where we equate hidden types but do not report errors

Cleanup opaque_type computation a bit
9a5cef1

Remove UsageKind::HasError
c6c58e3

Merge match and if
a3fbae5

rust-cloud-vmsBotforce-pushed the opaque-type-fallback branch from ca75834 to a3fbae5Compare October 2, 2025 21:20

lcnr reviewed Oct 3, 2025
View reviewed changes

Comment threadcompiler/rustc_hir_typeck/src/opaque_types.rs Outdated
Comment threadcompiler/rustc_hir_typeck/src/opaque_types.rs Outdated
Comment threadcompiler/rustc_hir_typeck/src/opaque_types.rs Outdated
Comment threadcompiler/rustc_hir_typeck/src/opaque_types.rs

This comment has been minimized.
Sign in to view

Fix comment, change first_pass to error_on_missing_defining_use, remo…
283ad66
…ve the assert in favor over a comment, and change to & for &mut

jackh726 force-pushed the opaque-type-fallback branch from c113b29 to 283ad66Compare October 3, 2025 22:01

Remove unneeded get_hidden_type
8b17827

lcnr reviewed Oct 7, 2025
View reviewed changes

Comment threadcompiler/rustc_hir_typeck/src/opaque_types.rs Outdated

lcnr reviewed Oct 7, 2025
View reviewed changes

lcnr reviewed Oct 13, 2025
View reviewed changes

Comment threadcompiler/rustc_hir_typeck/src/opaque_types.rs Outdated

lcnr reviewed Oct 13, 2025
View reviewed changes

Comment threadtests/ui/traits/next-solver/opaques/hidden-types-equate-before-fallback.rs Outdated

lcnr reviewed Oct 13, 2025
View reviewed changes

Review comments. Move resolve_vars_if_possible into fn and add test m…
d51f09e
…inimizations. Update comment and test.

rust-cloud-vmsBotforce-pushed the opaque-type-fallback branch from 2fc6f80 to d51f09eCompare October 13, 2025 20:25

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 14, 2025

Zalathar mentioned this pull request Oct 14, 2025
Rollup of 11 pull requests #147659
Closed

Zalathar mentioned this pull request Oct 14, 2025
Rollup of 12 pull requests #147662
Merged

This was referenced Oct 14, 2025
Rollup of 10 pull requests #147663
Closed
Rollup of 10 pull requests #147661
Closed

bors merged commit 3a80521 into rust-lang:masterOct 14, 2025
10 checks passed

rustbot added this to the 1.92.0 milestone Oct 14, 2025

jackh726 deleted the opaque-type-fallback branch October 14, 2025 17:30

matthiaskrgr mentioned this pull request Oct 14, 2025
Rollup of 11 pull requests #147690
Closed

lcnr mentioned this pull request Oct 14, 2025
handle_opaque_type_uses happens after fallback rust-lang/trait-system-refactor-initiative#240
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 15, 2025

lcnr mentioned this pull request Oct 23, 2025
Stabilize the next-generation trait solver rust-lang/goals#113
Open
8 tasks

lcnr mentioned this pull request Aug 3, 2026
utoipa-gen breakage rust-lang/trait-system-refactor-initiative#207
Closed

Uh oh!

Uh oh!

Conversation

jackh726 commented Oct 1, 2025

Uh oh!

Uh oh!

rustbot commented Oct 2, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jackh726 commented Oct 3, 2025

Uh oh!

This comment has been minimized.

Uh oh!

lcnrOct 7, 2025

Choose a reason for hiding this comment

Uh oh!

jackh726Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

lcnrOct 13, 2025

Choose a reason for hiding this comment

Uh oh!

lcnr left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jackh726 commented Oct 12, 2025

Uh oh!

Uh oh!

Uh oh!

lcnr left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jackh726 commented Oct 14, 2025

Uh oh!

bors commented Oct 14, 2025

Uh oh!

Uh oh!

Zalathar commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

lcnr left a comment •
edited by rustbot
Loading

lcnr left a comment •
edited by rustbot
Loading