Skip to content

Don't normalize higher-ranked assumptions if they're not used - #147299

Merged
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:hr-norm
Oct 4, 2025
Merged

Don't normalize higher-ranked assumptions if they're not used#147299
bors merged 1 commit into
rust-lang:masterfrom
compiler-errors:hr-norm

Conversation

@compiler-errors

@compiler-errorscompiler-errors commented Oct 3, 2025•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

See the comment in the code.

Normalizing these assumptions may cause us to register things like new placeholder outlives obligations that cause higher-ranked lifetime errors, and this is problematic if we're not even using these assumptions in borrowck.

Fixes#147244
Fixes#147285

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 3, 2025
@rustbot

rustbot commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@compiler-errorscompiler-errors added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-async-await Area: Async & Await T-types Relevant to the types team, which will review and decide on the PR/issue. A-higher-ranked Area: Higher-ranked things (e.g., lifetimes, types, trait bounds aka HRTBs) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2025
@jackh726

jackh726 commented Oct 3, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup=never

@bors

bors commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit e3f1046 has been approved by jackh726

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2025
@bors

bors commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit e3f1046 with merge 7950f24...

@bors

bors commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing 7950f24 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 4, 2025
@bors
bors merged commit 7950f24 into rust-lang:masterOct 4, 2025
11 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 4, 2025
@github-actions

github-actionsBot commented Oct 4, 2025

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 595b9a4 (parent) -> 7950f24 (this PR)

Test differences

Show 16 test diffs

Stage 1

  • [ui] tests/ui/async-await/higher-ranked-normalize-assumptions-2.rs#hr: [missing] -> pass (J0)
  • [ui] tests/ui/async-await/higher-ranked-normalize-assumptions-2.rs#stock: [missing] -> pass (J0)
  • [ui] tests/ui/async-await/higher-ranked-normalize-assumptions.rs#hr: [missing] -> pass (J0)
  • [ui] tests/ui/async-await/higher-ranked-normalize-assumptions.rs#stock: [missing] -> pass (J0)

Stage 2

  • [ui] tests/ui/async-await/higher-ranked-normalize-assumptions-2.rs#hr: [missing] -> pass (J1)
  • [ui] tests/ui/async-await/higher-ranked-normalize-assumptions-2.rs#stock: [missing] -> pass (J1)
  • [ui] tests/ui/async-await/higher-ranked-normalize-assumptions.rs#hr: [missing] -> pass (J1)
  • [ui] tests/ui/async-await/higher-ranked-normalize-assumptions.rs#stock: [missing] -> pass (J1)

Additionally, 8 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 7950f244e7ef55b61a83d12f4662be643cd182d6 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-msvc: 5274.6s -> 6397.1s (21.3%)
  2. test-various: 4011.5s -> 4749.2s (18.4%)
  3. i686-gnu-nopt-1: 7051.7s -> 8138.1s (15.4%)
  4. dist-aarch64-apple: 5608.3s -> 6359.8s (13.4%)
  5. aarch64-msvc-2: 4604.2s -> 5220.5s (13.4%)
  6. aarch64-apple: 9620.4s -> 8432.2s (-12.4%)
  7. pr-check-1: 1400.5s -> 1571.3s (12.2%)
  8. aarch64-gnu-llvm-20-2: 2153.3s -> 2375.8s (10.3%)
  9. x86_64-gnu-tools: 3368.6s -> 3712.1s (10.2%)
  10. x86_64-gnu: 6808.1s -> 7455.1s (9.5%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (7950f24): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-0.4%[-0.6%, -0.3%]2
All ❌✅ (primary)--0

Max RSS (memory usage)

Results (secondary -1.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-1.0%[-1.0%, -1.0%]1
All ❌✅ (primary)--0

Cycles

Results (primary -2.4%, secondary 1.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		1.8%[1.1%, 2.5%]2
Improvements ✅
(primary)		-2.4%[-2.4%, -2.4%]1
Improvements ✅
(secondary)		--0
All ❌✅ (primary)-2.4%[-2.4%, -2.4%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.682s -> 473.406s (0.58%)
Artifact size: 388.33 MiB -> 388.33 MiB (-0.00%)

@dtolnaydtolnay mentioned this pull request Oct 5, 2025
Closed
@apiraino

apiraino commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

Beta and stable backport accepted as per compiler team on Zulip. A backport PR will be authored by the release team at the end of the current development cycle. Backport labels handled by them.

Stable backport approved as well provided there are plans for a dot release, this alone does not warrant one.

@rustbot label +beta-accepted +stable-accepted

@rustbotrustbot added beta-accepted Accepted for backporting to the compiler in the beta channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Oct 9, 2025
@cuvipercuviper mentioned this pull request Oct 10, 2025
Merged
@cuvipercuviper modified the milestones: 1.92.0, 1.91.0Oct 11, 2025
@cuvipercuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 11, 2025
bors added a commit that referenced this pull request Oct 11, 2025
@bors
Auto merge of#147571- cuviper:beta-next, r=cuviper
cbf84ed
[beta] backports
- Don't normalize higher-ranked assumptions if they're not used #147299
- Fix target list of `link_section` #147418
- bootstrap: add `Builder::rustc_cmd` that includes the lib path #147419
- Update LLVM to 21.1.2 #146953
- Remove the temporary directory when a check ends -- part of #147518
r? cuviper
@lcnrlcnr mentioned this pull request Nov 3, 2025
Closed
@emilyalbiniemilyalbini removed stable-nominated Nominated for backporting to the compiler in the stable channel. stable-accepted Accepted for backporting to the compiler in the stable channel. labels Nov 5, 2025
@emilyalbini

emilyalbini commented Nov 5, 2025

Copy link
Copy Markdown
Member

Removing stable labels as 1.90.1 is not going to happen, and this was backported to 1.91.0.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@fee1-deadfee1-dead

Labels

A-async-awaitArea: Async & AwaitA-higher-rankedArea: Higher-ranked things (e.g., lifetimes, types, trait bounds aka HRTBs)beta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-typesRelevant to the types team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

"higher-ranked lifetime error" on rust 1.90 Regression in nightly-2025-07-19: implementation of FnOnce is not general enough

9 participants

@compiler-errors@rustbot@jackh726@bors@rust-timer@apiraino@emilyalbini@cuviper@fee1-dead