Skip to content

Rollup of 5 pull requests - #147308

Merged
bors merged 16 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-ov04tbi
Oct 4, 2025
Merged

Rollup of 5 pull requests#147308
bors merged 16 commits into
rust-lang:masterfrom
matthiaskrgr:rollup-ov04tbi

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Oct 3, 2025•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

A4-Tacksand others added 16 commits October 1, 2025 22:45
@A4-Tacks@karolzwolak
Fix diagnostics str::replace comma to bar
4735c21
@karolzwolak
bless tests
a08228d
@karolzwolak
regression test
934ad74
@karolzwolak
fix wording; we're replacing coma with a bar
5a8f963
@karolzwolak
bring back plural 'alternatives' in suggestion message
d1d7b94
@reddevilmidzy
test: Add regression test for ICE when projecting associated types th…
fab9906
…rough dyn traits
@fee1-dead
Extract common logic for iterating over features
a5c9030
Two places doing the same thing is enough to motivate me to extract this to a method :)
@Urgau
Respect -Z unstable options in rustdoc --test
3d5f54a
@Urgau
Respect --error-format in rustdoc --test
e914a1a
@Urgau
Add regression test for -Zcrate-attr in rustdoc --test
c1443e2
@MabezDev
Add xtensa arch to object file creation
3f9c493
@matthiaskrgr
Rollup merge ofrust-lang#147245- karolzwolak:only-replace-intended-…
2e06dcd
…bar-not-all-in-pattern, r=lcnr
only replace the intended comma in pattern suggestions
Only suggest to replace the intended comma, not all bars in the pattern.
Fixesrust-lang#143330.
This continues rust-lang#143331, the credit for making the fix goes to `@A4-Tacks.` I just blessed tests and added a regression test.
@matthiaskrgr
Rollup merge ofrust-lang#147269- reddevilmidzy:ice-fix, r=petrochenkov
0d0b695
Add regression test for 123953
close: rust-lang#123953
@matthiaskrgr
Rollup merge ofrust-lang#147277- fee1-dead-contrib:featiter, r=Zala…
9e477c4
…thar
Extract common logic for iterating over features
Two places doing the same thing is enough to motivate me to extract this to a method :)
@matthiaskrgr
Rollup merge ofrust-lang#147292- Urgau:rustdoc-test-unstable_opts, …
dbc5e72
…r=fmease
Respect `-Z` unstable options in `rustdoc --test`
This PR makes rustdoc respect `-Z` unstable options when collecting doctests (`rustdoc --test`).
In the process I also realized that `--error-format` wasn't respected as well, making UI annotations impossible to write so I fixed that as well.
Best reviewed commit by commit.
Fixesrust-lang#147276Fixesrust-lang#143930
r? fmease
@matthiaskrgr
Rollup merge ofrust-lang#147300- esp-rs:xtensa-meta, r=saethlin
30442dc
Add xtensa arch to object file creation
Just something that was missed in the xtensa target PRs.
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 3, 2025
@matthiaskrgr

matthiaskrgr commented Oct 3, 2025

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=5

@bors

bors commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 30442dc has been approved by matthiaskrgr

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 3, 2025
@bors

bors commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 30442dc with merge f4babc6...

bors added a commit that referenced this pull request Oct 3, 2025
@bors
Auto merge of#147308- matthiaskrgr:rollup-ov04tbi, r=matthiaskrgr
f4babc6
Rollup of 5 pull requests
Successful merges:
- #147245 (only replace the intended comma in pattern suggestions)
- #147269 (Add regression test for 123953)
- #147277 (Extract common logic for iterating over features)
- #147292 (Respect `-Z` unstable options in `rustdoc --test`)
- #147300 (Add xtensa arch to object file creation)
r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer

rust-log-analyzer commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

The job x86_64-msvc-ext1 failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)
 Verifying foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2383\foo)
Downloading crates ...
Downloaded bar v1.0.0 (registry `dummy-registry`)
Compiling bar v1.0.0
Compiling foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2383\foo\target\package\foo-0.0.1)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.59s
stack backtrace:
0: __rustc::rust_begin_unwind
1: core::panicking::panic_fmt

@bors

bors commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 3, 2025
@matthiaskrgr

matthiaskrgr commented Oct 4, 2025

Copy link
Copy Markdown
MemberAuthor

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2025
@bors

bors commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 30442dc with merge a0f398e...

@ZalatharZalathar mentioned this pull request Oct 4, 2025
Closed
@jieyouxujieyouxu mentioned this pull request Oct 4, 2025
Closed
@jieyouxu

jieyouxu commented Oct 4, 2025•
edited
Loading

Copy link
Copy Markdown
Member

msvc failure is tracked in #147321

This was referenced Oct 4, 2025
Closed
Closed
@bors

bors commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing a0f398e to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 4, 2025
@bors
bors merged commit a0f398e into rust-lang:masterOct 4, 2025
11 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 4, 2025
@rust-timer

rust-timer commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

📌 Perf builds for each rolled up PR:

PR#MessagePerf Build Sha
#147245only replace the intended comma in pattern suggestions823632bbfbb2941cdc3c69130f19b39ea565a7aa (link)
#147269Add regression test for 123953e6d43ed4b0f2576be199aef09c60fa1cb7bbab03 (link)
#147277Extract common logic for iterating over featuresa5e9d3e62738bb76f7cf43ada29a686ba2433980 (link)
#147292Respect -Z unstable options in rustdoc --testfa55f38d23003d9a2935ed235975b2e2046974ca (link)
#147300Add xtensa arch to object file creationa91ab691b96334aeb2da787f9fc3655ae4a93d7a (link)

previous master: 7950f244e7

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@github-actions

github-actionsBot commented Oct 4, 2025

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7950f24 (parent) -> a0f398e (this PR)

Test differences

Show 36 test diffs

Stage 1

  • [ui] tests/rustdoc-ui/doctest/unstable-opts-143930.rs: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#crate_attr: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#normal: [missing] -> pass (J1)
  • [ui] tests/ui/associated-types/projection-dyn-associated-type.rs: [missing] -> pass (J1)
  • [ui] tests/ui/suggestions/only-replace-intended-coma-not-all-in-pattern.rs: [missing] -> pass (J1)

Stage 2

  • [ui] tests/ui/associated-types/projection-dyn-associated-type.rs: [missing] -> pass (J0)
  • [ui] tests/ui/suggestions/only-replace-intended-coma-not-all-in-pattern.rs: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-143930.rs: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#crate_attr: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#normal: [missing] -> pass (J2)

Additionally, 26 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a0f398e89df9767c93c81cd58d44fdba071258a8 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-x86_64-apple: 6570.0s -> 7916.6s (20.5%)
  2. x86_64-rust-for-linux: 2584.3s -> 3038.0s (17.6%)
  3. i686-gnu-nopt-1: 8138.1s -> 7155.8s (-12.1%)
  4. x86_64-gnu-tools: 3712.1s -> 3300.1s (-11.1%)
  5. armhf-gnu: 4770.2s -> 5198.8s (9.0%)
  6. dist-riscv64-linux: 5409.4s -> 4974.0s (-8.0%)
  7. i686-gnu-2: 5862.5s -> 6233.1s (6.3%)
  8. x86_64-gnu-miri: 4649.0s -> 4367.8s (-6.0%)
  9. aarch64-msvc-2: 5220.5s -> 4905.7s (-6.0%)
  10. dist-apple-various: 3708.7s -> 3490.6s (-5.9%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (a0f398e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.8%, secondary -1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		0.8%[0.8%, 0.8%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-1.9%[-1.9%, -1.9%]1
All ❌✅ (primary)0.8%[0.8%, 0.8%]1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.406s -> 472.925s (-0.10%)
Artifact size: 388.33 MiB -> 388.34 MiB (0.00%)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

12 participants

@matthiaskrgr@bors@rust-log-analyzer@jieyouxu@rust-timer@rustbot@A4-Tacks@karolzwolak@reddevilmidzy@fee1-dead@Urgau@MabezDev
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Rollup of 5 pull requests by matthiaskrgr · Pull Request #147308 · rust-lang/rust · GitHub
Skip to content
Rollup of 5 pull requests - #147308
Merged
bors merged 16 commits into
rust-lang:masterfrom 
matthiaskrgr:rollup-ov04tbi
Oct 4, 2025
Merged
Rollup of 5 pull requests#147308
bors merged 16 commits into
rust-lang:masterfrom 
matthiaskrgr:rollup-ov04tbi
Conversation
@matthiaskrgr
@matthiaskrgrmatthiaskrgr
commented
Oct 3, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
A4-Tacksand others
added 16 commits
October 1, 2025 22:45
@A4-Tacks@karolzwolak
Fix diagnostics str::replace comma to bar
4735c21
@karolzwolak
bless tests
a08228d
@karolzwolak
regression test
934ad74
@karolzwolak
fix wording; we're replacing coma with a bar
5a8f963
@karolzwolak
bring back plural 'alternatives' in suggestion message
d1d7b94
@reddevilmidzy
test: Add regression test for ICE when projecting associated types th…
fab9906
…rough dyn traits
@fee1-dead
Extract common logic for iterating over features
a5c9030
Two places doing the same thing is enough to motivate me to extract this to a method :)
@Urgau
Respect -Z unstable options in rustdoc --test
3d5f54a
@Urgau
Respect --error-format in rustdoc --test
e914a1a
@Urgau
Add regression test for -Zcrate-attr in rustdoc --test
c1443e2
@MabezDev
Add xtensa arch to object file creation
3f9c493
@matthiaskrgr
Rollup merge ofrust-lang#147245- karolzwolak:only-replace-intended-…
2e06dcd
…bar-not-all-in-pattern, r=lcnr
only replace the intended comma in pattern suggestions
Only suggest to replace the intended comma, not all bars in the pattern.
Fixesrust-lang#143330.
This continues rust-lang#143331, the credit for making the fix goes to `@A4-Tacks.` I just blessed tests and added a regression test.
@matthiaskrgr
Rollup merge ofrust-lang#147269- reddevilmidzy:ice-fix, r=petrochenkov
0d0b695
Add regression test for 123953
close: rust-lang#123953
@matthiaskrgr
Rollup merge ofrust-lang#147277- fee1-dead-contrib:featiter, r=Zala…
9e477c4
…thar
Extract common logic for iterating over features
Two places doing the same thing is enough to motivate me to extract this to a method :)
@matthiaskrgr
Rollup merge ofrust-lang#147292- Urgau:rustdoc-test-unstable_opts, …
dbc5e72
…r=fmease
Respect `-Z` unstable options in `rustdoc --test`
This PR makes rustdoc respect `-Z` unstable options when collecting doctests (`rustdoc --test`).
In the process I also realized that `--error-format` wasn't respected as well, making UI annotations impossible to write so I fixed that as well.
Best reviewed commit by commit.
Fixesrust-lang#147276Fixesrust-lang#143930
r? fmease
@matthiaskrgr
Rollup merge ofrust-lang#147300- esp-rs:xtensa-meta, r=saethlin
30442dc
Add xtensa arch to object file creation
Just something that was missed in the xtensa target PRs.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Oct 3, 2025
@matthiaskrgr
matthiaskrgr
commented
Oct 3, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 30442dc has been approved by matthiaskrgr
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 3, 2025
@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 30442dc with merge f4babc6...
bors added a commit
that referenced
this pull request
Oct 3, 2025
@bors
Auto merge of#147308- matthiaskrgr:rollup-ov04tbi, r=matthiaskrgr
f4babc6
Rollup of 5 pull requests
Successful merges:
- #147245 (only replace the intended comma in pattern suggestions)
- #147269 (Add regression test for 123953)
- #147277 (Extract common logic for iterating over features)
- #147292 (Respect `-Z` unstable options in `rustdoc --test`)
- #147300 (Add xtensa arch to object file creation)
r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
rust-log-analyzer
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
The job x86_64-msvc-ext1 failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
 Verifying foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2383\foo)
Downloading crates ...
Downloaded bar v1.0.0 (registry `dummy-registry`)
Compiling bar v1.0.0
Compiling foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2383\foo\target\package\foo-0.0.1)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.59s
stack backtrace:
0: __rustc::rust_begin_unwind
1: core::panicking::panic_fmt

@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Oct 3, 2025
@matthiaskrgr
matthiaskrgr
commented
Oct 4, 2025

Copy link


Copy Markdown

MemberAuthor
@bors retry
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 4, 2025
@bors
bors
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 30442dc with merge a0f398e...
@ZalatharZalathar
mentioned this pull request
Oct 4, 2025
 Closed

@jieyouxujieyouxu
mentioned this pull request
Oct 4, 2025

Closed

@jieyouxu
jieyouxu
commented
Oct 4, 2025•

edited

Loading

Copy link


Copy Markdown

Member
msvc failure is tracked in #147321

This was referenced Oct 4, 2025
 Closed

 Closed

@bors
bors
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: matthiaskrgr

Pushing a0f398e to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Oct 4, 2025
@bors
bors
merged commit a0f398e
into
rust-lang:masterOct 4, 2025

11 checks passed

@rustbotrustbot
added this to the 1.92.0 milestone
Oct 4, 2025
@rust-timer
rust-timer
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#147245only replace the intended comma in pattern suggestions823632bbfbb2941cdc3c69130f19b39ea565a7aa (link)
#147269Add regression test for 123953e6d43ed4b0f2576be199aef09c60fa1cb7bbab03 (link)
#147277Extract common logic for iterating over featuresa5e9d3e62738bb76f7cf43ada29a686ba2433980 (link)
#147292Respect -Z unstable options in rustdoc --testfa55f38d23003d9a2935ed235975b2e2046974ca (link)
#147300Add xtensa arch to object file creationa91ab691b96334aeb2da787f9fc3655ae4a93d7a (link)
previous master: 7950f244e7
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Oct 4, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7950f24 (parent) -> a0f398e (this PR)
Test differences
Show 36 test diffs

Stage 1
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-143930.rs: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#crate_attr: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#normal: [missing] -> pass (J1)
  • [ui] tests/ui/associated-types/projection-dyn-associated-type.rs: [missing] -> pass (J1)
  • [ui] tests/ui/suggestions/only-replace-intended-coma-not-all-in-pattern.rs: [missing] -> pass (J1)
Stage 2
  • [ui] tests/ui/associated-types/projection-dyn-associated-type.rs: [missing] -> pass (J0)
  • [ui] tests/ui/suggestions/only-replace-intended-coma-not-all-in-pattern.rs: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-143930.rs: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#crate_attr: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#normal: [missing] -> pass (J2)
Additionally, 26 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a0f398e89df9767c93c81cd58d44fdba071258a8 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-x86_64-apple: 6570.0s -> 7916.6s (20.5%)
  2. x86_64-rust-for-linux: 2584.3s -> 3038.0s (17.6%)
  3. i686-gnu-nopt-1: 8138.1s -> 7155.8s (-12.1%)
  4. x86_64-gnu-tools: 3712.1s -> 3300.1s (-11.1%)
  5. armhf-gnu: 4770.2s -> 5198.8s (9.0%)
  6. dist-riscv64-linux: 5409.4s -> 4974.0s (-8.0%)
  7. i686-gnu-2: 5862.5s -> 6233.1s (6.3%)
  8. x86_64-gnu-miri: 4649.0s -> 4367.8s (-6.0%)
  9. aarch64-msvc-2: 5220.5s -> 4905.7s (-6.0%)
  10. dist-apple-various: 3708.7s -> 3490.6s (-5.9%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (a0f398e): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results (primary 0.8%, secondary -1.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		0.8%[0.8%, 0.8%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-1.9%[-1.9%, -1.9%]1
All ❌✅ (primary)0.8%[0.8%, 0.8%]1
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 473.406s -> 472.925s (-0.10%)
Artifact size: 388.33 MiB -> 388.34 MiB (0.00%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

12 participants

@matthiaskrgr@bors@rust-log-analyzer@jieyouxu@rust-timer@rustbot@A4-Tacks@karolzwolak@reddevilmidzy@fee1-dead@Urgau@MabezDev

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rollup of 5 pull requests by matthiaskrgr · Pull Request #147308 · rust-lang/rust · GitHub
Skip to content
Rollup of 5 pull requests - #147308
Merged
bors merged 16 commits into
rust-lang:masterfrom 
matthiaskrgr:rollup-ov04tbi
Oct 4, 2025
Merged
Rollup of 5 pull requests#147308
bors merged 16 commits into
rust-lang:masterfrom 
matthiaskrgr:rollup-ov04tbi
Conversation
@matthiaskrgr
@matthiaskrgrmatthiaskrgr
commented
Oct 3, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
A4-Tacksand others
added 16 commits
October 1, 2025 22:45
@A4-Tacks@karolzwolak
Fix diagnostics str::replace comma to bar
4735c21
@karolzwolak
bless tests
a08228d
@karolzwolak
regression test
934ad74
@karolzwolak
fix wording; we're replacing coma with a bar
5a8f963
@karolzwolak
bring back plural 'alternatives' in suggestion message
d1d7b94
@reddevilmidzy
test: Add regression test for ICE when projecting associated types th…
fab9906
…rough dyn traits
@fee1-dead
Extract common logic for iterating over features
a5c9030
Two places doing the same thing is enough to motivate me to extract this to a method :)
@Urgau
Respect -Z unstable options in rustdoc --test
3d5f54a
@Urgau
Respect --error-format in rustdoc --test
e914a1a
@Urgau
Add regression test for -Zcrate-attr in rustdoc --test
c1443e2
@MabezDev
Add xtensa arch to object file creation
3f9c493
@matthiaskrgr
Rollup merge ofrust-lang#147245- karolzwolak:only-replace-intended-…
2e06dcd
…bar-not-all-in-pattern, r=lcnr
only replace the intended comma in pattern suggestions
Only suggest to replace the intended comma, not all bars in the pattern.
Fixesrust-lang#143330.
This continues rust-lang#143331, the credit for making the fix goes to `@A4-Tacks.` I just blessed tests and added a regression test.
@matthiaskrgr
Rollup merge ofrust-lang#147269- reddevilmidzy:ice-fix, r=petrochenkov
0d0b695
Add regression test for 123953
close: rust-lang#123953
@matthiaskrgr
Rollup merge ofrust-lang#147277- fee1-dead-contrib:featiter, r=Zala…
9e477c4
…thar
Extract common logic for iterating over features
Two places doing the same thing is enough to motivate me to extract this to a method :)
@matthiaskrgr
Rollup merge ofrust-lang#147292- Urgau:rustdoc-test-unstable_opts, …
dbc5e72
…r=fmease
Respect `-Z` unstable options in `rustdoc --test`
This PR makes rustdoc respect `-Z` unstable options when collecting doctests (`rustdoc --test`).
In the process I also realized that `--error-format` wasn't respected as well, making UI annotations impossible to write so I fixed that as well.
Best reviewed commit by commit.
Fixesrust-lang#147276Fixesrust-lang#143930
r? fmease
@matthiaskrgr
Rollup merge ofrust-lang#147300- esp-rs:xtensa-meta, r=saethlin
30442dc
Add xtensa arch to object file creation
Just something that was missed in the xtensa target PRs.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Oct 3, 2025
@matthiaskrgr
matthiaskrgr
commented
Oct 3, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 30442dc has been approved by matthiaskrgr
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 3, 2025
@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 30442dc with merge f4babc6...
bors added a commit
that referenced
this pull request
Oct 3, 2025
@bors
Auto merge of#147308- matthiaskrgr:rollup-ov04tbi, r=matthiaskrgr
f4babc6
Rollup of 5 pull requests
Successful merges:
- #147245 (only replace the intended comma in pattern suggestions)
- #147269 (Add regression test for 123953)
- #147277 (Extract common logic for iterating over features)
- #147292 (Respect `-Z` unstable options in `rustdoc --test`)
- #147300 (Add xtensa arch to object file creation)
r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
rust-log-analyzer
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
The job x86_64-msvc-ext1 failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
 Verifying foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2383\foo)
Downloading crates ...
Downloaded bar v1.0.0 (registry `dummy-registry`)
Compiling bar v1.0.0
Compiling foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2383\foo\target\package\foo-0.0.1)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.59s
stack backtrace:
0: __rustc::rust_begin_unwind
1: core::panicking::panic_fmt

@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Oct 3, 2025
@matthiaskrgr
matthiaskrgr
commented
Oct 4, 2025

Copy link


Copy Markdown

MemberAuthor
@bors retry
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 4, 2025
@bors
bors
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 30442dc with merge a0f398e...
@ZalatharZalathar
mentioned this pull request
Oct 4, 2025
 Closed

@jieyouxujieyouxu
mentioned this pull request
Oct 4, 2025

Closed

@jieyouxu
jieyouxu
commented
Oct 4, 2025•

edited

Loading

Copy link


Copy Markdown

Member
msvc failure is tracked in #147321

This was referenced Oct 4, 2025
 Closed

 Closed

@bors
bors
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: matthiaskrgr

Pushing a0f398e to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Oct 4, 2025
@bors
bors
merged commit a0f398e
into
rust-lang:masterOct 4, 2025

11 checks passed

@rustbotrustbot
added this to the 1.92.0 milestone
Oct 4, 2025
@rust-timer
rust-timer
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#147245only replace the intended comma in pattern suggestions823632bbfbb2941cdc3c69130f19b39ea565a7aa (link)
#147269Add regression test for 123953e6d43ed4b0f2576be199aef09c60fa1cb7bbab03 (link)
#147277Extract common logic for iterating over featuresa5e9d3e62738bb76f7cf43ada29a686ba2433980 (link)
#147292Respect -Z unstable options in rustdoc --testfa55f38d23003d9a2935ed235975b2e2046974ca (link)
#147300Add xtensa arch to object file creationa91ab691b96334aeb2da787f9fc3655ae4a93d7a (link)
previous master: 7950f244e7
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Oct 4, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7950f24 (parent) -> a0f398e (this PR)
Test differences
Show 36 test diffs

Stage 1
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-143930.rs: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#crate_attr: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#normal: [missing] -> pass (J1)
  • [ui] tests/ui/associated-types/projection-dyn-associated-type.rs: [missing] -> pass (J1)
  • [ui] tests/ui/suggestions/only-replace-intended-coma-not-all-in-pattern.rs: [missing] -> pass (J1)
Stage 2
  • [ui] tests/ui/associated-types/projection-dyn-associated-type.rs: [missing] -> pass (J0)
  • [ui] tests/ui/suggestions/only-replace-intended-coma-not-all-in-pattern.rs: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-143930.rs: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#crate_attr: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#normal: [missing] -> pass (J2)
Additionally, 26 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a0f398e89df9767c93c81cd58d44fdba071258a8 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-x86_64-apple: 6570.0s -> 7916.6s (20.5%)
  2. x86_64-rust-for-linux: 2584.3s -> 3038.0s (17.6%)
  3. i686-gnu-nopt-1: 8138.1s -> 7155.8s (-12.1%)
  4. x86_64-gnu-tools: 3712.1s -> 3300.1s (-11.1%)
  5. armhf-gnu: 4770.2s -> 5198.8s (9.0%)
  6. dist-riscv64-linux: 5409.4s -> 4974.0s (-8.0%)
  7. i686-gnu-2: 5862.5s -> 6233.1s (6.3%)
  8. x86_64-gnu-miri: 4649.0s -> 4367.8s (-6.0%)
  9. aarch64-msvc-2: 5220.5s -> 4905.7s (-6.0%)
  10. dist-apple-various: 3708.7s -> 3490.6s (-5.9%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (a0f398e): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results (primary 0.8%, secondary -1.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		0.8%[0.8%, 0.8%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-1.9%[-1.9%, -1.9%]1
All ❌✅ (primary)0.8%[0.8%, 0.8%]1
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 473.406s -> 472.925s (-0.10%)
Artifact size: 388.33 MiB -> 388.34 MiB (0.00%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

12 participants

@matthiaskrgr@bors@rust-log-analyzer@jieyouxu@rust-timer@rustbot@A4-Tacks@karolzwolak@reddevilmidzy@fee1-dead@Urgau@MabezDev

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rollup of 5 pull requests by matthiaskrgr · Pull Request #147308 · rust-lang/rust · GitHub
Skip to content
Rollup of 5 pull requests - #147308
Merged
bors merged 16 commits into
rust-lang:masterfrom 
matthiaskrgr:rollup-ov04tbi
Oct 4, 2025
Merged
Rollup of 5 pull requests#147308
bors merged 16 commits into
rust-lang:masterfrom 
matthiaskrgr:rollup-ov04tbi
Conversation
@matthiaskrgr
@matthiaskrgrmatthiaskrgr
commented
Oct 3, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
A4-Tacksand others
added 16 commits
October 1, 2025 22:45
@A4-Tacks@karolzwolak
Fix diagnostics str::replace comma to bar
4735c21
@karolzwolak
bless tests
a08228d
@karolzwolak
regression test
934ad74
@karolzwolak
fix wording; we're replacing coma with a bar
5a8f963
@karolzwolak
bring back plural 'alternatives' in suggestion message
d1d7b94
@reddevilmidzy
test: Add regression test for ICE when projecting associated types th…
fab9906
…rough dyn traits
@fee1-dead
Extract common logic for iterating over features
a5c9030
Two places doing the same thing is enough to motivate me to extract this to a method :)
@Urgau
Respect -Z unstable options in rustdoc --test
3d5f54a
@Urgau
Respect --error-format in rustdoc --test
e914a1a
@Urgau
Add regression test for -Zcrate-attr in rustdoc --test
c1443e2
@MabezDev
Add xtensa arch to object file creation
3f9c493
@matthiaskrgr
Rollup merge ofrust-lang#147245- karolzwolak:only-replace-intended-…
2e06dcd
…bar-not-all-in-pattern, r=lcnr
only replace the intended comma in pattern suggestions
Only suggest to replace the intended comma, not all bars in the pattern.
Fixesrust-lang#143330.
This continues rust-lang#143331, the credit for making the fix goes to `@A4-Tacks.` I just blessed tests and added a regression test.
@matthiaskrgr
Rollup merge ofrust-lang#147269- reddevilmidzy:ice-fix, r=petrochenkov
0d0b695
Add regression test for 123953
close: rust-lang#123953
@matthiaskrgr
Rollup merge ofrust-lang#147277- fee1-dead-contrib:featiter, r=Zala…
9e477c4
…thar
Extract common logic for iterating over features
Two places doing the same thing is enough to motivate me to extract this to a method :)
@matthiaskrgr
Rollup merge ofrust-lang#147292- Urgau:rustdoc-test-unstable_opts, …
dbc5e72
…r=fmease
Respect `-Z` unstable options in `rustdoc --test`
This PR makes rustdoc respect `-Z` unstable options when collecting doctests (`rustdoc --test`).
In the process I also realized that `--error-format` wasn't respected as well, making UI annotations impossible to write so I fixed that as well.
Best reviewed commit by commit.
Fixesrust-lang#147276Fixesrust-lang#143930
r? fmease
@matthiaskrgr
Rollup merge ofrust-lang#147300- esp-rs:xtensa-meta, r=saethlin
30442dc
Add xtensa arch to object file creation
Just something that was missed in the xtensa target PRs.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Oct 3, 2025
@matthiaskrgr
matthiaskrgr
commented
Oct 3, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 30442dc has been approved by matthiaskrgr
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 3, 2025
@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 30442dc with merge f4babc6...
bors added a commit
that referenced
this pull request
Oct 3, 2025
@bors
Auto merge of#147308- matthiaskrgr:rollup-ov04tbi, r=matthiaskrgr
f4babc6
Rollup of 5 pull requests
Successful merges:
- #147245 (only replace the intended comma in pattern suggestions)
- #147269 (Add regression test for 123953)
- #147277 (Extract common logic for iterating over features)
- #147292 (Respect `-Z` unstable options in `rustdoc --test`)
- #147300 (Add xtensa arch to object file creation)
r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
rust-log-analyzer
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
The job x86_64-msvc-ext1 failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
 Verifying foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2383\foo)
Downloading crates ...
Downloaded bar v1.0.0 (registry `dummy-registry`)
Compiling bar v1.0.0
Compiling foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2383\foo\target\package\foo-0.0.1)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.59s
stack backtrace:
0: __rustc::rust_begin_unwind
1: core::panicking::panic_fmt

@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Oct 3, 2025
@matthiaskrgr
matthiaskrgr
commented
Oct 4, 2025

Copy link


Copy Markdown

MemberAuthor
@bors retry
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 4, 2025
@bors
bors
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 30442dc with merge a0f398e...
@ZalatharZalathar
mentioned this pull request
Oct 4, 2025
 Closed

@jieyouxujieyouxu
mentioned this pull request
Oct 4, 2025

Closed

@jieyouxu
jieyouxu
commented
Oct 4, 2025•

edited

Loading

Copy link


Copy Markdown

Member
msvc failure is tracked in #147321

This was referenced Oct 4, 2025
 Closed

 Closed

@bors
bors
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: matthiaskrgr

Pushing a0f398e to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Oct 4, 2025
@bors
bors
merged commit a0f398e
into
rust-lang:masterOct 4, 2025

11 checks passed

@rustbotrustbot
added this to the 1.92.0 milestone
Oct 4, 2025
@rust-timer
rust-timer
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#147245only replace the intended comma in pattern suggestions823632bbfbb2941cdc3c69130f19b39ea565a7aa (link)
#147269Add regression test for 123953e6d43ed4b0f2576be199aef09c60fa1cb7bbab03 (link)
#147277Extract common logic for iterating over featuresa5e9d3e62738bb76f7cf43ada29a686ba2433980 (link)
#147292Respect -Z unstable options in rustdoc --testfa55f38d23003d9a2935ed235975b2e2046974ca (link)
#147300Add xtensa arch to object file creationa91ab691b96334aeb2da787f9fc3655ae4a93d7a (link)
previous master: 7950f244e7
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Oct 4, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7950f24 (parent) -> a0f398e (this PR)
Test differences
Show 36 test diffs

Stage 1
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-143930.rs: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#crate_attr: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#normal: [missing] -> pass (J1)
  • [ui] tests/ui/associated-types/projection-dyn-associated-type.rs: [missing] -> pass (J1)
  • [ui] tests/ui/suggestions/only-replace-intended-coma-not-all-in-pattern.rs: [missing] -> pass (J1)
Stage 2
  • [ui] tests/ui/associated-types/projection-dyn-associated-type.rs: [missing] -> pass (J0)
  • [ui] tests/ui/suggestions/only-replace-intended-coma-not-all-in-pattern.rs: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-143930.rs: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#crate_attr: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#normal: [missing] -> pass (J2)
Additionally, 26 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a0f398e89df9767c93c81cd58d44fdba071258a8 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-x86_64-apple: 6570.0s -> 7916.6s (20.5%)
  2. x86_64-rust-for-linux: 2584.3s -> 3038.0s (17.6%)
  3. i686-gnu-nopt-1: 8138.1s -> 7155.8s (-12.1%)
  4. x86_64-gnu-tools: 3712.1s -> 3300.1s (-11.1%)
  5. armhf-gnu: 4770.2s -> 5198.8s (9.0%)
  6. dist-riscv64-linux: 5409.4s -> 4974.0s (-8.0%)
  7. i686-gnu-2: 5862.5s -> 6233.1s (6.3%)
  8. x86_64-gnu-miri: 4649.0s -> 4367.8s (-6.0%)
  9. aarch64-msvc-2: 5220.5s -> 4905.7s (-6.0%)
  10. dist-apple-various: 3708.7s -> 3490.6s (-5.9%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (a0f398e): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results (primary 0.8%, secondary -1.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		0.8%[0.8%, 0.8%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-1.9%[-1.9%, -1.9%]1
All ❌✅ (primary)0.8%[0.8%, 0.8%]1
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 473.406s -> 472.925s (-0.10%)
Artifact size: 388.33 MiB -> 388.34 MiB (0.00%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

12 participants

@matthiaskrgr@bors@rust-log-analyzer@jieyouxu@rust-timer@rustbot@A4-Tacks@karolzwolak@reddevilmidzy@fee1-dead@Urgau@MabezDev

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Rollup of 5 pull requests by matthiaskrgr · Pull Request #147308 · rust-lang/rust · GitHub
Skip to content
Rollup of 5 pull requests - #147308
Merged
bors merged 16 commits into
rust-lang:masterfrom 
matthiaskrgr:rollup-ov04tbi
Oct 4, 2025
Merged
Rollup of 5 pull requests#147308
bors merged 16 commits into
rust-lang:masterfrom 
matthiaskrgr:rollup-ov04tbi
Conversation
@matthiaskrgr
@matthiaskrgrmatthiaskrgr
commented
Oct 3, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
A4-Tacksand others
added 16 commits
October 1, 2025 22:45
@A4-Tacks@karolzwolak
Fix diagnostics str::replace comma to bar
4735c21
@karolzwolak
bless tests
a08228d
@karolzwolak
regression test
934ad74
@karolzwolak
fix wording; we're replacing coma with a bar
5a8f963
@karolzwolak
bring back plural 'alternatives' in suggestion message
d1d7b94
@reddevilmidzy
test: Add regression test for ICE when projecting associated types th…
fab9906
…rough dyn traits
@fee1-dead
Extract common logic for iterating over features
a5c9030
Two places doing the same thing is enough to motivate me to extract this to a method :)
@Urgau
Respect -Z unstable options in rustdoc --test
3d5f54a
@Urgau
Respect --error-format in rustdoc --test
e914a1a
@Urgau
Add regression test for -Zcrate-attr in rustdoc --test
c1443e2
@MabezDev
Add xtensa arch to object file creation
3f9c493
@matthiaskrgr
Rollup merge ofrust-lang#147245- karolzwolak:only-replace-intended-…
2e06dcd
…bar-not-all-in-pattern, r=lcnr
only replace the intended comma in pattern suggestions
Only suggest to replace the intended comma, not all bars in the pattern.
Fixesrust-lang#143330.
This continues rust-lang#143331, the credit for making the fix goes to `@A4-Tacks.` I just blessed tests and added a regression test.
@matthiaskrgr
Rollup merge ofrust-lang#147269- reddevilmidzy:ice-fix, r=petrochenkov
0d0b695
Add regression test for 123953
close: rust-lang#123953
@matthiaskrgr
Rollup merge ofrust-lang#147277- fee1-dead-contrib:featiter, r=Zala…
9e477c4
…thar
Extract common logic for iterating over features
Two places doing the same thing is enough to motivate me to extract this to a method :)
@matthiaskrgr
Rollup merge ofrust-lang#147292- Urgau:rustdoc-test-unstable_opts, …
dbc5e72
…r=fmease
Respect `-Z` unstable options in `rustdoc --test`
This PR makes rustdoc respect `-Z` unstable options when collecting doctests (`rustdoc --test`).
In the process I also realized that `--error-format` wasn't respected as well, making UI annotations impossible to write so I fixed that as well.
Best reviewed commit by commit.
Fixesrust-lang#147276Fixesrust-lang#143930
r? fmease
@matthiaskrgr
Rollup merge ofrust-lang#147300- esp-rs:xtensa-meta, r=saethlin
30442dc
Add xtensa arch to object file creation
Just something that was missed in the xtensa target PRs.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Oct 3, 2025
@matthiaskrgr
matthiaskrgr
commented
Oct 3, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 30442dc has been approved by matthiaskrgr
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 3, 2025
@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 30442dc with merge f4babc6...
bors added a commit
that referenced
this pull request
Oct 3, 2025
@bors
Auto merge of#147308- matthiaskrgr:rollup-ov04tbi, r=matthiaskrgr
f4babc6
Rollup of 5 pull requests
Successful merges:
- #147245 (only replace the intended comma in pattern suggestions)
- #147269 (Add regression test for 123953)
- #147277 (Extract common logic for iterating over features)
- #147292 (Respect `-Z` unstable options in `rustdoc --test`)
- #147300 (Add xtensa arch to object file creation)
r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
rust-log-analyzer
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
The job x86_64-msvc-ext1 failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
 Verifying foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2383\foo)
Downloading crates ...
Downloaded bar v1.0.0 (registry `dummy-registry`)
Compiling bar v1.0.0
Compiling foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2383\foo\target\package\foo-0.0.1)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.59s
stack backtrace:
0: __rustc::rust_begin_unwind
1: core::panicking::panic_fmt

@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Oct 3, 2025
@matthiaskrgr
matthiaskrgr
commented
Oct 4, 2025

Copy link


Copy Markdown

MemberAuthor
@bors retry
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 4, 2025
@bors
bors
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 30442dc with merge a0f398e...
@ZalatharZalathar
mentioned this pull request
Oct 4, 2025
 Closed

@jieyouxujieyouxu
mentioned this pull request
Oct 4, 2025

Closed

@jieyouxu
jieyouxu
commented
Oct 4, 2025•

edited

Loading

Copy link


Copy Markdown

Member
msvc failure is tracked in #147321

This was referenced Oct 4, 2025
 Closed

 Closed

@bors
bors
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: matthiaskrgr

Pushing a0f398e to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Oct 4, 2025
@bors
bors
merged commit a0f398e
into
rust-lang:masterOct 4, 2025

11 checks passed

@rustbotrustbot
added this to the 1.92.0 milestone
Oct 4, 2025
@rust-timer
rust-timer
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#147245only replace the intended comma in pattern suggestions823632bbfbb2941cdc3c69130f19b39ea565a7aa (link)
#147269Add regression test for 123953e6d43ed4b0f2576be199aef09c60fa1cb7bbab03 (link)
#147277Extract common logic for iterating over featuresa5e9d3e62738bb76f7cf43ada29a686ba2433980 (link)
#147292Respect -Z unstable options in rustdoc --testfa55f38d23003d9a2935ed235975b2e2046974ca (link)
#147300Add xtensa arch to object file creationa91ab691b96334aeb2da787f9fc3655ae4a93d7a (link)
previous master: 7950f244e7
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Oct 4, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7950f24 (parent) -> a0f398e (this PR)
Test differences
Show 36 test diffs

Stage 1
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-143930.rs: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#crate_attr: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#normal: [missing] -> pass (J1)
  • [ui] tests/ui/associated-types/projection-dyn-associated-type.rs: [missing] -> pass (J1)
  • [ui] tests/ui/suggestions/only-replace-intended-coma-not-all-in-pattern.rs: [missing] -> pass (J1)
Stage 2
  • [ui] tests/ui/associated-types/projection-dyn-associated-type.rs: [missing] -> pass (J0)
  • [ui] tests/ui/suggestions/only-replace-intended-coma-not-all-in-pattern.rs: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-143930.rs: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#crate_attr: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#normal: [missing] -> pass (J2)
Additionally, 26 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a0f398e89df9767c93c81cd58d44fdba071258a8 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-x86_64-apple: 6570.0s -> 7916.6s (20.5%)
  2. x86_64-rust-for-linux: 2584.3s -> 3038.0s (17.6%)
  3. i686-gnu-nopt-1: 8138.1s -> 7155.8s (-12.1%)
  4. x86_64-gnu-tools: 3712.1s -> 3300.1s (-11.1%)
  5. armhf-gnu: 4770.2s -> 5198.8s (9.0%)
  6. dist-riscv64-linux: 5409.4s -> 4974.0s (-8.0%)
  7. i686-gnu-2: 5862.5s -> 6233.1s (6.3%)
  8. x86_64-gnu-miri: 4649.0s -> 4367.8s (-6.0%)
  9. aarch64-msvc-2: 5220.5s -> 4905.7s (-6.0%)
  10. dist-apple-various: 3708.7s -> 3490.6s (-5.9%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (a0f398e): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results (primary 0.8%, secondary -1.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		0.8%[0.8%, 0.8%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-1.9%[-1.9%, -1.9%]1
All ❌✅ (primary)0.8%[0.8%, 0.8%]1
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 473.406s -> 472.925s (-0.10%)
Artifact size: 388.33 MiB -> 388.34 MiB (0.00%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

12 participants

@matthiaskrgr@bors@rust-log-analyzer@jieyouxu@rust-timer@rustbot@A4-Tacks@karolzwolak@reddevilmidzy@fee1-dead@Urgau@MabezDev

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Rollup of 5 pull requests by matthiaskrgr · Pull Request #147308 · rust-lang/rust · GitHub
Skip to content
Rollup of 5 pull requests - #147308
Merged
bors merged 16 commits into
rust-lang:masterfrom 
matthiaskrgr:rollup-ov04tbi
Oct 4, 2025
Merged
Rollup of 5 pull requests#147308
bors merged 16 commits into
rust-lang:masterfrom 
matthiaskrgr:rollup-ov04tbi
Conversation
@matthiaskrgr
@matthiaskrgrmatthiaskrgr
commented
Oct 3, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
A4-Tacksand others
added 16 commits
October 1, 2025 22:45
@A4-Tacks@karolzwolak
Fix diagnostics str::replace comma to bar
4735c21
@karolzwolak
bless tests
a08228d
@karolzwolak
regression test
934ad74
@karolzwolak
fix wording; we're replacing coma with a bar
5a8f963
@karolzwolak
bring back plural 'alternatives' in suggestion message
d1d7b94
@reddevilmidzy
test: Add regression test for ICE when projecting associated types th…
fab9906
…rough dyn traits
@fee1-dead
Extract common logic for iterating over features
a5c9030
Two places doing the same thing is enough to motivate me to extract this to a method :)
@Urgau
Respect -Z unstable options in rustdoc --test
3d5f54a
@Urgau
Respect --error-format in rustdoc --test
e914a1a
@Urgau
Add regression test for -Zcrate-attr in rustdoc --test
c1443e2
@MabezDev
Add xtensa arch to object file creation
3f9c493
@matthiaskrgr
Rollup merge ofrust-lang#147245- karolzwolak:only-replace-intended-…
2e06dcd
…bar-not-all-in-pattern, r=lcnr
only replace the intended comma in pattern suggestions
Only suggest to replace the intended comma, not all bars in the pattern.
Fixesrust-lang#143330.
This continues rust-lang#143331, the credit for making the fix goes to `@A4-Tacks.` I just blessed tests and added a regression test.
@matthiaskrgr
Rollup merge ofrust-lang#147269- reddevilmidzy:ice-fix, r=petrochenkov
0d0b695
Add regression test for 123953
close: rust-lang#123953
@matthiaskrgr
Rollup merge ofrust-lang#147277- fee1-dead-contrib:featiter, r=Zala…
9e477c4
…thar
Extract common logic for iterating over features
Two places doing the same thing is enough to motivate me to extract this to a method :)
@matthiaskrgr
Rollup merge ofrust-lang#147292- Urgau:rustdoc-test-unstable_opts, …
dbc5e72
…r=fmease
Respect `-Z` unstable options in `rustdoc --test`
This PR makes rustdoc respect `-Z` unstable options when collecting doctests (`rustdoc --test`).
In the process I also realized that `--error-format` wasn't respected as well, making UI annotations impossible to write so I fixed that as well.
Best reviewed commit by commit.
Fixesrust-lang#147276Fixesrust-lang#143930
r? fmease
@matthiaskrgr
Rollup merge ofrust-lang#147300- esp-rs:xtensa-meta, r=saethlin
30442dc
Add xtensa arch to object file creation
Just something that was missed in the xtensa target PRs.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Oct 3, 2025
@matthiaskrgr
matthiaskrgr
commented
Oct 3, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 30442dc has been approved by matthiaskrgr
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 3, 2025
@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 30442dc with merge f4babc6...
bors added a commit
that referenced
this pull request
Oct 3, 2025
@bors
Auto merge of#147308- matthiaskrgr:rollup-ov04tbi, r=matthiaskrgr
f4babc6
Rollup of 5 pull requests
Successful merges:
- #147245 (only replace the intended comma in pattern suggestions)
- #147269 (Add regression test for 123953)
- #147277 (Extract common logic for iterating over features)
- #147292 (Respect `-Z` unstable options in `rustdoc --test`)
- #147300 (Add xtensa arch to object file creation)
r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
rust-log-analyzer
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
The job x86_64-msvc-ext1 failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
 Verifying foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2383\foo)
Downloading crates ...
Downloaded bar v1.0.0 (registry `dummy-registry`)
Compiling bar v1.0.0
Compiling foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2383\foo\target\package\foo-0.0.1)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.59s
stack backtrace:
0: __rustc::rust_begin_unwind
1: core::panicking::panic_fmt

@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Oct 3, 2025
@matthiaskrgr
matthiaskrgr
commented
Oct 4, 2025

Copy link


Copy Markdown

MemberAuthor
@bors retry
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 4, 2025
@bors
bors
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 30442dc with merge a0f398e...
@ZalatharZalathar
mentioned this pull request
Oct 4, 2025
 Closed

@jieyouxujieyouxu
mentioned this pull request
Oct 4, 2025

Closed

@jieyouxu
jieyouxu
commented
Oct 4, 2025•

edited

Loading

Copy link


Copy Markdown

Member
msvc failure is tracked in #147321

This was referenced Oct 4, 2025
 Closed

 Closed

@bors
bors
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: matthiaskrgr

Pushing a0f398e to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Oct 4, 2025
@bors
bors
merged commit a0f398e
into
rust-lang:masterOct 4, 2025

11 checks passed

@rustbotrustbot
added this to the 1.92.0 milestone
Oct 4, 2025
@rust-timer
rust-timer
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#147245only replace the intended comma in pattern suggestions823632bbfbb2941cdc3c69130f19b39ea565a7aa (link)
#147269Add regression test for 123953e6d43ed4b0f2576be199aef09c60fa1cb7bbab03 (link)
#147277Extract common logic for iterating over featuresa5e9d3e62738bb76f7cf43ada29a686ba2433980 (link)
#147292Respect -Z unstable options in rustdoc --testfa55f38d23003d9a2935ed235975b2e2046974ca (link)
#147300Add xtensa arch to object file creationa91ab691b96334aeb2da787f9fc3655ae4a93d7a (link)
previous master: 7950f244e7
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Oct 4, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7950f24 (parent) -> a0f398e (this PR)
Test differences
Show 36 test diffs

Stage 1
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-143930.rs: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#crate_attr: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#normal: [missing] -> pass (J1)
  • [ui] tests/ui/associated-types/projection-dyn-associated-type.rs: [missing] -> pass (J1)
  • [ui] tests/ui/suggestions/only-replace-intended-coma-not-all-in-pattern.rs: [missing] -> pass (J1)
Stage 2
  • [ui] tests/ui/associated-types/projection-dyn-associated-type.rs: [missing] -> pass (J0)
  • [ui] tests/ui/suggestions/only-replace-intended-coma-not-all-in-pattern.rs: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-143930.rs: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#crate_attr: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#normal: [missing] -> pass (J2)
Additionally, 26 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a0f398e89df9767c93c81cd58d44fdba071258a8 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-x86_64-apple: 6570.0s -> 7916.6s (20.5%)
  2. x86_64-rust-for-linux: 2584.3s -> 3038.0s (17.6%)
  3. i686-gnu-nopt-1: 8138.1s -> 7155.8s (-12.1%)
  4. x86_64-gnu-tools: 3712.1s -> 3300.1s (-11.1%)
  5. armhf-gnu: 4770.2s -> 5198.8s (9.0%)
  6. dist-riscv64-linux: 5409.4s -> 4974.0s (-8.0%)
  7. i686-gnu-2: 5862.5s -> 6233.1s (6.3%)
  8. x86_64-gnu-miri: 4649.0s -> 4367.8s (-6.0%)
  9. aarch64-msvc-2: 5220.5s -> 4905.7s (-6.0%)
  10. dist-apple-various: 3708.7s -> 3490.6s (-5.9%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (a0f398e): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results (primary 0.8%, secondary -1.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		0.8%[0.8%, 0.8%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-1.9%[-1.9%, -1.9%]1
All ❌✅ (primary)0.8%[0.8%, 0.8%]1
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 473.406s -> 472.925s (-0.10%)
Artifact size: 388.33 MiB -> 388.34 MiB (0.00%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

12 participants

@matthiaskrgr@bors@rust-log-analyzer@jieyouxu@rust-timer@rustbot@A4-Tacks@karolzwolak@reddevilmidzy@fee1-dead@Urgau@MabezDev

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Rollup of 5 pull requests by matthiaskrgr · Pull Request #147308 · rust-lang/rust · GitHub
Skip to content
Rollup of 5 pull requests - #147308
Merged
bors merged 16 commits into
rust-lang:masterfrom 
matthiaskrgr:rollup-ov04tbi
Oct 4, 2025
Merged
Rollup of 5 pull requests#147308
bors merged 16 commits into
rust-lang:masterfrom 
matthiaskrgr:rollup-ov04tbi
Conversation
@matthiaskrgr
@matthiaskrgrmatthiaskrgr
commented
Oct 3, 2025•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup
A4-Tacksand others
added 16 commits
October 1, 2025 22:45
@A4-Tacks@karolzwolak
Fix diagnostics str::replace comma to bar
4735c21
@karolzwolak
bless tests
a08228d
@karolzwolak
regression test
934ad74
@karolzwolak
fix wording; we're replacing coma with a bar
5a8f963
@karolzwolak
bring back plural 'alternatives' in suggestion message
d1d7b94
@reddevilmidzy
test: Add regression test for ICE when projecting associated types th…
fab9906
…rough dyn traits
@fee1-dead
Extract common logic for iterating over features
a5c9030
Two places doing the same thing is enough to motivate me to extract this to a method :)
@Urgau
Respect -Z unstable options in rustdoc --test
3d5f54a
@Urgau
Respect --error-format in rustdoc --test
e914a1a
@Urgau
Add regression test for -Zcrate-attr in rustdoc --test
c1443e2
@MabezDev
Add xtensa arch to object file creation
3f9c493
@matthiaskrgr
Rollup merge ofrust-lang#147245- karolzwolak:only-replace-intended-…
2e06dcd
…bar-not-all-in-pattern, r=lcnr
only replace the intended comma in pattern suggestions
Only suggest to replace the intended comma, not all bars in the pattern.
Fixesrust-lang#143330.
This continues rust-lang#143331, the credit for making the fix goes to `@A4-Tacks.` I just blessed tests and added a regression test.
@matthiaskrgr
Rollup merge ofrust-lang#147269- reddevilmidzy:ice-fix, r=petrochenkov
0d0b695
Add regression test for 123953
close: rust-lang#123953
@matthiaskrgr
Rollup merge ofrust-lang#147277- fee1-dead-contrib:featiter, r=Zala…
9e477c4
…thar
Extract common logic for iterating over features
Two places doing the same thing is enough to motivate me to extract this to a method :)
@matthiaskrgr
Rollup merge ofrust-lang#147292- Urgau:rustdoc-test-unstable_opts, …
dbc5e72
…r=fmease
Respect `-Z` unstable options in `rustdoc --test`
This PR makes rustdoc respect `-Z` unstable options when collecting doctests (`rustdoc --test`).
In the process I also realized that `--error-format` wasn't respected as well, making UI annotations impossible to write so I fixed that as well.
Best reviewed commit by commit.
Fixesrust-lang#147276Fixesrust-lang#143930
r? fmease
@matthiaskrgr
Rollup merge ofrust-lang#147300- esp-rs:xtensa-meta, r=saethlin
30442dc
Add xtensa arch to object file creation
Just something that was missed in the xtensa target PRs.
@rustbotrustbot
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-rustdoc
Relevant to the rustdoc team, which will review and decide on the PR/issue.
rollup
A PR which is a rollup
labels
Oct 3, 2025
@matthiaskrgr
matthiaskrgr
commented
Oct 3, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=5
@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 30442dc has been approved by matthiaskrgr
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 3, 2025
@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 30442dc with merge f4babc6...
bors added a commit
that referenced
this pull request
Oct 3, 2025
@bors
Auto merge of#147308- matthiaskrgr:rollup-ov04tbi, r=matthiaskrgr
f4babc6
Rollup of 5 pull requests
Successful merges:
- #147245 (only replace the intended comma in pattern suggestions)
- #147269 (Add regression test for 123953)
- #147277 (Extract common logic for iterating over features)
- #147292 (Respect `-Z` unstable options in `rustdoc --test`)
- #147300 (Add xtensa arch to object file creation)
r? `@ghost`
`@rustbot` modify labels: rollup
@rust-log-analyzer
rust-log-analyzer
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
The job x86_64-msvc-ext1 failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
 Verifying foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2383\foo)
Downloading crates ...
Downloaded bar v1.0.0 (registry `dummy-registry`)
Compiling bar v1.0.0
Compiling foo v0.0.1 (D:\a\rust\rust\build\x86_64-pc-windows-msvc\stage2-tools\x86_64-pc-windows-msvc\tmp\cit\t2383\foo\target\package\foo-0.0.1)
Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.59s
stack backtrace:
0: __rustc::rust_begin_unwind
1: core::panicking::panic_fmt

@bors
bors
commented
Oct 3, 2025

Copy link


Copy Markdown

Collaborator
💔 Test failed - checks-actions
@borsbors
added

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Oct 3, 2025
@matthiaskrgr
matthiaskrgr
commented
Oct 4, 2025

Copy link


Copy Markdown

MemberAuthor
@bors retry
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 4, 2025
@bors
bors
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 30442dc with merge a0f398e...
@ZalatharZalathar
mentioned this pull request
Oct 4, 2025
 Closed

@jieyouxujieyouxu
mentioned this pull request
Oct 4, 2025

Closed

@jieyouxu
jieyouxu
commented
Oct 4, 2025•

edited

Loading

Copy link


Copy Markdown

Member
msvc failure is tracked in #147321

This was referenced Oct 4, 2025
 Closed

 Closed

@bors
bors
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: matthiaskrgr

Pushing a0f398e to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Oct 4, 2025
@bors
bors
merged commit a0f398e
into
rust-lang:masterOct 4, 2025

11 checks passed

@rustbotrustbot
added this to the 1.92.0 milestone
Oct 4, 2025
@rust-timer
rust-timer
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
📌 Perf builds for each rolled up PR:
PR#MessagePerf Build Sha
#147245only replace the intended comma in pattern suggestions823632bbfbb2941cdc3c69130f19b39ea565a7aa (link)
#147269Add regression test for 123953e6d43ed4b0f2576be199aef09c60fa1cb7bbab03 (link)
#147277Extract common logic for iterating over featuresa5e9d3e62738bb76f7cf43ada29a686ba2433980 (link)
#147292Respect -Z unstable options in rustdoc --testfa55f38d23003d9a2935ed235975b2e2046974ca (link)
#147300Add xtensa arch to object file creationa91ab691b96334aeb2da787f9fc3655ae4a93d7a (link)
previous master: 7950f244e7
In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA
@github-actions
github-actionsBot
commented
Oct 4, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7950f24 (parent) -> a0f398e (this PR)
Test differences
Show 36 test diffs

Stage 1
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-143930.rs: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#crate_attr: [missing] -> pass (J1)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#normal: [missing] -> pass (J1)
  • [ui] tests/ui/associated-types/projection-dyn-associated-type.rs: [missing] -> pass (J1)
  • [ui] tests/ui/suggestions/only-replace-intended-coma-not-all-in-pattern.rs: [missing] -> pass (J1)
Stage 2
  • [ui] tests/ui/associated-types/projection-dyn-associated-type.rs: [missing] -> pass (J0)
  • [ui] tests/ui/suggestions/only-replace-intended-coma-not-all-in-pattern.rs: [missing] -> pass (J0)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-143930.rs: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#crate_attr: [missing] -> pass (J2)
  • [ui] tests/rustdoc-ui/doctest/unstable-opts-147276.rs#normal: [missing] -> pass (J2)
Additionally, 26 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard a0f398e89df9767c93c81cd58d44fdba071258a8 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. dist-x86_64-apple: 6570.0s -> 7916.6s (20.5%)
  2. x86_64-rust-for-linux: 2584.3s -> 3038.0s (17.6%)
  3. i686-gnu-nopt-1: 8138.1s -> 7155.8s (-12.1%)
  4. x86_64-gnu-tools: 3712.1s -> 3300.1s (-11.1%)
  5. armhf-gnu: 4770.2s -> 5198.8s (9.0%)
  6. dist-riscv64-linux: 5409.4s -> 4974.0s (-8.0%)
  7. i686-gnu-2: 5862.5s -> 6233.1s (6.3%)
  8. x86_64-gnu-miri: 4649.0s -> 4367.8s (-6.0%)
  9. aarch64-msvc-2: 5220.5s -> 4905.7s (-6.0%)
  10. dist-apple-various: 3708.7s -> 3490.6s (-5.9%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Oct 4, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (a0f398e): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
Results (primary 0.8%, secondary -1.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		0.8%[0.8%, 0.8%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-1.9%[-1.9%, -1.9%]1
All ❌✅ (primary)0.8%[0.8%, 0.8%]1
Cycles
This benchmark run did not return any relevant results for this metric.
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 473.406s -> 472.925s (-0.10%)
Artifact size: 388.33 MiB -> 388.34 MiB (0.00%)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.rollupA PR which is a rollupS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

12 participants

@matthiaskrgr@bors@rust-log-analyzer@jieyouxu@rust-timer@rustbot@A4-Tacks@karolzwolak@reddevilmidzy@fee1-dead@Urgau@MabezDev