Uh oh!
There was an error while loading. Please reload this page.
Set opt-level flag for installing tool only on CI - #147332
Merged
Merged
Conversation
Shunpoco
commented
Oct 4, 2025
ContributorAuthor
r? @Kobzol |
Shunpoco
marked this pull request as ready for review
October 4, 2025 12:46
Kobzol
reviewed
Oct 5, 2025
Uh oh!
There was an error while loading. Please reload this page.
ensure_version_or_cargo_install uses -Copt-level=0 for quicker installation. However, the flag affects the tool's performance. For example, typos-cli with opt-level=0 takes 15 seconds for checking ./compiler, but the tool with default opt-level only takes less than 1 sec. This commit enables the option only when the test tidy is run on CI.
Kobzol
commented
Oct 5, 2025
Member
Thank you! :) @bors r+ rollup |
bors
commented
Oct 5, 2025
Collaborator
bors added a commit
that referenced
this pull request
Oct 5, 2025
Rollup of 4 pull requests Successful merges: - #147327 (cg_llvm: Remove inherent methods from several LLVM FFI types) - #147332 (Set opt-level flag for installing tool only on CI) - #147374 (bootstrap: don't build book redirect pages during dry-run/test) - #147376 (bootstrap: relax `compiler-rt` root assertion) r? `@ghost` `@rustbot` modify labels: rollup
Uh oh!
There was an error while loading. Please reload this page.
rust-timer added a commit
that referenced
this pull request
Oct 5, 2025
Rollup merge of #147332 - Shunpoco:fast-spellcheck, r=Kobzol Set opt-level flag for installing tool only on CI ## Context ensure_version_or_cargo_install uses -Copt-level=0 for quicker installation. However, the flag affects the tool's performance. For example, typos-cli with opt-level=0 takes 15 seconds for checking /compiler on my local, but the tool with default opt-level only takes less than 1 sec. It fixes#147331 ## Changes This PR enables the option only when the test tidy is run on CI. We've discussed that opt-level=1 should be enough, so I also change the level from 0 to 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
ensure_version_or_cargo_install uses -Copt-level=0 for quicker installation. However, the flag affects the tool's performance. For example, typos-cli with opt-level=0 takes 15 seconds for checking /compiler on my local, but the tool with default opt-level only takes less than 1 sec.
It fixes#147331
Changes
This PR enables the option only when the test tidy is run on CI.
We've discussed that opt-level=1 should be enough, so I also change the level from 0 to 1.