Uh oh!
There was an error while loading. Please reload this page.
Rollup of 6 pull requests - #147352
Closed
matthiaskrgr wants to merge 19 commits into
Closed
Conversation
This commit adds some documentation about the state of `-Cpanic=unwind` for the following wasm targets: * `wasm32-unknown-unknown` * `wasm32-wasip1` * `wasm32-wasip2` * `wasm32v1-none` Notably it's possible to use `-Cpanic=unwind` with `-Zbuild-std` and it's also mentioned that there are no concrete proposals at this time to adding a new set of targets which support unwinding. My hunch is that in a few years' time it would make sense to enable it by default on these targets (except for `wasm32v1-none`) but that's a problem for future folks to debate. For now this is an attempt to document the status quo.
…narycat,fmease [rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition Fixesrust-lang#143009. Fixesrust-lang#143858. Since it includes fixes from rust-lang#143453, it's taking it over (commits 2, 3 and 4 are from rust-lang#143453). For `--no-run`, we forgot to check the "global" options in the 2024 edition, fixed in the first commit. For `should_panic` fix, the exit code check has been fixed. cc `@TroyKomodo` (thanks so much for providing such a complete test, made my life a lot easier!) r? `@notriddle`
…json, r=fmease Fix doctest output json Fixesrust-lang#144798. Hopefully it will work with the new changes in `libtest` without needing to do both at once. This PR moves the `rustdoc` merged doctest extra information directly into `libtest` to ensure they share the same rendering to prevent the bug uncovered in rust-lang#144798. cc `@lolbinary` (as you reviewed the first PR) And since we're making changes to `libtest`: r? `@Amanieu`
…r=jieyouxu Add documentation about unwinding to wasm targets This commit adds some documentation about the state of `-Cpanic=unwind` for the following wasm targets: * `wasm32-unknown-unknown` * `wasm32-wasip1` * `wasm32-wasip2` * `wasm32v1-none` Notably it's possible to use `-Cpanic=unwind` with `-Zbuild-std` and it's also mentioned that there are no concrete proposals at this time to adding a new set of targets which support unwinding. My hunch is that in a few years' time it would make sense to enable it by default on these targets (except for `wasm32v1-none`) but that's a problem for future folks to debate. For now this is an attempt to document the status quo.
Implement non-poisoning `Mutex::with_mut`, `RwLock::with` and `RwLock::with_mut` ACP: rust-lang/libs-team#497.
Make `fmt::Write` a diagnostic item I'm working on an enhancement to [`clippy::format_push_string`](https://rust-lang.github.io/rust-clippy/master/index.html#format_push_string), which would suggest an autofix to replace `push_str`/`+=` with `write!`. But that could require importing `std::fmt::Write`, and so I need this diagnostic item to check if it's already in scope. The reason I called it `FmtWrite` and not just `Write` is that there's already an `IoWrite` defined.
…=Noratrieb Improve the advice given by panic_immediate_abort Now that rust-lang#147338 is merged, users should consider using the Cargo support for immediate-aborting panics.
matthiaskrgr
commented
Oct 4, 2025
MemberAuthor
@bors r+ rollup=never p=5 |
bors
commented
Oct 4, 2025
Collaborator
bors added a commit
that referenced
this pull request
Oct 5, 2025
Rollup of 6 pull requests Successful merges: - #143900 ([rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition) - #144908 (Fix doctest output json) - #147309 (Add documentation about unwinding to wasm targets) - #147328 (Implement non-poisoning `Mutex::with_mut`, `RwLock::with` and `RwLock::with_mut`) - #147337 (Make `fmt::Write` a diagnostic item) - #147349 (Improve the advice given by panic_immediate_abort) r? `@ghost` `@rustbot` modify labels: rollup
bors
commented
Oct 5, 2025
Collaborator
rust-log-analyzer
commented
Oct 5, 2025
Collaborator
The job Click to see the possible cause of the failure (guessed by this bot) |
bors
commented
Oct 5, 2025
Collaborator
💔 Test failed - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
should_panicdoctest attribute and fix--no-runtest flag on the 2024 edition #143900 ([rustdoc] Correctly handleshould_panicdoctest attribute and fix--no-runtest flag on the 2024 edition)Mutex::with_mut,RwLock::withandRwLock::with_mut#147328 (Implement non-poisoningMutex::with_mut,RwLock::withandRwLock::with_mut)fmt::Writea diagnostic item #147337 (Makefmt::Writea diagnostic item)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup