Clippy subtree update by flip1995 · Pull Request #147405 · rust-lang/rust

flip1995 · 2025-10-06T15:55:45Z

r? Manishearth

Cargo.lock update due to toml version bump. This caused serde_core being added as a transitive dependency, so tidy --bless had to be run.

(Sorry for the late sync)

The autofix now: - includes the swapping of index and element in the closure in which the content will be consumed; - notes, with applicability `MaybeIncorrect` (because it will be), that the element and the index will be swapped.

Signed-off-by: Justus Flügel <justusfluegel@gmail.com>

…tion

Renames InstantSubtraction to UncheckedTimeSubtraction

* Don't check for repetition if the previous module crosses a body boundary. * Don't take a snippet of the entire item. * Check each item's visibility once. * Use `is_from_proc_macro` before linting

Clean up `ty::Dynamic` 1. As a follow-up to PR rust-lang#143036, remove `DynKind` entirely. 2. Inside HIR ty lowering, consolidate modules `dyn_compatibility` and `lint` into `dyn_trait` * `dyn_compatibility` wasn't about dyn compatibility itself, it's about lowering trait object types * `lint` contained dyn-Trait-specific diagnostics+lints only

refactored with `check_item` and `check_item_post`. this refactoring also fixed a few bugs related to mod path with shared segment name caused by preivous approach. changelog: [`self_named_module_files`]: don't lint mod tagged with path attribute changelog: [`mod_module_files`]: don't lint mod tagged with path attribute Signed-off-by: Zihan <zihanli0822@gmail.com>

…ubtree-update

changelog: none

and use it instead of clippy::only_used_in_recursion when the parameter in question is self.

* Don't check for repetition if the previous module crosses a body boundary. * Don't take a snippet of the entire item. * Check each item's visibility once. * Use `is_from_proc_macro` before linting changelog: none

@flip1995

Missed update lints versions for 1.90 at rust-lang/rust-clippy#15670 so doing this changelog: none r? @flip1995

and use it instead of `clippy::only_used_in_recursion` when the parameter in question is self. Fixesrust-lang/rust-clippy#10370 changelog: [`only_used_in_recursion`]: Don't lint if parameter is `self`; add pedantic `self_only_used_in_recursion` lint.

The autofix now: - includes the swapping of index and element in the closure in which the content will be consumed; - notes, with applicability `MaybeIncorrect` (because it will be), that the element and the index will be swapped. changelog: [`range_zip_with_len`]: better suggestion, and better applicability Fixesrust-lang/rust-clippy#14929

rust-lang#15593) Fixesrust-lang/rust-clippy#9913 changelog: [`nonstandard_macro_braces`]: suggest trailing semicolon when needed

changelog: none

Signed-off-by: Justus Flügel <justusfluegel@gmail.com>

all the lints work with `if`-expressions

rustbot · 2025-10-06T15:55:54Z

⚠️Warning⚠️

There are issue links (such as #123) in the commit messages of the following commits.
Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.

…ubtree-update

rustbot · 2025-10-06T16:28:32Z

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

Manishearth · 2025-10-06T17:24:34Z

@bors r+ p=1 rollup=never

bors · 2025-10-06T17:24:36Z

📌 Commit e652436 has been approved by Manishearth

It is now in the queue for this repository.

bors · 2025-10-06T21:12:28Z

⌛ Testing commit e652436 with merge 68ad253...

bors · 2025-10-07T00:21:33Z

☀️ Test successful - checks-actions
Approved by: Manishearth
Pushing 68ad253 to master...

github-actions · 2025-10-07T00:24:42Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3d8c1c1 (parent) -> 68ad253 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 68ad25392f6faf1af5d169bdd81c817521ad2c1d --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

dist-various-1: 4452.6s -> 3665.3s (-17.7%)
dist-apple-various: 4181.1s -> 3450.2s (-17.5%)
tidy: 183.4s -> 214.5s (16.9%)
i686-gnu-2: 5432.5s -> 6332.2s (16.6%)
aarch64-gnu-debug: 3862.6s -> 4357.8s (12.8%)
dist-i686-msvc: 7648.3s -> 8572.0s (12.1%)
test-various: 4421.7s -> 4940.2s (11.7%)
i686-gnu-nopt-1: 7441.5s -> 8262.8s (11.0%)
x86_64-gnu-llvm-20-1: 3189.4s -> 3475.0s (9.0%)
arm-android: 5850.6s -> 6362.2s (8.7%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-10-07T01:31:28Z

Finished benchmarking commit (68ad253): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.0%	[3.0%, 3.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.0%	[3.0%, 3.0%]	1

Cycles

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-4.9%, -2.0%]	4
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 472.01s -> 473.761s (0.37%)
Artifact size: 388.39 MiB -> 388.37 MiB (-0.00%)

bonzini · 2025-10-09T20:48:46Z

Seems to have caused rust-lang/rust-clippy#15852

samueltardieuand others added 30 commits June 4, 2025 15:51

Note that using enumerate() will swap the arguments
ea2ea62
The autofix now: - includes the swapping of index and element in the closure in which the content will be consumed; - notes, with applicability `MaybeIncorrect` (because it will be), that the element and the index will be swapped.

Bless clippy tests.
d43c55b

Fix explicit_deref_methods triggering from within proc macros
e513ecc
Signed-off-by: Justus Flügel <justusfluegel@gmail.com>

fix nonstandard_macro_braces: suggest trailing semicolon when needed
b92330b

clean-up single_match a bit
05156f4

fix(collapsible{,_else}_if): respect #[expect] on inner if
593a9c9

Remove DynKind
4d931e6

rename_lint: unchecked_duration_subtraction to unchecked_time_subtrac…
2972ae5
…tion

rename module: instant_substraction to time_substraction
b0566b9

Implement Duration - Duration
f296de4
Renames InstantSubtraction to UncheckedTimeSubtraction

Rework module_inception
26cf3ee
* Don't check for repetition if the previous module crosses a body boundary. * Don't take a snippet of the entire item. * Check each item's visibility once. * Use `is_from_proc_macro` before linting

Changelog: fix heading level in 1.90 section
427774a

Merge commit '20ce69b9a63bcd2756cd906fe0964d1e901e042a' into clippy-s…
47bcee4
…ubtree-update

Changelog: fix heading level in 1.90 section (rust-lang#15703)
8a5dc7c
changelog: none

Add clippy::self_only_used_in_recursion lint
63a5508
and use it instead of clippy::only_used_in_recursion when the parameter in question is self.

Reworkmodule_inception(rust-lang#14753)
00bbdea
* Don't check for repetition if the previous module crosses a body boundary. * Don't take a snippet of the entire item. * Check each item's visibility once. * Use `is_from_proc_macro` before linting changelog: none

Fix versions lints from 1.90.0
4a909bc

Fix versions lints for 1.90.0 (rust-lang#15712)
fac86e3
Missed update lints versions for 1.90 at rust-lang/rust-clippy#15670 so doing this changelog: none r? @flip1995

fix: question_mark FP on variables used after
fb7e89c

fix nonstandard_macro_braces: suggest trailing semicolon when needed (
cc5a01d
rust-lang#15593) Fixesrust-lang/rust-clippy#9913 changelog: [`nonstandard_macro_braces`]: suggest trailing semicolon when needed

clean-upsingle_matcha bit (rust-lang#15641)
1c14af8
changelog: none

Add tests for explicit_deref_methods lints from within proc macros
3e65620
Signed-off-by: Justus Flügel <justusfluegel@gmail.com>

Update actions/download-artifact to v5
2f6503d

default_constructed_unit_structs: use check_source_text
77f44f2

clean-up match_same_arms a bit
f76664c

move copies.rs to ifs/mod.rs
b6c4b30
all the lints work with `if`-expressions

rustbot added the T-clippy Relevant to the Clippy team. label Oct 6, 2025

rustbot assigned Manishearth Oct 6, 2025

This comment has been minimized.
Sign in to view

flip1995 added 2 commits October 6, 2025 18:10

Merge commit '2dc84cb744ad19d187871afb0385a616d80c209d' into clippy-s…
827fc6e
…ubtree-update

Update Cargo.lock
8c4be66

flip1995 force-pushed the clippy-subtree-update branch from 4583238 to 8c4be66Compare October 6, 2025 16:10

This comment has been minimized.
Sign in to view

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Oct 6, 2025

This comment has been minimized.
Sign in to view

Allow serde_core as a dependency
e652436

flip1995 force-pushed the clippy-subtree-update branch from ef574f9 to e652436Compare October 6, 2025 16:28

rustbot added the A-tidy Area: The tidy tool label Oct 6, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 7, 2025

bors merged commit 68ad253 into rust-lang:masterOct 7, 2025
11 checks passed

rustbot added this to the 1.92.0 milestone Oct 7, 2025

This was referenced Oct 7, 2025
Weekly cargo update#145516
Open
Weekly cargo update + update allowed dependencies list #145849
Closed
Uplift and extend clippy::needless-maybe-sized into rustc #145924
Open

dtolnay mentioned this pull request Oct 8, 2025
allow(clippy::expl_impl_clone_on_copy) stopped working rust-lang/rust-clippy#15842
Closed

Navigation Menu

Uh oh!

Uh oh!

Clippy subtree update - #147405

Clippy subtree update#147405
bors merged 152 commits into
rust-lang:masterfrom
flip1995:clippy-subtree-update

flip1995 commented Oct 6, 2025•
edited
Loading

Uh oh!

rustbot commented Oct 6, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Oct 6, 2025

Uh oh!

Manishearth commented Oct 6, 2025

Uh oh!

bors commented Oct 6, 2025

Uh oh!

bors commented Oct 6, 2025

Uh oh!

bors commented Oct 7, 2025

Uh oh!

Uh oh!

github-actionsBot commented Oct 7, 2025

Uh oh!

rust-timer commented Oct 7, 2025

Uh oh!

bonzini commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Uh oh!

Conversation

flip1995 commented Oct 6, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 6, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rustbot commented Oct 6, 2025

Uh oh!

Manishearth commented Oct 6, 2025

Uh oh!

bors commented Oct 6, 2025

Uh oh!

bors commented Oct 6, 2025

Uh oh!

bors commented Oct 7, 2025

Uh oh!

Uh oh!

github-actionsBot commented Oct 7, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Oct 7, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

bonzini commented Oct 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

flip1995 commented Oct 6, 2025•
edited
Loading