Skip to content

Add doc links between {integer}::from_str_radix and from_str - #147605

Merged
bors merged 1 commit into
rust-lang:masterfrom
Zalathar:from-str-radix
Oct 13, 2025
Merged

Add doc links between {integer}::from_str_radix and from_str#147605
bors merged 1 commit into
rust-lang:masterfrom
Zalathar:from-str-radix

Conversation

@Zalathar

Copy link
Copy Markdown
Member

When parsing base-10 numbers, it's easy to miss <Self as FromStr>::from_str and str::parse as potential alternatives to from_str_radix.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 12, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Oct 12, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 2be88e3 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2025
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 13, 2025
…mulacrum
Add doc links between `{integer}::from_str_radix` and `from_str`
When parsing base-10 numbers, it's easy to miss `<Self as FromStr>::from_str` and `str::parse` as potential alternatives to `from_str_radix`.
- A similar suggestion is given by https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10
This was referenced Oct 13, 2025
bors added a commit that referenced this pull request Oct 13, 2025
Rollup of 6 pull requests
Successful merges:
- #147514 (repr_transparent_external_private_fields: normalize types during traversal)
- #147605 (Add doc links between `{integer}::from_str_radix` and `from_str`)
- #147608 (cg_llvm: Use `LLVMDIBuilderCreateGlobalVariableExpression`)
- #147623 (Clear `ChunkedBitSet` without reallocating)
- #147625 (Add a warning when running tests with the GCC backend and debug assertions are enabled)
- #147626 (Generalize configuring LLD as the default linker in bootstrap)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit b7ea44a into rust-lang:masterOct 13, 2025
10 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 13, 2025
rust-timer added a commit that referenced this pull request Oct 13, 2025
Rollup merge of #147605 - Zalathar:from-str-radix, r=Mark-Simulacrum
Add doc links between `{integer}::from_str_radix` and `from_str`
When parsing base-10 numbers, it's easy to miss `<Self as FromStr>::from_str` and `str::parse` as potential alternatives to `from_str_radix`.
- A similar suggestion is given by https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10
@Zalathar
Zalathar deleted the from-str-radix branch October 14, 2025 01:12
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
…mulacrum
Add doc links between `{integer}::from_str_radix` and `from_str`
When parsing base-10 numbers, it's easy to miss `<Self as FromStr>::from_str` and `str::parse` as potential alternatives to `from_str_radix`.
- A similar suggestion is given by https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Zalathar@rustbot@rust-log-analyzer@Mark-Simulacrum@bors