Skip to content

Liveness: Cache the set of string constants for suggestions. - #147641

Merged
bors merged 1 commit into
rust-lang:masterfrom
cjgillot:liveness-cache-strings
Nov 7, 2025
Merged

Liveness: Cache the set of string constants for suggestions.#147641
bors merged 1 commit into
rust-lang:masterfrom
cjgillot:liveness-cache-strings

Conversation

@cjgillot

@cjgillotcjgillot commented Oct 13, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Even on a slow diagnostic path, listing all the constants in MIR can be expensive, so cache it.

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 13, 2025
@cjgillot

cjgillot commented Oct 13, 2025

Copy link
Copy Markdown
ContributorAuthor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot added a commit that referenced this pull request Oct 13, 2025
@rust-bors
Auto merge of#147641- cjgillot:liveness-cache-strings, r=<try>
adc508b
Liveness: Cache the set of string constants for suggestions.
@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 13, 2025
@rust-bors

rust-borsBot commented Oct 13, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: adc508b (adc508b9c46926c0f3e4b324eab0405c2ec2e126, parent: 9b8264604ef800b5539d04bf78ebdef5c5fa4968)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer

rust-timer commented Oct 13, 2025

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (adc508b): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.8%[-1.3%, -0.4%]4
Improvements ✅
(secondary)		-0.1%[-0.1%, -0.1%]1
All ❌✅ (primary)-0.8%[-1.3%, -0.4%]4

Max RSS (memory usage)

Results (primary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-2.9%[-2.9%, -2.9%]1
Improvements ✅
(secondary)		--0
All ❌✅ (primary)-2.9%[-2.9%, -2.9%]1

Cycles

Results (secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		4.3%[2.5%, 6.1%]2
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-2.7%[-3.4%, -2.1%]2
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 474.96s -> 474.876s (-0.02%)
Artifact size: 388.14 MiB -> 388.11 MiB (-0.01%)

@rustbotrustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Oct 13, 2025
@cjgillot
cjgillot marked this pull request as ready for review October 13, 2025 19:32
@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 13, 2025
@rustbot

rustbot commented Oct 13, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbotrustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 13, 2025
@rustbot

rustbot commented Oct 13, 2025

Copy link
Copy Markdown
Collaborator

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@cjgillot

cjgillot commented Oct 13, 2025

Copy link
Copy Markdown
ContributorAuthor

r? estebank

@rustbotrustbot assigned estebank and unassigned petrochenkovOct 13, 2025
@cjgillot
cjgillotforce-pushed the liveness-cache-strings branch from 1e1f299 to 727da8cCompareOctober 26, 2025 17:40
@rustbot

rustbot commented Oct 26, 2025

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@cjgillot

cjgillot commented Nov 6, 2025

Copy link
Copy Markdown
ContributorAuthor

r? compiler

@rustbotrustbot assigned madsmtm and unassigned estebankNov 6, 2025
@estebank

estebank commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Nov 6, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 727da8c has been approved by estebank

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025
@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 727da8c with merge 9606412...

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 9606412 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 7, 2025
@bors
bors merged commit 9606412 into rust-lang:masterNov 7, 2025
12 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 7, 2025
@github-actions

github-actionsBot commented Nov 7, 2025

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0bbef55 (parent) -> 9606412 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 96064126a086a8428d66e07fb3b91421bb86a512 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. tidy: 296.8s -> 173.3s (-41.6%)
  2. pr-check-1: 1817.4s -> 1319.5s (-27.4%)
  3. i686-gnu-2: 6340.6s -> 5251.6s (-17.2%)
  4. i686-gnu-1: 8461.7s -> 7041.6s (-16.8%)
  5. dist-x86_64-apple: 7985.9s -> 6723.0s (-15.8%)
  6. dist-aarch64-apple: 6568.6s -> 5563.0s (-15.3%)
  7. x86_64-gnu-gcc: 3512.3s -> 3065.2s (-12.7%)
  8. dist-aarch64-msvc: 6164.9s -> 5398.0s (-12.4%)
  9. x86_64-gnu-llvm-21-3: 6354.1s -> 5617.6s (-11.6%)
  10. x86_64-gnu-tools: 3761.6s -> 3375.5s (-10.3%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (9606412): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		-0.9%[-1.4%, -0.5%]4
Improvements ✅
(secondary)		--0
All ❌✅ (primary)-0.9%[-1.4%, -0.5%]4

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		2.9%[2.9%, 2.9%]2
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		-5.7%[-5.7%, -5.7%]1
All ❌✅ (primary)--0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.138s -> 473.265s (-0.39%)
Artifact size: 390.81 MiB -> 390.81 MiB (-0.00%)

@cjgillot
cjgillot deleted the liveness-cache-strings branch November 7, 2025 18:26
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@bors
Auto merge ofrust-lang#147641- cjgillot:liveness-cache-strings, r=e…
6eb4ca2
…stebank
Liveness: Cache the set of string constants for suggestions.
Even on a slow diagnostic path, listing all the constants in MIR can be expensive, so cache it.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@madsmtmmadsmtm

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

7 participants

@cjgillot@rust-timer@rustbot@estebank@bors@petrochenkov@madsmtm
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Liveness: Cache the set of string constants for suggestions. by cjgillot · Pull Request #147641 · rust-lang/rust · GitHub
Skip to content
Liveness: Cache the set of string constants for suggestions. - #147641
Merged
bors merged 1 commit into
rust-lang:masterfrom 
cjgillot:liveness-cache-strings
Nov 7, 2025
Merged
Liveness: Cache the set of string constants for suggestions.#147641
bors merged 1 commit into
rust-lang:masterfrom 
cjgillot:liveness-cache-strings
Conversation
@cjgillot
@cjgillotcjgillot
commented
Oct 13, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Even on a slow diagnostic path, listing all the constants in MIR can be expensive, so cache it.
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Oct 13, 2025
@cjgillot
cjgillot
commented
Oct 13, 2025

Copy link


Copy Markdown

ContributorAuthor
@bors try @rust-timer queue
@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
added a commit
that referenced
this pull request
Oct 13, 2025
@rust-bors
Auto merge of#147641- cjgillot:liveness-cache-strings, r=<try>
adc508b
Liveness: Cache the set of string constants for suggestions.
@rustbotrustbot
added
the 
S-waiting-on-perf
Status: Waiting on a perf run to be completed.
label
Oct 13, 2025
@rust-bors
rust-borsBot
commented
Oct 13, 2025

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: adc508b (adc508b9c46926c0f3e4b324eab0405c2ec2e126, parent: 9b8264604ef800b5539d04bf78ebdef5c5fa4968)
@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
rust-timer
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (adc508b): comparison URL.
Overall result: ✅ improvements - no action needed
Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.
@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.8%[-1.3%, -0.4%]4
Improvements ✅ 
 (secondary)		-0.1%[-0.1%, -0.1%]1
All ❌✅ (primary)-0.8%[-1.3%, -0.4%]4
Max RSS (memory usage)
Results (primary -2.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-2.9%[-2.9%, -2.9%]1
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-2.9%[-2.9%, -2.9%]1
Cycles
Results (secondary 0.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		4.3%[2.5%, 6.1%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.7%[-3.4%, -2.1%]2
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 474.96s -> 474.876s (-0.02%)
Artifact size: 388.14 MiB -> 388.11 MiB (-0.01%)
@rustbotrustbot
removed
the 
S-waiting-on-perf
Status: Waiting on a perf run to be completed.
label
Oct 13, 2025
@cjgillot
cjgillot
marked this pull request as ready for review
October 13, 2025 19:32
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 13, 2025
@rustbot
rustbot
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
Some changes occurred to MIR optimizations
cc @rust-lang/wg-mir-opt
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Oct 13, 2025
@rustbot
rustbot
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
r? @petrochenkov
rustbot has assigned @petrochenkov.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@cjgillot
cjgillot
commented
Oct 13, 2025

Copy link


Copy Markdown

ContributorAuthor
r? estebank
@rustbotrustbot
assigned estebank and unassigned petrochenkovOct 13, 2025
@cjgillot
cjgillotforce-pushed
the
liveness-cache-strings
branch
from
1e1f299 to
727da8cCompareOctober 26, 2025 17:40
@rustbot
rustbot
commented
Oct 26, 2025

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@cjgillot
cjgillot
commented
Nov 6, 2025

Copy link


Copy Markdown

ContributorAuthor
r? compiler
@rustbotrustbot
assigned madsmtm and unassigned estebankNov 6, 2025
@estebank
estebank
commented
Nov 6, 2025

Copy link


Copy Markdown

Contributor
@bors r+
@bors
bors
commented
Nov 6, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 727da8c has been approved by estebank
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 6, 2025
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 727da8c with merge 9606412...
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: estebank

Pushing 9606412 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 7, 2025
@bors
bors
merged commit 9606412
into
rust-lang:masterNov 7, 2025

12 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 7, 2025
@github-actions
github-actionsBot
commented
Nov 7, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0bbef55 (parent) -> 9606412 (this PR)
Test differences
Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 96064126a086a8428d66e07fb3b91421bb86a512 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. tidy: 296.8s -> 173.3s (-41.6%)
  2. pr-check-1: 1817.4s -> 1319.5s (-27.4%)
  3. i686-gnu-2: 6340.6s -> 5251.6s (-17.2%)
  4. i686-gnu-1: 8461.7s -> 7041.6s (-16.8%)
  5. dist-x86_64-apple: 7985.9s -> 6723.0s (-15.8%)
  6. dist-aarch64-apple: 6568.6s -> 5563.0s (-15.3%)
  7. x86_64-gnu-gcc: 3512.3s -> 3065.2s (-12.7%)
  8. dist-aarch64-msvc: 6164.9s -> 5398.0s (-12.4%)
  9. x86_64-gnu-llvm-21-3: 6354.1s -> 5617.6s (-11.6%)
  10. x86_64-gnu-tools: 3761.6s -> 3375.5s (-10.3%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (9606412): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.9%[-1.4%, -0.5%]4
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-0.9%[-1.4%, -0.5%]4
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (secondary 0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		2.9%[2.9%, 2.9%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-5.7%[-5.7%, -5.7%]1
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 475.138s -> 473.265s (-0.39%)
Artifact size: 390.81 MiB -> 390.81 MiB (-0.00%)
@cjgillot
cjgillot
deleted the

liveness-cache-strings

branch
November 7, 2025 18:26
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@bors
Auto merge ofrust-lang#147641- cjgillot:liveness-cache-strings, r=e…
6eb4ca2
…stebank
Liveness: Cache the set of string constants for suggestions.
Even on a slow diagnostic path, listing all the constants in MIR can be expensive, so cache it.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@madsmtmmadsmtm

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

7 participants

@cjgillot@rust-timer@rustbot@estebank@bors@petrochenkov@madsmtm

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Liveness: Cache the set of string constants for suggestions. by cjgillot · Pull Request #147641 · rust-lang/rust · GitHub
Skip to content
Liveness: Cache the set of string constants for suggestions. - #147641
Merged
bors merged 1 commit into
rust-lang:masterfrom 
cjgillot:liveness-cache-strings
Nov 7, 2025
Merged
Liveness: Cache the set of string constants for suggestions.#147641
bors merged 1 commit into
rust-lang:masterfrom 
cjgillot:liveness-cache-strings
Conversation
@cjgillot
@cjgillotcjgillot
commented
Oct 13, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Even on a slow diagnostic path, listing all the constants in MIR can be expensive, so cache it.
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Oct 13, 2025
@cjgillot
cjgillot
commented
Oct 13, 2025

Copy link


Copy Markdown

ContributorAuthor
@bors try @rust-timer queue
@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
added a commit
that referenced
this pull request
Oct 13, 2025
@rust-bors
Auto merge of#147641- cjgillot:liveness-cache-strings, r=<try>
adc508b
Liveness: Cache the set of string constants for suggestions.
@rustbotrustbot
added
the 
S-waiting-on-perf
Status: Waiting on a perf run to be completed.
label
Oct 13, 2025
@rust-bors
rust-borsBot
commented
Oct 13, 2025

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: adc508b (adc508b9c46926c0f3e4b324eab0405c2ec2e126, parent: 9b8264604ef800b5539d04bf78ebdef5c5fa4968)
@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
rust-timer
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (adc508b): comparison URL.
Overall result: ✅ improvements - no action needed
Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.
@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.8%[-1.3%, -0.4%]4
Improvements ✅ 
 (secondary)		-0.1%[-0.1%, -0.1%]1
All ❌✅ (primary)-0.8%[-1.3%, -0.4%]4
Max RSS (memory usage)
Results (primary -2.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-2.9%[-2.9%, -2.9%]1
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-2.9%[-2.9%, -2.9%]1
Cycles
Results (secondary 0.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		4.3%[2.5%, 6.1%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.7%[-3.4%, -2.1%]2
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 474.96s -> 474.876s (-0.02%)
Artifact size: 388.14 MiB -> 388.11 MiB (-0.01%)
@rustbotrustbot
removed
the 
S-waiting-on-perf
Status: Waiting on a perf run to be completed.
label
Oct 13, 2025
@cjgillot
cjgillot
marked this pull request as ready for review
October 13, 2025 19:32
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 13, 2025
@rustbot
rustbot
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
Some changes occurred to MIR optimizations
cc @rust-lang/wg-mir-opt
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Oct 13, 2025
@rustbot
rustbot
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
r? @petrochenkov
rustbot has assigned @petrochenkov.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@cjgillot
cjgillot
commented
Oct 13, 2025

Copy link


Copy Markdown

ContributorAuthor
r? estebank
@rustbotrustbot
assigned estebank and unassigned petrochenkovOct 13, 2025
@cjgillot
cjgillotforce-pushed
the
liveness-cache-strings
branch
from
1e1f299 to
727da8cCompareOctober 26, 2025 17:40
@rustbot
rustbot
commented
Oct 26, 2025

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@cjgillot
cjgillot
commented
Nov 6, 2025

Copy link


Copy Markdown

ContributorAuthor
r? compiler
@rustbotrustbot
assigned madsmtm and unassigned estebankNov 6, 2025
@estebank
estebank
commented
Nov 6, 2025

Copy link


Copy Markdown

Contributor
@bors r+
@bors
bors
commented
Nov 6, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 727da8c has been approved by estebank
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 6, 2025
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 727da8c with merge 9606412...
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: estebank

Pushing 9606412 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 7, 2025
@bors
bors
merged commit 9606412
into
rust-lang:masterNov 7, 2025

12 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 7, 2025
@github-actions
github-actionsBot
commented
Nov 7, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0bbef55 (parent) -> 9606412 (this PR)
Test differences
Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 96064126a086a8428d66e07fb3b91421bb86a512 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. tidy: 296.8s -> 173.3s (-41.6%)
  2. pr-check-1: 1817.4s -> 1319.5s (-27.4%)
  3. i686-gnu-2: 6340.6s -> 5251.6s (-17.2%)
  4. i686-gnu-1: 8461.7s -> 7041.6s (-16.8%)
  5. dist-x86_64-apple: 7985.9s -> 6723.0s (-15.8%)
  6. dist-aarch64-apple: 6568.6s -> 5563.0s (-15.3%)
  7. x86_64-gnu-gcc: 3512.3s -> 3065.2s (-12.7%)
  8. dist-aarch64-msvc: 6164.9s -> 5398.0s (-12.4%)
  9. x86_64-gnu-llvm-21-3: 6354.1s -> 5617.6s (-11.6%)
  10. x86_64-gnu-tools: 3761.6s -> 3375.5s (-10.3%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (9606412): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.9%[-1.4%, -0.5%]4
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-0.9%[-1.4%, -0.5%]4
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (secondary 0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		2.9%[2.9%, 2.9%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-5.7%[-5.7%, -5.7%]1
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 475.138s -> 473.265s (-0.39%)
Artifact size: 390.81 MiB -> 390.81 MiB (-0.00%)
@cjgillot
cjgillot
deleted the

liveness-cache-strings

branch
November 7, 2025 18:26
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@bors
Auto merge ofrust-lang#147641- cjgillot:liveness-cache-strings, r=e…
6eb4ca2
…stebank
Liveness: Cache the set of string constants for suggestions.
Even on a slow diagnostic path, listing all the constants in MIR can be expensive, so cache it.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@madsmtmmadsmtm

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

7 participants

@cjgillot@rust-timer@rustbot@estebank@bors@petrochenkov@madsmtm

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Liveness: Cache the set of string constants for suggestions. by cjgillot · Pull Request #147641 · rust-lang/rust · GitHub
Skip to content
Liveness: Cache the set of string constants for suggestions. - #147641
Merged
bors merged 1 commit into
rust-lang:masterfrom 
cjgillot:liveness-cache-strings
Nov 7, 2025
Merged
Liveness: Cache the set of string constants for suggestions.#147641
bors merged 1 commit into
rust-lang:masterfrom 
cjgillot:liveness-cache-strings
Conversation
@cjgillot
@cjgillotcjgillot
commented
Oct 13, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Even on a slow diagnostic path, listing all the constants in MIR can be expensive, so cache it.
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Oct 13, 2025
@cjgillot
cjgillot
commented
Oct 13, 2025

Copy link


Copy Markdown

ContributorAuthor
@bors try @rust-timer queue
@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
added a commit
that referenced
this pull request
Oct 13, 2025
@rust-bors
Auto merge of#147641- cjgillot:liveness-cache-strings, r=<try>
adc508b
Liveness: Cache the set of string constants for suggestions.
@rustbotrustbot
added
the 
S-waiting-on-perf
Status: Waiting on a perf run to be completed.
label
Oct 13, 2025
@rust-bors
rust-borsBot
commented
Oct 13, 2025

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: adc508b (adc508b9c46926c0f3e4b324eab0405c2ec2e126, parent: 9b8264604ef800b5539d04bf78ebdef5c5fa4968)
@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
rust-timer
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (adc508b): comparison URL.
Overall result: ✅ improvements - no action needed
Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.
@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.8%[-1.3%, -0.4%]4
Improvements ✅ 
 (secondary)		-0.1%[-0.1%, -0.1%]1
All ❌✅ (primary)-0.8%[-1.3%, -0.4%]4
Max RSS (memory usage)
Results (primary -2.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-2.9%[-2.9%, -2.9%]1
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-2.9%[-2.9%, -2.9%]1
Cycles
Results (secondary 0.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		4.3%[2.5%, 6.1%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.7%[-3.4%, -2.1%]2
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 474.96s -> 474.876s (-0.02%)
Artifact size: 388.14 MiB -> 388.11 MiB (-0.01%)
@rustbotrustbot
removed
the 
S-waiting-on-perf
Status: Waiting on a perf run to be completed.
label
Oct 13, 2025
@cjgillot
cjgillot
marked this pull request as ready for review
October 13, 2025 19:32
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 13, 2025
@rustbot
rustbot
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
Some changes occurred to MIR optimizations
cc @rust-lang/wg-mir-opt
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Oct 13, 2025
@rustbot
rustbot
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
r? @petrochenkov
rustbot has assigned @petrochenkov.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@cjgillot
cjgillot
commented
Oct 13, 2025

Copy link


Copy Markdown

ContributorAuthor
r? estebank
@rustbotrustbot
assigned estebank and unassigned petrochenkovOct 13, 2025
@cjgillot
cjgillotforce-pushed
the
liveness-cache-strings
branch
from
1e1f299 to
727da8cCompareOctober 26, 2025 17:40
@rustbot
rustbot
commented
Oct 26, 2025

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@cjgillot
cjgillot
commented
Nov 6, 2025

Copy link


Copy Markdown

ContributorAuthor
r? compiler
@rustbotrustbot
assigned madsmtm and unassigned estebankNov 6, 2025
@estebank
estebank
commented
Nov 6, 2025

Copy link


Copy Markdown

Contributor
@bors r+
@bors
bors
commented
Nov 6, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 727da8c has been approved by estebank
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 6, 2025
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 727da8c with merge 9606412...
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: estebank

Pushing 9606412 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 7, 2025
@bors
bors
merged commit 9606412
into
rust-lang:masterNov 7, 2025

12 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 7, 2025
@github-actions
github-actionsBot
commented
Nov 7, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0bbef55 (parent) -> 9606412 (this PR)
Test differences
Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 96064126a086a8428d66e07fb3b91421bb86a512 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. tidy: 296.8s -> 173.3s (-41.6%)
  2. pr-check-1: 1817.4s -> 1319.5s (-27.4%)
  3. i686-gnu-2: 6340.6s -> 5251.6s (-17.2%)
  4. i686-gnu-1: 8461.7s -> 7041.6s (-16.8%)
  5. dist-x86_64-apple: 7985.9s -> 6723.0s (-15.8%)
  6. dist-aarch64-apple: 6568.6s -> 5563.0s (-15.3%)
  7. x86_64-gnu-gcc: 3512.3s -> 3065.2s (-12.7%)
  8. dist-aarch64-msvc: 6164.9s -> 5398.0s (-12.4%)
  9. x86_64-gnu-llvm-21-3: 6354.1s -> 5617.6s (-11.6%)
  10. x86_64-gnu-tools: 3761.6s -> 3375.5s (-10.3%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (9606412): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.9%[-1.4%, -0.5%]4
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-0.9%[-1.4%, -0.5%]4
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (secondary 0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		2.9%[2.9%, 2.9%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-5.7%[-5.7%, -5.7%]1
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 475.138s -> 473.265s (-0.39%)
Artifact size: 390.81 MiB -> 390.81 MiB (-0.00%)
@cjgillot
cjgillot
deleted the

liveness-cache-strings

branch
November 7, 2025 18:26
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@bors
Auto merge ofrust-lang#147641- cjgillot:liveness-cache-strings, r=e…
6eb4ca2
…stebank
Liveness: Cache the set of string constants for suggestions.
Even on a slow diagnostic path, listing all the constants in MIR can be expensive, so cache it.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@madsmtmmadsmtm

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

7 participants

@cjgillot@rust-timer@rustbot@estebank@bors@petrochenkov@madsmtm

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Liveness: Cache the set of string constants for suggestions. by cjgillot · Pull Request #147641 · rust-lang/rust · GitHub
Skip to content
Liveness: Cache the set of string constants for suggestions. - #147641
Merged
bors merged 1 commit into
rust-lang:masterfrom 
cjgillot:liveness-cache-strings
Nov 7, 2025
Merged
Liveness: Cache the set of string constants for suggestions.#147641
bors merged 1 commit into
rust-lang:masterfrom 
cjgillot:liveness-cache-strings
Conversation
@cjgillot
@cjgillotcjgillot
commented
Oct 13, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Even on a slow diagnostic path, listing all the constants in MIR can be expensive, so cache it.
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Oct 13, 2025
@cjgillot
cjgillot
commented
Oct 13, 2025

Copy link


Copy Markdown

ContributorAuthor
@bors try @rust-timer queue
@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
added a commit
that referenced
this pull request
Oct 13, 2025
@rust-bors
Auto merge of#147641- cjgillot:liveness-cache-strings, r=<try>
adc508b
Liveness: Cache the set of string constants for suggestions.
@rustbotrustbot
added
the 
S-waiting-on-perf
Status: Waiting on a perf run to be completed.
label
Oct 13, 2025
@rust-bors
rust-borsBot
commented
Oct 13, 2025

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: adc508b (adc508b9c46926c0f3e4b324eab0405c2ec2e126, parent: 9b8264604ef800b5539d04bf78ebdef5c5fa4968)
@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
rust-timer
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (adc508b): comparison URL.
Overall result: ✅ improvements - no action needed
Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.
@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.8%[-1.3%, -0.4%]4
Improvements ✅ 
 (secondary)		-0.1%[-0.1%, -0.1%]1
All ❌✅ (primary)-0.8%[-1.3%, -0.4%]4
Max RSS (memory usage)
Results (primary -2.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-2.9%[-2.9%, -2.9%]1
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-2.9%[-2.9%, -2.9%]1
Cycles
Results (secondary 0.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		4.3%[2.5%, 6.1%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.7%[-3.4%, -2.1%]2
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 474.96s -> 474.876s (-0.02%)
Artifact size: 388.14 MiB -> 388.11 MiB (-0.01%)
@rustbotrustbot
removed
the 
S-waiting-on-perf
Status: Waiting on a perf run to be completed.
label
Oct 13, 2025
@cjgillot
cjgillot
marked this pull request as ready for review
October 13, 2025 19:32
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 13, 2025
@rustbot
rustbot
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
Some changes occurred to MIR optimizations
cc @rust-lang/wg-mir-opt
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Oct 13, 2025
@rustbot
rustbot
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
r? @petrochenkov
rustbot has assigned @petrochenkov.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@cjgillot
cjgillot
commented
Oct 13, 2025

Copy link


Copy Markdown

ContributorAuthor
r? estebank
@rustbotrustbot
assigned estebank and unassigned petrochenkovOct 13, 2025
@cjgillot
cjgillotforce-pushed
the
liveness-cache-strings
branch
from
1e1f299 to
727da8cCompareOctober 26, 2025 17:40
@rustbot
rustbot
commented
Oct 26, 2025

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@cjgillot
cjgillot
commented
Nov 6, 2025

Copy link


Copy Markdown

ContributorAuthor
r? compiler
@rustbotrustbot
assigned madsmtm and unassigned estebankNov 6, 2025
@estebank
estebank
commented
Nov 6, 2025

Copy link


Copy Markdown

Contributor
@bors r+
@bors
bors
commented
Nov 6, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 727da8c has been approved by estebank
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 6, 2025
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 727da8c with merge 9606412...
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: estebank

Pushing 9606412 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 7, 2025
@bors
bors
merged commit 9606412
into
rust-lang:masterNov 7, 2025

12 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 7, 2025
@github-actions
github-actionsBot
commented
Nov 7, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0bbef55 (parent) -> 9606412 (this PR)
Test differences
Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 96064126a086a8428d66e07fb3b91421bb86a512 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. tidy: 296.8s -> 173.3s (-41.6%)
  2. pr-check-1: 1817.4s -> 1319.5s (-27.4%)
  3. i686-gnu-2: 6340.6s -> 5251.6s (-17.2%)
  4. i686-gnu-1: 8461.7s -> 7041.6s (-16.8%)
  5. dist-x86_64-apple: 7985.9s -> 6723.0s (-15.8%)
  6. dist-aarch64-apple: 6568.6s -> 5563.0s (-15.3%)
  7. x86_64-gnu-gcc: 3512.3s -> 3065.2s (-12.7%)
  8. dist-aarch64-msvc: 6164.9s -> 5398.0s (-12.4%)
  9. x86_64-gnu-llvm-21-3: 6354.1s -> 5617.6s (-11.6%)
  10. x86_64-gnu-tools: 3761.6s -> 3375.5s (-10.3%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (9606412): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.9%[-1.4%, -0.5%]4
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-0.9%[-1.4%, -0.5%]4
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (secondary 0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		2.9%[2.9%, 2.9%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-5.7%[-5.7%, -5.7%]1
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 475.138s -> 473.265s (-0.39%)
Artifact size: 390.81 MiB -> 390.81 MiB (-0.00%)
@cjgillot
cjgillot
deleted the

liveness-cache-strings

branch
November 7, 2025 18:26
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@bors
Auto merge ofrust-lang#147641- cjgillot:liveness-cache-strings, r=e…
6eb4ca2
…stebank
Liveness: Cache the set of string constants for suggestions.
Even on a slow diagnostic path, listing all the constants in MIR can be expensive, so cache it.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@madsmtmmadsmtm

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

7 participants

@cjgillot@rust-timer@rustbot@estebank@bors@petrochenkov@madsmtm

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Liveness: Cache the set of string constants for suggestions. by cjgillot · Pull Request #147641 · rust-lang/rust · GitHub
Skip to content
Liveness: Cache the set of string constants for suggestions. - #147641
Merged
bors merged 1 commit into
rust-lang:masterfrom 
cjgillot:liveness-cache-strings
Nov 7, 2025
Merged
Liveness: Cache the set of string constants for suggestions.#147641
bors merged 1 commit into
rust-lang:masterfrom 
cjgillot:liveness-cache-strings
Conversation
@cjgillot
@cjgillotcjgillot
commented
Oct 13, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Even on a slow diagnostic path, listing all the constants in MIR can be expensive, so cache it.
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Oct 13, 2025
@cjgillot
cjgillot
commented
Oct 13, 2025

Copy link


Copy Markdown

ContributorAuthor
@bors try @rust-timer queue
@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
added a commit
that referenced
this pull request
Oct 13, 2025
@rust-bors
Auto merge of#147641- cjgillot:liveness-cache-strings, r=<try>
adc508b
Liveness: Cache the set of string constants for suggestions.
@rustbotrustbot
added
the 
S-waiting-on-perf
Status: Waiting on a perf run to be completed.
label
Oct 13, 2025
@rust-bors
rust-borsBot
commented
Oct 13, 2025

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: adc508b (adc508b9c46926c0f3e4b324eab0405c2ec2e126, parent: 9b8264604ef800b5539d04bf78ebdef5c5fa4968)
@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
rust-timer
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (adc508b): comparison URL.
Overall result: ✅ improvements - no action needed
Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.
@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.8%[-1.3%, -0.4%]4
Improvements ✅ 
 (secondary)		-0.1%[-0.1%, -0.1%]1
All ❌✅ (primary)-0.8%[-1.3%, -0.4%]4
Max RSS (memory usage)
Results (primary -2.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-2.9%[-2.9%, -2.9%]1
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-2.9%[-2.9%, -2.9%]1
Cycles
Results (secondary 0.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		4.3%[2.5%, 6.1%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.7%[-3.4%, -2.1%]2
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 474.96s -> 474.876s (-0.02%)
Artifact size: 388.14 MiB -> 388.11 MiB (-0.01%)
@rustbotrustbot
removed
the 
S-waiting-on-perf
Status: Waiting on a perf run to be completed.
label
Oct 13, 2025
@cjgillot
cjgillot
marked this pull request as ready for review
October 13, 2025 19:32
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 13, 2025
@rustbot
rustbot
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
Some changes occurred to MIR optimizations
cc @rust-lang/wg-mir-opt
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Oct 13, 2025
@rustbot
rustbot
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
r? @petrochenkov
rustbot has assigned @petrochenkov.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@cjgillot
cjgillot
commented
Oct 13, 2025

Copy link


Copy Markdown

ContributorAuthor
r? estebank
@rustbotrustbot
assigned estebank and unassigned petrochenkovOct 13, 2025
@cjgillot
cjgillotforce-pushed
the
liveness-cache-strings
branch
from
1e1f299 to
727da8cCompareOctober 26, 2025 17:40
@rustbot
rustbot
commented
Oct 26, 2025

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@cjgillot
cjgillot
commented
Nov 6, 2025

Copy link


Copy Markdown

ContributorAuthor
r? compiler
@rustbotrustbot
assigned madsmtm and unassigned estebankNov 6, 2025
@estebank
estebank
commented
Nov 6, 2025

Copy link


Copy Markdown

Contributor
@bors r+
@bors
bors
commented
Nov 6, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 727da8c has been approved by estebank
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 6, 2025
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 727da8c with merge 9606412...
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: estebank

Pushing 9606412 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 7, 2025
@bors
bors
merged commit 9606412
into
rust-lang:masterNov 7, 2025

12 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 7, 2025
@github-actions
github-actionsBot
commented
Nov 7, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0bbef55 (parent) -> 9606412 (this PR)
Test differences
Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 96064126a086a8428d66e07fb3b91421bb86a512 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. tidy: 296.8s -> 173.3s (-41.6%)
  2. pr-check-1: 1817.4s -> 1319.5s (-27.4%)
  3. i686-gnu-2: 6340.6s -> 5251.6s (-17.2%)
  4. i686-gnu-1: 8461.7s -> 7041.6s (-16.8%)
  5. dist-x86_64-apple: 7985.9s -> 6723.0s (-15.8%)
  6. dist-aarch64-apple: 6568.6s -> 5563.0s (-15.3%)
  7. x86_64-gnu-gcc: 3512.3s -> 3065.2s (-12.7%)
  8. dist-aarch64-msvc: 6164.9s -> 5398.0s (-12.4%)
  9. x86_64-gnu-llvm-21-3: 6354.1s -> 5617.6s (-11.6%)
  10. x86_64-gnu-tools: 3761.6s -> 3375.5s (-10.3%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (9606412): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.9%[-1.4%, -0.5%]4
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-0.9%[-1.4%, -0.5%]4
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (secondary 0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		2.9%[2.9%, 2.9%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-5.7%[-5.7%, -5.7%]1
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 475.138s -> 473.265s (-0.39%)
Artifact size: 390.81 MiB -> 390.81 MiB (-0.00%)
@cjgillot
cjgillot
deleted the

liveness-cache-strings

branch
November 7, 2025 18:26
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@bors
Auto merge ofrust-lang#147641- cjgillot:liveness-cache-strings, r=e…
6eb4ca2
…stebank
Liveness: Cache the set of string constants for suggestions.
Even on a slow diagnostic path, listing all the constants in MIR can be expensive, so cache it.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@madsmtmmadsmtm

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

7 participants

@cjgillot@rust-timer@rustbot@estebank@bors@petrochenkov@madsmtm

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Liveness: Cache the set of string constants for suggestions. by cjgillot · Pull Request #147641 · rust-lang/rust · GitHub
Skip to content
Liveness: Cache the set of string constants for suggestions. - #147641
Merged
bors merged 1 commit into
rust-lang:masterfrom 
cjgillot:liveness-cache-strings
Nov 7, 2025
Merged
Liveness: Cache the set of string constants for suggestions.#147641
bors merged 1 commit into
rust-lang:masterfrom 
cjgillot:liveness-cache-strings
Conversation
@cjgillot
@cjgillotcjgillot
commented
Oct 13, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Even on a slow diagnostic path, listing all the constants in MIR can be expensive, so cache it.
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Oct 13, 2025
@cjgillot
cjgillot
commented
Oct 13, 2025

Copy link


Copy Markdown

ContributorAuthor
@bors try @rust-timer queue
@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
added a commit
that referenced
this pull request
Oct 13, 2025
@rust-bors
Auto merge of#147641- cjgillot:liveness-cache-strings, r=<try>
adc508b
Liveness: Cache the set of string constants for suggestions.
@rustbotrustbot
added
the 
S-waiting-on-perf
Status: Waiting on a perf run to be completed.
label
Oct 13, 2025
@rust-bors
rust-borsBot
commented
Oct 13, 2025

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: adc508b (adc508b9c46926c0f3e4b324eab0405c2ec2e126, parent: 9b8264604ef800b5539d04bf78ebdef5c5fa4968)
@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
rust-timer
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (adc508b): comparison URL.
Overall result: ✅ improvements - no action needed
Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.
@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.8%[-1.3%, -0.4%]4
Improvements ✅ 
 (secondary)		-0.1%[-0.1%, -0.1%]1
All ❌✅ (primary)-0.8%[-1.3%, -0.4%]4
Max RSS (memory usage)
Results (primary -2.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-2.9%[-2.9%, -2.9%]1
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-2.9%[-2.9%, -2.9%]1
Cycles
Results (secondary 0.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		4.3%[2.5%, 6.1%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.7%[-3.4%, -2.1%]2
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 474.96s -> 474.876s (-0.02%)
Artifact size: 388.14 MiB -> 388.11 MiB (-0.01%)
@rustbotrustbot
removed
the 
S-waiting-on-perf
Status: Waiting on a perf run to be completed.
label
Oct 13, 2025
@cjgillot
cjgillot
marked this pull request as ready for review
October 13, 2025 19:32
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 13, 2025
@rustbot
rustbot
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
Some changes occurred to MIR optimizations
cc @rust-lang/wg-mir-opt
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Oct 13, 2025
@rustbot
rustbot
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
r? @petrochenkov
rustbot has assigned @petrochenkov.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@cjgillot
cjgillot
commented
Oct 13, 2025

Copy link


Copy Markdown

ContributorAuthor
r? estebank
@rustbotrustbot
assigned estebank and unassigned petrochenkovOct 13, 2025
@cjgillot
cjgillotforce-pushed
the
liveness-cache-strings
branch
from
1e1f299 to
727da8cCompareOctober 26, 2025 17:40
@rustbot
rustbot
commented
Oct 26, 2025

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@cjgillot
cjgillot
commented
Nov 6, 2025

Copy link


Copy Markdown

ContributorAuthor
r? compiler
@rustbotrustbot
assigned madsmtm and unassigned estebankNov 6, 2025
@estebank
estebank
commented
Nov 6, 2025

Copy link


Copy Markdown

Contributor
@bors r+
@bors
bors
commented
Nov 6, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 727da8c has been approved by estebank
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 6, 2025
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 727da8c with merge 9606412...
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: estebank

Pushing 9606412 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 7, 2025
@bors
bors
merged commit 9606412
into
rust-lang:masterNov 7, 2025

12 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 7, 2025
@github-actions
github-actionsBot
commented
Nov 7, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0bbef55 (parent) -> 9606412 (this PR)
Test differences
Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 96064126a086a8428d66e07fb3b91421bb86a512 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. tidy: 296.8s -> 173.3s (-41.6%)
  2. pr-check-1: 1817.4s -> 1319.5s (-27.4%)
  3. i686-gnu-2: 6340.6s -> 5251.6s (-17.2%)
  4. i686-gnu-1: 8461.7s -> 7041.6s (-16.8%)
  5. dist-x86_64-apple: 7985.9s -> 6723.0s (-15.8%)
  6. dist-aarch64-apple: 6568.6s -> 5563.0s (-15.3%)
  7. x86_64-gnu-gcc: 3512.3s -> 3065.2s (-12.7%)
  8. dist-aarch64-msvc: 6164.9s -> 5398.0s (-12.4%)
  9. x86_64-gnu-llvm-21-3: 6354.1s -> 5617.6s (-11.6%)
  10. x86_64-gnu-tools: 3761.6s -> 3375.5s (-10.3%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (9606412): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.9%[-1.4%, -0.5%]4
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-0.9%[-1.4%, -0.5%]4
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (secondary 0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		2.9%[2.9%, 2.9%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-5.7%[-5.7%, -5.7%]1
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 475.138s -> 473.265s (-0.39%)
Artifact size: 390.81 MiB -> 390.81 MiB (-0.00%)
@cjgillot
cjgillot
deleted the

liveness-cache-strings

branch
November 7, 2025 18:26
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@bors
Auto merge ofrust-lang#147641- cjgillot:liveness-cache-strings, r=e…
6eb4ca2
…stebank
Liveness: Cache the set of string constants for suggestions.
Even on a slow diagnostic path, listing all the constants in MIR can be expensive, so cache it.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@madsmtmmadsmtm

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

7 participants

@cjgillot@rust-timer@rustbot@estebank@bors@petrochenkov@madsmtm

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Liveness: Cache the set of string constants for suggestions. by cjgillot · Pull Request #147641 · rust-lang/rust · GitHub
Skip to content
Liveness: Cache the set of string constants for suggestions. - #147641
Merged
bors merged 1 commit into
rust-lang:masterfrom 
cjgillot:liveness-cache-strings
Nov 7, 2025
Merged
Liveness: Cache the set of string constants for suggestions.#147641
bors merged 1 commit into
rust-lang:masterfrom 
cjgillot:liveness-cache-strings
Conversation
@cjgillot
@cjgillotcjgillot
commented
Oct 13, 2025•

edited

Loading

Copy link


Copy Markdown

Contributor
Even on a slow diagnostic path, listing all the constants in MIR can be expensive, so cache it.
@rustbotrustbot
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Oct 13, 2025
@cjgillot
cjgillot
commented
Oct 13, 2025

Copy link


Copy Markdown

ContributorAuthor
@bors try @rust-timer queue
@rust-timer

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
added a commit
that referenced
this pull request
Oct 13, 2025
@rust-bors
Auto merge of#147641- cjgillot:liveness-cache-strings, r=<try>
adc508b
Liveness: Cache the set of string constants for suggestions.
@rustbotrustbot
added
the 
S-waiting-on-perf
Status: Waiting on a perf run to be completed.
label
Oct 13, 2025
@rust-bors
rust-borsBot
commented
Oct 13, 2025

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: adc508b (adc508b9c46926c0f3e4b324eab0405c2ec2e126, parent: 9b8264604ef800b5539d04bf78ebdef5c5fa4968)
@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
rust-timer
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (adc508b): comparison URL.
Overall result: ✅ improvements - no action needed
Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.
@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.8%[-1.3%, -0.4%]4
Improvements ✅ 
 (secondary)		-0.1%[-0.1%, -0.1%]1
All ❌✅ (primary)-0.8%[-1.3%, -0.4%]4
Max RSS (memory usage)
Results (primary -2.9%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-2.9%[-2.9%, -2.9%]1
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-2.9%[-2.9%, -2.9%]1
Cycles
Results (secondary 0.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		4.3%[2.5%, 6.1%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-2.7%[-3.4%, -2.1%]2
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 474.96s -> 474.876s (-0.02%)
Artifact size: 388.14 MiB -> 388.11 MiB (-0.01%)
@rustbotrustbot
removed
the 
S-waiting-on-perf
Status: Waiting on a perf run to be completed.
label
Oct 13, 2025
@cjgillot
cjgillot
marked this pull request as ready for review
October 13, 2025 19:32
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 13, 2025
@rustbot
rustbot
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
Some changes occurred to MIR optimizations
cc @rust-lang/wg-mir-opt
@rustbotrustbot
removed
the 
S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
label
Oct 13, 2025
@rustbot
rustbot
commented
Oct 13, 2025

Copy link


Copy Markdown

Collaborator
r? @petrochenkov
rustbot has assigned @petrochenkov.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@cjgillot
cjgillot
commented
Oct 13, 2025

Copy link


Copy Markdown

ContributorAuthor
r? estebank
@rustbotrustbot
assigned estebank and unassigned petrochenkovOct 13, 2025
@cjgillot
cjgillotforce-pushed
the
liveness-cache-strings
branch
from
1e1f299 to
727da8cCompareOctober 26, 2025 17:40
@rustbot
rustbot
commented
Oct 26, 2025

Copy link


Copy Markdown

Collaborator
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.
Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@cjgillot
cjgillot
commented
Nov 6, 2025

Copy link


Copy Markdown

ContributorAuthor
r? compiler
@rustbotrustbot
assigned madsmtm and unassigned estebankNov 6, 2025
@estebank
estebank
commented
Nov 6, 2025

Copy link


Copy Markdown

Contributor
@bors r+
@bors
bors
commented
Nov 6, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 727da8c has been approved by estebank
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 6, 2025
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 727da8c with merge 9606412...
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: estebank

Pushing 9606412 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 7, 2025
@bors
bors
merged commit 9606412
into
rust-lang:masterNov 7, 2025

12 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 7, 2025
@github-actions
github-actionsBot
commented
Nov 7, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 0bbef55 (parent) -> 9606412 (this PR)
Test differences
Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 96064126a086a8428d66e07fb3b91421bb86a512 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. tidy: 296.8s -> 173.3s (-41.6%)
  2. pr-check-1: 1817.4s -> 1319.5s (-27.4%)
  3. i686-gnu-2: 6340.6s -> 5251.6s (-17.2%)
  4. i686-gnu-1: 8461.7s -> 7041.6s (-16.8%)
  5. dist-x86_64-apple: 7985.9s -> 6723.0s (-15.8%)
  6. dist-aarch64-apple: 6568.6s -> 5563.0s (-15.3%)
  7. x86_64-gnu-gcc: 3512.3s -> 3065.2s (-12.7%)
  8. dist-aarch64-msvc: 6164.9s -> 5398.0s (-12.4%)
  9. x86_64-gnu-llvm-21-3: 6354.1s -> 5617.6s (-11.6%)
  10. x86_64-gnu-tools: 3761.6s -> 3375.5s (-10.3%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (9606412): comparison URL.
Overall result: ✅ improvements - no action needed
@rustbot label: -perf-regression
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		-0.9%[-1.4%, -0.5%]4
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)-0.9%[-1.4%, -0.5%]4
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (secondary 0.0%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		2.9%[2.9%, 2.9%]2
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		-5.7%[-5.7%, -5.7%]1
All ❌✅ (primary)--0
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 475.138s -> 473.265s (-0.39%)
Artifact size: 390.81 MiB -> 390.81 MiB (-0.00%)
@cjgillot
cjgillot
deleted the

liveness-cache-strings

branch
November 7, 2025 18:26
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Nov 10, 2025
@bors
Auto merge ofrust-lang#147641- cjgillot:liveness-cache-strings, r=e…
6eb4ca2
…stebank
Liveness: Cache the set of string constants for suggestions.
Even on a slow diagnostic path, listing all the constants in MIR can be expensive, so cache it.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees

@madsmtmmadsmtm

Labels

merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

7 participants

@cjgillot@rust-timer@rustbot@estebank@bors@petrochenkov@madsmtm