Skip to content

Miscellaneous const-generics-related fixes - #147642

Merged
bors merged 3 commits into
rust-lang:masterfrom
camelid:misc-const-fixes
Nov 2, 2025
Merged

Miscellaneous const-generics-related fixes#147642
bors merged 3 commits into
rust-lang:masterfrom
camelid:misc-const-fixes

Conversation

@camelid

@camelidcamelid commented Oct 13, 2025•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Fixes#129209.
Fixes#131295.
Fixes#139738.

@camelid
Remove parent def lookup hack that is no longer needed
124bfc9
The tcx.parent tree appears to be correct now.
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 13, 2025
@rustbot

rustbot commented Oct 13, 2025

Copy link
Copy Markdown
Collaborator

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@lcnr

lcnr commented Oct 14, 2025

Copy link
Copy Markdown
Contributor

r? @BoxyUwU lgtm, but not totally sure about the first change and don't want to look into this

@rustbotrustbot assigned BoxyUwU and unassigned lcnrOct 14, 2025
@camelid
Fix lowering of CStr constants to valtrees
379a057
They need an extra branch for the newtype.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@BoxyUwU

BoxyUwU commented Oct 21, 2025

Copy link
Copy Markdown
Member

lgtm, need to move the crashes tests over to normal test suite

@rustbot author

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2025
@BoxyUwUBoxyUwU changed the title Miscellaneous const-related fixesMiscellaneous const-generics-related fixesOct 21, 2025
@rustbot

rustbot commented Nov 1, 2025

Copy link
Copy Markdown
Collaborator

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@camelidcamelid added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 1, 2025
@camelid

camelid commented Nov 1, 2025

Copy link
Copy Markdown
MemberAuthor

@bors r=BoxyUwU rollup

@bors

bors commented Nov 1, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit f39fb70 has been approved by BoxyUwU

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 2, 2025
@jhpratt
Rollup merge ofrust-lang#147642- camelid:misc-const-fixes, r=BoxyUwU
056f32c
Miscellaneous const-generics-related fixes
Fixesrust-lang#129209.
Fixesrust-lang#131295.
Fixesrust-lang#139738.
@jhprattjhpratt mentioned this pull request Nov 2, 2025
Closed
bors added a commit that referenced this pull request Nov 2, 2025
@bors
Auto merge of#148376- jhpratt:rollup-tfn2bbb, r=jhpratt
45259b5
Rollup of 12 pull requests
Successful merges:
- #147137 (Mention crate being analyzed in query description)
- #147642 (Miscellaneous const-generics-related fixes)
- #147806 (Ignore test-dashboard related files)
- #147947 (Implement `strip_circumfix` lib feature)
- #148194 (compiletest: Remove `cleanup_debug_info_options`)
- #148199 (compiletest: Don't modify `testpaths` when creating aux contexts)
- #148247 (Remove two special cases from reachable_non_generics)
- #148348 (dangling ptr lint cleanup)
- #148357 (temporary-lifetime-extension.rs test works in all editions)
- #148362 (docs: makes a note about possible building `rustc 1.91.0 + host tools` for win7)
- #148367 (Use --print host-tuple to get the host)
- #148374 (miri subtree update)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 2, 2025
@Zalathar
Rollup merge ofrust-lang#147642- camelid:misc-const-fixes, r=BoxyUwU
1d64a4b
Miscellaneous const-generics-related fixes
Fixesrust-lang#129209.
Fixesrust-lang#131295.
Fixesrust-lang#139738.
@ZalatharZalathar mentioned this pull request Nov 2, 2025
Closed
@Zalathar

Zalathar commented Nov 2, 2025

Copy link
Copy Markdown
Member

Investigating rollup failure in #148376 (comment):

@bors try jobs=armhf-gnu

@rust-bors

rust-borsBot commented Nov 2, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

⌛ Trying commit f39fb70 with merge f7fb7a9…

To cancel the try build, run the command @bors try cancel.

Workflow: https://github.com/rust-lang/rust/actions/runs/19008794305

rust-borsBot added a commit that referenced this pull request Nov 2, 2025
@rust-bors
Auto merge of#147642- camelid:misc-const-fixes, r=<try>
f7fb7a9
Miscellaneous const-generics-related fixes
try-job: armhf-gnu
@Zalathar

Zalathar commented Nov 2, 2025

Copy link
Copy Markdown
Member

Failure found at #148247 (comment).

@bors try cancel

@rust-bors

rust-borsBot commented Nov 2, 2025

Copy link
Copy Markdown
Contributor

Try build cancelled. Cancelled workflows:

@matthiaskrgrmatthiaskrgr mentioned this pull request Nov 2, 2025
Merged
bors added a commit that referenced this pull request Nov 2, 2025
@bors
Auto merge of#148404- matthiaskrgr:rollup-o61qhjw, r=matthiaskrgr
8483293
Rollup of 9 pull requests
Successful merges:
- #147137 (Mention crate being analyzed in query description)
- #147155 (arm-linux.md: various fixes/improvements)
- #147642 (Miscellaneous const-generics-related fixes)
- #147806 (Ignore test-dashboard related files)
- #147947 (Implement `strip_circumfix` lib feature)
- #148346 (Change cfg_trace, cfg_attr_trace symbol values)
- #148348 (dangling ptr lint cleanup)
- #148393 (Remove `tests/run-make/fmt-write-bloat/`)
- #148400 (Better warning message for crate type unsupported by codegen backend)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit ec576bb into rust-lang:masterNov 2, 2025
11 of 12 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 2, 2025
rust-timer added a commit that referenced this pull request Nov 2, 2025
@rust-timer
Unrolled build for#147642
0bf4278
Rollup merge of #147642 - camelid:misc-const-fixes, r=BoxyUwU
Miscellaneous const-generics-related fixes
Fixes#129209.
Fixes#131295.
Fixes#139738.
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Nov 3, 2025
@bors
Auto merge of #148404 - matthiaskrgr:rollup-o61qhjw, r=matthiaskrgr
cd53100
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#147137 (Mention crate being analyzed in query description)
- rust-lang/rust#147155 (arm-linux.md: various fixes/improvements)
- rust-lang/rust#147642 (Miscellaneous const-generics-related fixes)
- rust-lang/rust#147806 (Ignore test-dashboard related files)
- rust-lang/rust#147947 (Implement `strip_circumfix` lib feature)
- rust-lang/rust#148346 (Change cfg_trace, cfg_attr_trace symbol values)
- rust-lang/rust#148348 (dangling ptr lint cleanup)
- rust-lang/rust#148393 (Remove `tests/run-make/fmt-write-bloat/`)
- rust-lang/rust#148400 (Better warning message for crate type unsupported by codegen backend)
r? `@ghost`
`@rustbot` modify labels: rollup
@camelid
camelid deleted the misc-const-fixes branch November 3, 2025 23:29
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@bors
Auto merge ofrust-lang#148404- matthiaskrgr:rollup-o61qhjw, r=matth…
daced61
…iaskrgr
Rollup of 9 pull requests
Successful merges:
- rust-lang#147137 (Mention crate being analyzed in query description)
- rust-lang#147155 (arm-linux.md: various fixes/improvements)
- rust-lang#147642 (Miscellaneous const-generics-related fixes)
- rust-lang#147806 (Ignore test-dashboard related files)
- rust-lang#147947 (Implement `strip_circumfix` lib feature)
- rust-lang#148346 (Change cfg_trace, cfg_attr_trace symbol values)
- rust-lang#148348 (dangling ptr lint cleanup)
- rust-lang#148393 (Remove `tests/run-make/fmt-write-bloat/`)
- rust-lang#148400 (Better warning message for crate type unsupported by codegen backend)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BoxyUwUBoxyUwU

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

ICE: cannot convert to a region vid ICE: cannot convert "'a/#4" to a region vid ICE: None in compiler/rustc_middle/src/ty/sty.rs

7 participants

@camelid@rustbot@rust-log-analyzer@lcnr@BoxyUwU@bors@Zalathar