Skip to content

const mem::drop - #147708

Merged
bors merged 1 commit into
rust-lang:masterfrom
clarfonthey:const-drop
Oct 16, 2025
Merged

const mem::drop#147708
bors merged 1 commit into
rust-lang:masterfrom
clarfonthey:const-drop

Conversation

@clarfonthey

@clarfontheyclarfonthey commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

I'm putting this under the const Destruct feature flag since it doesn't really feel relevant to put it elsewhere… it's just an empty function body, so, it doesn't have any particular weirdness attached to it (unlike drop_in_place, for example).

r? wg-const-eval

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 15, 2025
@clarfontheyclarfonthey mentioned this pull request Oct 15, 2025
Merged
@clarfonthey

clarfonthey commented Oct 15, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

As expected, failures due to differences in a few UI tests. Will go through and fix everything and then get back, although as usual, running tests will take forever.

EDIT: Actually, in this case, it's a soundness check in the new solver getting extra, unexpected errors due to an additional trait bound (Destruct). Even though you might argue that this error probably shouldn't be there alongside the others, rather than having to deal with it, I just changed the function to identity and left a comment why. It doesn't feel particularly relevant, but it also seems hard to fix.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rustbotrustbot added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Oct 15, 2025
@RalfJung

RalfJung commented Oct 15, 2025

Copy link
Copy Markdown
Member

Please, I'm not part of const-traitificiation for lack of time so this isn't a great review group to use for PRs like this.
r? @fee1-dead

@rustbotrustbot assigned fee1-dead and unassigned RalfJungOct 15, 2025
@rustbot

rustbot commented Oct 15, 2025

Copy link
Copy Markdown
Collaborator

fee1-dead is currently at their maximum review capacity.
They may take a while to respond.

@oli-obk

oli-obk commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

r? @oli-obk

@bors r+ rollup

@bors

bors commented Oct 15, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 491bc50 has been approved by oli-obk

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2025
@matthiaskrgrmatthiaskrgr mentioned this pull request Oct 15, 2025
Merged
bors added a commit that referenced this pull request Oct 15, 2025
@bors
Auto merge of#147745- matthiaskrgr:rollup-b4kftk9, r=matthiaskrgr
402ce0e
Rollup of 11 pull requests
Successful merges:
- #143191 (Stabilize `rwlock_downgrade` library feature)
- #147444 (Allow printing a fully-qualified path in `def_path_str`)
- #147527 (Update t-compiler beta nomination Zulip msg)
- #147670 (some `ErrorGuaranteed` cleanups)
- #147676 (Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes)
- #147708 (const `mem::drop`)
- #147710 (Fix ICE when using contracts on async functions)
- #147716 (Fix some comments)
- #147718 (miri: use allocator_shim_contents codegen helper)
- #147729 (ignore boring locals when explaining why a borrow contains a point due to drop of a live local under polonius)
- #147742 (Revert unintentional whitespace changes to rustfmt-excluded file)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 9bd8aa5 into rust-lang:masterOct 16, 2025
11 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 16, 2025
rust-timer added a commit that referenced this pull request Oct 16, 2025
@rust-timer
Unrolled build for#147708
3a31f72
Rollup merge of #147708 - clarfonthey:const-drop, r=oli-obk
const `mem::drop`
I'm putting this under the `const Destruct` feature flag since it doesn't really feel relevant to put it elsewhere… it's just an empty function body, so, it doesn't have any particular weirdness attached to it (unlike `drop_in_place`, for example).
r? wg-const-eval
@clarfontheyclarfonthey mentioned this pull request Oct 16, 2025
Open
3 tasks
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Oct 16, 2025
@bors
Auto merge of #147745 - matthiaskrgr:rollup-b4kftk9, r=matthiaskrgr
33df85e
Rollup of 11 pull requests
Successful merges:
- rust-lang/rust#143191 (Stabilize `rwlock_downgrade` library feature)
- rust-lang/rust#147444 (Allow printing a fully-qualified path in `def_path_str`)
- rust-lang/rust#147527 (Update t-compiler beta nomination Zulip msg)
- rust-lang/rust#147670 (some `ErrorGuaranteed` cleanups)
- rust-lang/rust#147676 (Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes)
- rust-lang/rust#147708 (const `mem::drop`)
- rust-lang/rust#147710 (Fix ICE when using contracts on async functions)
- rust-lang/rust#147716 (Fix some comments)
- rust-lang/rust#147718 (miri: use allocator_shim_contents codegen helper)
- rust-lang/rust#147729 (ignore boring locals when explaining why a borrow contains a point due to drop of a live local under polonius)
- rust-lang/rust#147742 (Revert unintentional whitespace changes to rustfmt-excluded file)
r? `@ghost`
`@rustbot` modify labels: rollup
@clarfonthey
clarfonthey deleted the const-drop branch October 16, 2025 05:33
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Oct 18, 2025
@bors
Auto merge of #147745 - matthiaskrgr:rollup-b4kftk9, r=matthiaskrgr
f706461
Rollup of 11 pull requests
Successful merges:
- rust-lang/rust#143191 (Stabilize `rwlock_downgrade` library feature)
- rust-lang/rust#147444 (Allow printing a fully-qualified path in `def_path_str`)
- rust-lang/rust#147527 (Update t-compiler beta nomination Zulip msg)
- rust-lang/rust#147670 (some `ErrorGuaranteed` cleanups)
- rust-lang/rust#147676 (Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes)
- rust-lang/rust#147708 (const `mem::drop`)
- rust-lang/rust#147710 (Fix ICE when using contracts on async functions)
- rust-lang/rust#147716 (Fix some comments)
- rust-lang/rust#147718 (miri: use allocator_shim_contents codegen helper)
- rust-lang/rust#147729 (ignore boring locals when explaining why a borrow contains a point due to drop of a live local under polonius)
- rust-lang/rust#147742 (Revert unintentional whitespace changes to rustfmt-excluded file)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@matthiaskrgr
Rollup merge ofrust-lang#147708- clarfonthey:const-drop, r=oli-obk
d0d66ed
const `mem::drop`
I'm putting this under the `const Destruct` feature flag since it doesn't really feel relevant to put it elsewhere… it's just an empty function body, so, it doesn't have any particular weirdness attached to it (unlike `drop_in_place`, for example).
r? wg-const-eval
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@bors
Auto merge ofrust-lang#147745- matthiaskrgr:rollup-b4kftk9, r=matth…
d68e6ed
…iaskrgr
Rollup of 11 pull requests
Successful merges:
- rust-lang#143191 (Stabilize `rwlock_downgrade` library feature)
- rust-lang#147444 (Allow printing a fully-qualified path in `def_path_str`)
- rust-lang#147527 (Update t-compiler beta nomination Zulip msg)
- rust-lang#147670 (some `ErrorGuaranteed` cleanups)
- rust-lang#147676 (Return spans out of `is_doc_comment` to reduce reliance on `.span()` on attributes)
- rust-lang#147708 (const `mem::drop`)
- rust-lang#147710 (Fix ICE when using contracts on async functions)
- rust-lang#147716 (Fix some comments)
- rust-lang#147718 (miri: use allocator_shim_contents codegen helper)
- rust-lang#147729 (ignore boring locals when explaining why a borrow contains a point due to drop of a live local under polonius)
- rust-lang#147742 (Revert unintentional whitespace changes to rustfmt-excluded file)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obkoli-obk

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.WG-trait-system-refactorThe Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

7 participants

@clarfonthey@rust-log-analyzer@RalfJung@rustbot@oli-obk@bors@fee1-dead