Skip to content

os_str: Make platform docs more consistent - #147933

Merged
bors merged 1 commit into
rust-lang:masterfrom
thaliaarchi:consistent-osstring
Oct 22, 2025
Merged

os_str: Make platform docs more consistent#147933
bors merged 1 commit into
rust-lang:masterfrom
thaliaarchi:consistent-osstring

Conversation

@thaliaarchi

@thaliaarchithaliaarchi commented Oct 21, 2025

Copy link
Copy Markdown
Contributor
  • Port Buf::as_slice/as_mut_slice wording from wtf8 to bytes
  • Make Buf::extend_from_slice_unchecked docs more platform-independent
  • wtf8 Buf was missing #[repr(transparent)]

@thaliaarchi
os_str: Make platform docs more consistent
563302e
- Port `Buf::as_slice`/`as_mut_slice` wording from wtf8 to bytes
- Make `Buf::extend_from_slice_unchecked` docs more platform-independent
- wtf8 `Buf` was missing `#[repr(transparent)]`
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 21, 2025
@rustbot

rustbot commented Oct 21, 2025

Copy link
Copy Markdown
Collaborator

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35

tgross35 commented Oct 21, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Oct 21, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 563302e has been approved by tgross35

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2025
@matthiaskrgrmatthiaskrgr mentioned this pull request Oct 22, 2025
Merged
bors added a commit that referenced this pull request Oct 22, 2025
@bors
Auto merge of#147957- matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
b2ee1b3
Rollup of 7 pull requests
Successful merges:
- #141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
- #142339 (Add NonNull pattern types)
- #147768 (Code refactoring on hir report_no_match_method_error)
- #147788 (const Cell methods)
- #147932 (Create UTF-8 version of `OsStr`/`OsString`)
- #147933 (os_str: Make platform docs more consistent)
- #147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 4a11759 into rust-lang:masterOct 22, 2025
11 checks passed
@rustbotrustbot added this to the 1.92.0 milestone Oct 22, 2025
@thaliaarchi
thaliaarchi deleted the consistent-osstring branch October 22, 2025 20:38
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Oct 23, 2025
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
698b2f9
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
- rust-lang/rust#142339 (Add NonNull pattern types)
- rust-lang/rust#147768 (Code refactoring on hir report_no_match_method_error)
- rust-lang/rust#147788 (const Cell methods)
- rust-lang/rust#147932 (Create UTF-8 version of `OsStr`/`OsString`)
- rust-lang/rust#147933 (os_str: Make platform docs more consistent)
- rust-lang/rust#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)
r? `@ghost`
`@rustbot` modify labels: rollup
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Oct 27, 2025
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
51930ee
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
- rust-lang/rust#142339 (Add NonNull pattern types)
- rust-lang/rust#147768 (Code refactoring on hir report_no_match_method_error)
- rust-lang/rust#147788 (const Cell methods)
- rust-lang/rust#147932 (Create UTF-8 version of `OsStr`/`OsString`)
- rust-lang/rust#147933 (os_str: Make platform docs more consistent)
- rust-lang/rust#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Nov 4, 2025
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
80008e8
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
- rust-lang/rust#142339 (Add NonNull pattern types)
- rust-lang/rust#147768 (Code refactoring on hir report_no_match_method_error)
- rust-lang/rust#147788 (const Cell methods)
- rust-lang/rust#147932 (Create UTF-8 version of `OsStr`/`OsString`)
- rust-lang/rust#147933 (os_str: Make platform docs more consistent)
- rust-lang/rust#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
@matthiaskrgr
Rollup merge ofrust-lang#147933- thaliaarchi:consistent-osstring, r…
a43d1b3
…=tgross35
os_str: Make platform docs more consistent
- Port `Buf::as_slice`/`as_mut_slice` wording from wtf8 to bytes
- Make `Buf::extend_from_slice_unchecked` docs more platform-independent
- wtf8 `Buf` was missing `#[repr(transparent)]`
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
@bors
Auto merge ofrust-lang#147957- matthiaskrgr:rollup-aqt593u, r=matth…
1486d5e
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
- rust-lang#142339 (Add NonNull pattern types)
- rust-lang#147768 (Code refactoring on hir report_no_match_method_error)
- rust-lang#147788 (const Cell methods)
- rust-lang#147932 (Create UTF-8 version of `OsStr`/`OsString`)
- rust-lang#147933 (os_str: Make platform docs more consistent)
- rust-lang#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@matthiaskrgr
Rollup merge ofrust-lang#147933- thaliaarchi:consistent-osstring, r…
6ae72af
…=tgross35
os_str: Make platform docs more consistent
- Port `Buf::as_slice`/`as_mut_slice` wording from wtf8 to bytes
- Make `Buf::extend_from_slice_unchecked` docs more platform-independent
- wtf8 `Buf` was missing `#[repr(transparent)]`
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@bors
Auto merge ofrust-lang#147957- matthiaskrgr:rollup-aqt593u, r=matth…
42b6509
…iaskrgr
Rollup of 7 pull requests
Successful merges:
- rust-lang#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
- rust-lang#142339 (Add NonNull pattern types)
- rust-lang#147768 (Code refactoring on hir report_no_match_method_error)
- rust-lang#147788 (const Cell methods)
- rust-lang#147932 (Create UTF-8 version of `OsStr`/`OsString`)
- rust-lang#147933 (os_str: Make platform docs more consistent)
- rust-lang#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Nov 16, 2025
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
8cd7c95
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
- rust-lang/rust#142339 (Add NonNull pattern types)
- rust-lang/rust#147768 (Code refactoring on hir report_no_match_method_error)
- rust-lang/rust#147788 (const Cell methods)
- rust-lang/rust#147932 (Create UTF-8 version of `OsStr`/`OsString`)
- rust-lang/rust#147933 (os_str: Make platform docs more consistent)
- rust-lang/rust#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Nov 30, 2025
@matthiaskrgr
Rollup merge ofrust-lang#147933- thaliaarchi:consistent-osstring, r…
edbe160
…=tgross35
os_str: Make platform docs more consistent
- Port `Buf::as_slice`/`as_mut_slice` wording from wtf8 to bytes
- Make `Buf::extend_from_slice_unchecked` docs more platform-independent
- wtf8 `Buf` was missing `#[repr(transparent)]`
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
700fbeb
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
- rust-lang/rust#142339 (Add NonNull pattern types)
- rust-lang/rust#147768 (Code refactoring on hir report_no_match_method_error)
- rust-lang/rust#147788 (const Cell methods)
- rust-lang/rust#147932 (Create UTF-8 version of `OsStr`/`OsString`)
- rust-lang/rust#147933 (os_str: Make platform docs more consistent)
- rust-lang/rust#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)
r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
16b51d1
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
- rust-lang/rust#142339 (Add NonNull pattern types)
- rust-lang/rust#147768 (Code refactoring on hir report_no_match_method_error)
- rust-lang/rust#147788 (const Cell methods)
- rust-lang/rust#147932 (Create UTF-8 version of `OsStr`/`OsString`)
- rust-lang/rust#147933 (os_str: Make platform docs more consistent)
- rust-lang/rust#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)
r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
58cebee
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
- rust-lang/rust#142339 (Add NonNull pattern types)
- rust-lang/rust#147768 (Code refactoring on hir report_no_match_method_error)
- rust-lang/rust#147788 (const Cell methods)
- rust-lang/rust#147932 (Create UTF-8 version of `OsStr`/`OsString`)
- rust-lang/rust#147933 (os_str: Make platform docs more consistent)
- rust-lang/rust#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Mar 27, 2026
@bors
Auto merge of #147957 - matthiaskrgr:rollup-aqt593u, r=matthiaskrgr
67410a8
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#141445 (Add `FromIterator` impls for `ascii::Char`s to `String`s)
- rust-lang/rust#142339 (Add NonNull pattern types)
- rust-lang/rust#147768 (Code refactoring on hir report_no_match_method_error)
- rust-lang/rust#147788 (const Cell methods)
- rust-lang/rust#147932 (Create UTF-8 version of `OsStr`/`OsString`)
- rust-lang/rust#147933 (os_str: Make platform docs more consistent)
- rust-lang/rust#147948 (PassWrapper: Access GlobalValueSummaryInfo::SummaryList via getter for LLVM 22+)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35tgross35tgross35 approved these changes

Assignees

@tgross35tgross35

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

4 participants

@thaliaarchi@rustbot@tgross35@bors