Skip to content

[beta] fix panic when rustc tries to reduce intermediate filenames length - #148019

Closed
tardyp wants to merge 1 commit into
rust-lang:betafrom
tardyp:lto_big_filesize_utf8_for_beta
Closed

[beta] fix panic when rustc tries to reduce intermediate filenames length#148019
tardyp wants to merge 1 commit into
rust-lang:betafrom
tardyp:lto_big_filesize_utf8_for_beta

Conversation

@tardyp

@tardyptardyp commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

with multi byte chars

The issue cannot be reproduced with the former testcase of creating external crates because rust refuses to use "external crate 28_找出字符串中第一个匹配项的下标" because it is not a valid indentifier (starts with number, and contain non ascii chars)

But still using 28_找出字符串中第一个匹配项的下标.rs as a filename is accepted by previous rustc releases So we consider it valid, and add an integration test for it to catch any regression on other code related to non ascii filenames.

This is the beta backport for this bug

#147975

r? @jieyouxu

…th multi byte chars
The issue cannot be reproduced with the former testcase of creating external crates because
rust refuses to use "external crate 28_找出字符串中第一个匹配项的下标"
because it is not a valid indentifier (starts with number, and contain non ascii chars)
But still using 28_找出字符串中第一个匹配项的下标.rs as a filename is accepted by previous rustc releases
So we consider it valid, and add an integration test for it to catch any regression on other code related to non ascii filenames.
@rustbotrustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 23, 2025
@Kivooeo

Copy link
Copy Markdown
Member

@rustbot label +beta-nominated

@rustbotrustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 23, 2025
@jieyouxu

Copy link
Copy Markdown
Member

r? compiler (wont get to this soon)

@rustbotrustbot assigned madsmtm and unassigned jieyouxuOct 23, 2025
@Noratrieb

Copy link
Copy Markdown
Member

Closing since this is not needed #148018 (comment)

@rustbotrustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2025
@apirainoapiraino removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 23, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-run-makeArea: port run-make Makefiles to rmake.rsT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@tardyp@Kivooeo@jieyouxu@Noratrieb@apiraino@madsmtm@rustbot