Uh oh!
There was an error while loading. Please reload this page.
Remove redundant .to_string().as_str() calls - #148155
Closed
osamakader wants to merge 1 commit into
Closed
Conversation
The pattern .to_string().as_str() creates a temporary String that is immediately borrowed and then dropped, which is inefficient. Replace with &.to_string() for cleaner, more idiomatic code. Changes: - compiler/rustc_builtin_macros/src/autodiff.rs: Simplify identifier creation - compiler/rustc_codegen_llvm/src/context.rs: Simplify error message formatting Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
osamakader
marked this pull request as ready for review
October 26, 2025 22:01
rustbot
commented
Oct 26, 2025
Collaborator
Some changes occurred in compiler/rustc_builtin_macros/src/autodiff.rs cc @ZuseZ4 |
rustbot
commented
Oct 26, 2025
Collaborator
Kobzol
commented
Oct 27, 2025
Member
|
lcnr
commented
Oct 27, 2025
Contributor
Why is I don't think this change is worth the (admittedly very small) churn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pattern .to_string().as_str() creates a temporary String that is immediately borrowed and then dropped, which is inefficient. Replace with &.to_string() for cleaner, more idiomatic code.
Changes: