Uh oh!
There was an error while loading. Please reload this page.
citool: Always print a signed percentage in job duration changes - #148237
Merged
Conversation
Kobzol
commented
Oct 29, 2025
Member
Makes sense, thanks! @bors r+ rollu |
bors
commented
Oct 29, 2025
Collaborator
Kobzol
commented
Oct 29, 2025
Member
@bors rollup |
bors added a commit
that referenced
this pull request
Oct 29, 2025
Rollup of 4 pull requests Successful merges: - #148159 (Move rustdoc tests to appropriate subdirectories) - #148218 (Update T-compiler/ops Zulip messages) - #148228 (Run regression test for #147964 on next solver too) - #148237 (citool: Always print a signed percentage in job duration changes) r? `@ghost` `@rustbot` modify labels: rollup
Uh oh!
There was an error while loading. Please reload this page.
rust-timer added a commit
that referenced
this pull request
Oct 29, 2025
Rollup merge of #148237 - Zalathar:analysis-signed, r=Kobzol citool: Always print a signed percentage in job duration changes I found myself confused by these percentage deltas, because it's not immediately obvious whether a change of 110% means “a little bit worse” (+10%, 110% overall) or ”more than twice as long” (+110%, 210% overall). The correct interpretation is “more than twice as long”. Including a sign for positive percentages should hopefully make it clearer that they are relative to a baseline of ±0%, not a baseline of 100%. Manually tested with: ```text cargo run --manifest-path src/ci/citool/Cargo.toml post-merge-report df984edc9537a9 ``` r? Kobzol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found myself confused by these percentage deltas, because it's not immediately obvious whether a change of 110% means “a little bit worse” (+10%, 110% overall) or ”more than twice as long” (+110%, 210% overall). The correct interpretation is “more than twice as long”.
Including a sign for positive percentages should hopefully make it clearer that they are relative to a baseline of ±0%, not a baseline of 100%.
Manually tested with:
r? Kobzol