Skip to content

Handle default features and -Ctarget-features in the dummy backend - #148253

Merged
bors merged 1 commit into
rust-lang:masterfrom
bjorn3:dummy_backend_target_features
Oct 30, 2025
Merged

Handle default features and -Ctarget-features in the dummy backend#148253
bors merged 1 commit into
rust-lang:masterfrom
bjorn3:dummy_backend_target_features

Conversation

@bjorn3

Copy link
Copy Markdown
Member

This prevents a warning about ABI relevant target features not being set on x86 and arm. In addition it is required for miri to report correct features in is_*_feature_detected!() if miri switches to the dummy backend.

Required for rust-lang/miri#4648

This prevents a warning about ABI relevant target features not being set
on x86 and arm. In addition it is required for miri to report correct
features in is_*_feature_detected!() if miri switches to the dummy backend.
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 29, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@JonathanBrouwer

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Oct 29, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 4d7c784 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 29, 2025
…es, r=JonathanBrouwer
Handle default features and -Ctarget-features in the dummy backend
This prevents a warning about ABI relevant target features not being set on x86 and arm. In addition it is required for miri to report correct features in is_*_feature_detected!() if miri switches to the dummy backend.
Required for rust-lang/miri#4648
bors added a commit that referenced this pull request Oct 30, 2025
Rollup of 4 pull requests
Successful merges:
- #148115 (rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`)
- #148137 (Couple of changes for Redox OS)
- #148176 ([rustdoc] Include attribute and derive macros when filtering on "macros")
- #148253 (Handle default features and -Ctarget-features in the dummy backend)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 30, 2025
…es, r=JonathanBrouwer
Handle default features and -Ctarget-features in the dummy backend
This prevents a warning about ABI relevant target features not being set on x86 and arm. In addition it is required for miri to report correct features in is_*_feature_detected!() if miri switches to the dummy backend.
Required for rust-lang/miri#4648
@ZalatharZalathar mentioned this pull request Oct 30, 2025
bors added a commit that referenced this pull request Oct 30, 2025
Rollup of 9 pull requests
Successful merges:
- #138217 (Turn `Cow::is_borrowed,is_owned` into associated functions.)
- #147858 (Micro-optimization attempt in coroutine layout computation)
- #147923 (Simplify rustc_public context handling)
- #147935 (Add LLVM realtime sanitizer)
- #148115 (rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`)
- #148137 (Couple of changes for Redox OS)
- #148176 ([rustdoc] Include attribute and derive macros when filtering on "macros")
- #148193 (Remove `QPath::LangItem`)
- #148253 (Handle default features and -Ctarget-features in the dummy backend)
r? `@ghost`
`@rustbot` modify labels: rollup
@jhprattjhpratt mentioned this pull request Oct 30, 2025
bors added a commit that referenced this pull request Oct 30, 2025
Rollup of 8 pull requests
Successful merges:
- #138217 (Turn `Cow::is_borrowed,is_owned` into associated functions.)
- #147858 (Micro-optimization attempt in coroutine layout computation)
- #147923 (Simplify rustc_public context handling)
- #148115 (rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`)
- #148137 (Couple of changes for Redox OS)
- #148176 ([rustdoc] Include attribute and derive macros when filtering on "macros")
- #148253 (Handle default features and -Ctarget-features in the dummy backend)
- #148272 (Align VEX V5 boot routine to 4 bytes)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit f76239c into rust-lang:masterOct 30, 2025
11 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Oct 30, 2025
rust-timer added a commit that referenced this pull request Oct 30, 2025
Rollup merge of #148253 - bjorn3:dummy_backend_target_features, r=JonathanBrouwer
Handle default features and -Ctarget-features in the dummy backend
This prevents a warning about ABI relevant target features not being set on x86 and arm. In addition it is required for miri to report correct features in is_*_feature_detected!() if miri switches to the dummy backend.
Required for rust-lang/miri#4648
@bjorn3
bjorn3 deleted the dummy_backend_target_features branch October 30, 2025 12:33
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Nov 4, 2025
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#138217 (Turn `Cow::is_borrowed,is_owned` into associated functions.)
- rust-lang/rust#147858 (Micro-optimization attempt in coroutine layout computation)
- rust-lang/rust#147923 (Simplify rustc_public context handling)
- rust-lang/rust#148115 (rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`)
- rust-lang/rust#148137 (Couple of changes for Redox OS)
- rust-lang/rust#148176 ([rustdoc] Include attribute and derive macros when filtering on "macros")
- rust-lang/rust#148253 (Handle default features and -Ctarget-features in the dummy backend)
- rust-lang/rust#148272 (Align VEX V5 boot routine to 4 bytes)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
…es, r=JonathanBrouwer
Handle default features and -Ctarget-features in the dummy backend
This prevents a warning about ABI relevant target features not being set on x86 and arm. In addition it is required for miri to report correct features in is_*_feature_detected!() if miri switches to the dummy backend.
Required for rust-lang/miri#4648
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
Rollup of 8 pull requests
Successful merges:
- rust-lang#138217 (Turn `Cow::is_borrowed,is_owned` into associated functions.)
- rust-lang#147858 (Micro-optimization attempt in coroutine layout computation)
- rust-lang#147923 (Simplify rustc_public context handling)
- rust-lang#148115 (rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`)
- rust-lang#148137 (Couple of changes for Redox OS)
- rust-lang#148176 ([rustdoc] Include attribute and derive macros when filtering on "macros")
- rust-lang#148253 (Handle default features and -Ctarget-features in the dummy backend)
- rust-lang#148272 (Align VEX V5 boot routine to 4 bytes)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
…es, r=JonathanBrouwer
Handle default features and -Ctarget-features in the dummy backend
This prevents a warning about ABI relevant target features not being set on x86 and arm. In addition it is required for miri to report correct features in is_*_feature_detected!() if miri switches to the dummy backend.
Required for rust-lang/miri#4648
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
Rollup of 8 pull requests
Successful merges:
- rust-lang#138217 (Turn `Cow::is_borrowed,is_owned` into associated functions.)
- rust-lang#147858 (Micro-optimization attempt in coroutine layout computation)
- rust-lang#147923 (Simplify rustc_public context handling)
- rust-lang#148115 (rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`)
- rust-lang#148137 (Couple of changes for Redox OS)
- rust-lang#148176 ([rustdoc] Include attribute and derive macros when filtering on "macros")
- rust-lang#148253 (Handle default features and -Ctarget-features in the dummy backend)
- rust-lang#148272 (Align VEX V5 boot routine to 4 bytes)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Nov 16, 2025
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#138217 (Turn `Cow::is_borrowed,is_owned` into associated functions.)
- rust-lang/rust#147858 (Micro-optimization attempt in coroutine layout computation)
- rust-lang/rust#147923 (Simplify rustc_public context handling)
- rust-lang/rust#148115 (rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`)
- rust-lang/rust#148137 (Couple of changes for Redox OS)
- rust-lang/rust#148176 ([rustdoc] Include attribute and derive macros when filtering on "macros")
- rust-lang/rust#148253 (Handle default features and -Ctarget-features in the dummy backend)
- rust-lang/rust#148272 (Align VEX V5 boot routine to 4 bytes)
r? `@ghost`
`@rustbot` modify labels: rollup
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Mar 27, 2026
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#138217 (Turn `Cow::is_borrowed,is_owned` into associated functions.)
- rust-lang/rust#147858 (Micro-optimization attempt in coroutine layout computation)
- rust-lang/rust#147923 (Simplify rustc_public context handling)
- rust-lang/rust#148115 (rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`)
- rust-lang/rust#148137 (Couple of changes for Redox OS)
- rust-lang/rust#148176 ([rustdoc] Include attribute and derive macros when filtering on "macros")
- rust-lang/rust#148253 (Handle default features and -Ctarget-features in the dummy backend)
- rust-lang/rust#148272 (Align VEX V5 boot routine to 4 bytes)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@bjorn3@rustbot@JonathanBrouwer@bors