compiletest: rename add-core-stubs/core-stubs-compile-flags to add-minicore/minicore-compile-flags

[RalfJung]

Fixes#148282

[rustbot]

compiletest directives have been modified. Please add or update docs for the
new or modified directive in src/doc/rustc-dev-guide/.

Some changes occurred in tests/codegen-llvm/stack-probes-inline.rs

cc @rust-lang/project-exploit-mitigations, @rcvalle

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

Some changes occurred in tests/codegen-llvm/sanitizer

cc @rcvalle

Some changes occurred in tests/ui/sanitizer

cc @rcvalle

Some changes occurred in src/tools/compiletest

cc @jieyouxu

[rustbot]

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[wesleywiser]

Looks good to me but I'll let @jieyouxu review as well before r+'ing

View changes since this review

[jieyouxu]

Thanks, one nit, you can r=Wesley and me after.

View changes since this review

[jieyouxu]

@bors p=10 (logically conflict-prone)

[jieyouxu]

@bors rollup=never (logically conflict-prone)

[jieyouxu]

@rustbot author

[RalfJung]

I'm happy to also do that rename here.

[RalfJung]

@rustbot ready

[jieyouxu]

I'm happy to also do that rename here.

If you are up for that, I think it might be better to just do that in this PR, otherwise we'd have this weird transitional phase where the main directive is called add-minicore but the flag directive is called core-stubs-compile-flags. I'd be happy to review that.

[bors]

⌛ Testing commit 97d8f3e with merge 2c903f2...

[rust-log-analyzer]

The job aarch64-gnu-llvm-20-1 failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)

failures:
---- fs::tests::metadata_access_times stdout ----
thread 'fs::tests::metadata_access_times' (250955) panicked at library/std/src/fs/tests.rs:1737:33:
assertion failed: t1 <= t2
stack backtrace:
0: __rustc::rust_begin_unwind
1: core::panicking::panic_fmt
2: core::panicking::panic
3: core::ops::function::FnOnce::call_once

[bors]

💔 Test failed - checks-actions

[RalfJung]

I... didn't change that code?
@bors retry

[bors]

⌛ Testing commit 97d8f3e with merge b15a874...

[bors]

☀️ Test successful - checks-actions
Approved by: jieyouxu,wesleywiser
Pushing b15a874 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 8483293 (parent) -> b15a874 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard b15a874aafe7eab9ea3ac2c1d59c7b03e1425027 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. aarch64-gnu-llvm-20-2: 2503.0s -> 2150.0s (-14.1%)
2. x86_64-rust-for-linux: 3099.3s -> 2692.7s (-13.1%)
3. i686-gnu-2: 6249.0s -> 5435.5s (-13.0%)
4. x86_64-gnu-debug: 7145.3s -> 6265.6s (-12.3%)
5. pr-check-2: 2631.0s -> 2314.3s (-12.0%)
6. x86_64-gnu-llvm-20-2: 6264.4s -> 5516.0s (-11.9%)
7. x86_64-gnu-miri: 5000.2s -> 4420.4s (-11.6%)
8. i686-msvc-1: 9459.9s -> 10519.5s (+11.2%)
9. i686-gnu-1: 8360.1s -> 7428.8s (-11.1%)
10. x86_64-gnu-gcc: 3477.6s -> 3099.9s (-10.9%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (b15a874): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

• If the regression was expected or you think it can be justified,
  please write a comment with sufficient written justification, and add
  @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
• If you think that you know of a way to resolve the regression, try to create
  a new PR with a fix for the regression.
• If you do not understand the regression or you think that it is just noise,
  you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
  were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	3.1%	[3.1%, 3.1%]	1
Regressions ❌ (secondary)	0.2%	[0.2%, 0.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.1%	[3.1%, 3.1%]	1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.0%	[3.0%, 3.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	3.0%	[3.0%, 3.0%]	1

Binary size

Results (primary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.1%	[1.1%, 1.1%]	1

Bootstrap: 473.503s -> 473.039s (-0.10%)
Artifact size: 390.87 MiB -> 390.80 MiB (-0.02%)

[Kobzol]

Noise, this only changed tests.

@rustbot label: +perf-regression-triaged