Skip to content

Check unsafety for non-macro attributes in validate_attr - #148647

Merged
bors merged 2 commits into
rust-lang:mainfrom
JonathanBrouwer:unsafe_attr_refactor
Nov 11, 2025
Merged

Check unsafety for non-macro attributes in validate_attr#148647
bors merged 2 commits into
rust-lang:mainfrom
JonathanBrouwer:unsafe_attr_refactor

Conversation

@JonathanBrouwer

@JonathanBrouwerJonathanBrouwer commented Nov 7, 2025

Copy link
Copy Markdown
Member

r? @jdonszelmann

Also adds a test for a previously untested case, unnecessary unsafe on a proc macro attribute

In preparation for #148453

@JonathanBrouwer
Refactor safety checking for attributes
c8618d2
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
@JonathanBrouwer
Add test for unnecessary unsafe on proc macro attr
87b2796
Signed-off-by: Jonathan Brouwer <jonathantbrouwer@gmail.com>
@rustbot

rustbot commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

@rustbotrustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 7, 2025
@rustbot

rustbot commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

jdonszelmann is currently at their maximum review capacity.
They may take a while to respond.

@jdonszelmann

jdonszelmann commented Nov 10, 2025

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@bors

bors commented Nov 10, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 87b2796 has been approved by jdonszelmann

It is now in the queue for this repository.

@bors

bors commented Nov 10, 2025

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 10, 2025
ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Nov 10, 2025
@ChrisDenton
Rollup merge ofrust-lang#148647- JonathanBrouwer:unsafe_attr_refact…
f132514
…or, r=jdonszelmann
Check unsafety for non-macro attributes in `validate_attr`
r? ``@jdonszelmann``
Also adds a test for a previously untested case, unnecessary unsafe on a proc macro attribute
In preparation for rust-lang#148453
@ChrisDentonChrisDenton mentioned this pull request Nov 10, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 11, 2025
@Zalathar
Rollup merge ofrust-lang#148647- JonathanBrouwer:unsafe_attr_refact…
b659868
…or, r=jdonszelmann
Check unsafety for non-macro attributes in `validate_attr`
r? ```@jdonszelmann```
Also adds a test for a previously untested case, unnecessary unsafe on a proc macro attribute
In preparation for rust-lang#148453
@ZalatharZalathar mentioned this pull request Nov 11, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 11, 2025
@Zalathar
Rollup merge ofrust-lang#148647- JonathanBrouwer:unsafe_attr_refact…
14b5633
…or, r=jdonszelmann
Check unsafety for non-macro attributes in `validate_attr`
r? ````@jdonszelmann````
Also adds a test for a previously untested case, unnecessary unsafe on a proc macro attribute
In preparation for rust-lang#148453
@ZalatharZalathar mentioned this pull request Nov 11, 2025
Closed
bors added a commit that referenced this pull request Nov 11, 2025
@bors
Auto merge of#148813- Zalathar:rollup-xsibgvo, r=Zalathar
03189ee
Rollup of 16 pull requests
Successful merges:
- #141470 (Add new `function_casts_as_integer` lint)
- #143619 (`c_variadic`: Add future-incompatibility warning for `...` arguments without a pattern outside of `extern` blocks)
- #146495 (rustdoc: Erase `#![doc(document_private_items)]`)
- #147771 (Rename `*exact_{div,shr,shl}` to `*{div,shr,shl}_exact`)
- #147833 (rustdoc-json: move `target` to `json::conversions`)
- #147952 (Add a timeout to the `remote-test-client` connection)
- #147955 (compiletest: Migrate `TestProps` directive handling to a system of named handlers)
- #148480 (Add `Steal::risky_hack_borrow_mut`)
- #148506 (Special case detecting `'static` lifetime requirement coming from `-> Box<dyn Trait>`)
- #148508 (Provide more context when mutably borrowing an imutably borrowed value)
- #148530 (update the bootstrap readme)
- #148608 (Add test for --test-builder success path)
- #148636 (bootstrap: respect `build.python` on macOS)
- #148639 (test(rustdoc): move tests into jump-to-def)
- #148647 (Check unsafety for non-macro attributes in `validate_attr`)
- #148667 (a few small clippy fixes)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Nov 11, 2025
@bors
Auto merge of#148813- Zalathar:rollup-xsibgvo, r=Zalathar
0519628
Rollup of 16 pull requests
Successful merges:
- #141470 (Add new `function_casts_as_integer` lint)
- #143619 (`c_variadic`: Add future-incompatibility warning for `...` arguments without a pattern outside of `extern` blocks)
- #146495 (rustdoc: Erase `#![doc(document_private_items)]`)
- #147771 (Rename `*exact_{div,shr,shl}` to `*{div,shr,shl}_exact`)
- #147833 (rustdoc-json: move `target` to `json::conversions`)
- #147952 (Add a timeout to the `remote-test-client` connection)
- #147955 (compiletest: Migrate `TestProps` directive handling to a system of named handlers)
- #148480 (Add `Steal::risky_hack_borrow_mut`)
- #148506 (Special case detecting `'static` lifetime requirement coming from `-> Box<dyn Trait>`)
- #148508 (Provide more context when mutably borrowing an imutably borrowed value)
- #148530 (update the bootstrap readme)
- #148608 (Add test for --test-builder success path)
- #148636 (bootstrap: respect `build.python` on macOS)
- #148639 (test(rustdoc): move tests into jump-to-def)
- #148647 (Check unsafety for non-macro attributes in `validate_attr`)
- #148667 (a few small clippy fixes)
r? `@ghost`
`@rustbot` modify labels: rollup
@ZalatharZalathar mentioned this pull request Nov 11, 2025
Merged
bors added a commit that referenced this pull request Nov 11, 2025
@bors
Auto merge of#148817- Zalathar:rollup-tf5ti2m, r=Zalathar
9312cd6
Rollup of 15 pull requests
Successful merges:
- #141470 (Add new `function_casts_as_integer` lint)
- #143619 (`c_variadic`: Add future-incompatibility warning for `...` arguments without a pattern outside of `extern` blocks)
- #146495 (rustdoc: Erase `#![doc(document_private_items)]`)
- #147771 (Rename `*exact_{div,shr,shl}` to `*{div,shr,shl}_exact`)
- #147833 (rustdoc-json: move `target` to `json::conversions`)
- #147955 (compiletest: Migrate `TestProps` directive handling to a system of named handlers)
- #148480 (Add `Steal::risky_hack_borrow_mut`)
- #148506 (Special case detecting `'static` lifetime requirement coming from `-> Box<dyn Trait>`)
- #148508 (Provide more context when mutably borrowing an imutably borrowed value)
- #148530 (update the bootstrap readme)
- #148608 (Add test for --test-builder success path)
- #148636 (bootstrap: respect `build.python` on macOS)
- #148639 (test(rustdoc): move tests into jump-to-def)
- #148647 (Check unsafety for non-macro attributes in `validate_attr`)
- #148667 (a few small clippy fixes)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 7327bbc into rust-lang:mainNov 11, 2025
11 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 11, 2025
rust-timer added a commit that referenced this pull request Nov 11, 2025
@rust-timer
Unrolled build for#148647
d4401e6
Rollup merge of #148647 - JonathanBrouwer:unsafe_attr_refactor, r=jdonszelmann
Check unsafety for non-macro attributes in `validate_attr`
r? `````@jdonszelmann`````
Also adds a test for a previously untested case, unnecessary unsafe on a proc macro attribute
In preparation for #148453
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Nov 12, 2025
@bors
Auto merge of #148817 - Zalathar:rollup-tf5ti2m, r=Zalathar
3f4f55a
Rollup of 15 pull requests
Successful merges:
- rust-lang/rust#141470 (Add new `function_casts_as_integer` lint)
- rust-lang/rust#143619 (`c_variadic`: Add future-incompatibility warning for `...` arguments without a pattern outside of `extern` blocks)
- rust-lang/rust#146495 (rustdoc: Erase `#![doc(document_private_items)]`)
- rust-lang/rust#147771 (Rename `*exact_{div,shr,shl}` to `*{div,shr,shl}_exact`)
- rust-lang/rust#147833 (rustdoc-json: move `target` to `json::conversions`)
- rust-lang/rust#147955 (compiletest: Migrate `TestProps` directive handling to a system of named handlers)
- rust-lang/rust#148480 (Add `Steal::risky_hack_borrow_mut`)
- rust-lang/rust#148506 (Special case detecting `'static` lifetime requirement coming from `-> Box<dyn Trait>`)
- rust-lang/rust#148508 (Provide more context when mutably borrowing an imutably borrowed value)
- rust-lang/rust#148530 (update the bootstrap readme)
- rust-lang/rust#148608 (Add test for --test-builder success path)
- rust-lang/rust#148636 (bootstrap: respect `build.python` on macOS)
- rust-lang/rust#148639 (test(rustdoc): move tests into jump-to-def)
- rust-lang/rust#148647 (Check unsafety for non-macro attributes in `validate_attr`)
- rust-lang/rust#148667 (a few small clippy fixes)
r? `@ghost`
`@rustbot` modify labels: rollup
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #148817 - Zalathar:rollup-tf5ti2m, r=Zalathar
657d390
Rollup of 15 pull requests
Successful merges:
- rust-lang/rust#141470 (Add new `function_casts_as_integer` lint)
- rust-lang/rust#143619 (`c_variadic`: Add future-incompatibility warning for `...` arguments without a pattern outside of `extern` blocks)
- rust-lang/rust#146495 (rustdoc: Erase `#![doc(document_private_items)]`)
- rust-lang/rust#147771 (Rename `*exact_{div,shr,shl}` to `*{div,shr,shl}_exact`)
- rust-lang/rust#147833 (rustdoc-json: move `target` to `json::conversions`)
- rust-lang/rust#147955 (compiletest: Migrate `TestProps` directive handling to a system of named handlers)
- rust-lang/rust#148480 (Add `Steal::risky_hack_borrow_mut`)
- rust-lang/rust#148506 (Special case detecting `'static` lifetime requirement coming from `-> Box<dyn Trait>`)
- rust-lang/rust#148508 (Provide more context when mutably borrowing an imutably borrowed value)
- rust-lang/rust#148530 (update the bootstrap readme)
- rust-lang/rust#148608 (Add test for --test-builder success path)
- rust-lang/rust#148636 (bootstrap: respect `build.python` on macOS)
- rust-lang/rust#148639 (test(rustdoc): move tests into jump-to-def)
- rust-lang/rust#148647 (Check unsafety for non-macro attributes in `validate_attr`)
- rust-lang/rust#148667 (a few small clippy fixes)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdonszelmannjdonszelmann

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

4 participants

@JonathanBrouwer@rustbot@jdonszelmann@bors