Update cargo submodule - #148674

Merged
bors merged 1 commit into
rust-lang:masterfrom
weihanglo:update-cargo
Nov 8, 2025
Merged

Update cargo submodule#148674
bors merged 1 commit into
rust-lang:masterfrom
weihanglo:update-cargo

Conversation

@weihanglo

@weihangloweihanglo commented Nov 7, 2025

Copy link
Copy Markdown
Member

22 commits in 6368002885a04cbeae39a82cf5118f941559a40a..445fe4a68f469bf936b2fd81de2c503b233a7f4f
2025-10-31 14:31:52 +0000 to 2025-11-07 18:08:19 +0000

r? ghost

@rustbot

rustbot commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred in src/tools/cargo

cc @ehuss

@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 7, 2025
@rustbot

rustbot commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

⚠️Warning⚠️

@rust-log-analyzer

rust-log-analyzer commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

The job tidy failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)
spellchecking files
building external tool typos from package typos-cli@1.38.1
finished building tool typos
npm WARN deprecated puppeteer@22.15.0: < 24.10.2 is no longer supported
npm ERR! code 127
npm ERR! git dep preparation failed
npm ERR! command /node/bin/node /node/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/home/user/.npm --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
npm ERR! npm WARN using --force Recommended protections disabled.
npm ERR! npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs
npm ERR! npm WARN deprecated debuglog@1.0.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm ERR! npm WARN deprecated read-package-json@2.1.2: This package is no longer supported. Please use @npmcli/package-json instead.
npm ERR! npm WARN deprecated read-installed@4.0.3: This package is no longer supported.
npm ERR! npm ERR! code 127
npm ERR! npm ERR! path /home/user/.npm/_cacache/tmp/git-cloneXXXXXXfei8Ol/node_modules/rollup
npm ERR! npm ERR! command failed
npm ERR! npm ERR! command sh -c patch-package
npm ERR! npm ERR! sh: 1: patch-package: not found
npm ERR! npm ERR! npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T21_39_50_196Z-debug-0.log
npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T21_39_43_747Z-debug-0.log
npm install did not exit successfully
tidy [extra_checks]: IO error: npm install returned exit code exit status: 127
tidy [extra_checks]: FAIL
tidy: The following check failed: extra_checks
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1549:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1279:29
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:02:49
local time: Fri Nov 7 21:40:11 UTC 2025
network time: Fri, 07 Nov 2025 21:40:11 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

@weihanglo

weihanglo commented Nov 7, 2025

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=1

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 2bd3508 has been approved by weihanglo

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025
@weihanglo

weihanglo commented Nov 7, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

On no the check failed

@weihanglo

weihanglo commented Nov 7, 2025

Copy link
Copy Markdown
MemberAuthor

@bors r-

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2025
@weihanglo

weihanglo commented Nov 7, 2025

Copy link
Copy Markdown
MemberAuthor

@bors r+ rollup=never p=1

@bors

bors commented Nov 7, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 2bd3508 has been approved by weihanglo

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 7, 2025
@bors

bors commented Nov 8, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 2bd3508 with merge 4e0baae...

@bors

bors commented Nov 8, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 4e0baae to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 8, 2025
@bors
bors merged commit 4e0baae into rust-lang:masterNov 8, 2025
22 of 23 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 8, 2025
@github-actions

github-actionsBot commented Nov 8, 2025

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ceb7df7 (parent) -> 4e0baae (this PR)

Test differences

Show 49 test diffs

Stage 2

  • build_analysis::log_rebuild_reason_file_changed: [missing] -> pass (J0)
  • build_analysis::log_rebuild_reason_fresh_build: [missing] -> pass (J0)
  • build_analysis::log_rebuild_reason_no_rebuild: [missing] -> pass (J0)
  • build_plan::build_plan_with_dev_dep: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_build_script: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_simple: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_single_dep: pass -> [missing] (J0)
  • config::nonmergable_lists: pass -> [missing] (J0)
  • config::nonmergeable_lists: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::checksum_use_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::dep_info_output_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::env_var_changed_both_some: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::env_var_changed_old_none: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::features_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::forced: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fresh_build: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_checksum: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_env: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_failed_to_read_metadata: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_file_size_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_missing_checksum: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_missing_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale_dep_fingerprint: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale_dependency: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_unable_to_read_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::local_fingerprint_type_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::nothing_obvious: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::number_of_dependencies_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rerun_if_changed_output_paths_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rustc_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rustflags_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::unit_dependency_info_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::unit_dependency_name_changed: [missing] -> pass (J0)
  • dep_info::no_trailing_separator_after_package_root_build_script: [missing] -> pass (J0)
  • dep_info::no_trailing_separator_after_package_root_proc_macro: [missing] -> ignore (proc_macro::tracked_path is unstable) (J0)
  • install::cli_root_argument_without_deprecation_warning: [missing] -> pass (J0)
  • install::relative_install_location_with_path_set: [missing] -> pass (J0)
  • install::relative_install_location_with_trailing_slash: [missing] -> pass (J0)
  • install::relative_install_location_without_trailing_slash: [missing] -> pass (J0)
  • metabuild::metabuild_build_plan: pass -> [missing] (J0)
  • progress::plain_string_when_doesnt_work: [missing] -> pass (J0)
  • warning_override::hard_warning_allow: [missing] -> pass (J0)
  • warning_override::hard_warning_deny: [missing] -> pass (J0)

Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 4e0baae06da3c29210ba3620db5b01bcb5aba38a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 7051.7s -> 10050.2s (+42.5%)
  2. dist-x86_64-apple: 5730.7s -> 7970.4s (+39.1%)
  3. pr-check-1: 1708.8s -> 1924.4s (+12.6%)
  4. dist-apple-various: 4533.5s -> 3978.8s (-12.2%)
  5. i686-gnu-2: 6186.8s -> 5457.2s (-11.8%)
  6. x86_64-gnu-llvm-20: 2881.1s -> 2555.9s (-11.3%)
  7. x86_64-gnu-llvm-21-2: 5504.7s -> 6028.0s (+9.5%)
  8. x86_64-msvc-ext2: 5400.4s -> 5892.6s (+9.1%)
  9. x86_64-gnu-llvm-20-3: 6232.6s -> 6777.2s (+8.7%)
  10. dist-x86_64-musl: 7687.6s -> 7028.9s (-8.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer

rust-timer commented Nov 8, 2025

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (4e0baae): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

  • If the regression was expected or you think it can be justified,
    please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)		2.9%[2.9%, 2.9%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)2.9%[2.9%, 2.9%]1

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (secondary 3.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		--0
Regressions ❌
(secondary)		3.8%[2.5%, 6.5%]3
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)--0

Binary size

Results (primary 1.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		1.1%[1.1%, 1.1%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)1.1%[1.1%, 1.1%]1

Bootstrap: 475.105s -> 477.474s (0.50%)
Artifact size: 390.80 MiB -> 390.94 MiB (0.04%)

@rustbotrustbot added the perf-regression Performance regression. label Nov 8, 2025
@lqd

lqd commented Nov 8, 2025

Copy link
Copy Markdown
Member

Usual clap_derive periodic noise

@rustbot label: +perf-regression-triaged

@rustbotrustbot added the perf-regression-triaged The performance regression has been triaged. label Nov 8, 2025
@weihanglo
weihanglo deleted the update-cargo branch November 8, 2025 08:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

merged-by-borsThis PR was explicitly merged by bors.perf-regressionPerformance regression.perf-regression-triagedThe performance regression has been triaged.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@weihanglo@rustbot@rust-log-analyzer@bors@rust-timer@lqd
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Update cargo submodule - #148674
Merged
bors merged 1 commit into
rust-lang:masterfrom 
weihanglo:update-cargo
Nov 8, 2025
Merged
Update cargo submodule#148674
bors merged 1 commit into
rust-lang:masterfrom 
weihanglo:update-cargo
Conversation
@weihanglo
@weihangloweihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

Member
22 commits in 6368002885a04cbeae39a82cf5118f941559a40a..445fe4a68f469bf936b2fd81de2c503b233a7f4f

2025-10-31 14:31:52 +0000 to 2025-11-07 18:08:19 +0000
r? ghost
@rustbot
rustbot
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
Some changes occurred in src/tools/cargo
cc @ehuss
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 7, 2025
@rustbot
rustbot
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@rust-log-analyzer
rust-log-analyzer
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
The job tidy failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
spellchecking files
building external tool typos from package typos-cli@1.38.1
finished building tool typos
npm WARN deprecated puppeteer@22.15.0: < 24.10.2 is no longer supported
npm ERR! code 127
npm ERR! git dep preparation failed
npm ERR! command /node/bin/node /node/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/home/user/.npm --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
npm ERR! npm WARN using --force Recommended protections disabled.
npm ERR! npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs
npm ERR! npm WARN deprecated debuglog@1.0.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm ERR! npm WARN deprecated read-package-json@2.1.2: This package is no longer supported. Please use @npmcli/package-json instead.
npm ERR! npm WARN deprecated read-installed@4.0.3: This package is no longer supported.
npm ERR! npm ERR! code 127
npm ERR! npm ERR! path /home/user/.npm/_cacache/tmp/git-cloneXXXXXXfei8Ol/node_modules/rollup
npm ERR! npm ERR! command failed
npm ERR! npm ERR! command sh -c patch-package
npm ERR! npm ERR! sh: 1: patch-package: not found
npm ERR! npm ERR! npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T21_39_50_196Z-debug-0.log
npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T21_39_43_747Z-debug-0.log
npm install did not exit successfully
tidy [extra_checks]: IO error: npm install returned exit code exit status: 127
tidy [extra_checks]: FAIL
tidy: The following check failed: extra_checks
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1549:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1279:29
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:02:49
local time: Fri Nov 7 21:40:11 UTC 2025
network time: Fri, 07 Nov 2025 21:40:11 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=1
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 2bd3508 has been approved by weihanglo
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 7, 2025
@weihanglo
weihanglo
commented
Nov 7, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
On no the check failed
@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r-
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 7, 2025
@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=1
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 2bd3508 has been approved by weihanglo
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 7, 2025
@bors
bors
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 2bd3508 with merge 4e0baae...
@bors
bors
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: weihanglo

Pushing 4e0baae to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 8, 2025
@bors
bors
merged commit 4e0baae
into
rust-lang:masterNov 8, 2025

22 of 23 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 8, 2025
@github-actions
github-actionsBot
commented
Nov 8, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ceb7df7 (parent) -> 4e0baae (this PR)
Test differences
Show 49 test diffs

Stage 2
  • build_analysis::log_rebuild_reason_file_changed: [missing] -> pass (J0)
  • build_analysis::log_rebuild_reason_fresh_build: [missing] -> pass (J0)
  • build_analysis::log_rebuild_reason_no_rebuild: [missing] -> pass (J0)
  • build_plan::build_plan_with_dev_dep: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_build_script: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_simple: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_single_dep: pass -> [missing] (J0)
  • config::nonmergable_lists: pass -> [missing] (J0)
  • config::nonmergeable_lists: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::checksum_use_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::dep_info_output_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::env_var_changed_both_some: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::env_var_changed_old_none: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::features_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::forced: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fresh_build: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_checksum: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_env: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_failed_to_read_metadata: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_file_size_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_missing_checksum: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_missing_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale_dep_fingerprint: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale_dependency: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_unable_to_read_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::local_fingerprint_type_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::nothing_obvious: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::number_of_dependencies_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rerun_if_changed_output_paths_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rustc_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rustflags_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::unit_dependency_info_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::unit_dependency_name_changed: [missing] -> pass (J0)
  • dep_info::no_trailing_separator_after_package_root_build_script: [missing] -> pass (J0)
  • dep_info::no_trailing_separator_after_package_root_proc_macro: [missing] -> ignore (proc_macro::tracked_path is unstable) (J0)
  • install::cli_root_argument_without_deprecation_warning: [missing] -> pass (J0)
  • install::relative_install_location_with_path_set: [missing] -> pass (J0)
  • install::relative_install_location_with_trailing_slash: [missing] -> pass (J0)
  • install::relative_install_location_without_trailing_slash: [missing] -> pass (J0)
  • metabuild::metabuild_build_plan: pass -> [missing] (J0)
  • progress::plain_string_when_doesnt_work: [missing] -> pass (J0)
  • warning_override::hard_warning_allow: [missing] -> pass (J0)
  • warning_override::hard_warning_deny: [missing] -> pass (J0)
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 4e0baae06da3c29210ba3620db5b01bcb5aba38a --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. aarch64-apple: 7051.7s -> 10050.2s (+42.5%)
  2. dist-x86_64-apple: 5730.7s -> 7970.4s (+39.1%)
  3. pr-check-1: 1708.8s -> 1924.4s (+12.6%)
  4. dist-apple-various: 4533.5s -> 3978.8s (-12.2%)
  5. i686-gnu-2: 6186.8s -> 5457.2s (-11.8%)
  6. x86_64-gnu-llvm-20: 2881.1s -> 2555.9s (-11.3%)
  7. x86_64-gnu-llvm-21-2: 5504.7s -> 6028.0s (+9.5%)
  8. x86_64-msvc-ext2: 5400.4s -> 5892.6s (+9.1%)
  9. x86_64-gnu-llvm-20-3: 6232.6s -> 6777.2s (+8.7%)
  10. dist-x86_64-musl: 7687.6s -> 7028.9s (-8.6%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (4e0baae): comparison URL.
Overall result: ❌ regressions - please read the text below
Our benchmarks found a performance regression caused by this PR.

This might be an actual regression, but it can also be just noise.
Next Steps:
  • If the regression was expected or you think it can be justified,
    
please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    
a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    
were already notified of this PR).
@rustbot label: +perf-regression

cc @rust-lang/wg-compiler-performance
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		2.9%[2.9%, 2.9%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)2.9%[2.9%, 2.9%]1
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (secondary 3.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		3.8%[2.5%, 6.5%]3
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Binary size
Results (primary 1.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		1.1%[1.1%, 1.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)1.1%[1.1%, 1.1%]1
Bootstrap: 475.105s -> 477.474s (0.50%)
Artifact size: 390.80 MiB -> 390.94 MiB (0.04%)
@rustbotrustbot
added
the 
perf-regression
Performance regression.
label
Nov 8, 2025
@lqd
lqd
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
Usual clap_derive periodic noise
@rustbot label: +perf-regression-triaged
@rustbotrustbot
added
the 
perf-regression-triaged
The performance regression has been triaged.
label
Nov 8, 2025
@weihanglo
weihanglo
deleted the

update-cargo

branch
November 8, 2025 08:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.perf-regressionPerformance regression.perf-regression-triagedThe performance regression has been triaged.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@weihanglo@rustbot@rust-log-analyzer@bors@rust-timer@lqd

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update cargo submodule - #148674
Merged
bors merged 1 commit into
rust-lang:masterfrom 
weihanglo:update-cargo
Nov 8, 2025
Merged
Update cargo submodule#148674
bors merged 1 commit into
rust-lang:masterfrom 
weihanglo:update-cargo
Conversation
@weihanglo
@weihangloweihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

Member
22 commits in 6368002885a04cbeae39a82cf5118f941559a40a..445fe4a68f469bf936b2fd81de2c503b233a7f4f

2025-10-31 14:31:52 +0000 to 2025-11-07 18:08:19 +0000
r? ghost
@rustbot
rustbot
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
Some changes occurred in src/tools/cargo
cc @ehuss
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 7, 2025
@rustbot
rustbot
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@rust-log-analyzer
rust-log-analyzer
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
The job tidy failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
spellchecking files
building external tool typos from package typos-cli@1.38.1
finished building tool typos
npm WARN deprecated puppeteer@22.15.0: < 24.10.2 is no longer supported
npm ERR! code 127
npm ERR! git dep preparation failed
npm ERR! command /node/bin/node /node/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/home/user/.npm --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
npm ERR! npm WARN using --force Recommended protections disabled.
npm ERR! npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs
npm ERR! npm WARN deprecated debuglog@1.0.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm ERR! npm WARN deprecated read-package-json@2.1.2: This package is no longer supported. Please use @npmcli/package-json instead.
npm ERR! npm WARN deprecated read-installed@4.0.3: This package is no longer supported.
npm ERR! npm ERR! code 127
npm ERR! npm ERR! path /home/user/.npm/_cacache/tmp/git-cloneXXXXXXfei8Ol/node_modules/rollup
npm ERR! npm ERR! command failed
npm ERR! npm ERR! command sh -c patch-package
npm ERR! npm ERR! sh: 1: patch-package: not found
npm ERR! npm ERR! npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T21_39_50_196Z-debug-0.log
npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T21_39_43_747Z-debug-0.log
npm install did not exit successfully
tidy [extra_checks]: IO error: npm install returned exit code exit status: 127
tidy [extra_checks]: FAIL
tidy: The following check failed: extra_checks
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1549:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1279:29
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:02:49
local time: Fri Nov 7 21:40:11 UTC 2025
network time: Fri, 07 Nov 2025 21:40:11 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=1
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 2bd3508 has been approved by weihanglo
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 7, 2025
@weihanglo
weihanglo
commented
Nov 7, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
On no the check failed
@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r-
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 7, 2025
@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=1
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 2bd3508 has been approved by weihanglo
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 7, 2025
@bors
bors
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 2bd3508 with merge 4e0baae...
@bors
bors
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: weihanglo

Pushing 4e0baae to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 8, 2025
@bors
bors
merged commit 4e0baae
into
rust-lang:masterNov 8, 2025

22 of 23 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 8, 2025
@github-actions
github-actionsBot
commented
Nov 8, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ceb7df7 (parent) -> 4e0baae (this PR)
Test differences
Show 49 test diffs

Stage 2
  • build_analysis::log_rebuild_reason_file_changed: [missing] -> pass (J0)
  • build_analysis::log_rebuild_reason_fresh_build: [missing] -> pass (J0)
  • build_analysis::log_rebuild_reason_no_rebuild: [missing] -> pass (J0)
  • build_plan::build_plan_with_dev_dep: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_build_script: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_simple: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_single_dep: pass -> [missing] (J0)
  • config::nonmergable_lists: pass -> [missing] (J0)
  • config::nonmergeable_lists: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::checksum_use_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::dep_info_output_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::env_var_changed_both_some: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::env_var_changed_old_none: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::features_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::forced: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fresh_build: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_checksum: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_env: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_failed_to_read_metadata: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_file_size_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_missing_checksum: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_missing_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale_dep_fingerprint: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale_dependency: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_unable_to_read_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::local_fingerprint_type_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::nothing_obvious: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::number_of_dependencies_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rerun_if_changed_output_paths_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rustc_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rustflags_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::unit_dependency_info_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::unit_dependency_name_changed: [missing] -> pass (J0)
  • dep_info::no_trailing_separator_after_package_root_build_script: [missing] -> pass (J0)
  • dep_info::no_trailing_separator_after_package_root_proc_macro: [missing] -> ignore (proc_macro::tracked_path is unstable) (J0)
  • install::cli_root_argument_without_deprecation_warning: [missing] -> pass (J0)
  • install::relative_install_location_with_path_set: [missing] -> pass (J0)
  • install::relative_install_location_with_trailing_slash: [missing] -> pass (J0)
  • install::relative_install_location_without_trailing_slash: [missing] -> pass (J0)
  • metabuild::metabuild_build_plan: pass -> [missing] (J0)
  • progress::plain_string_when_doesnt_work: [missing] -> pass (J0)
  • warning_override::hard_warning_allow: [missing] -> pass (J0)
  • warning_override::hard_warning_deny: [missing] -> pass (J0)
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 4e0baae06da3c29210ba3620db5b01bcb5aba38a --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. aarch64-apple: 7051.7s -> 10050.2s (+42.5%)
  2. dist-x86_64-apple: 5730.7s -> 7970.4s (+39.1%)
  3. pr-check-1: 1708.8s -> 1924.4s (+12.6%)
  4. dist-apple-various: 4533.5s -> 3978.8s (-12.2%)
  5. i686-gnu-2: 6186.8s -> 5457.2s (-11.8%)
  6. x86_64-gnu-llvm-20: 2881.1s -> 2555.9s (-11.3%)
  7. x86_64-gnu-llvm-21-2: 5504.7s -> 6028.0s (+9.5%)
  8. x86_64-msvc-ext2: 5400.4s -> 5892.6s (+9.1%)
  9. x86_64-gnu-llvm-20-3: 6232.6s -> 6777.2s (+8.7%)
  10. dist-x86_64-musl: 7687.6s -> 7028.9s (-8.6%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (4e0baae): comparison URL.
Overall result: ❌ regressions - please read the text below
Our benchmarks found a performance regression caused by this PR.

This might be an actual regression, but it can also be just noise.
Next Steps:
  • If the regression was expected or you think it can be justified,
    
please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    
a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    
were already notified of this PR).
@rustbot label: +perf-regression

cc @rust-lang/wg-compiler-performance
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		2.9%[2.9%, 2.9%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)2.9%[2.9%, 2.9%]1
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (secondary 3.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		3.8%[2.5%, 6.5%]3
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Binary size
Results (primary 1.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		1.1%[1.1%, 1.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)1.1%[1.1%, 1.1%]1
Bootstrap: 475.105s -> 477.474s (0.50%)
Artifact size: 390.80 MiB -> 390.94 MiB (0.04%)
@rustbotrustbot
added
the 
perf-regression
Performance regression.
label
Nov 8, 2025
@lqd
lqd
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
Usual clap_derive periodic noise
@rustbot label: +perf-regression-triaged
@rustbotrustbot
added
the 
perf-regression-triaged
The performance regression has been triaged.
label
Nov 8, 2025
@weihanglo
weihanglo
deleted the

update-cargo

branch
November 8, 2025 08:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.perf-regressionPerformance regression.perf-regression-triagedThe performance regression has been triaged.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@weihanglo@rustbot@rust-log-analyzer@bors@rust-timer@lqd

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update cargo submodule - #148674
Merged
bors merged 1 commit into
rust-lang:masterfrom 
weihanglo:update-cargo
Nov 8, 2025
Merged
Update cargo submodule#148674
bors merged 1 commit into
rust-lang:masterfrom 
weihanglo:update-cargo
Conversation
@weihanglo
@weihangloweihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

Member
22 commits in 6368002885a04cbeae39a82cf5118f941559a40a..445fe4a68f469bf936b2fd81de2c503b233a7f4f

2025-10-31 14:31:52 +0000 to 2025-11-07 18:08:19 +0000
r? ghost
@rustbot
rustbot
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
Some changes occurred in src/tools/cargo
cc @ehuss
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 7, 2025
@rustbot
rustbot
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@rust-log-analyzer
rust-log-analyzer
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
The job tidy failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
spellchecking files
building external tool typos from package typos-cli@1.38.1
finished building tool typos
npm WARN deprecated puppeteer@22.15.0: < 24.10.2 is no longer supported
npm ERR! code 127
npm ERR! git dep preparation failed
npm ERR! command /node/bin/node /node/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/home/user/.npm --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
npm ERR! npm WARN using --force Recommended protections disabled.
npm ERR! npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs
npm ERR! npm WARN deprecated debuglog@1.0.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm ERR! npm WARN deprecated read-package-json@2.1.2: This package is no longer supported. Please use @npmcli/package-json instead.
npm ERR! npm WARN deprecated read-installed@4.0.3: This package is no longer supported.
npm ERR! npm ERR! code 127
npm ERR! npm ERR! path /home/user/.npm/_cacache/tmp/git-cloneXXXXXXfei8Ol/node_modules/rollup
npm ERR! npm ERR! command failed
npm ERR! npm ERR! command sh -c patch-package
npm ERR! npm ERR! sh: 1: patch-package: not found
npm ERR! npm ERR! npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T21_39_50_196Z-debug-0.log
npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T21_39_43_747Z-debug-0.log
npm install did not exit successfully
tidy [extra_checks]: IO error: npm install returned exit code exit status: 127
tidy [extra_checks]: FAIL
tidy: The following check failed: extra_checks
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1549:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1279:29
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:02:49
local time: Fri Nov 7 21:40:11 UTC 2025
network time: Fri, 07 Nov 2025 21:40:11 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=1
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 2bd3508 has been approved by weihanglo
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 7, 2025
@weihanglo
weihanglo
commented
Nov 7, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
On no the check failed
@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r-
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 7, 2025
@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=1
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 2bd3508 has been approved by weihanglo
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 7, 2025
@bors
bors
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 2bd3508 with merge 4e0baae...
@bors
bors
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: weihanglo

Pushing 4e0baae to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 8, 2025
@bors
bors
merged commit 4e0baae
into
rust-lang:masterNov 8, 2025

22 of 23 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 8, 2025
@github-actions
github-actionsBot
commented
Nov 8, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ceb7df7 (parent) -> 4e0baae (this PR)
Test differences
Show 49 test diffs

Stage 2
  • build_analysis::log_rebuild_reason_file_changed: [missing] -> pass (J0)
  • build_analysis::log_rebuild_reason_fresh_build: [missing] -> pass (J0)
  • build_analysis::log_rebuild_reason_no_rebuild: [missing] -> pass (J0)
  • build_plan::build_plan_with_dev_dep: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_build_script: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_simple: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_single_dep: pass -> [missing] (J0)
  • config::nonmergable_lists: pass -> [missing] (J0)
  • config::nonmergeable_lists: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::checksum_use_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::dep_info_output_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::env_var_changed_both_some: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::env_var_changed_old_none: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::features_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::forced: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fresh_build: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_checksum: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_env: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_failed_to_read_metadata: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_file_size_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_missing_checksum: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_missing_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale_dep_fingerprint: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale_dependency: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_unable_to_read_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::local_fingerprint_type_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::nothing_obvious: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::number_of_dependencies_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rerun_if_changed_output_paths_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rustc_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rustflags_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::unit_dependency_info_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::unit_dependency_name_changed: [missing] -> pass (J0)
  • dep_info::no_trailing_separator_after_package_root_build_script: [missing] -> pass (J0)
  • dep_info::no_trailing_separator_after_package_root_proc_macro: [missing] -> ignore (proc_macro::tracked_path is unstable) (J0)
  • install::cli_root_argument_without_deprecation_warning: [missing] -> pass (J0)
  • install::relative_install_location_with_path_set: [missing] -> pass (J0)
  • install::relative_install_location_with_trailing_slash: [missing] -> pass (J0)
  • install::relative_install_location_without_trailing_slash: [missing] -> pass (J0)
  • metabuild::metabuild_build_plan: pass -> [missing] (J0)
  • progress::plain_string_when_doesnt_work: [missing] -> pass (J0)
  • warning_override::hard_warning_allow: [missing] -> pass (J0)
  • warning_override::hard_warning_deny: [missing] -> pass (J0)
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 4e0baae06da3c29210ba3620db5b01bcb5aba38a --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. aarch64-apple: 7051.7s -> 10050.2s (+42.5%)
  2. dist-x86_64-apple: 5730.7s -> 7970.4s (+39.1%)
  3. pr-check-1: 1708.8s -> 1924.4s (+12.6%)
  4. dist-apple-various: 4533.5s -> 3978.8s (-12.2%)
  5. i686-gnu-2: 6186.8s -> 5457.2s (-11.8%)
  6. x86_64-gnu-llvm-20: 2881.1s -> 2555.9s (-11.3%)
  7. x86_64-gnu-llvm-21-2: 5504.7s -> 6028.0s (+9.5%)
  8. x86_64-msvc-ext2: 5400.4s -> 5892.6s (+9.1%)
  9. x86_64-gnu-llvm-20-3: 6232.6s -> 6777.2s (+8.7%)
  10. dist-x86_64-musl: 7687.6s -> 7028.9s (-8.6%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (4e0baae): comparison URL.
Overall result: ❌ regressions - please read the text below
Our benchmarks found a performance regression caused by this PR.

This might be an actual regression, but it can also be just noise.
Next Steps:
  • If the regression was expected or you think it can be justified,
    
please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    
a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    
were already notified of this PR).
@rustbot label: +perf-regression

cc @rust-lang/wg-compiler-performance
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		2.9%[2.9%, 2.9%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)2.9%[2.9%, 2.9%]1
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (secondary 3.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		3.8%[2.5%, 6.5%]3
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Binary size
Results (primary 1.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		1.1%[1.1%, 1.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)1.1%[1.1%, 1.1%]1
Bootstrap: 475.105s -> 477.474s (0.50%)
Artifact size: 390.80 MiB -> 390.94 MiB (0.04%)
@rustbotrustbot
added
the 
perf-regression
Performance regression.
label
Nov 8, 2025
@lqd
lqd
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
Usual clap_derive periodic noise
@rustbot label: +perf-regression-triaged
@rustbotrustbot
added
the 
perf-regression-triaged
The performance regression has been triaged.
label
Nov 8, 2025
@weihanglo
weihanglo
deleted the

update-cargo

branch
November 8, 2025 08:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.perf-regressionPerformance regression.perf-regression-triagedThe performance regression has been triaged.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@weihanglo@rustbot@rust-log-analyzer@bors@rust-timer@lqd

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Update cargo submodule - #148674
Merged
bors merged 1 commit into
rust-lang:masterfrom 
weihanglo:update-cargo
Nov 8, 2025
Merged
Update cargo submodule#148674
bors merged 1 commit into
rust-lang:masterfrom 
weihanglo:update-cargo
Conversation
@weihanglo
@weihangloweihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

Member
22 commits in 6368002885a04cbeae39a82cf5118f941559a40a..445fe4a68f469bf936b2fd81de2c503b233a7f4f

2025-10-31 14:31:52 +0000 to 2025-11-07 18:08:19 +0000
r? ghost
@rustbot
rustbot
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
Some changes occurred in src/tools/cargo
cc @ehuss
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 7, 2025
@rustbot
rustbot
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@rust-log-analyzer
rust-log-analyzer
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
The job tidy failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
spellchecking files
building external tool typos from package typos-cli@1.38.1
finished building tool typos
npm WARN deprecated puppeteer@22.15.0: < 24.10.2 is no longer supported
npm ERR! code 127
npm ERR! git dep preparation failed
npm ERR! command /node/bin/node /node/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/home/user/.npm --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
npm ERR! npm WARN using --force Recommended protections disabled.
npm ERR! npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs
npm ERR! npm WARN deprecated debuglog@1.0.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm ERR! npm WARN deprecated read-package-json@2.1.2: This package is no longer supported. Please use @npmcli/package-json instead.
npm ERR! npm WARN deprecated read-installed@4.0.3: This package is no longer supported.
npm ERR! npm ERR! code 127
npm ERR! npm ERR! path /home/user/.npm/_cacache/tmp/git-cloneXXXXXXfei8Ol/node_modules/rollup
npm ERR! npm ERR! command failed
npm ERR! npm ERR! command sh -c patch-package
npm ERR! npm ERR! sh: 1: patch-package: not found
npm ERR! npm ERR! npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T21_39_50_196Z-debug-0.log
npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T21_39_43_747Z-debug-0.log
npm install did not exit successfully
tidy [extra_checks]: IO error: npm install returned exit code exit status: 127
tidy [extra_checks]: FAIL
tidy: The following check failed: extra_checks
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1549:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1279:29
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:02:49
local time: Fri Nov 7 21:40:11 UTC 2025
network time: Fri, 07 Nov 2025 21:40:11 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=1
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 2bd3508 has been approved by weihanglo
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 7, 2025
@weihanglo
weihanglo
commented
Nov 7, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
On no the check failed
@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r-
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 7, 2025
@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=1
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 2bd3508 has been approved by weihanglo
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 7, 2025
@bors
bors
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 2bd3508 with merge 4e0baae...
@bors
bors
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: weihanglo

Pushing 4e0baae to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 8, 2025
@bors
bors
merged commit 4e0baae
into
rust-lang:masterNov 8, 2025

22 of 23 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 8, 2025
@github-actions
github-actionsBot
commented
Nov 8, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ceb7df7 (parent) -> 4e0baae (this PR)
Test differences
Show 49 test diffs

Stage 2
  • build_analysis::log_rebuild_reason_file_changed: [missing] -> pass (J0)
  • build_analysis::log_rebuild_reason_fresh_build: [missing] -> pass (J0)
  • build_analysis::log_rebuild_reason_no_rebuild: [missing] -> pass (J0)
  • build_plan::build_plan_with_dev_dep: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_build_script: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_simple: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_single_dep: pass -> [missing] (J0)
  • config::nonmergable_lists: pass -> [missing] (J0)
  • config::nonmergeable_lists: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::checksum_use_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::dep_info_output_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::env_var_changed_both_some: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::env_var_changed_old_none: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::features_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::forced: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fresh_build: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_checksum: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_env: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_failed_to_read_metadata: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_file_size_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_missing_checksum: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_missing_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale_dep_fingerprint: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale_dependency: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_unable_to_read_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::local_fingerprint_type_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::nothing_obvious: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::number_of_dependencies_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rerun_if_changed_output_paths_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rustc_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rustflags_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::unit_dependency_info_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::unit_dependency_name_changed: [missing] -> pass (J0)
  • dep_info::no_trailing_separator_after_package_root_build_script: [missing] -> pass (J0)
  • dep_info::no_trailing_separator_after_package_root_proc_macro: [missing] -> ignore (proc_macro::tracked_path is unstable) (J0)
  • install::cli_root_argument_without_deprecation_warning: [missing] -> pass (J0)
  • install::relative_install_location_with_path_set: [missing] -> pass (J0)
  • install::relative_install_location_with_trailing_slash: [missing] -> pass (J0)
  • install::relative_install_location_without_trailing_slash: [missing] -> pass (J0)
  • metabuild::metabuild_build_plan: pass -> [missing] (J0)
  • progress::plain_string_when_doesnt_work: [missing] -> pass (J0)
  • warning_override::hard_warning_allow: [missing] -> pass (J0)
  • warning_override::hard_warning_deny: [missing] -> pass (J0)
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 4e0baae06da3c29210ba3620db5b01bcb5aba38a --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. aarch64-apple: 7051.7s -> 10050.2s (+42.5%)
  2. dist-x86_64-apple: 5730.7s -> 7970.4s (+39.1%)
  3. pr-check-1: 1708.8s -> 1924.4s (+12.6%)
  4. dist-apple-various: 4533.5s -> 3978.8s (-12.2%)
  5. i686-gnu-2: 6186.8s -> 5457.2s (-11.8%)
  6. x86_64-gnu-llvm-20: 2881.1s -> 2555.9s (-11.3%)
  7. x86_64-gnu-llvm-21-2: 5504.7s -> 6028.0s (+9.5%)
  8. x86_64-msvc-ext2: 5400.4s -> 5892.6s (+9.1%)
  9. x86_64-gnu-llvm-20-3: 6232.6s -> 6777.2s (+8.7%)
  10. dist-x86_64-musl: 7687.6s -> 7028.9s (-8.6%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (4e0baae): comparison URL.
Overall result: ❌ regressions - please read the text below
Our benchmarks found a performance regression caused by this PR.

This might be an actual regression, but it can also be just noise.
Next Steps:
  • If the regression was expected or you think it can be justified,
    
please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    
a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    
were already notified of this PR).
@rustbot label: +perf-regression

cc @rust-lang/wg-compiler-performance
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		2.9%[2.9%, 2.9%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)2.9%[2.9%, 2.9%]1
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (secondary 3.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		3.8%[2.5%, 6.5%]3
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Binary size
Results (primary 1.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		1.1%[1.1%, 1.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)1.1%[1.1%, 1.1%]1
Bootstrap: 475.105s -> 477.474s (0.50%)
Artifact size: 390.80 MiB -> 390.94 MiB (0.04%)
@rustbotrustbot
added
the 
perf-regression
Performance regression.
label
Nov 8, 2025
@lqd
lqd
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
Usual clap_derive periodic noise
@rustbot label: +perf-regression-triaged
@rustbotrustbot
added
the 
perf-regression-triaged
The performance regression has been triaged.
label
Nov 8, 2025
@weihanglo
weihanglo
deleted the

update-cargo

branch
November 8, 2025 08:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.perf-regressionPerformance regression.perf-regression-triagedThe performance regression has been triaged.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@weihanglo@rustbot@rust-log-analyzer@bors@rust-timer@lqd

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update cargo submodule - #148674
Merged
bors merged 1 commit into
rust-lang:masterfrom 
weihanglo:update-cargo
Nov 8, 2025
Merged
Update cargo submodule#148674
bors merged 1 commit into
rust-lang:masterfrom 
weihanglo:update-cargo
Conversation
@weihanglo
@weihangloweihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

Member
22 commits in 6368002885a04cbeae39a82cf5118f941559a40a..445fe4a68f469bf936b2fd81de2c503b233a7f4f

2025-10-31 14:31:52 +0000 to 2025-11-07 18:08:19 +0000
r? ghost
@rustbot
rustbot
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
Some changes occurred in src/tools/cargo
cc @ehuss
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 7, 2025
@rustbot
rustbot
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@rust-log-analyzer
rust-log-analyzer
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
The job tidy failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
spellchecking files
building external tool typos from package typos-cli@1.38.1
finished building tool typos
npm WARN deprecated puppeteer@22.15.0: < 24.10.2 is no longer supported
npm ERR! code 127
npm ERR! git dep preparation failed
npm ERR! command /node/bin/node /node/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/home/user/.npm --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
npm ERR! npm WARN using --force Recommended protections disabled.
npm ERR! npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs
npm ERR! npm WARN deprecated debuglog@1.0.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm ERR! npm WARN deprecated read-package-json@2.1.2: This package is no longer supported. Please use @npmcli/package-json instead.
npm ERR! npm WARN deprecated read-installed@4.0.3: This package is no longer supported.
npm ERR! npm ERR! code 127
npm ERR! npm ERR! path /home/user/.npm/_cacache/tmp/git-cloneXXXXXXfei8Ol/node_modules/rollup
npm ERR! npm ERR! command failed
npm ERR! npm ERR! command sh -c patch-package
npm ERR! npm ERR! sh: 1: patch-package: not found
npm ERR! npm ERR! npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T21_39_50_196Z-debug-0.log
npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T21_39_43_747Z-debug-0.log
npm install did not exit successfully
tidy [extra_checks]: IO error: npm install returned exit code exit status: 127
tidy [extra_checks]: FAIL
tidy: The following check failed: extra_checks
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1549:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1279:29
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:02:49
local time: Fri Nov 7 21:40:11 UTC 2025
network time: Fri, 07 Nov 2025 21:40:11 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=1
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 2bd3508 has been approved by weihanglo
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 7, 2025
@weihanglo
weihanglo
commented
Nov 7, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
On no the check failed
@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r-
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 7, 2025
@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=1
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 2bd3508 has been approved by weihanglo
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 7, 2025
@bors
bors
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 2bd3508 with merge 4e0baae...
@bors
bors
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: weihanglo

Pushing 4e0baae to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 8, 2025
@bors
bors
merged commit 4e0baae
into
rust-lang:masterNov 8, 2025

22 of 23 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 8, 2025
@github-actions
github-actionsBot
commented
Nov 8, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ceb7df7 (parent) -> 4e0baae (this PR)
Test differences
Show 49 test diffs

Stage 2
  • build_analysis::log_rebuild_reason_file_changed: [missing] -> pass (J0)
  • build_analysis::log_rebuild_reason_fresh_build: [missing] -> pass (J0)
  • build_analysis::log_rebuild_reason_no_rebuild: [missing] -> pass (J0)
  • build_plan::build_plan_with_dev_dep: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_build_script: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_simple: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_single_dep: pass -> [missing] (J0)
  • config::nonmergable_lists: pass -> [missing] (J0)
  • config::nonmergeable_lists: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::checksum_use_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::dep_info_output_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::env_var_changed_both_some: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::env_var_changed_old_none: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::features_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::forced: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fresh_build: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_checksum: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_env: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_failed_to_read_metadata: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_file_size_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_missing_checksum: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_missing_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale_dep_fingerprint: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale_dependency: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_unable_to_read_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::local_fingerprint_type_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::nothing_obvious: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::number_of_dependencies_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rerun_if_changed_output_paths_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rustc_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rustflags_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::unit_dependency_info_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::unit_dependency_name_changed: [missing] -> pass (J0)
  • dep_info::no_trailing_separator_after_package_root_build_script: [missing] -> pass (J0)
  • dep_info::no_trailing_separator_after_package_root_proc_macro: [missing] -> ignore (proc_macro::tracked_path is unstable) (J0)
  • install::cli_root_argument_without_deprecation_warning: [missing] -> pass (J0)
  • install::relative_install_location_with_path_set: [missing] -> pass (J0)
  • install::relative_install_location_with_trailing_slash: [missing] -> pass (J0)
  • install::relative_install_location_without_trailing_slash: [missing] -> pass (J0)
  • metabuild::metabuild_build_plan: pass -> [missing] (J0)
  • progress::plain_string_when_doesnt_work: [missing] -> pass (J0)
  • warning_override::hard_warning_allow: [missing] -> pass (J0)
  • warning_override::hard_warning_deny: [missing] -> pass (J0)
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 4e0baae06da3c29210ba3620db5b01bcb5aba38a --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. aarch64-apple: 7051.7s -> 10050.2s (+42.5%)
  2. dist-x86_64-apple: 5730.7s -> 7970.4s (+39.1%)
  3. pr-check-1: 1708.8s -> 1924.4s (+12.6%)
  4. dist-apple-various: 4533.5s -> 3978.8s (-12.2%)
  5. i686-gnu-2: 6186.8s -> 5457.2s (-11.8%)
  6. x86_64-gnu-llvm-20: 2881.1s -> 2555.9s (-11.3%)
  7. x86_64-gnu-llvm-21-2: 5504.7s -> 6028.0s (+9.5%)
  8. x86_64-msvc-ext2: 5400.4s -> 5892.6s (+9.1%)
  9. x86_64-gnu-llvm-20-3: 6232.6s -> 6777.2s (+8.7%)
  10. dist-x86_64-musl: 7687.6s -> 7028.9s (-8.6%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (4e0baae): comparison URL.
Overall result: ❌ regressions - please read the text below
Our benchmarks found a performance regression caused by this PR.

This might be an actual regression, but it can also be just noise.
Next Steps:
  • If the regression was expected or you think it can be justified,
    
please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    
a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    
were already notified of this PR).
@rustbot label: +perf-regression

cc @rust-lang/wg-compiler-performance
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		2.9%[2.9%, 2.9%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)2.9%[2.9%, 2.9%]1
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (secondary 3.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		3.8%[2.5%, 6.5%]3
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Binary size
Results (primary 1.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		1.1%[1.1%, 1.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)1.1%[1.1%, 1.1%]1
Bootstrap: 475.105s -> 477.474s (0.50%)
Artifact size: 390.80 MiB -> 390.94 MiB (0.04%)
@rustbotrustbot
added
the 
perf-regression
Performance regression.
label
Nov 8, 2025
@lqd
lqd
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
Usual clap_derive periodic noise
@rustbot label: +perf-regression-triaged
@rustbotrustbot
added
the 
perf-regression-triaged
The performance regression has been triaged.
label
Nov 8, 2025
@weihanglo
weihanglo
deleted the

update-cargo

branch
November 8, 2025 08:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.perf-regressionPerformance regression.perf-regression-triagedThe performance regression has been triaged.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@weihanglo@rustbot@rust-log-analyzer@bors@rust-timer@lqd

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Update cargo submodule - #148674
Merged
bors merged 1 commit into
rust-lang:masterfrom 
weihanglo:update-cargo
Nov 8, 2025
Merged
Update cargo submodule#148674
bors merged 1 commit into
rust-lang:masterfrom 
weihanglo:update-cargo
Conversation
@weihanglo
@weihangloweihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

Member
22 commits in 6368002885a04cbeae39a82cf5118f941559a40a..445fe4a68f469bf936b2fd81de2c503b233a7f4f

2025-10-31 14:31:52 +0000 to 2025-11-07 18:08:19 +0000
r? ghost
@rustbot
rustbot
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
Some changes occurred in src/tools/cargo
cc @ehuss
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 7, 2025
@rustbot
rustbot
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@rust-log-analyzer
rust-log-analyzer
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
The job tidy failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
spellchecking files
building external tool typos from package typos-cli@1.38.1
finished building tool typos
npm WARN deprecated puppeteer@22.15.0: < 24.10.2 is no longer supported
npm ERR! code 127
npm ERR! git dep preparation failed
npm ERR! command /node/bin/node /node/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/home/user/.npm --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
npm ERR! npm WARN using --force Recommended protections disabled.
npm ERR! npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs
npm ERR! npm WARN deprecated debuglog@1.0.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm ERR! npm WARN deprecated read-package-json@2.1.2: This package is no longer supported. Please use @npmcli/package-json instead.
npm ERR! npm WARN deprecated read-installed@4.0.3: This package is no longer supported.
npm ERR! npm ERR! code 127
npm ERR! npm ERR! path /home/user/.npm/_cacache/tmp/git-cloneXXXXXXfei8Ol/node_modules/rollup
npm ERR! npm ERR! command failed
npm ERR! npm ERR! command sh -c patch-package
npm ERR! npm ERR! sh: 1: patch-package: not found
npm ERR! npm ERR! npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T21_39_50_196Z-debug-0.log
npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T21_39_43_747Z-debug-0.log
npm install did not exit successfully
tidy [extra_checks]: IO error: npm install returned exit code exit status: 127
tidy [extra_checks]: FAIL
tidy: The following check failed: extra_checks
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1549:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1279:29
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:02:49
local time: Fri Nov 7 21:40:11 UTC 2025
network time: Fri, 07 Nov 2025 21:40:11 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=1
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 2bd3508 has been approved by weihanglo
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 7, 2025
@weihanglo
weihanglo
commented
Nov 7, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
On no the check failed
@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r-
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 7, 2025
@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=1
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 2bd3508 has been approved by weihanglo
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 7, 2025
@bors
bors
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 2bd3508 with merge 4e0baae...
@bors
bors
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: weihanglo

Pushing 4e0baae to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 8, 2025
@bors
bors
merged commit 4e0baae
into
rust-lang:masterNov 8, 2025

22 of 23 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 8, 2025
@github-actions
github-actionsBot
commented
Nov 8, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ceb7df7 (parent) -> 4e0baae (this PR)
Test differences
Show 49 test diffs

Stage 2
  • build_analysis::log_rebuild_reason_file_changed: [missing] -> pass (J0)
  • build_analysis::log_rebuild_reason_fresh_build: [missing] -> pass (J0)
  • build_analysis::log_rebuild_reason_no_rebuild: [missing] -> pass (J0)
  • build_plan::build_plan_with_dev_dep: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_build_script: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_simple: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_single_dep: pass -> [missing] (J0)
  • config::nonmergable_lists: pass -> [missing] (J0)
  • config::nonmergeable_lists: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::checksum_use_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::dep_info_output_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::env_var_changed_both_some: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::env_var_changed_old_none: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::features_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::forced: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fresh_build: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_checksum: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_env: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_failed_to_read_metadata: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_file_size_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_missing_checksum: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_missing_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale_dep_fingerprint: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale_dependency: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_unable_to_read_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::local_fingerprint_type_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::nothing_obvious: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::number_of_dependencies_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rerun_if_changed_output_paths_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rustc_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rustflags_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::unit_dependency_info_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::unit_dependency_name_changed: [missing] -> pass (J0)
  • dep_info::no_trailing_separator_after_package_root_build_script: [missing] -> pass (J0)
  • dep_info::no_trailing_separator_after_package_root_proc_macro: [missing] -> ignore (proc_macro::tracked_path is unstable) (J0)
  • install::cli_root_argument_without_deprecation_warning: [missing] -> pass (J0)
  • install::relative_install_location_with_path_set: [missing] -> pass (J0)
  • install::relative_install_location_with_trailing_slash: [missing] -> pass (J0)
  • install::relative_install_location_without_trailing_slash: [missing] -> pass (J0)
  • metabuild::metabuild_build_plan: pass -> [missing] (J0)
  • progress::plain_string_when_doesnt_work: [missing] -> pass (J0)
  • warning_override::hard_warning_allow: [missing] -> pass (J0)
  • warning_override::hard_warning_deny: [missing] -> pass (J0)
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 4e0baae06da3c29210ba3620db5b01bcb5aba38a --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. aarch64-apple: 7051.7s -> 10050.2s (+42.5%)
  2. dist-x86_64-apple: 5730.7s -> 7970.4s (+39.1%)
  3. pr-check-1: 1708.8s -> 1924.4s (+12.6%)
  4. dist-apple-various: 4533.5s -> 3978.8s (-12.2%)
  5. i686-gnu-2: 6186.8s -> 5457.2s (-11.8%)
  6. x86_64-gnu-llvm-20: 2881.1s -> 2555.9s (-11.3%)
  7. x86_64-gnu-llvm-21-2: 5504.7s -> 6028.0s (+9.5%)
  8. x86_64-msvc-ext2: 5400.4s -> 5892.6s (+9.1%)
  9. x86_64-gnu-llvm-20-3: 6232.6s -> 6777.2s (+8.7%)
  10. dist-x86_64-musl: 7687.6s -> 7028.9s (-8.6%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (4e0baae): comparison URL.
Overall result: ❌ regressions - please read the text below
Our benchmarks found a performance regression caused by this PR.

This might be an actual regression, but it can also be just noise.
Next Steps:
  • If the regression was expected or you think it can be justified,
    
please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    
a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    
were already notified of this PR).
@rustbot label: +perf-regression

cc @rust-lang/wg-compiler-performance
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		2.9%[2.9%, 2.9%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)2.9%[2.9%, 2.9%]1
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (secondary 3.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		3.8%[2.5%, 6.5%]3
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Binary size
Results (primary 1.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		1.1%[1.1%, 1.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)1.1%[1.1%, 1.1%]1
Bootstrap: 475.105s -> 477.474s (0.50%)
Artifact size: 390.80 MiB -> 390.94 MiB (0.04%)
@rustbotrustbot
added
the 
perf-regression
Performance regression.
label
Nov 8, 2025
@lqd
lqd
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
Usual clap_derive periodic noise
@rustbot label: +perf-regression-triaged
@rustbotrustbot
added
the 
perf-regression-triaged
The performance regression has been triaged.
label
Nov 8, 2025
@weihanglo
weihanglo
deleted the

update-cargo

branch
November 8, 2025 08:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.perf-regressionPerformance regression.perf-regression-triagedThe performance regression has been triaged.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@weihanglo@rustbot@rust-log-analyzer@bors@rust-timer@lqd

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Update cargo submodule - #148674
Merged
bors merged 1 commit into
rust-lang:masterfrom 
weihanglo:update-cargo
Nov 8, 2025
Merged
Update cargo submodule#148674
bors merged 1 commit into
rust-lang:masterfrom 
weihanglo:update-cargo
Conversation
@weihanglo
@weihangloweihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

Member
22 commits in 6368002885a04cbeae39a82cf5118f941559a40a..445fe4a68f469bf936b2fd81de2c503b233a7f4f

2025-10-31 14:31:52 +0000 to 2025-11-07 18:08:19 +0000
r? ghost
@rustbot
rustbot
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
Some changes occurred in src/tools/cargo
cc @ehuss
@rustbotrustbot
added
the 
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Nov 7, 2025
@rustbot
rustbot
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
⚠️Warning⚠️
@rust-log-analyzer
rust-log-analyzer
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
The job tidy failed! Check out the build log: (web)(plain enhanced)(plain)
Click to see the possible cause of the failure (guessed by this bot)
spellchecking files
building external tool typos from package typos-cli@1.38.1
finished building tool typos
npm WARN deprecated puppeteer@22.15.0: < 24.10.2 is no longer supported
npm ERR! code 127
npm ERR! git dep preparation failed
npm ERR! command /node/bin/node /node/lib/node_modules/npm/bin/npm-cli.js install --force --cache=/home/user/.npm --prefer-offline=false --prefer-online=false --offline=false --no-progress --no-save --no-audit --include=dev --include=peer --include=optional --no-package-lock-only --no-dry-run
npm ERR! npm WARN using --force Recommended protections disabled.
npm ERR! npm WARN deprecated inflight@1.0.6: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated glob@7.2.3: Glob versions prior to v9 are no longer supported
npm ERR! npm WARN deprecated readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs
npm ERR! npm WARN deprecated debuglog@1.0.1: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
npm ERR! npm WARN deprecated read-package-json@2.1.2: This package is no longer supported. Please use @npmcli/package-json instead.
npm ERR! npm WARN deprecated read-installed@4.0.3: This package is no longer supported.
npm ERR! npm ERR! code 127
npm ERR! npm ERR! path /home/user/.npm/_cacache/tmp/git-cloneXXXXXXfei8Ol/node_modules/rollup
npm ERR! npm ERR! command failed
npm ERR! npm ERR! command sh -c patch-package
npm ERR! npm ERR! sh: 1: patch-package: not found
npm ERR! npm ERR! npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T21_39_50_196Z-debug-0.log
npm ERR! A complete log of this run can be found in: /home/user/.npm/_logs/2025-11-07T21_39_43_747Z-debug-0.log
npm install did not exit successfully
tidy [extra_checks]: IO error: npm install returned exit code exit status: 127
tidy [extra_checks]: FAIL
tidy: The following check failed: extra_checks
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy /checkout /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo /checkout/obj/build 4 /node/bin/npm --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1549:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1279:29
Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:02:49
local time: Fri Nov 7 21:40:11 UTC 2025
network time: Fri, 07 Nov 2025 21:40:11 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=1
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 2bd3508 has been approved by weihanglo
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 7, 2025
@weihanglo
weihanglo
commented
Nov 7, 2025•

edited

Loading

Copy link


Copy Markdown

MemberAuthor
On no the check failed
@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r-
@borsbors
added

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
and removed

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
labels
Nov 7, 2025
@weihanglo
weihanglo
commented
Nov 7, 2025

Copy link


Copy Markdown

MemberAuthor
@bors r+ rollup=never p=1
@bors
bors
commented
Nov 7, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit 2bd3508 has been approved by weihanglo
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.
labels
Nov 7, 2025
@bors
bors
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit 2bd3508 with merge 4e0baae...
@bors
bors
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: weihanglo

Pushing 4e0baae to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 8, 2025
@bors
bors
merged commit 4e0baae
into
rust-lang:masterNov 8, 2025

22 of 23 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 8, 2025
@github-actions
github-actionsBot
commented
Nov 8, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ceb7df7 (parent) -> 4e0baae (this PR)
Test differences
Show 49 test diffs

Stage 2
  • build_analysis::log_rebuild_reason_file_changed: [missing] -> pass (J0)
  • build_analysis::log_rebuild_reason_fresh_build: [missing] -> pass (J0)
  • build_analysis::log_rebuild_reason_no_rebuild: [missing] -> pass (J0)
  • build_plan::build_plan_with_dev_dep: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_build_script: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_simple: pass -> [missing] (J0)
  • build_plan::cargo_build_plan_single_dep: pass -> [missing] (J0)
  • config::nonmergable_lists: pass -> [missing] (J0)
  • config::nonmergeable_lists: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::checksum_use_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::dep_info_output_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::env_var_changed_both_some: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::env_var_changed_old_none: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::features_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::forced: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fresh_build: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_checksum: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_env: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_changed_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_failed_to_read_metadata: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_file_size_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_missing_checksum: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_missing_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale_dep_fingerprint: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_stale_dependency: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::fs_status_unable_to_read_file: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::local_fingerprint_type_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::nothing_obvious: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::number_of_dependencies_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rerun_if_changed_output_paths_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rustc_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::rustflags_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::unit_dependency_info_changed: [missing] -> pass (J0)
  • core::compiler::fingerprint::dirty_reason::json_schema::unit_dependency_name_changed: [missing] -> pass (J0)
  • dep_info::no_trailing_separator_after_package_root_build_script: [missing] -> pass (J0)
  • dep_info::no_trailing_separator_after_package_root_proc_macro: [missing] -> ignore (proc_macro::tracked_path is unstable) (J0)
  • install::cli_root_argument_without_deprecation_warning: [missing] -> pass (J0)
  • install::relative_install_location_with_path_set: [missing] -> pass (J0)
  • install::relative_install_location_with_trailing_slash: [missing] -> pass (J0)
  • install::relative_install_location_without_trailing_slash: [missing] -> pass (J0)
  • metabuild::metabuild_build_plan: pass -> [missing] (J0)
  • progress::plain_string_when_doesnt_work: [missing] -> pass (J0)
  • warning_override::hard_warning_allow: [missing] -> pass (J0)
  • warning_override::hard_warning_deny: [missing] -> pass (J0)
Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 4e0baae06da3c29210ba3620db5b01bcb5aba38a --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. aarch64-apple: 7051.7s -> 10050.2s (+42.5%)
  2. dist-x86_64-apple: 5730.7s -> 7970.4s (+39.1%)
  3. pr-check-1: 1708.8s -> 1924.4s (+12.6%)
  4. dist-apple-various: 4533.5s -> 3978.8s (-12.2%)
  5. i686-gnu-2: 6186.8s -> 5457.2s (-11.8%)
  6. x86_64-gnu-llvm-20: 2881.1s -> 2555.9s (-11.3%)
  7. x86_64-gnu-llvm-21-2: 5504.7s -> 6028.0s (+9.5%)
  8. x86_64-msvc-ext2: 5400.4s -> 5892.6s (+9.1%)
  9. x86_64-gnu-llvm-20-3: 6232.6s -> 6777.2s (+8.7%)
  10. dist-x86_64-musl: 7687.6s -> 7028.9s (-8.6%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@rust-timer
rust-timer
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (4e0baae): comparison URL.
Overall result: ❌ regressions - please read the text below
Our benchmarks found a performance regression caused by this PR.

This might be an actual regression, but it can also be just noise.
Next Steps:
  • If the regression was expected or you think it can be justified,
    
please write a comment with sufficient written justification, and add
    @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
  • If you think that you know of a way to resolve the regression, try to create
    
a new PR with a fix for the regression.
  • If you do not understand the regression or you think that it is just noise,
    
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
    
were already notified of this PR).
@rustbot label: +perf-regression

cc @rust-lang/wg-compiler-performance
Instruction count
Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
meanrangecount
Regressions ❌ 
 (primary)		2.9%[2.9%, 2.9%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)2.9%[2.9%, 2.9%]1
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (secondary 3.8%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		--0
Regressions ❌ 
 (secondary)		3.8%[2.5%, 6.5%]3
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)--0
Binary size
Results (primary 1.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		1.1%[1.1%, 1.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)1.1%[1.1%, 1.1%]1
Bootstrap: 475.105s -> 477.474s (0.50%)
Artifact size: 390.80 MiB -> 390.94 MiB (0.04%)
@rustbotrustbot
added
the 
perf-regression
Performance regression.
label
Nov 8, 2025
@lqd
lqd
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
Usual clap_derive periodic noise
@rustbot label: +perf-regression-triaged
@rustbotrustbot
added
the 
perf-regression-triaged
The performance regression has been triaged.
label
Nov 8, 2025
@weihanglo
weihanglo
deleted the

update-cargo

branch
November 8, 2025 08:44
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

merged-by-borsThis PR was explicitly merged by bors.perf-regressionPerformance regression.perf-regression-triagedThe performance regression has been triaged.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@weihanglo@rustbot@rust-log-analyzer@bors@rust-timer@lqd