Skip to content

compiletest: Run the lldb_batchmode.py script in LLDB's embedded Python - #148685

Merged
bors merged 3 commits into
rust-lang:masterfrom
Zalathar:lldb-python
Nov 10, 2025
Merged

compiletest: Run the lldb_batchmode.py script in LLDB's embedded Python#148685
bors merged 3 commits into
rust-lang:masterfrom
Zalathar:lldb-python

Conversation

@Zalathar

@ZalatharZalathar commented Nov 8, 2025

Copy link
Copy Markdown
Member

Historically, LLDB debuginfo tests have used a Python script to control LLDB via its Python API, instead of invoking the lldb command directly.

Unfortunately, this requires us to find and use a version of Python that is compatible with LLDB's Python bindings.

However, it turns out that there is a simpler way to find a compatible Python interpreter: use the one that is embedded in LLDB itself, via the script command.

@rustbot

rustbot commented Nov 8, 2025

Copy link
Copy Markdown
Collaborator

This PR modifies bootstrap.example.toml.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbotrustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 8, 2025
@rustbot

rustbot commented Nov 8, 2025

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@Zalathar

Zalathar commented Nov 8, 2025

Copy link
Copy Markdown
MemberAuthor

Big thanks to @Walnut356 for suggesting the use of LLDB's embedded Python.

cc @jieyouxu@xSetech

This may be a useful alternative to some of the changes proposed in:

r? jieyouxu

@rustbot

rustbot commented Nov 8, 2025

Copy link
Copy Markdown
Collaborator

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

@ZalatharZalathar mentioned this pull request Nov 8, 2025
Merged
@jieyouxu

jieyouxu commented Nov 8, 2025

Copy link
Copy Markdown
Member

@bors try jobs=aarch64-apple

@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot added a commit that referenced this pull request Nov 8, 2025
@rust-bors
Auto merge of#148685- Zalathar:lldb-python, r=<try>
9d85981
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python
try-job: aarch64-apple
@rust-bors

rust-borsBot commented Nov 8, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: 9d85981 (9d85981868d8787740cfbd23500af90eabf8b01e, parent: 4e0baae06da3c29210ba3620db5b01bcb5aba38a)

@Zalathar

Zalathar commented Nov 8, 2025

Copy link
Copy Markdown
MemberAuthor

Pushed a small tweak to explicitly specify that the script is in Python, and not some other language.

Doesn't seem to be needed in practice, but perhaps it will avoid headaches someday.

jieyouxu
jieyouxu approved these changes Nov 9, 2025
View reviewed changes

@jieyouxujieyouxu left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes a lot of sense than trying to figure out some random Python from the environment... I tried this locally and it seems to work. Let's give this a try, at worst we can revert if any cursed issues crop up.

View changes since this review

@jieyouxu

jieyouxu commented Nov 9, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup=never

@bors

bors commented Nov 9, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit dca8be9 has been approved by jieyouxu

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2025
@bors

bors commented Nov 10, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit dca8be9 with merge 00426d6...

@bors

bors commented Nov 10, 2025

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 00426d6 to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Nov 10, 2025
@bors
bors merged commit 00426d6 into rust-lang:masterNov 10, 2025
12 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 10, 2025
@github-actions

github-actionsBot commented Nov 10, 2025

Copy link
Copy Markdown
Contributor
What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5f666a6 (parent) -> 00426d6 (this PR)

Test differences

Show 4 test diffs

Stage 2

  • [run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) -> pass (J0)

Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 00426d642ad6a8c6192bf517702a68b0a8001547 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 2549.4s -> 1468.1s (-42.4%)
  2. x86_64-rust-for-linux: 4160.1s -> 2584.6s (-37.9%)
  3. pr-check-2: 3160.3s -> 2130.4s (-32.6%)
  4. x86_64-gnu-tools: 4881.6s -> 3335.8s (-31.7%)
  5. aarch64-gnu-debug: 5871.7s -> 4025.2s (-31.4%)
  6. x86_64-gnu-debug: 10143.7s -> 6965.4s (-31.3%)
  7. x86_64-gnu-gcc: 4389.4s -> 3072.5s (-30.0%)
  8. dist-aarch64-apple: 5714.9s -> 7342.9s (+28.5%)
  9. armhf-gnu: 6693.1s -> 4910.3s (-26.6%)
  10. arm-android: 7492.2s -> 5538.8s (-26.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@Zalathar
Zalathar deleted the lldb-python branch November 10, 2025 09:12
@rust-timer

rust-timer commented Nov 10, 2025

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (00426d6): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)		2.1%[2.1%, 2.1%]1
Regressions ❌
(secondary)		--0
Improvements ✅
(primary)		--0
Improvements ✅
(secondary)		--0
All ❌✅ (primary)2.1%[2.1%, 2.1%]1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.073s -> 476.293s (0.26%)
Artifact size: 391.33 MiB -> 391.34 MiB (0.00%)

makai410 pushed a commit to makai410/rust that referenced this pull request Dec 10, 2025
@bors
Auto merge ofrust-lang#148685- Zalathar:lldb-python, r=jieyouxu
146999c
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python
Historically, LLDB debuginfo tests have used a Python script to control LLDB via its Python API, instead of invoking the `lldb` command directly.
Unfortunately, this requires us to find and use a version of Python that is compatible with LLDB's Python bindings.
However, it turns out that there is a simpler way to find a compatible Python interpreter: use the one that is embedded in LLDB itself, via the `script` command.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcmerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Zalathar@rustbot@jieyouxu@bors@rust-timer@Mark-Simulacrum
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python by Zalathar · Pull Request #148685 · rust-lang/rust · GitHub
Skip to content
compiletest: Run the lldb_batchmode.py script in LLDB's embedded Python - #148685
Merged
bors merged 3 commits into
rust-lang:masterfrom 
Zalathar:lldb-python
Nov 10, 2025
Merged
compiletest: Run the lldb_batchmode.py script in LLDB's embedded Python#148685
bors merged 3 commits into
rust-lang:masterfrom 
Zalathar:lldb-python
Conversation
@Zalathar
@ZalatharZalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
Historically, LLDB debuginfo tests have used a Python script to control LLDB via its Python API, instead of invoking the lldb command directly.
Unfortunately, this requires us to find and use a version of Python that is compatible with LLDB's Python bindings.
However, it turns out that there is a simpler way to find a compatible Python interpreter: use the one that is embedded in LLDB itself, via the script command.
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
This PR modifies bootstrap.example.toml.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
Some changes occurred in src/tools/compiletest
cc @jieyouxu
@rustbotrustbot
added

A-compiletest
Area: The compiletest test runner
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Nov 8, 2025
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
r? @Mark-Simulacrum
rustbot has assigned @Mark-Simulacrum.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@Zalathar
Zalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

MemberAuthor
Big thanks to @Walnut356 for suggesting the use of LLDB's embedded Python.
cc @jieyouxu@xSetech
This may be a useful alternative to some of the changes proposed in:
r? jieyouxu
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
jieyouxu is currently at their maximum review capacity.

They may take a while to respond.
@ZalatharZalathar
mentioned this pull request
Nov 8, 2025
 Merged

@jieyouxu
jieyouxu
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
@bors try jobs=aarch64-apple
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
added a commit
that referenced
this pull request
Nov 8, 2025
@rust-bors
Auto merge of#148685- Zalathar:lldb-python, r=<try>
9d85981
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python
try-job: aarch64-apple
@rust-bors
rust-borsBot
commented
Nov 8, 2025

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 9d85981 (9d85981868d8787740cfbd23500af90eabf8b01e, parent: 4e0baae06da3c29210ba3620db5b01bcb5aba38a)
@Zalathar
Zalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

MemberAuthor
Pushed a small tweak to explicitly specify that the script is in Python, and not some other language.
Doesn't seem to be needed in practice, but perhaps it will avoid headaches someday.
jieyouxu
jieyouxu
approved these changes
Nov 9, 2025
View reviewed changes
@jieyouxujieyouxu
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes a lot of sense than trying to figure out some random Python from the environment... I tried this locally and it seems to work. Let's give this a try, at worst we can revert if any cursed issues crop up.
View changes since this review
@jieyouxu
jieyouxu
commented
Nov 9, 2025

Copy link


Copy Markdown

Member
@bors r+ rollup=never
@bors
bors
commented
Nov 9, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit dca8be9 has been approved by jieyouxu
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 9, 2025
@bors
bors
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dca8be9 with merge 00426d6...
@bors
bors
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: jieyouxu

Pushing 00426d6 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 10, 2025
@bors
bors
merged commit 00426d6
into
rust-lang:masterNov 10, 2025

12 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 10, 2025
@github-actions
github-actionsBot
commented
Nov 10, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5f666a6 (parent) -> 00426d6 (this PR)
Test differences
Show 4 test diffs

Stage 2
  • [run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) -> pass (J0)
Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 00426d642ad6a8c6192bf517702a68b0a8001547 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. pr-check-1: 2549.4s -> 1468.1s (-42.4%)
  2. x86_64-rust-for-linux: 4160.1s -> 2584.6s (-37.9%)
  3. pr-check-2: 3160.3s -> 2130.4s (-32.6%)
  4. x86_64-gnu-tools: 4881.6s -> 3335.8s (-31.7%)
  5. aarch64-gnu-debug: 5871.7s -> 4025.2s (-31.4%)
  6. x86_64-gnu-debug: 10143.7s -> 6965.4s (-31.3%)
  7. x86_64-gnu-gcc: 4389.4s -> 3072.5s (-30.0%)
  8. dist-aarch64-apple: 5714.9s -> 7342.9s (+28.5%)
  9. armhf-gnu: 6693.1s -> 4910.3s (-26.6%)
  10. arm-android: 7492.2s -> 5538.8s (-26.1%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@Zalathar
Zalathar
deleted the

lldb-python

branch
November 10, 2025 09:12
@rust-timer
rust-timer
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (00426d6): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (primary 2.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.1%[2.1%, 2.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)2.1%[2.1%, 2.1%]1
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 475.073s -> 476.293s (0.26%)
Artifact size: 391.33 MiB -> 391.34 MiB (0.00%)
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Dec 10, 2025
@bors
Auto merge ofrust-lang#148685- Zalathar:lldb-python, r=jieyouxu
146999c
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python
Historically, LLDB debuginfo tests have used a Python script to control LLDB via its Python API, instead of invoking the `lldb` command directly.
Unfortunately, this requires us to find and use a version of Python that is compatible with LLDB's Python bindings.
However, it turns out that there is a simpler way to find a compatible Python interpreter: use the one that is embedded in LLDB itself, via the `script` command.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcmerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Zalathar@rustbot@jieyouxu@bors@rust-timer@Mark-Simulacrum

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python by Zalathar · Pull Request #148685 · rust-lang/rust · GitHub
Skip to content
compiletest: Run the lldb_batchmode.py script in LLDB's embedded Python - #148685
Merged
bors merged 3 commits into
rust-lang:masterfrom 
Zalathar:lldb-python
Nov 10, 2025
Merged
compiletest: Run the lldb_batchmode.py script in LLDB's embedded Python#148685
bors merged 3 commits into
rust-lang:masterfrom 
Zalathar:lldb-python
Conversation
@Zalathar
@ZalatharZalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
Historically, LLDB debuginfo tests have used a Python script to control LLDB via its Python API, instead of invoking the lldb command directly.
Unfortunately, this requires us to find and use a version of Python that is compatible with LLDB's Python bindings.
However, it turns out that there is a simpler way to find a compatible Python interpreter: use the one that is embedded in LLDB itself, via the script command.
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
This PR modifies bootstrap.example.toml.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
Some changes occurred in src/tools/compiletest
cc @jieyouxu
@rustbotrustbot
added

A-compiletest
Area: The compiletest test runner
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Nov 8, 2025
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
r? @Mark-Simulacrum
rustbot has assigned @Mark-Simulacrum.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@Zalathar
Zalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

MemberAuthor
Big thanks to @Walnut356 for suggesting the use of LLDB's embedded Python.
cc @jieyouxu@xSetech
This may be a useful alternative to some of the changes proposed in:
r? jieyouxu
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
jieyouxu is currently at their maximum review capacity.

They may take a while to respond.
@ZalatharZalathar
mentioned this pull request
Nov 8, 2025
 Merged

@jieyouxu
jieyouxu
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
@bors try jobs=aarch64-apple
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
added a commit
that referenced
this pull request
Nov 8, 2025
@rust-bors
Auto merge of#148685- Zalathar:lldb-python, r=<try>
9d85981
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python
try-job: aarch64-apple
@rust-bors
rust-borsBot
commented
Nov 8, 2025

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 9d85981 (9d85981868d8787740cfbd23500af90eabf8b01e, parent: 4e0baae06da3c29210ba3620db5b01bcb5aba38a)
@Zalathar
Zalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

MemberAuthor
Pushed a small tweak to explicitly specify that the script is in Python, and not some other language.
Doesn't seem to be needed in practice, but perhaps it will avoid headaches someday.
jieyouxu
jieyouxu
approved these changes
Nov 9, 2025
View reviewed changes
@jieyouxujieyouxu
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes a lot of sense than trying to figure out some random Python from the environment... I tried this locally and it seems to work. Let's give this a try, at worst we can revert if any cursed issues crop up.
View changes since this review
@jieyouxu
jieyouxu
commented
Nov 9, 2025

Copy link


Copy Markdown

Member
@bors r+ rollup=never
@bors
bors
commented
Nov 9, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit dca8be9 has been approved by jieyouxu
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 9, 2025
@bors
bors
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dca8be9 with merge 00426d6...
@bors
bors
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: jieyouxu

Pushing 00426d6 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 10, 2025
@bors
bors
merged commit 00426d6
into
rust-lang:masterNov 10, 2025

12 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 10, 2025
@github-actions
github-actionsBot
commented
Nov 10, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5f666a6 (parent) -> 00426d6 (this PR)
Test differences
Show 4 test diffs

Stage 2
  • [run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) -> pass (J0)
Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 00426d642ad6a8c6192bf517702a68b0a8001547 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. pr-check-1: 2549.4s -> 1468.1s (-42.4%)
  2. x86_64-rust-for-linux: 4160.1s -> 2584.6s (-37.9%)
  3. pr-check-2: 3160.3s -> 2130.4s (-32.6%)
  4. x86_64-gnu-tools: 4881.6s -> 3335.8s (-31.7%)
  5. aarch64-gnu-debug: 5871.7s -> 4025.2s (-31.4%)
  6. x86_64-gnu-debug: 10143.7s -> 6965.4s (-31.3%)
  7. x86_64-gnu-gcc: 4389.4s -> 3072.5s (-30.0%)
  8. dist-aarch64-apple: 5714.9s -> 7342.9s (+28.5%)
  9. armhf-gnu: 6693.1s -> 4910.3s (-26.6%)
  10. arm-android: 7492.2s -> 5538.8s (-26.1%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@Zalathar
Zalathar
deleted the

lldb-python

branch
November 10, 2025 09:12
@rust-timer
rust-timer
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (00426d6): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (primary 2.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.1%[2.1%, 2.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)2.1%[2.1%, 2.1%]1
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 475.073s -> 476.293s (0.26%)
Artifact size: 391.33 MiB -> 391.34 MiB (0.00%)
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Dec 10, 2025
@bors
Auto merge ofrust-lang#148685- Zalathar:lldb-python, r=jieyouxu
146999c
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python
Historically, LLDB debuginfo tests have used a Python script to control LLDB via its Python API, instead of invoking the `lldb` command directly.
Unfortunately, this requires us to find and use a version of Python that is compatible with LLDB's Python bindings.
However, it turns out that there is a simpler way to find a compatible Python interpreter: use the one that is embedded in LLDB itself, via the `script` command.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcmerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Zalathar@rustbot@jieyouxu@bors@rust-timer@Mark-Simulacrum

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python by Zalathar · Pull Request #148685 · rust-lang/rust · GitHub
Skip to content
compiletest: Run the lldb_batchmode.py script in LLDB's embedded Python - #148685
Merged
bors merged 3 commits into
rust-lang:masterfrom 
Zalathar:lldb-python
Nov 10, 2025
Merged
compiletest: Run the lldb_batchmode.py script in LLDB's embedded Python#148685
bors merged 3 commits into
rust-lang:masterfrom 
Zalathar:lldb-python
Conversation
@Zalathar
@ZalatharZalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
Historically, LLDB debuginfo tests have used a Python script to control LLDB via its Python API, instead of invoking the lldb command directly.
Unfortunately, this requires us to find and use a version of Python that is compatible with LLDB's Python bindings.
However, it turns out that there is a simpler way to find a compatible Python interpreter: use the one that is embedded in LLDB itself, via the script command.
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
This PR modifies bootstrap.example.toml.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
Some changes occurred in src/tools/compiletest
cc @jieyouxu
@rustbotrustbot
added

A-compiletest
Area: The compiletest test runner
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Nov 8, 2025
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
r? @Mark-Simulacrum
rustbot has assigned @Mark-Simulacrum.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@Zalathar
Zalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

MemberAuthor
Big thanks to @Walnut356 for suggesting the use of LLDB's embedded Python.
cc @jieyouxu@xSetech
This may be a useful alternative to some of the changes proposed in:
r? jieyouxu
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
jieyouxu is currently at their maximum review capacity.

They may take a while to respond.
@ZalatharZalathar
mentioned this pull request
Nov 8, 2025
 Merged

@jieyouxu
jieyouxu
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
@bors try jobs=aarch64-apple
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
added a commit
that referenced
this pull request
Nov 8, 2025
@rust-bors
Auto merge of#148685- Zalathar:lldb-python, r=<try>
9d85981
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python
try-job: aarch64-apple
@rust-bors
rust-borsBot
commented
Nov 8, 2025

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 9d85981 (9d85981868d8787740cfbd23500af90eabf8b01e, parent: 4e0baae06da3c29210ba3620db5b01bcb5aba38a)
@Zalathar
Zalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

MemberAuthor
Pushed a small tweak to explicitly specify that the script is in Python, and not some other language.
Doesn't seem to be needed in practice, but perhaps it will avoid headaches someday.
jieyouxu
jieyouxu
approved these changes
Nov 9, 2025
View reviewed changes
@jieyouxujieyouxu
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes a lot of sense than trying to figure out some random Python from the environment... I tried this locally and it seems to work. Let's give this a try, at worst we can revert if any cursed issues crop up.
View changes since this review
@jieyouxu
jieyouxu
commented
Nov 9, 2025

Copy link


Copy Markdown

Member
@bors r+ rollup=never
@bors
bors
commented
Nov 9, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit dca8be9 has been approved by jieyouxu
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 9, 2025
@bors
bors
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dca8be9 with merge 00426d6...
@bors
bors
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: jieyouxu

Pushing 00426d6 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 10, 2025
@bors
bors
merged commit 00426d6
into
rust-lang:masterNov 10, 2025

12 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 10, 2025
@github-actions
github-actionsBot
commented
Nov 10, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5f666a6 (parent) -> 00426d6 (this PR)
Test differences
Show 4 test diffs

Stage 2
  • [run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) -> pass (J0)
Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 00426d642ad6a8c6192bf517702a68b0a8001547 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. pr-check-1: 2549.4s -> 1468.1s (-42.4%)
  2. x86_64-rust-for-linux: 4160.1s -> 2584.6s (-37.9%)
  3. pr-check-2: 3160.3s -> 2130.4s (-32.6%)
  4. x86_64-gnu-tools: 4881.6s -> 3335.8s (-31.7%)
  5. aarch64-gnu-debug: 5871.7s -> 4025.2s (-31.4%)
  6. x86_64-gnu-debug: 10143.7s -> 6965.4s (-31.3%)
  7. x86_64-gnu-gcc: 4389.4s -> 3072.5s (-30.0%)
  8. dist-aarch64-apple: 5714.9s -> 7342.9s (+28.5%)
  9. armhf-gnu: 6693.1s -> 4910.3s (-26.6%)
  10. arm-android: 7492.2s -> 5538.8s (-26.1%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@Zalathar
Zalathar
deleted the

lldb-python

branch
November 10, 2025 09:12
@rust-timer
rust-timer
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (00426d6): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (primary 2.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.1%[2.1%, 2.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)2.1%[2.1%, 2.1%]1
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 475.073s -> 476.293s (0.26%)
Artifact size: 391.33 MiB -> 391.34 MiB (0.00%)
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Dec 10, 2025
@bors
Auto merge ofrust-lang#148685- Zalathar:lldb-python, r=jieyouxu
146999c
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python
Historically, LLDB debuginfo tests have used a Python script to control LLDB via its Python API, instead of invoking the `lldb` command directly.
Unfortunately, this requires us to find and use a version of Python that is compatible with LLDB's Python bindings.
However, it turns out that there is a simpler way to find a compatible Python interpreter: use the one that is embedded in LLDB itself, via the `script` command.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcmerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Zalathar@rustbot@jieyouxu@bors@rust-timer@Mark-Simulacrum

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python by Zalathar · Pull Request #148685 · rust-lang/rust · GitHub
Skip to content
compiletest: Run the lldb_batchmode.py script in LLDB's embedded Python - #148685
Merged
bors merged 3 commits into
rust-lang:masterfrom 
Zalathar:lldb-python
Nov 10, 2025
Merged
compiletest: Run the lldb_batchmode.py script in LLDB's embedded Python#148685
bors merged 3 commits into
rust-lang:masterfrom 
Zalathar:lldb-python
Conversation
@Zalathar
@ZalatharZalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
Historically, LLDB debuginfo tests have used a Python script to control LLDB via its Python API, instead of invoking the lldb command directly.
Unfortunately, this requires us to find and use a version of Python that is compatible with LLDB's Python bindings.
However, it turns out that there is a simpler way to find a compatible Python interpreter: use the one that is embedded in LLDB itself, via the script command.
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
This PR modifies bootstrap.example.toml.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
Some changes occurred in src/tools/compiletest
cc @jieyouxu
@rustbotrustbot
added

A-compiletest
Area: The compiletest test runner
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Nov 8, 2025
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
r? @Mark-Simulacrum
rustbot has assigned @Mark-Simulacrum.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@Zalathar
Zalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

MemberAuthor
Big thanks to @Walnut356 for suggesting the use of LLDB's embedded Python.
cc @jieyouxu@xSetech
This may be a useful alternative to some of the changes proposed in:
r? jieyouxu
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
jieyouxu is currently at their maximum review capacity.

They may take a while to respond.
@ZalatharZalathar
mentioned this pull request
Nov 8, 2025
 Merged

@jieyouxu
jieyouxu
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
@bors try jobs=aarch64-apple
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
added a commit
that referenced
this pull request
Nov 8, 2025
@rust-bors
Auto merge of#148685- Zalathar:lldb-python, r=<try>
9d85981
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python
try-job: aarch64-apple
@rust-bors
rust-borsBot
commented
Nov 8, 2025

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 9d85981 (9d85981868d8787740cfbd23500af90eabf8b01e, parent: 4e0baae06da3c29210ba3620db5b01bcb5aba38a)
@Zalathar
Zalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

MemberAuthor
Pushed a small tweak to explicitly specify that the script is in Python, and not some other language.
Doesn't seem to be needed in practice, but perhaps it will avoid headaches someday.
jieyouxu
jieyouxu
approved these changes
Nov 9, 2025
View reviewed changes
@jieyouxujieyouxu
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes a lot of sense than trying to figure out some random Python from the environment... I tried this locally and it seems to work. Let's give this a try, at worst we can revert if any cursed issues crop up.
View changes since this review
@jieyouxu
jieyouxu
commented
Nov 9, 2025

Copy link


Copy Markdown

Member
@bors r+ rollup=never
@bors
bors
commented
Nov 9, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit dca8be9 has been approved by jieyouxu
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 9, 2025
@bors
bors
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dca8be9 with merge 00426d6...
@bors
bors
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: jieyouxu

Pushing 00426d6 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 10, 2025
@bors
bors
merged commit 00426d6
into
rust-lang:masterNov 10, 2025

12 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 10, 2025
@github-actions
github-actionsBot
commented
Nov 10, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5f666a6 (parent) -> 00426d6 (this PR)
Test differences
Show 4 test diffs

Stage 2
  • [run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) -> pass (J0)
Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 00426d642ad6a8c6192bf517702a68b0a8001547 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. pr-check-1: 2549.4s -> 1468.1s (-42.4%)
  2. x86_64-rust-for-linux: 4160.1s -> 2584.6s (-37.9%)
  3. pr-check-2: 3160.3s -> 2130.4s (-32.6%)
  4. x86_64-gnu-tools: 4881.6s -> 3335.8s (-31.7%)
  5. aarch64-gnu-debug: 5871.7s -> 4025.2s (-31.4%)
  6. x86_64-gnu-debug: 10143.7s -> 6965.4s (-31.3%)
  7. x86_64-gnu-gcc: 4389.4s -> 3072.5s (-30.0%)
  8. dist-aarch64-apple: 5714.9s -> 7342.9s (+28.5%)
  9. armhf-gnu: 6693.1s -> 4910.3s (-26.6%)
  10. arm-android: 7492.2s -> 5538.8s (-26.1%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@Zalathar
Zalathar
deleted the

lldb-python

branch
November 10, 2025 09:12
@rust-timer
rust-timer
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (00426d6): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (primary 2.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.1%[2.1%, 2.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)2.1%[2.1%, 2.1%]1
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 475.073s -> 476.293s (0.26%)
Artifact size: 391.33 MiB -> 391.34 MiB (0.00%)
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Dec 10, 2025
@bors
Auto merge ofrust-lang#148685- Zalathar:lldb-python, r=jieyouxu
146999c
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python
Historically, LLDB debuginfo tests have used a Python script to control LLDB via its Python API, instead of invoking the `lldb` command directly.
Unfortunately, this requires us to find and use a version of Python that is compatible with LLDB's Python bindings.
However, it turns out that there is a simpler way to find a compatible Python interpreter: use the one that is embedded in LLDB itself, via the `script` command.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcmerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Zalathar@rustbot@jieyouxu@bors@rust-timer@Mark-Simulacrum

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python by Zalathar · Pull Request #148685 · rust-lang/rust · GitHub
Skip to content
compiletest: Run the lldb_batchmode.py script in LLDB's embedded Python - #148685
Merged
bors merged 3 commits into
rust-lang:masterfrom 
Zalathar:lldb-python
Nov 10, 2025
Merged
compiletest: Run the lldb_batchmode.py script in LLDB's embedded Python#148685
bors merged 3 commits into
rust-lang:masterfrom 
Zalathar:lldb-python
Conversation
@Zalathar
@ZalatharZalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
Historically, LLDB debuginfo tests have used a Python script to control LLDB via its Python API, instead of invoking the lldb command directly.
Unfortunately, this requires us to find and use a version of Python that is compatible with LLDB's Python bindings.
However, it turns out that there is a simpler way to find a compatible Python interpreter: use the one that is embedded in LLDB itself, via the script command.
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
This PR modifies bootstrap.example.toml.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
Some changes occurred in src/tools/compiletest
cc @jieyouxu
@rustbotrustbot
added

A-compiletest
Area: The compiletest test runner
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Nov 8, 2025
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
r? @Mark-Simulacrum
rustbot has assigned @Mark-Simulacrum.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@Zalathar
Zalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

MemberAuthor
Big thanks to @Walnut356 for suggesting the use of LLDB's embedded Python.
cc @jieyouxu@xSetech
This may be a useful alternative to some of the changes proposed in:
r? jieyouxu
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
jieyouxu is currently at their maximum review capacity.

They may take a while to respond.
@ZalatharZalathar
mentioned this pull request
Nov 8, 2025
 Merged

@jieyouxu
jieyouxu
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
@bors try jobs=aarch64-apple
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
added a commit
that referenced
this pull request
Nov 8, 2025
@rust-bors
Auto merge of#148685- Zalathar:lldb-python, r=<try>
9d85981
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python
try-job: aarch64-apple
@rust-bors
rust-borsBot
commented
Nov 8, 2025

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 9d85981 (9d85981868d8787740cfbd23500af90eabf8b01e, parent: 4e0baae06da3c29210ba3620db5b01bcb5aba38a)
@Zalathar
Zalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

MemberAuthor
Pushed a small tweak to explicitly specify that the script is in Python, and not some other language.
Doesn't seem to be needed in practice, but perhaps it will avoid headaches someday.
jieyouxu
jieyouxu
approved these changes
Nov 9, 2025
View reviewed changes
@jieyouxujieyouxu
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes a lot of sense than trying to figure out some random Python from the environment... I tried this locally and it seems to work. Let's give this a try, at worst we can revert if any cursed issues crop up.
View changes since this review
@jieyouxu
jieyouxu
commented
Nov 9, 2025

Copy link


Copy Markdown

Member
@bors r+ rollup=never
@bors
bors
commented
Nov 9, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit dca8be9 has been approved by jieyouxu
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 9, 2025
@bors
bors
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dca8be9 with merge 00426d6...
@bors
bors
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: jieyouxu

Pushing 00426d6 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 10, 2025
@bors
bors
merged commit 00426d6
into
rust-lang:masterNov 10, 2025

12 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 10, 2025
@github-actions
github-actionsBot
commented
Nov 10, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5f666a6 (parent) -> 00426d6 (this PR)
Test differences
Show 4 test diffs

Stage 2
  • [run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) -> pass (J0)
Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 00426d642ad6a8c6192bf517702a68b0a8001547 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. pr-check-1: 2549.4s -> 1468.1s (-42.4%)
  2. x86_64-rust-for-linux: 4160.1s -> 2584.6s (-37.9%)
  3. pr-check-2: 3160.3s -> 2130.4s (-32.6%)
  4. x86_64-gnu-tools: 4881.6s -> 3335.8s (-31.7%)
  5. aarch64-gnu-debug: 5871.7s -> 4025.2s (-31.4%)
  6. x86_64-gnu-debug: 10143.7s -> 6965.4s (-31.3%)
  7. x86_64-gnu-gcc: 4389.4s -> 3072.5s (-30.0%)
  8. dist-aarch64-apple: 5714.9s -> 7342.9s (+28.5%)
  9. armhf-gnu: 6693.1s -> 4910.3s (-26.6%)
  10. arm-android: 7492.2s -> 5538.8s (-26.1%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@Zalathar
Zalathar
deleted the

lldb-python

branch
November 10, 2025 09:12
@rust-timer
rust-timer
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (00426d6): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (primary 2.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.1%[2.1%, 2.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)2.1%[2.1%, 2.1%]1
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 475.073s -> 476.293s (0.26%)
Artifact size: 391.33 MiB -> 391.34 MiB (0.00%)
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Dec 10, 2025
@bors
Auto merge ofrust-lang#148685- Zalathar:lldb-python, r=jieyouxu
146999c
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python
Historically, LLDB debuginfo tests have used a Python script to control LLDB via its Python API, instead of invoking the `lldb` command directly.
Unfortunately, this requires us to find and use a version of Python that is compatible with LLDB's Python bindings.
However, it turns out that there is a simpler way to find a compatible Python interpreter: use the one that is embedded in LLDB itself, via the `script` command.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcmerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Zalathar@rustbot@jieyouxu@bors@rust-timer@Mark-Simulacrum

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python by Zalathar · Pull Request #148685 · rust-lang/rust · GitHub
Skip to content
compiletest: Run the lldb_batchmode.py script in LLDB's embedded Python - #148685
Merged
bors merged 3 commits into
rust-lang:masterfrom 
Zalathar:lldb-python
Nov 10, 2025
Merged
compiletest: Run the lldb_batchmode.py script in LLDB's embedded Python#148685
bors merged 3 commits into
rust-lang:masterfrom 
Zalathar:lldb-python
Conversation
@Zalathar
@ZalatharZalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
Historically, LLDB debuginfo tests have used a Python script to control LLDB via its Python API, instead of invoking the lldb command directly.
Unfortunately, this requires us to find and use a version of Python that is compatible with LLDB's Python bindings.
However, it turns out that there is a simpler way to find a compatible Python interpreter: use the one that is embedded in LLDB itself, via the script command.
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
This PR modifies bootstrap.example.toml.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
Some changes occurred in src/tools/compiletest
cc @jieyouxu
@rustbotrustbot
added

A-compiletest
Area: The compiletest test runner
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Nov 8, 2025
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
r? @Mark-Simulacrum
rustbot has assigned @Mark-Simulacrum.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@Zalathar
Zalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

MemberAuthor
Big thanks to @Walnut356 for suggesting the use of LLDB's embedded Python.
cc @jieyouxu@xSetech
This may be a useful alternative to some of the changes proposed in:
r? jieyouxu
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
jieyouxu is currently at their maximum review capacity.

They may take a while to respond.
@ZalatharZalathar
mentioned this pull request
Nov 8, 2025
 Merged

@jieyouxu
jieyouxu
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
@bors try jobs=aarch64-apple
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
added a commit
that referenced
this pull request
Nov 8, 2025
@rust-bors
Auto merge of#148685- Zalathar:lldb-python, r=<try>
9d85981
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python
try-job: aarch64-apple
@rust-bors
rust-borsBot
commented
Nov 8, 2025

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 9d85981 (9d85981868d8787740cfbd23500af90eabf8b01e, parent: 4e0baae06da3c29210ba3620db5b01bcb5aba38a)
@Zalathar
Zalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

MemberAuthor
Pushed a small tweak to explicitly specify that the script is in Python, and not some other language.
Doesn't seem to be needed in practice, but perhaps it will avoid headaches someday.
jieyouxu
jieyouxu
approved these changes
Nov 9, 2025
View reviewed changes
@jieyouxujieyouxu
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes a lot of sense than trying to figure out some random Python from the environment... I tried this locally and it seems to work. Let's give this a try, at worst we can revert if any cursed issues crop up.
View changes since this review
@jieyouxu
jieyouxu
commented
Nov 9, 2025

Copy link


Copy Markdown

Member
@bors r+ rollup=never
@bors
bors
commented
Nov 9, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit dca8be9 has been approved by jieyouxu
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 9, 2025
@bors
bors
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dca8be9 with merge 00426d6...
@bors
bors
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: jieyouxu

Pushing 00426d6 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 10, 2025
@bors
bors
merged commit 00426d6
into
rust-lang:masterNov 10, 2025

12 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 10, 2025
@github-actions
github-actionsBot
commented
Nov 10, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5f666a6 (parent) -> 00426d6 (this PR)
Test differences
Show 4 test diffs

Stage 2
  • [run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) -> pass (J0)
Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 00426d642ad6a8c6192bf517702a68b0a8001547 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. pr-check-1: 2549.4s -> 1468.1s (-42.4%)
  2. x86_64-rust-for-linux: 4160.1s -> 2584.6s (-37.9%)
  3. pr-check-2: 3160.3s -> 2130.4s (-32.6%)
  4. x86_64-gnu-tools: 4881.6s -> 3335.8s (-31.7%)
  5. aarch64-gnu-debug: 5871.7s -> 4025.2s (-31.4%)
  6. x86_64-gnu-debug: 10143.7s -> 6965.4s (-31.3%)
  7. x86_64-gnu-gcc: 4389.4s -> 3072.5s (-30.0%)
  8. dist-aarch64-apple: 5714.9s -> 7342.9s (+28.5%)
  9. armhf-gnu: 6693.1s -> 4910.3s (-26.6%)
  10. arm-android: 7492.2s -> 5538.8s (-26.1%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@Zalathar
Zalathar
deleted the

lldb-python

branch
November 10, 2025 09:12
@rust-timer
rust-timer
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (00426d6): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (primary 2.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.1%[2.1%, 2.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)2.1%[2.1%, 2.1%]1
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 475.073s -> 476.293s (0.26%)
Artifact size: 391.33 MiB -> 391.34 MiB (0.00%)
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Dec 10, 2025
@bors
Auto merge ofrust-lang#148685- Zalathar:lldb-python, r=jieyouxu
146999c
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python
Historically, LLDB debuginfo tests have used a Python script to control LLDB via its Python API, instead of invoking the `lldb` command directly.
Unfortunately, this requires us to find and use a version of Python that is compatible with LLDB's Python bindings.
However, it turns out that there is a simpler way to find a compatible Python interpreter: use the one that is embedded in LLDB itself, via the `script` command.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcmerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Zalathar@rustbot@jieyouxu@bors@rust-timer@Mark-Simulacrum

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python by Zalathar · Pull Request #148685 · rust-lang/rust · GitHub
Skip to content
compiletest: Run the lldb_batchmode.py script in LLDB's embedded Python - #148685
Merged
bors merged 3 commits into
rust-lang:masterfrom 
Zalathar:lldb-python
Nov 10, 2025
Merged
compiletest: Run the lldb_batchmode.py script in LLDB's embedded Python#148685
bors merged 3 commits into
rust-lang:masterfrom 
Zalathar:lldb-python
Conversation
@Zalathar
@ZalatharZalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
Historically, LLDB debuginfo tests have used a Python script to control LLDB via its Python API, instead of invoking the lldb command directly.
Unfortunately, this requires us to find and use a version of Python that is compatible with LLDB's Python bindings.
However, it turns out that there is a simpler way to find a compatible Python interpreter: use the one that is embedded in LLDB itself, via the script command.
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
This PR modifies bootstrap.example.toml.
If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
Some changes occurred in src/tools/compiletest
cc @jieyouxu
@rustbotrustbot
added

A-compiletest
Area: The compiletest test runner
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Nov 8, 2025
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
r? @Mark-Simulacrum
rustbot has assigned @Mark-Simulacrum.

They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.
Use r? to explicitly pick a reviewer
@Zalathar
Zalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

MemberAuthor
Big thanks to @Walnut356 for suggesting the use of LLDB's embedded Python.
cc @jieyouxu@xSetech
This may be a useful alternative to some of the changes proposed in:
r? jieyouxu
@rustbot
rustbot
commented
Nov 8, 2025

Copy link


Copy Markdown

Collaborator
jieyouxu is currently at their maximum review capacity.

They may take a while to respond.
@ZalatharZalathar
mentioned this pull request
Nov 8, 2025
 Merged

@jieyouxu
jieyouxu
commented
Nov 8, 2025

Copy link


Copy Markdown

Member
@bors try jobs=aarch64-apple
@rust-bors

This comment has been minimized.

Sign in to view
rust-borsBot
added a commit
that referenced
this pull request
Nov 8, 2025
@rust-bors
Auto merge of#148685- Zalathar:lldb-python, r=<try>
9d85981
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python
try-job: aarch64-apple
@rust-bors
rust-borsBot
commented
Nov 8, 2025

Copy link


Copy Markdown

Contributor
☀️ Try build successful (CI)

Build commit: 9d85981 (9d85981868d8787740cfbd23500af90eabf8b01e, parent: 4e0baae06da3c29210ba3620db5b01bcb5aba38a)
@Zalathar
Zalathar
commented
Nov 8, 2025

Copy link


Copy Markdown

MemberAuthor
Pushed a small tweak to explicitly specify that the script is in Python, and not some other language.
Doesn't seem to be needed in practice, but perhaps it will avoid headaches someday.
jieyouxu
jieyouxu
approved these changes
Nov 9, 2025
View reviewed changes
@jieyouxujieyouxu
left a comment
•

edited by rustbot

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes a lot of sense than trying to figure out some random Python from the environment... I tried this locally and it seems to work. Let's give this a try, at worst we can revert if any cursed issues crop up.
View changes since this review
@jieyouxu
jieyouxu
commented
Nov 9, 2025

Copy link


Copy Markdown

Member
@bors r+ rollup=never
@bors
bors
commented
Nov 9, 2025

Copy link


Copy Markdown

Collaborator
📌 Commit dca8be9 has been approved by jieyouxu
It is now in the queue for this repository.
@borsbors
added

S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed

S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Nov 9, 2025
@bors
bors
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
⌛ Testing commit dca8be9 with merge 00426d6...
@bors
bors
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
☀️ Test successful - checks-actions

Approved by: jieyouxu

Pushing 00426d6 to master...
@borsbors
added
the 
merged-by-bors
This PR was explicitly merged by bors.
label
Nov 10, 2025
@bors
bors
merged commit 00426d6
into
rust-lang:masterNov 10, 2025

12 checks passed

@rustbotrustbot
added this to the 1.93.0 milestone
Nov 10, 2025
@github-actions
github-actionsBot
commented
Nov 10, 2025

Copy link


Copy Markdown

Contributor
What is this?
This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 5f666a6 (parent) -> 00426d6 (this PR)
Test differences
Show 4 test diffs

Stage 2
  • [run-make] tests/run-make/compressed-debuginfo-zstd: ignore (ignored if LLVM wasn't build with zstd for ELF section compression or LLVM is not the default codegen backend) -> pass (J0)
Additionally, 3 doctest diffs were found. These are ignored, as they are noisy.
Job group index
Test dashboard
Run
cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 00426d642ad6a8c6192bf517702a68b0a8001547 --output-dir test-dashboard
And then open test-dashboard/index.html in your browser to see an overview of all executed tests.
Job duration changes
  1. pr-check-1: 2549.4s -> 1468.1s (-42.4%)
  2. x86_64-rust-for-linux: 4160.1s -> 2584.6s (-37.9%)
  3. pr-check-2: 3160.3s -> 2130.4s (-32.6%)
  4. x86_64-gnu-tools: 4881.6s -> 3335.8s (-31.7%)
  5. aarch64-gnu-debug: 5871.7s -> 4025.2s (-31.4%)
  6. x86_64-gnu-debug: 10143.7s -> 6965.4s (-31.3%)
  7. x86_64-gnu-gcc: 4389.4s -> 3072.5s (-30.0%)
  8. dist-aarch64-apple: 5714.9s -> 7342.9s (+28.5%)
  9. armhf-gnu: 6693.1s -> 4910.3s (-26.6%)
  10. arm-android: 7492.2s -> 5538.8s (-26.1%)
How to interpret the job duration changes?
Job durations can vary a lot, based on the actual runner instance

that executed the job, system noise, invalidated caches, etc. The table above is provided

mostly for t-infra members, for simpler debugging of potential CI slow-downs.
@Zalathar
Zalathar
deleted the

lldb-python

branch
November 10, 2025 09:12
@rust-timer
rust-timer
commented
Nov 10, 2025

Copy link


Copy Markdown

Collaborator
Finished benchmarking commit (00426d6): comparison URL.
Overall result: no relevant changes - no action needed
@rustbot label: -perf-regression
Instruction count
This benchmark run did not return any relevant results for this metric.
Max RSS (memory usage)
This benchmark run did not return any relevant results for this metric.
Cycles
Results (primary 2.1%)
A less reliable metric. May be of interest, but not used to determine the overall result above.
meanrangecount
Regressions ❌ 
 (primary)		2.1%[2.1%, 2.1%]1
Regressions ❌ 
 (secondary)		--0
Improvements ✅ 
 (primary)		--0
Improvements ✅ 
 (secondary)		--0
All ❌✅ (primary)2.1%[2.1%, 2.1%]1
Binary size
This benchmark run did not return any relevant results for this metric.
Bootstrap: 475.073s -> 476.293s (0.26%)
Artifact size: 391.33 MiB -> 391.34 MiB (0.00%)
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Dec 10, 2025
@bors
Auto merge ofrust-lang#148685- Zalathar:lldb-python, r=jieyouxu
146999c
compiletest: Run the `lldb_batchmode.py` script in LLDB's embedded Python
Historically, LLDB debuginfo tests have used a Python script to control LLDB via its Python API, instead of invoking the `lldb` command directly.
Unfortunately, this requires us to find and use a version of Python that is compatible with LLDB's Python bindings.
However, it turns out that there is a simpler way to find a compatible Python interpreter: use the one that is embedded in LLDB itself, via the `script` command.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@jieyouxujieyouxujieyouxu approved these changes

Assignees

@jieyouxujieyouxu

Labels

A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcmerged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects


None yet


Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Zalathar@rustbot@jieyouxu@bors@rust-timer@Mark-Simulacrum