Rollup of 5 pull requests by matthiaskrgr · Pull Request #149063 · rust-lang/rust

matthiaskrgr · 2025-11-18T15:52:15Z

Successful merges:

Improve the documentation of atomic::fence #147887 (Improve the documentation of atomic::fence)
repr(transparent) check: do not compute check_unsuited more than once #148281 (repr(transparent) check: do not compute check_unsuited more than once)
Fix suggestion for the cfg! macro #148484 (Fix suggestion for the cfg! macro)
rust-analyzer subtree update #149057 (rust-analyzer subtree update)
debug-assert FixedSizeEncoding invariant #149061 (debug-assert FixedSizeEncoding invariant)

r? @ghost
@rustbot modify labels: rollup

Make type in Param optional

10: Allow type aliases in extern blocks r=jonas-schievink a=jonas-schievink This is for the unstable feature rust-lang#43467, which rustc uses internally Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>

closesrust-analyzer/ungrammar#9

11: Allow both const & async modifiers r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

12: Fix .gitignore r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

I don't really look at the results of the benchmarks anyway, so having them in the repo creates a false sense of benchmarkdness. If I get to implementing proper benchmarking, I'd probably stay away from criterion -- we need something much much simpler for this crate.

23: modernize r=matklad a=matklad Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

The Travis workflow was deleted in 3d5b7e3476f91280aedda3900c13838b00d64a9d

…cros Move towards upstream `macro_rules!` model

It's unclear if this is worthwhile, and this requires a lot of changes in r-a

matthiaskrgr · 2025-11-18T15:52:44Z

@bors r+ rollup=never p=5

bors · 2025-11-18T15:52:47Z

📌 Commit ceb33e9 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-11-18T17:26:10Z

⌛ Testing commit ceb33e9 with merge 26e29af...

Rollup of 5 pull requests Successful merges: - #147887 (Improve the documentation of atomic::fence) - #148281 (repr(transparent) check: do not compute check_unsuited more than once) - #148484 (Fix suggestion for the `cfg!` macro) - #149057 (`rust-analyzer` subtree update) - #149061 (debug-assert FixedSizeEncoding invariant) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-11-18T20:42:08Z

💔 Test failed - checks-actions

rust-log-analyzer · 2025-11-18T20:42:17Z

A job failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)

matthiaskrgr · 2025-11-18T20:42:23Z

@bors retry

matthiaskrgr · 2025-11-18T20:42:41Z

@bors treeclosed=100
https://www.githubstatus.com/incidents/5q7nmlxz30sk

matthiaskrgr · 2025-11-18T21:58:17Z

@bors treeclosed-

bors · 2025-11-18T21:59:30Z

⌛ Testing commit ceb33e9 with merge 7c2c3c0...

bors · 2025-11-19T01:11:03Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 7c2c3c0 to main...

rust-timer · 2025-11-19T01:12:39Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#147887	Improve the documentation of atomic::fence	`8501ec820887f003ca7030ad962ce5b73afd44be` (link)
#148281	repr(transparent) check: do not compute check_unsuited more…	`f62f33aacbbfa33ac5f1c0b4c7ac58d03b5d4c3f` (link)
#148484	Fix suggestion for the `cfg!` macro	`ae0ecb8218153e60b793d5d26aa5d6259d957110` (link)
#149057	`rust-analyzer` subtree update	`cbc73e357c09d6f1eb904324ddde17aa5c828638` (link)
#149061	debug-assert FixedSizeEncoding invariant	`6f8a14f1c08b371746942d5c328c366b6675acbf` (link)

previous master: 3d461af2a2

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-11-19T01:13:51Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 3d461af (parent) -> 7c2c3c0 (this PR)

Test differences

Show 12 test diffs

12 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 7c2c3c0ded2de378bfab2f5b55c387c66fbaf353 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

aarch64-apple: 11367.7s -> 8633.8s (-24.0%)
pr-check-1: 1974.5s -> 1673.2s (-15.3%)
aarch64-gnu-llvm-20-2: 2630.2s -> 2249.7s (-14.5%)
x86_64-rust-for-linux: 3035.3s -> 2608.9s (-14.0%)
x86_64-gnu-gcc: 3580.4s -> 3079.5s (-14.0%)
x86_64-gnu-tools: 3767.6s -> 3288.1s (-12.7%)
armhf-gnu: 5651.2s -> 4934.7s (-12.7%)
dist-x86_64-netbsd: 4509.7s -> 5070.1s (+12.4%)
x86_64-gnu-llvm-20: 2784.6s -> 2451.0s (-12.0%)
dist-aarch64-apple: 7460.7s -> 6582.1s (-11.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-11-19T02:32:44Z

Finished benchmarking commit (7c2c3c0): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 2.7%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.7%	[2.7%, 2.7%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.7%	[2.7%, 2.7%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 473.417s -> 474.558s (0.24%)
Artifact size: 388.75 MiB -> 388.75 MiB (-0.00%)

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#147887 (Improve the documentation of atomic::fence) - rust-lang#148281 (repr(transparent) check: do not compute check_unsuited more than once) - rust-lang#148484 (Fix suggestion for the `cfg!` macro) - rust-lang#149057 (`rust-analyzer` subtree update) - rust-lang#149061 (debug-assert FixedSizeEncoding invariant) r? `@ghost` `@rustbot` modify labels: rollup

matkladand others added 30 commits August 7, 2020 23:53

Merge pull requestrust-analyzer/ungrammar#4from Apanatshka/patch-1
2a5b30a
Make type in Param optional

Allow pipes in parameters
366d647
closesrust-analyzer/ungrammar#8

Name MethodCall's receiver
a9cae3e

v1.1.2
4d441ca

Allow type aliases in extern blocks
ca09035

Bump to 1.1.3
3c19796

Mergerust-analyzer/ungrammar#10
1c82b88
10: Allow type aliases in extern blocks r=jonas-schievink a=jonas-schievink This is for the unstable feature rust-lang#43467, which rustc uses internally Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>

Continious release
43354a5

Allow both const & async modifiers
d9d0ed2
closesrust-analyzer/ungrammar#9

Mergerust-analyzer/ungrammar#11
a8c9fa5
11: Allow both const & async modifiers r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Fix .gitignore
78f5d1b

Mergerust-analyzer/ungrammar#12
643354e
12: Fix .gitignore r=matklad a=matklad bors r+ 🤖 Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Add new_inline const-fn constructor
7a744b9

⬆️ proptest
60e075e

Switch CI to actions
951523a

Bump major version
c7b86a6

Drop benchmarking
56f34ee
I don't really look at the results of the benchmarks anyway, so having them in the repo creates a false sense of benchmarkdness. If I get to implementing proper benchmarking, I'd probably stay away from criterion -- we need something much much simpler for this crate.

Mergerust-analyzer/smol_str#23
a5fc8a0
23: modernize r=matklad a=matklad Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>

Document MSRV
7e76690

Update CI badge in readme to point to Github Actions
77a4fa5
The Travis workflow was deleted in 3d5b7e3476f91280aedda3900c13838b00d64a9d

Minor
f03a19e

Link post
c3f2679

Move towards upstream macro_rules! model
61257d6

Merge pull requestrust-analyzer/ungrammar#14from jonas-schievink/ma…
7a1c02e
…cros Move towards upstream `macro_rules!` model

Bump to 1.2.0
a10691c

Fixup MacroRules to work with xtask codegen
58aade1

Roll back MacroArm change
9e4810f
It's unclear if this is worthwhile, and this requires a lot of changes in r-a

Add MacroDef for "Macros 2.0"
a6073ec

Fix labels missing the colon token in rust ungrammar
8bb6876

Node-ify lifetime
a28544c

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2025

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 18, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 18, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 19, 2025

bors merged commit 7c2c3c0 into rust-lang:mainNov 19, 2025
12 checks passed

rustbot added this to the 1.93.0 milestone Nov 19, 2025

Uh oh!

Uh oh!

Conversation

matthiaskrgr commented Nov 18, 2025• edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Nov 18, 2025

Uh oh!

bors commented Nov 18, 2025

Uh oh!

bors commented Nov 18, 2025

Uh oh!

bors commented Nov 18, 2025

Uh oh!

rust-log-analyzer commented Nov 18, 2025

Uh oh!

matthiaskrgr commented Nov 18, 2025

Uh oh!

matthiaskrgr commented Nov 18, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Nov 18, 2025

Uh oh!

bors commented Nov 18, 2025

Uh oh!

bors commented Nov 19, 2025

Uh oh!

Uh oh!

rust-timer commented Nov 19, 2025

Uh oh!

github-actionsBot commented Nov 19, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Nov 19, 2025

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

matthiaskrgr commented Nov 18, 2025•
edited by rustbot
Loading

matthiaskrgr commented Nov 18, 2025•
edited
Loading