Skip to content

num: Implement uint_gather_scatter_bits feature for unsigned integers - #149097

Merged
bors merged 1 commit into
rust-lang:mainfrom
okaneco:gather_scatter_bits
Nov 27, 2025
Merged

num: Implement uint_gather_scatter_bits feature for unsigned integers#149097
bors merged 1 commit into
rust-lang:mainfrom
okaneco:gather_scatter_bits

Conversation

@okaneco

@okanecookaneco commented Nov 19, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Feature gate: #![feature(uint_gather_scatter_bits)]
Tracking issue: #149069
Accepted ACP: rust-lang/libs-team#695 (comment)

Implement gather_bits, scatter_bits functions on unsigned integers
Add tests to coretests

This implementation is a small improvement over the plain naive form (see the solution sketch).
We only check the set bits in the mask instead of iterating over every bit.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 19, 2025
@rustbot

rustbot commented Nov 19, 2025

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@okanecookaneco mentioned this pull request Nov 19, 2025
Open
4 tasks
okaneco
okaneco commented Nov 19, 2025
View reviewed changes
Comment threadlibrary/coretests/tests/num/uint_macros.rs
quaternic
quaternic reviewed Nov 24, 2025
View reviewed changes

@quaternicquaternic left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions, but otherwise looks good to me.

View changes since this review

Comment threadlibrary/core/src/num/uint_macros.rs Outdated
#[unstable(feature = "uint_gather_scatter_bits", issue = "149069")]
#[must_use = "this returns the result of the operation, \
without modifying the original"]
#[inline(always)]

@quaternicquaternicNov 24, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[inline(always)]
#[inline]

This seems more appropriate for something with a nontrivial amount of code within. Comparable to wrapping_pow.

@okanecookanecoNov 24, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with this, and changed the function signatures to be mut param instead of redeclaring in the function body.

Comment threadlibrary/core/src/num/uint_macros.rs Outdated
Comment threadlibrary/core/src/num/uint_macros.rs Outdated
Comment threadlibrary/core/src/num/uint_macros.rs Outdated
@okaneco
num: Implement uint_gather_scatter_bits feature for unsigned integers
7f89192
Implement `gather_bits`, `scatter_bits` functions on unsigned integers
Add tests to coretests
@Mark-Simulacrum

Mark-Simulacrum commented Nov 26, 2025

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Nov 26, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 7f89192 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 26, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 26, 2025
@Zalathar
Rollup merge ofrust-lang#149097- okaneco:gather_scatter_bits, r=Mar…
152b70f
…k-Simulacrum
num: Implement `uint_gather_scatter_bits` feature for unsigned integers
Feature gate: `#![feature(uint_gather_scatter_bits)]`
Tracking issue: rust-lang#149069
Accepted ACP: rust-lang/libs-team#695 (comment)
Implement `gather_bits`, `scatter_bits` functions on unsigned integers
Add tests to coretests
This implementation is a small improvement over the plain naive form (see the [solution sketch](rust-lang/libs-team#695)).
We only check the set bits in the mask instead of iterating over every bit.
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 26, 2025
@Zalathar
Rollup merge ofrust-lang#149097- okaneco:gather_scatter_bits, r=Mar…
df64173
…k-Simulacrum
num: Implement `uint_gather_scatter_bits` feature for unsigned integers
Feature gate: `#![feature(uint_gather_scatter_bits)]`
Tracking issue: rust-lang#149069
Accepted ACP: rust-lang/libs-team#695 (comment)
Implement `gather_bits`, `scatter_bits` functions on unsigned integers
Add tests to coretests
This implementation is a small improvement over the plain naive form (see the [solution sketch](rust-lang/libs-team#695)).
We only check the set bits in the mask instead of iterating over every bit.
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 26, 2025
@Zalathar
Rollup merge ofrust-lang#149097- okaneco:gather_scatter_bits, r=Mar…
d7a80db
…k-Simulacrum
num: Implement `uint_gather_scatter_bits` feature for unsigned integers
Feature gate: `#![feature(uint_gather_scatter_bits)]`
Tracking issue: rust-lang#149069
Accepted ACP: rust-lang/libs-team#695 (comment)
Implement `gather_bits`, `scatter_bits` functions on unsigned integers
Add tests to coretests
This implementation is a small improvement over the plain naive form (see the [solution sketch](rust-lang/libs-team#695)).
We only check the set bits in the mask instead of iterating over every bit.
@ZalatharZalathar mentioned this pull request Nov 26, 2025
Closed
bors added a commit that referenced this pull request Nov 26, 2025
@bors
Auto merge of#149361- Zalathar:rollup-ygtgbn5, r=Zalathar
ddd5e13
Rollup of 19 pull requests
Successful merges:
- #148048 (Stabilize `maybe_uninit_write_slice`)
- #148641 (Add a diagnostic attribute for special casing const bound errors for non-const impls)
- #148765 (std: split up the `thread` module)
- #149074 (Add Command::get_env_clear)
- #149097 (num: Implement `uint_gather_scatter_bits` feature for unsigned integers)
- #149131 (optimize `slice::Iter::next_chunk`)
- #149190 (Forbid `CHECK: br` and `CHECK-NOT: br` in codegen tests (suggest `br {{.*}}` instead))
- #149239 (clarify float min/max behavios for NaNs and signed zeros)
- #149243 (Fix typo and clarify bootstrap change tracker entry)
- #149270 (implement `Iterator::{exactly_one, collect_array}`)
- #149295 (Suggest _bytes versions of endian-converting methods)
- #149301 (Motor OS: make decode_error_kind more comprehensive)
- #149306 (bootstrap: Miri now handles jemalloc like everything else)
- #149325 (rustdoc: add regression test for #140968)
- #149332 (fix rustdoc search says “Consider searching for "null" instead.” #149324)
- #149349 (Fix typo in comment.)
- #149353 (Tidying up UI tests [3/N])
- #149355 (Document that `build.description` affects symbol mangling and crate IDs)
- #149360 (Enable CI download for windows-gnullvm)
r? `@ghost`
`@rustbot` modify labels: rollup
@ZalatharZalathar mentioned this pull request Nov 27, 2025
Merged
bors added a commit that referenced this pull request Nov 27, 2025
@bors
Auto merge of#149368- Zalathar:rollup-dakpdsl, r=Zalathar
a417515
Rollup of 12 pull requests
Successful merges:
- #147115 (More robust stack protector testing)
- #148048 (Stabilize `maybe_uninit_write_slice`)
- #148641 (Add a diagnostic attribute for special casing const bound errors for non-const impls)
- #149074 (Add Command::get_env_clear)
- #149097 (num: Implement `uint_gather_scatter_bits` feature for unsigned integers)
- #149131 (optimize `slice::Iter::next_chunk`)
- #149190 (Forbid `CHECK: br` and `CHECK-NOT: br` in codegen tests (suggest `br {{.*}}` instead))
- #149239 (clarify float min/max behavios for NaNs and signed zeros)
- #149243 (Fix typo and clarify bootstrap change tracker entry)
- #149301 (Motor OS: make decode_error_kind more comprehensive)
- #149306 (bootstrap: Miri now handles jemalloc like everything else)
- #149325 (rustdoc: add regression test for #140968)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit e3ecd45 into rust-lang:mainNov 27, 2025
11 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 27, 2025
rust-timer added a commit that referenced this pull request Nov 27, 2025
@rust-timer
Unrolled build for#149097
050262e
Rollup merge of #149097 - okaneco:gather_scatter_bits, r=Mark-Simulacrum
num: Implement `uint_gather_scatter_bits` feature for unsigned integers
Feature gate: `#![feature(uint_gather_scatter_bits)]`
Tracking issue: #149069
Accepted ACP: rust-lang/libs-team#695 (comment)
Implement `gather_bits`, `scatter_bits` functions on unsigned integers
Add tests to coretests
This implementation is a small improvement over the plain naive form (see the [solution sketch](rust-lang/libs-team#695)).
We only check the set bits in the mask instead of iterating over every bit.
@okaneco
okaneco deleted the gather_scatter_bits branch November 27, 2025 14:18
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jan 20, 2026
@Zalathar
Rollup merge ofrust-lang#149097- okaneco:gather_scatter_bits, r=Mar…
887145f
…k-Simulacrum
num: Implement `uint_gather_scatter_bits` feature for unsigned integers
Feature gate: `#![feature(uint_gather_scatter_bits)]`
Tracking issue: rust-lang#149069
Accepted ACP: rust-lang/libs-team#695 (comment)
Implement `gather_bits`, `scatter_bits` functions on unsigned integers
Add tests to coretests
This implementation is a small improvement over the plain naive form (see the [solution sketch](rust-lang/libs-team#695)).
We only check the set bits in the mask instead of iterating over every bit.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@quaternicquaternicquaternic left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

5 participants

@okaneco@rustbot@Mark-Simulacrum@bors@quaternic