Skip to content

stabilize maybe_uninit_slice - #149102

Merged
bors merged 2 commits into
rust-lang:mainfrom
bend-n:maybe_uninit_slice
Dec 1, 2025
Merged

stabilize maybe_uninit_slice#149102
bors merged 2 commits into
rust-lang:mainfrom
bend-n:maybe_uninit_slice

Conversation

@bend-n

@bend-nbend-n commented Nov 19, 2025•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Tracking issue: #63569
Closes: #63569
FCP completed: #63569 (comment)

Removes:

pubconstfnslice_as_ptr(this:&[MaybeUninit<T>]) -> *constT;pubconstfnslice_as_mut_ptr(this:&mut[MaybeUninit<T>]) -> *mutT;

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 19, 2025
@rustbot

rustbot commented Nov 19, 2025

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
clarfonthey
clarfonthey reviewed Nov 23, 2025
View reviewed changes
Comment threadlibrary/core/src/slice/sort/stable/merge.rs Outdated
// 2. Fills the remaining gap in `v` if the longer run gets consumed first.

let buf = MaybeUninit::slice_as_mut_ptr(scratch);
let buf = scratch.as_mut_ptr().cast::<T>();

@clarfontheyclarfontheyNov 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should be using the cast_init method that was added to replace this instead of a generic cast.

clarfonthey
clarfonthey reviewed Nov 23, 2025
View reviewed changes
Comment threadlibrary/core/src/slice/sort/stable/quicksort.rs Outdated

let v_base = v.as_ptr();
let scratch_base = MaybeUninit::slice_as_mut_ptr(scratch);
let scratch_base = scratch.as_mut_ptr() as *mut T;

@clarfontheyclarfontheyNov 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto here.

@rustbot

This comment has been minimized.

Sign in to view
@bors

bors commented Nov 27, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #149368) made this pull request unmergeable. Please resolve the merge conflicts.

@rustbot

rustbot commented Nov 27, 2025

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@joboet

joboet commented Nov 30, 2025

Copy link
Copy Markdown
Member

Great, thank you.
@bors r+

@bors

bors commented Nov 30, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit d67f99a has been approved by joboet

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 30, 2025
bors added a commit that referenced this pull request Dec 1, 2025
@bors
Auto merge of#149102- bend-n:maybe_uninit_slice, r=joboet
3e3bbf3
stabilize maybe_uninit_slice
Tracking issue: #63569Closes: #63569
FCP completed: #63569 (comment)
Removes:
```rs
pub const fn slice_as_ptr(this: &[MaybeUninit<T>]) -> *const T;
pub const fn slice_as_mut_ptr(this: &mut [MaybeUninit<T>]) -> *mut T;
```
@bors

bors commented Dec 1, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit d67f99a with merge 3e3bbf3...

@rust-log-analyzer

rust-log-analyzer commented Dec 1, 2025

Copy link
Copy Markdown
Collaborator

The job armhf-gnu failed! Check out the build log: (web)(plain enhanced)(plain)

Click to see the possible cause of the failure (guessed by this bot)
failures:
---- [ui] tests/ui/for-loop-while/for-loop-macro.rs stdout ----
error: test did not exit with success! code=Some(101) so test would pass with `run-fail`
status: exit status: 101
command: RUSTC="/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" RUST_TEST_THREADS="4" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/remote-test-client" "run" "0" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/for-loop-while/for-loop-macro/a"
--- stdout -------------------------------
uploaded "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/for-loop-while/for-loop-macro/a", waiting for result
------------------------------------------

@bors

bors commented Dec 1, 2025

Copy link
Copy Markdown
Collaborator

💔 Test failed - checks-actions

@borsbors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 1, 2025
@bend-n

bend-n commented Dec 1, 2025

Copy link
Copy Markdown
ContributorAuthor

@bors retry

@bors

bors commented Dec 1, 2025

Copy link
Copy Markdown
Collaborator

@bend-n: 🔑 Insufficient privileges: not in try users

@Noratrieb

Noratrieb commented Dec 1, 2025

Copy link
Copy Markdown
Member

@bors retry

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2025
@matthiaskrgrmatthiaskrgr mentioned this pull request Dec 1, 2025
Merged
bors added a commit that referenced this pull request Dec 1, 2025
@bors
Auto merge of#149510- matthiaskrgr:rollup-5rt6o7z, r=matthiaskrgr
a463b0e
Rollup of 9 pull requests
Successful merges:
- #148690 (Implement `clamp_magnitude` method for primitive floats & signed integers)
- #149102 (stabilize maybe_uninit_slice)
- #149269 (cmse: do not calculate the layout of a type with infer types)
- #149299 (Fudge infer vars in the cause code of `Obligation` intentionally)
- #149344 (Don't suggest unwrap for Result in const)
- #149358 (fix(parse): Limit frontmatter fences to 255 dashes )
- #149445 (make assoc fn inherit const stability from inherent `const impl` blocks)
- #149479 (Fix indent in E0591.md)
- #149496 (Fix#148889: Add label rib when visiting delegation body)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 5f3dc5d into rust-lang:mainDec 1, 2025
11 of 12 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Dec 1, 2025
rust-timer added a commit that referenced this pull request Dec 1, 2025
@rust-timer
Unrolled build for#149102
c9022e6
Rollup merge of #149102 - bend-n:maybe_uninit_slice, r=joboet
stabilize maybe_uninit_slice
Tracking issue: #63569Closes: #63569
FCP completed: #63569 (comment)
Removes:
```rs
pub const fn slice_as_ptr(this: &[MaybeUninit<T>]) -> *const T;
pub const fn slice_as_mut_ptr(this: &mut [MaybeUninit<T>]) -> *mut T;
```
@bend-n
bend-n deleted the maybe_uninit_slice branch December 1, 2025 20:34
github-actionsBot pushed a commit to rust-lang/rust-analyzer that referenced this pull request Dec 15, 2025
@bors
Auto merge of #149510 - matthiaskrgr:rollup-5rt6o7z, r=matthiaskrgr
9b730b7
Rollup of 9 pull requests
Successful merges:
- rust-lang/rust#148690 (Implement `clamp_magnitude` method for primitive floats & signed integers)
- rust-lang/rust#149102 (stabilize maybe_uninit_slice)
- rust-lang/rust#149269 (cmse: do not calculate the layout of a type with infer types)
- rust-lang/rust#149299 (Fudge infer vars in the cause code of `Obligation` intentionally)
- rust-lang/rust#149344 (Don't suggest unwrap for Result in const)
- rust-lang/rust#149358 (fix(parse): Limit frontmatter fences to 255 dashes )
- rust-lang/rust#149445 (make assoc fn inherit const stability from inherent `const impl` blocks)
- rust-lang/rust#149479 (Fix indent in E0591.md)
- rust-lang/rust#149496 (Fixrust-lang/rust#148889: Add label rib when visiting delegation body)
r? `@ghost`
`@rustbot` modify labels: rollup
@zjp-CNzjp-CN mentioned this pull request Jan 17, 2026
Closed
@cuvipercuviper mentioned this pull request Jan 19, 2026
Merged
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jan 20, 2026
@matthiaskrgr
Rollup merge ofrust-lang#149102- bend-n:maybe_uninit_slice, r=joboet
dd2f90f
stabilize maybe_uninit_slice
Tracking issue: rust-lang#63569Closes: rust-lang#63569
FCP completed: rust-lang#63569 (comment)
Removes:
```rs
pub const fn slice_as_ptr(this: &[MaybeUninit<T>]) -> *const T;
pub const fn slice_as_mut_ptr(this: &mut [MaybeUninit<T>]) -> *mut T;
```
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@clarfontheyclarfontheyclarfonthey approved these changes

Assignees

@joboetjoboet

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

Tracking issue for #![feature(maybe_uninit_slice)]

7 participants

@bend-n@rustbot@rust-log-analyzer@bors@joboet@Noratrieb@clarfonthey