Skip to content

unwrap ret ty of iter::ArrayChunks::into_remainder - #149127

Merged
bors merged 1 commit into
rust-lang:mainfrom
bend-n:iter_array_chunks_into_remainder_is_non_optional
Nov 21, 2025
Merged

unwrap ret ty of iter::ArrayChunks::into_remainder#149127
bors merged 1 commit into
rust-lang:mainfrom
bend-n:iter_array_chunks_into_remainder_is_non_optional

Conversation

@bend-n

@bend-nbend-n commented Nov 20, 2025

Copy link
Copy Markdown
Contributor

changes iter::ArrayChunks::into_remainder to return array::IntoIter instead of Option<array::IntoIter> as suggested by @WaffleLapkin

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 20, 2025
@rustbot

rustbot commented Nov 20, 2025

Copy link
Copy Markdown
Collaborator

r? @tgross35

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@tgross35tgross35 mentioned this pull request Nov 20, 2025
Open
8 tasks
@tgross35

tgross35 commented Nov 20, 2025

Copy link
Copy Markdown
Member

This would need libs-api to take a look, I nominated #100450 for that.

@tgross35tgross35 added S-waiting-on-t-libs-api [DEPRECATED; DO NOT USE] and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2025
dtolnay
dtolnay approved these changes Nov 21, 2025
View reviewed changes

@dtolnaydtolnay left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

View changes since this review

@dtolnaydtolnay linked an issue Nov 21, 2025 that may be closed by this pull request
ArrayChunks::into_remainder does not return None when there is no remainder #116000
Closed
@dtolnay

dtolnay commented Nov 21, 2025

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Nov 21, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 68abe69 has been approved by dtolnay

It is now in the queue for this repository.

@borsbors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 21, 2025
@dtolnaydtolnay assigned dtolnay and unassigned tgross35Nov 21, 2025
@ZalatharZalathar mentioned this pull request Nov 21, 2025
Merged
bors added a commit that referenced this pull request Nov 21, 2025
@bors
Auto merge of#149166- Zalathar:rollup-fyrwtcb, r=Zalathar
e22dab3
Rollup of 5 pull requests
Successful merges:
- #148990 (Exhaustively specify names and stability of `--print` values)
- #149127 (unwrap ret ty of `iter::ArrayChunks::into_remainder` )
- #149134 (std: sys: net: uefi: Implement read_vectored)
- #149135 (Constify `residual_into_try_type`)
- #149160 (Check for intrinsic to fn ptr casts in unified coercions)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit f8bc31a into rust-lang:mainNov 21, 2025
11 checks passed
@rustbotrustbot added this to the 1.93.0 milestone Nov 21, 2025
rust-timer added a commit that referenced this pull request Nov 21, 2025
@rust-timer
Unrolled build for#149127
52ad945
Rollup merge of #149127 - bend-n:iter_array_chunks_into_remainder_is_non_optional, r=dtolnay
unwrap ret ty of `iter::ArrayChunks::into_remainder`
changes [`iter::ArrayChunks::into_remainder`](#100450) to return `array::IntoIter` instead of `Option<array::IntoIter>` as suggested by [`@WaffleLapkin](https://github.com/rust-lang/rust/issues/100450#issuecomment-3555519025)`
@bors

bors commented Nov 21, 2025

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 68abe69 with merge e22dab3...

@bend-n
bend-n deleted the iter_array_chunks_into_remainder_is_non_optional branch November 21, 2025 07:14
@hkBst

hkBst commented Nov 21, 2025

Copy link
Copy Markdown
Member

See also #148249

@WaffleLapkinWaffleLapkin mentioned this pull request Nov 21, 2025
Closed
@Kobzol

Kobzol commented Nov 21, 2025

Copy link
Copy Markdown
Member

@bors r- retry

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 21, 2025
github-actionsBot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jan 17, 2026
@Zalathar
Rollup merge ofrust-lang#149127- bend-n:iter_array_chunks_into_rema…
76a6d0a
…inder_is_non_optional, r=dtolnay
unwrap ret ty of `iter::ArrayChunks::into_remainder`
changes [`iter::ArrayChunks::into_remainder`](rust-lang#100450) to return `array::IntoIter` instead of `Option<array::IntoIter>` as suggested by [`@WaffleLapkin](https://github.com/rust-lang/rust/issues/100450#issuecomment-3555519025)`
@mikedep333mikedep333 mentioned this pull request May 26, 2026
Closed
mikedep333 added a commit to mikedep333/Daft that referenced this pull request May 28, 2026
@mikedep333@claude
fix: update code for nightly-2026-01-08 toolchain
8a7dc31
Bump rust nightly toolchain from nightly-2025-09-03 to nightly-2026-01-08.
This picks up the ArrayChunks::into_remainder() return type change
(rust-lang/rust#149127) while staying before the cargo --timings=html
removal (rust-lang/cargo#16420), which CI still relies on.
Changes to accommodate the new nightly:
- Fix into_remainder() call in daft-minhash to match new return type
(no longer wrapped in Option) (This enables distributions to build
with Rust 1.93 stable and newer when RUSTC_BOOTSTRAP is set.)
- Upgrade cargo-llvm-cov from 0.7.1 to 0.8.7 to fix corrupt profraw
files due to LLVM profdata format incompatibility
Clippy lint fixes for newer nightly:
- Fix use_self by replacing self-referential type names with Self
across multiple enum/struct definitions
- Allow clippy::use_self on snafu-derived Error variants that use
Arc<Error> (snafu macro generates code with concrete type names,
incompatible with Self): daft-io CachedError, daft-parquet
RemoteFetchFailed
- Allow clippy::result_large_err in daft-io/src/tos.rs (IO error
types are inherently large)
- Rename clippy::only_used_in_recursion allow attributes to
clippy::self_only_used_in_recursion (lint renamed in newer clippy)
- Fix ref_as_ptr by using std::ptr::from_ref
- Fix unnecessary_unwrap in daft-sql by using if-let
- Fix unchecked_time_subtraction by using checked_sub().unwrap()
- Fix useless_vec in daft-io test
- Fix derivable_impls on PreviewFormat by using #[derive(Default)]
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@nia-enia-e added S-waiting-on-t-libs Status: Awaiting decision from T-libs and removed S-waiting-on-t-libs-api [DEPRECATED; DO NOT USE] labels Aug 10, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dtolnaydtolnaydtolnay approved these changes

Assignees

@dtolnaydtolnay

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.S-waiting-on-t-libsStatus: Awaiting decision from T-libsT-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.93.0

Development

Successfully merging this pull request may close these issues.

ArrayChunks::into_remainder does not return None when there is no remainder

8 participants

@bend-n@rustbot@tgross35@dtolnay@bors@hkBst@Kobzol@nia-e