library: upgrade to hashbrown v0.16.1

[cuviper]

This is another step toward unspecializing Copy.

See also #135634 and rust-lang/hashbrown#662

r? @Amanieu
cc @joboet

[rustbot]

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

[cuviper]

Side note: I would also like to upgrade the hashbrown dependency of the compiler, along with indexmap v2.12.1 using its new bucket API, but we can't do that until TrivialClone is in stage0 (beta).

[cuviper]

Oh, it's more tangled than I realized, because the compiler's hashbrown/nightly still needs to compile in later stages as well. So we can't fully remove the Copy specialization until TrivialClone is in stage0 and we upgrade them all.

So I'll drop that commit here.

[Amanieu]

Hashbrown updates are always perf-sensitive.

@bors try
@rust-timer queue

[rust-bors]

💥 Test timed out after 21600s

[cuviper]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: 4ae2860 (4ae2860d284fdb187a2551eb4a3625226eaac4b3, parent: e22dab387f6b4f6a87dfc54ac2f6013dddb41e68)

[rust-timer]

Finished benchmarking commit (4ae2860): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.3%, 1.3%]	2
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-0.2%	[-0.3%, -0.1%]	3
Improvements ✅ (secondary)	-0.4%	[-0.5%, -0.2%]	24
All ❌✅ (primary)	0.2%	[-0.3%, 1.3%]	5

Max RSS (memory usage)

Results (primary 1.0%, secondary -0.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.2%	[1.7%, 6.0%]	3
Regressions ❌ (secondary)	1.0%	[1.0%, 1.0%]	1
Improvements ✅ (primary)	-5.6%	[-5.6%, -5.6%]	1
Improvements ✅ (secondary)	-1.4%	[-1.4%, -1.4%]	1
All ❌✅ (primary)	1.0%	[-5.6%, 6.0%]	4

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results (primary 0.0%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.3%]	24
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.5%, -0.1%]	4
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	0.0%	[-0.5%, 0.3%]	28

Bootstrap: 473.456s -> 471.73s (-0.36%)
Artifact size: 388.90 MiB -> 388.82 MiB (-0.02%)

[Amanieu]

Seems to mostly be an improvement.

@bors r+

[bors]

📌 Commit 3a56d49 has been approved by Amanieu

It is now in the queue for this repository.

[bors]

⌛ Testing commit 3a56d49 with merge 1dd43f2...

[bors]

☀️ Test successful - checks-actions
Approved by: Amanieu
Pushing 1dd43f2 to main...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing af17d59 (parent) -> 1dd43f2 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1dd43f247e6ec20a84dd017e4665266fa65e3a89 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. aarch64-apple: 8134.8s -> 7170.7s (-11.9%)
2. dist-i686-msvc: 8225.5s -> 9082.5s (+10.4%)
3. armhf-gnu: 4897.4s -> 5390.8s (+10.1%)
4. dist-apple-various: 3724.5s -> 3408.7s (-8.5%)
5. dist-x86_64-freebsd: 4661.6s -> 5051.4s (+8.4%)
6. x86_64-mingw-1: 10677.1s -> 9900.3s (-7.3%)
7. dist-ohos-aarch64: 4380.3s -> 4680.0s (+6.8%)
8. x86_64-gnu-debug: 6238.7s -> 6634.7s (+6.3%)
9. i686-msvc-1: 10067.9s -> 10679.5s (+6.1%)
10. x86_64-gnu-llvm-21-1: 3346.6s -> 3152.4s (-5.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (1dd43f2): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

• If the regression was expected or you think it can be justified,
  please write a comment with sufficient written justification, and add
  @rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
• If you think that you know of a way to resolve the regression, try to create
  a new PR with a fix for the regression.
• If you do not understand the regression or you think that it is just noise,
  you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
  were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.4%, 1.4%]	4
Regressions ❌ (secondary)	1.5%	[1.5%, 1.5%]	1
Improvements ✅ (primary)	-0.2%	[-0.2%, -0.2%]	2
Improvements ✅ (secondary)	-0.3%	[-0.5%, -0.1%]	25
All ❌✅ (primary)	0.4%	[-0.2%, 1.4%]	6

Max RSS (memory usage)

Results (primary -1.0%, secondary -3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.1%	[2.1%, 4.0%]	2
Regressions ❌ (secondary)	1.9%	[1.9%, 1.9%]	1
Improvements ✅ (primary)	-3.8%	[-7.1%, -1.0%]	3
Improvements ✅ (secondary)	-3.6%	[-4.9%, -1.5%]	9
All ❌✅ (primary)	-1.0%	[-7.1%, 4.0%]	5

Cycles

Results (secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.0%	[1.5%, 6.6%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.4%	[-6.5%, -2.3%]	2
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.0%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.1%	[0.0%, 0.3%]	17
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.2%	[-0.4%, -0.1%]	7
Improvements ✅ (secondary)	-0.3%	[-0.3%, -0.3%]	1
All ❌✅ (primary)	-0.0%	[-0.4%, 0.3%]	24

Bootstrap: 469.465s -> 469.271s (-0.04%)
Artifact size: 388.29 MiB -> 386.21 MiB (-0.54%)

[Kobzol]

Huh, the 2.07 MiB reduction of the compiler library looks real 👀 Very interesting. Otherwise more improvements than regressions.

@rustbot label: +perf-regression-triaged

[Kobzol]

Ok no the artifact size change was noise, it fllipped back in https://perf.rust-lang.org/compare.html?start=122cbd043833a1d7540cc5f99c458bfca2d3c525&end=e9acbd99d384280874129fb7fa0da9faeae0d051&stat=cycles%3Au&tab=artifact-size.