Uh oh!
There was an error while loading. Please reload this page.
Formally deprecate numeric consts modules - #149249
Conversation
rustbot
commented
Nov 23, 2025
cc @tgross35 |
rustbot
commented
Nov 23, 2025
This comment has been minimized.
This comment has been minimized.
bstrie
commented
Nov 23, 2025
I'm unclear about the order of operations when it comes to updating compiler-builtins (which only requires a single-line change). I'll submit a PR there to make the change, but what needs to be done on the rust-lang/rust side? |
This comment has been minimized.
This comment has been minimized.
bstrie
commented
Nov 23, 2025
Actually, now I'm even more confused, because I can't actually find the equivalent line in the upstream compiler-builtins. |
d5bf725 to
4beceabCompare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
4beceab to
96f75b8Comparerustbot
commented
Nov 24, 2025
Some changes occurred in src/tools/rustfmt cc @rust-lang/rustfmt |
ChrisDenton
commented
Nov 24, 2025
Noratrieb
commented
Nov 24, 2025
@rust-lang/libs-api |
96f75b8 to
6e65dd8Compare
This comment has been minimized.
This comment has been minimized.
6e65dd8 to
026d21aComparerust-log-analyzer
commented
Nov 24, 2025
The job Click to see the possible cause of the failure (guessed by this bot) |
tgross35
commented
Dec 3, 2025
#146882 is also open, which does the deprecation but not the rest of the updates. I'll try to do a compiler-builtins sync soon. |
| #![deny(unsafe_op_in_unsafe_fn)] | ||
| #![deny(fuzzy_provenance_casts)] | ||
| #![warn(deprecated_in_future)] | ||
| #![warn(deprecated)] |
There was a problem hiding this comment.
unsure: seems like we wouldn't want this? Is it just temporary while figuring out other things?
scottmcm
commented
Jan 9, 2026
Looks like this is waiting on things other than me, so |
rustbot
commented
Jan 9, 2026
Reminder, once the PR becomes ready for a review, use |
ChrisDenton
commented
Jan 9, 2026
This needs to fix the CI errors but more to the point it needs libs-api to confirm the decision to formally mark these as deprecated. This was the plan in #68490. |
cyrgani
commented
Jan 9, 2026
FCP for this already passed in #146882. Unless I'm missing something, this PR is just a duplicate of that one? |
Oh there is an FCP on another PR. I forgot about that. Un-nominating... |
☔ The latest upstream changes (presumably #152516) made this pull request unmergeable. Please resolve the merge conflicts. |
Dylan-DPC
commented
Jun 16, 2026
Closing this in favour of #146882 since it contains the fcp for the same. |
View all comments
Long-overdue successor to #80958
Closes#68490