Uh oh!
There was an error while loading. Please reload this page.
Use let...else consistently in user-facing diagnostics - #149255
Merged
Conversation
rustbot
commented
Nov 24, 2025
Collaborator
r? @fee1-dead rustbot has assigned @fee1-dead. Use |
Kivooeo
commented
Nov 24, 2025
Member
thanks @bors r+ rollup |
bors
commented
Nov 24, 2025
Collaborator
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Nov 24, 2025
Use `let...else` consistently in user-facing diagnostics resolve: rust-lang#148772 Standardize `let...else` terminology in user-facing diagnostics. Goal: Consistently use `let...else` in all error/warning messages. Internal technical names (`let-else`) in comments and documentation remain unchanged. cc `@carols10cents,` `@jieyouxu`
bors added a commit
that referenced
this pull request
Nov 24, 2025
Rollup of 6 pull requests Successful merges: - #148234 (rustdoc: make mergeable crate info more usable) - #149201 (Add suggest alternatives for Out-of-range \x escapes) - #149208 ([rustdoc] Make more functions return `fmt::Result` and reduce number of `.unwrap()` calls) - #149252 (miri: use `tikv-jemalloc-sys` from sysroot) - #149255 (Use `let...else` consistently in user-facing diagnostics) - #149275 (Fix missing double-quote in `std::env::consts::OS` values) r? `@ghost` `@rustbot` modify labels: rollup
Uh oh!
There was an error while loading. Please reload this page.
rust-timer added a commit
that referenced
this pull request
Nov 24, 2025
Rollup merge of #149255 - reddevilmidzy:let-else, r=Kivooeo Use `let...else` consistently in user-facing diagnostics resolve: #148772 Standardize `let...else` terminology in user-facing diagnostics. Goal: Consistently use `let...else` in all error/warning messages. Internal technical names (`let-else`) in comments and documentation remain unchanged. cc ``@carols10cents,`` ``@jieyouxu``
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 25, 2025
Rollup of 6 pull requests Successful merges: - rust-lang/rust#148234 (rustdoc: make mergeable crate info more usable) - rust-lang/rust#149201 (Add suggest alternatives for Out-of-range \x escapes) - rust-lang/rust#149208 ([rustdoc] Make more functions return `fmt::Result` and reduce number of `.unwrap()` calls) - rust-lang/rust#149252 (miri: use `tikv-jemalloc-sys` from sysroot) - rust-lang/rust#149255 (Use `let...else` consistently in user-facing diagnostics) - rust-lang/rust#149275 (Fix missing double-quote in `std::env::consts::OS` values) r? `@ghost` `@rustbot` modify labels: rollup
github-actionsBot
pushed a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Nov 27, 2025
Rollup of 6 pull requests Successful merges: - rust-lang/rust#148234 (rustdoc: make mergeable crate info more usable) - rust-lang/rust#149201 (Add suggest alternatives for Out-of-range \x escapes) - rust-lang/rust#149208 ([rustdoc] Make more functions return `fmt::Result` and reduce number of `.unwrap()` calls) - rust-lang/rust#149252 (miri: use `tikv-jemalloc-sys` from sysroot) - rust-lang/rust#149255 (Use `let...else` consistently in user-facing diagnostics) - rust-lang/rust#149275 (Fix missing double-quote in `std::env::consts::OS` values) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve: #148772
Standardize
let...elseterminology in user-facing diagnostics.Goal: Consistently use
let...elsein all error/warning messages.Internal technical names (
let-else) in comments and documentation remain unchanged.cc @carols10cents, @jieyouxu