Uh oh!
There was an error while loading. Please reload this page.
Remove an unnecessary unwrap in rustc_codegen_gcc - #149449
Merged
bors merged 1 commit intoNov 29, 2025
Merged
Conversation
rustbot
commented
Nov 29, 2025
Collaborator
Some changes occurred in compiler/rustc_codegen_gcc |
workingjubilee
commented
Nov 29, 2025
Member
Yeah, it should be fine. @bors r+ |
bors
commented
Nov 29, 2025
Collaborator
Uh oh!
There was an error while loading. Please reload this page.
rust-timer added a commit
that referenced
this pull request
Nov 29, 2025
Rollup merge of #149449 - AudaciousAxiom:refactor/rustc-codegen-gcc-remove-unnecessary-unwrap, r=workingjubilee Remove an unnecessary `unwrap` in `rustc_codegen_gcc` This should hopefully unblock #149425 (I couldn't find an in-flight PR that was already doing this). I've tested locally with the `master` version of Clippy that `rustc_codegen_gcc` passes the lints (the syncing PR could still fail for other reasons however). I understand that `rustc_codegen_gcc` is normally developed [outside of this repo](https://github.com/rust-lang/rustc_codegen_gcc) but my understanding is that that repo is two-way synced regularly and hopefully it is acceptable to do this tiny change here to unblock the Clippy syncing PR (is there an established process for how to unblock these syncing PRs?). Of course feel free to close if this isn't the expected process.
antoyo
reviewed
Nov 29, 2025
Comment on lines
+506
to
509
| if let Some(location) = bx.location { | ||
| #[cfg(feature = "master")] | ||
| rvalue.set_location(bx.location.unwrap()); | ||
| rvalue.set_location(location); | ||
| } |
Contributor
There was a problem hiding this comment.
It's probably going to cause some clippy failures on our side, though.
Better would have been:
Suggested change
| ifletSome(location) = bx.location{ | |
| #[cfg(feature = "master")] | |
| rvalue.set_location(bx.location.unwrap()); | |
| rvalue.set_location(location); | |
| } | |
| #[cfg(feature = "master")] | |
| ifletSome(location) = bx.location{ | |
| rvalue.set_location(location); | |
| } |
There was a problem hiding this comment.
Hm. It seems unlikely that it would do so, @antoyo, given it fixes a clippy lint? But I will try to pay closer attention to the cfg on any PRs in this area.
Member
There was a problem hiding this comment.
I suppose it might seem weird as an "empty" conditional?
Contributor
There was a problem hiding this comment.
When the feature master is disabled, the variable location is unused. That might even be a compiler warning instead of a clippy warning.
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 9, 2025
…bzol Run clippy on cg_gcc in CI This is to prevent [this issue](rust-lang#149449 (comment)): in cg_gcc repository, we run clippy on our code but not in here, which can create issues. cc `@antoyo` r? `@Kobzol`
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Dec 10, 2025
…bzol Run clippy on cg_gcc in CI This is to prevent [this issue](rust-lang#149449 (comment)): in cg_gcc repository, we run clippy on our code but not in here, which can create issues. cc ``@antoyo`` r? ``@Kobzol``
Zalathar added a commit
to Zalathar/rust
that referenced
this pull request
Dec 10, 2025
…bzol Run clippy on cg_gcc in CI This is to prevent [this issue](rust-lang#149449 (comment)): in cg_gcc repository, we run clippy on our code but not in here, which can create issues. cc ```@antoyo``` r? ```@Kobzol```
matthiaskrgr added a commit
to matthiaskrgr/rust
that referenced
this pull request
Dec 10, 2025
…bzol Run clippy on cg_gcc in CI This is to prevent [this issue](rust-lang#149449 (comment)): in cg_gcc repository, we run clippy on our code but not in here, which can create issues. cc ````@antoyo```` r? ````@Kobzol````
makai410 pushed a commit
to makai410/rustc_public
that referenced
this pull request
Dec 10, 2025
Rollup of 3 pull requests Successful merges: - rust-lang/rust#144000 (Add `DefId::parent()` accessor for `rustc_public`) - rust-lang/rust#149409 (Test the coexistence of 'stack-protector' and 'safe-stack') - rust-lang/rust#149449 (Remove an unnecessary `unwrap` in `rustc_codegen_gcc`) r? `@ghost` `@rustbot` modify labels: rollup
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Dec 10, 2025
…gen-gcc-remove-unnecessary-unwrap, r=workingjubilee Remove an unnecessary `unwrap` in `rustc_codegen_gcc` This should hopefully unblock rust-lang#149425 (I couldn't find an in-flight PR that was already doing this). I've tested locally with the `master` version of Clippy that `rustc_codegen_gcc` passes the lints (the syncing PR could still fail for other reasons however). I understand that `rustc_codegen_gcc` is normally developed [outside of this repo](https://github.com/rust-lang/rustc_codegen_gcc) but my understanding is that that repo is two-way synced regularly and hopefully it is acceptable to do this tiny change here to unblock the Clippy syncing PR (is there an established process for how to unblock these syncing PRs?). Of course feel free to close if this isn't the expected process.
makai410 pushed a commit
to makai410/rust
that referenced
this pull request
Dec 10, 2025
Rollup of 3 pull requests Successful merges: - rust-lang#144000 (Add `DefId::parent()` accessor for `rustc_public`) - rust-lang#149409 (Test the coexistence of 'stack-protector' and 'safe-stack') - rust-lang#149449 (Remove an unnecessary `unwrap` in `rustc_codegen_gcc`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit
that referenced
this pull request
Dec 10, 2025
Rollup merge of #149458 - GuillaumeGomez:clippy-cg_gcc, r=kobzol Run clippy on cg_gcc in CI This is to prevent [this issue](#149449 (comment)): in cg_gcc repository, we run clippy on our code but not in here, which can create issues. cc ````@antoyo```` r? ````@Kobzol````
github-actionsBot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Dec 11, 2025
Run clippy on cg_gcc in CI This is to prevent [this issue](rust-lang/rust#149449 (comment)): in cg_gcc repository, we run clippy on our code but not in here, which can create issues. cc ````@antoyo```` r? ````@Kobzol````
antoyo pushed a commit
to rust-lang/rustc_codegen_gcc
that referenced
this pull request
Dec 20, 2025
Run clippy on cg_gcc in CI This is to prevent [this issue](rust-lang/rust#149449 (comment)): in cg_gcc repository, we run clippy on our code but not in here, which can create issues. cc ````@antoyo```` r? ````@Kobzol````
Kobzol pushed a commit
to Kobzol/rustc_codegen_gcc
that referenced
this pull request
Dec 21, 2025
Rollup of 3 pull requests Successful merges: - rust-lang/rust#144000 (Add `DefId::parent()` accessor for `rustc_public`) - rust-lang/rust#149409 (Test the coexistence of 'stack-protector' and 'safe-stack') - rust-lang/rust#149449 (Remove an unnecessary `unwrap` in `rustc_codegen_gcc`) r? `@ghost` `@rustbot` modify labels: rollup
Kobzol pushed a commit
to Kobzol/rustc_codegen_gcc
that referenced
this pull request
Dec 21, 2025
Run clippy on cg_gcc in CI This is to prevent [this issue](rust-lang/rust#149449 (comment)): in cg_gcc repository, we run clippy on our code but not in here, which can create issues. cc ````@antoyo```` r? ````@Kobzol````
Kobzol pushed a commit
to Kobzol/rustc_codegen_cranelift
that referenced
this pull request
Dec 29, 2025
Run clippy on cg_gcc in CI This is to prevent [this issue](rust-lang/rust#149449 (comment)): in cg_gcc repository, we run clippy on our code but not in here, which can create issues. cc ````@antoyo```` r? ````@Kobzol````
makai410 pushed a commit
to makai410/rustc_public
that referenced
this pull request
Mar 19, 2026
Rollup of 3 pull requests Successful merges: - rust-lang/rust#144000 (Add `DefId::parent()` accessor for `rustc_public`) - rust-lang/rust#149409 (Test the coexistence of 'stack-protector' and 'safe-stack') - rust-lang/rust#149449 (Remove an unnecessary `unwrap` in `rustc_codegen_gcc`) r? `@ghost` `@rustbot` modify labels: rollup
makai410 pushed a commit
to makai410/rustc_public
that referenced
this pull request
Mar 27, 2026
Rollup of 3 pull requests Successful merges: - rust-lang/rust#144000 (Add `DefId::parent()` accessor for `rustc_public`) - rust-lang/rust#149409 (Test the coexistence of 'stack-protector' and 'safe-stack') - rust-lang/rust#149449 (Remove an unnecessary `unwrap` in `rustc_codegen_gcc`) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should hopefully unblock #149425 (I couldn't find an in-flight PR that was already doing this).
I've tested locally with the
masterversion of Clippy thatrustc_codegen_gccpasses the lints (the syncing PR could still fail for other reasons however).I understand that
rustc_codegen_gccis normally developed outside of this repo but my understanding is that that repo is two-way synced regularly and hopefully it is acceptable to do this tiny change here to unblock the Clippy syncing PR (is there an established process for how to unblock these syncing PRs?). Of course feel free to close if this isn't the expected process.r? @matthiaskrgr