Uh oh!
There was an error while loading. Please reload this page.
coverage: Store signature/body spans and branch spans in the expansion tree - #149471
Conversation
rustbot
commented
Nov 30, 2025
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot
commented
Nov 30, 2025
rustbot has assigned @jdonszelmann. Use |
oli-obk
commented
Nov 30, 2025
Preexisting, but are there tests for the signature coming from a macro def, but the body from the invocation site? Or where the outer block is also part of the macro and the statements inside are from the call site? I see the code "handling" it, but not sure what the effects are |
Zalathar
commented
Nov 30, 2025
Instrumentation of macro expansions has pretty poor test coverage overall, but it was easy enough to add a new test for those specific cases. The other changes in this PR don't seem to affect the new tests, which is reassuring. |
oli-obk
commented
Nov 30, 2025
bors
commented
Nov 30, 2025
coverage: Store signature/body spans and branch spans in the expansion tree In order to support coverage instrumentation of expansion regions, we need to reduce the amount of code that assumes we're only instrumenting a flat function body. Moving more data into expansion tree nodes is an incremental step in that direction. There should be no change to compiler output.
Uh oh!
There was an error while loading. Please reload this page.
Rollup merge of #149471 - Zalathar:tree, r=oli-obk coverage: Store signature/body spans and branch spans in the expansion tree In order to support coverage instrumentation of expansion regions, we need to reduce the amount of code that assumes we're only instrumenting a flat function body. Moving more data into expansion tree nodes is an incremental step in that direction. There should be no change to compiler output.
In order to support coverage instrumentation of expansion regions, we need to reduce the amount of code that assumes we're only instrumenting a flat function body. Moving more data into expansion tree nodes is an incremental step in that direction.
There should be no change to compiler output.