Skip to content

Another attempt at Vec::extend_with via iter::repeat_n - #149751

Draft
scottmcm wants to merge 1 commit into
rust-lang:mainfrom
scottmcm:spec-repeat-n-fold
Draft

Another attempt at Vec::extend_with via iter::repeat_n#149751
scottmcm wants to merge 1 commit into
rust-lang:mainfrom
scottmcm:spec-repeat-n-fold

Conversation

@scottmcm

@scottmcmscottmcm commented Dec 8, 2025

Copy link
Copy Markdown
Member

This time, try specializing RepeatN::fold instead, since for TrivialClone it can just copy it every time.

Since this hasn't gone well in perf the last few times, start in draft and with
r? ghost

(Inspired by #133662 and #104596 but rather different from both of those)

This time, try specializing `RepeatN::fold` instead, since for `TrivialClone` it can just copy it every time.
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 8, 2025
@scottmcm

Copy link
Copy Markdown
MemberAuthor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-borsBot added a commit that referenced this pull request Dec 8, 2025
Another attempt at `Vec::extend_with` via `iter::repeat_n`
@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 8, 2025
@rust-bors

rust-borsBot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: c311241 (c311241ae75ce3e70730757e2a9b994fb92fe911, parent: ba2142a19c1acabe770433418fa395b8a0ef47a4)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (c311241): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
0.9%[0.1%, 9.7%]20
Regressions ❌
(secondary)
0.2%[0.0%, 0.3%]11
Improvements ✅
(primary)
-0.7%[-0.7%, -0.6%]2
Improvements ✅
(secondary)
-0.2%[-0.2%, -0.2%]1
All ❌✅ (primary)0.8%[-0.7%, 9.7%]22

Max RSS (memory usage)

Results (primary 2.9%, secondary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
2.9%[1.5%, 4.9%]3
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-3.2%[-3.2%, -3.2%]1
All ❌✅ (primary)2.9%[1.5%, 4.9%]3

Cycles

Results (primary 3.8%, secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
3.8%[1.4%, 10.1%]5
Regressions ❌
(secondary)
2.1%[2.1%, 2.1%]2
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)3.8%[1.4%, 10.1%]5

Binary size

Results (primary 0.0%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
0.5%[0.1%, 1.8%]28
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.4%[-1.7%, -0.0%]28
Improvements ✅
(secondary)
-0.3%[-0.3%, -0.3%]1
All ❌✅ (primary)0.0%[-1.7%, 1.8%]56

Bootstrap: 470.113s -> 473.879s (0.80%)
Artifact size: 388.98 MiB -> 389.00 MiB (0.01%)

@rustbotrustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 8, 2025
@rust-bors

rust-borsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #161990) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regressionPerformance regression.S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@scottmcm@rust-timer@rustbot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Another attempt at `Vec::extend_with` via `iter::repeat_n` by scottmcm · Pull Request #149751 · rust-lang/rust · GitHub
Skip to content

Another attempt at Vec::extend_with via iter::repeat_n - #149751

Draft
scottmcm wants to merge 1 commit into
rust-lang:mainfrom
scottmcm:spec-repeat-n-fold
Draft

Another attempt at Vec::extend_with via iter::repeat_n#149751
scottmcm wants to merge 1 commit into
rust-lang:mainfrom
scottmcm:spec-repeat-n-fold

Conversation

@scottmcm

@scottmcmscottmcm commented Dec 8, 2025

Copy link
Copy Markdown
Member

This time, try specializing RepeatN::fold instead, since for TrivialClone it can just copy it every time.

Since this hasn't gone well in perf the last few times, start in draft and with
r? ghost

(Inspired by #133662 and #104596 but rather different from both of those)

This time, try specializing `RepeatN::fold` instead, since for `TrivialClone` it can just copy it every time.
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 8, 2025
@scottmcm

Copy link
Copy Markdown
MemberAuthor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-borsBot added a commit that referenced this pull request Dec 8, 2025
Another attempt at `Vec::extend_with` via `iter::repeat_n`
@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 8, 2025
@rust-bors

rust-borsBot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: c311241 (c311241ae75ce3e70730757e2a9b994fb92fe911, parent: ba2142a19c1acabe770433418fa395b8a0ef47a4)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (c311241): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
0.9%[0.1%, 9.7%]20
Regressions ❌
(secondary)
0.2%[0.0%, 0.3%]11
Improvements ✅
(primary)
-0.7%[-0.7%, -0.6%]2
Improvements ✅
(secondary)
-0.2%[-0.2%, -0.2%]1
All ❌✅ (primary)0.8%[-0.7%, 9.7%]22

Max RSS (memory usage)

Results (primary 2.9%, secondary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
2.9%[1.5%, 4.9%]3
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-3.2%[-3.2%, -3.2%]1
All ❌✅ (primary)2.9%[1.5%, 4.9%]3

Cycles

Results (primary 3.8%, secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
3.8%[1.4%, 10.1%]5
Regressions ❌
(secondary)
2.1%[2.1%, 2.1%]2
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)3.8%[1.4%, 10.1%]5

Binary size

Results (primary 0.0%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
0.5%[0.1%, 1.8%]28
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.4%[-1.7%, -0.0%]28
Improvements ✅
(secondary)
-0.3%[-0.3%, -0.3%]1
All ❌✅ (primary)0.0%[-1.7%, 1.8%]56

Bootstrap: 470.113s -> 473.879s (0.80%)
Artifact size: 388.98 MiB -> 389.00 MiB (0.01%)

@rustbotrustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 8, 2025
@rust-bors

rust-borsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #161990) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regressionPerformance regression.S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@scottmcm@rust-timer@rustbot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Another attempt at `Vec::extend_with` via `iter::repeat_n` by scottmcm · Pull Request #149751 · rust-lang/rust · GitHub
Skip to content

Another attempt at Vec::extend_with via iter::repeat_n - #149751

Draft
scottmcm wants to merge 1 commit into
rust-lang:mainfrom
scottmcm:spec-repeat-n-fold
Draft

Another attempt at Vec::extend_with via iter::repeat_n#149751
scottmcm wants to merge 1 commit into
rust-lang:mainfrom
scottmcm:spec-repeat-n-fold

Conversation

@scottmcm

@scottmcmscottmcm commented Dec 8, 2025

Copy link
Copy Markdown
Member

This time, try specializing RepeatN::fold instead, since for TrivialClone it can just copy it every time.

Since this hasn't gone well in perf the last few times, start in draft and with
r? ghost

(Inspired by #133662 and #104596 but rather different from both of those)

This time, try specializing `RepeatN::fold` instead, since for `TrivialClone` it can just copy it every time.
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 8, 2025
@scottmcm

Copy link
Copy Markdown
MemberAuthor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-borsBot added a commit that referenced this pull request Dec 8, 2025
Another attempt at `Vec::extend_with` via `iter::repeat_n`
@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 8, 2025
@rust-bors

rust-borsBot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: c311241 (c311241ae75ce3e70730757e2a9b994fb92fe911, parent: ba2142a19c1acabe770433418fa395b8a0ef47a4)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (c311241): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
0.9%[0.1%, 9.7%]20
Regressions ❌
(secondary)
0.2%[0.0%, 0.3%]11
Improvements ✅
(primary)
-0.7%[-0.7%, -0.6%]2
Improvements ✅
(secondary)
-0.2%[-0.2%, -0.2%]1
All ❌✅ (primary)0.8%[-0.7%, 9.7%]22

Max RSS (memory usage)

Results (primary 2.9%, secondary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
2.9%[1.5%, 4.9%]3
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-3.2%[-3.2%, -3.2%]1
All ❌✅ (primary)2.9%[1.5%, 4.9%]3

Cycles

Results (primary 3.8%, secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
3.8%[1.4%, 10.1%]5
Regressions ❌
(secondary)
2.1%[2.1%, 2.1%]2
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)3.8%[1.4%, 10.1%]5

Binary size

Results (primary 0.0%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
0.5%[0.1%, 1.8%]28
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.4%[-1.7%, -0.0%]28
Improvements ✅
(secondary)
-0.3%[-0.3%, -0.3%]1
All ❌✅ (primary)0.0%[-1.7%, 1.8%]56

Bootstrap: 470.113s -> 473.879s (0.80%)
Artifact size: 388.98 MiB -> 389.00 MiB (0.01%)

@rustbotrustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 8, 2025
@rust-bors

rust-borsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #161990) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regressionPerformance regression.S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@scottmcm@rust-timer@rustbot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Another attempt at `Vec::extend_with` via `iter::repeat_n` by scottmcm · Pull Request #149751 · rust-lang/rust · GitHub
Skip to content

Another attempt at Vec::extend_with via iter::repeat_n - #149751

Draft
scottmcm wants to merge 1 commit into
rust-lang:mainfrom
scottmcm:spec-repeat-n-fold
Draft

Another attempt at Vec::extend_with via iter::repeat_n#149751
scottmcm wants to merge 1 commit into
rust-lang:mainfrom
scottmcm:spec-repeat-n-fold

Conversation

@scottmcm

@scottmcmscottmcm commented Dec 8, 2025

Copy link
Copy Markdown
Member

This time, try specializing RepeatN::fold instead, since for TrivialClone it can just copy it every time.

Since this hasn't gone well in perf the last few times, start in draft and with
r? ghost

(Inspired by #133662 and #104596 but rather different from both of those)

This time, try specializing `RepeatN::fold` instead, since for `TrivialClone` it can just copy it every time.
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 8, 2025
@scottmcm

Copy link
Copy Markdown
MemberAuthor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-borsBot added a commit that referenced this pull request Dec 8, 2025
Another attempt at `Vec::extend_with` via `iter::repeat_n`
@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 8, 2025
@rust-bors

rust-borsBot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: c311241 (c311241ae75ce3e70730757e2a9b994fb92fe911, parent: ba2142a19c1acabe770433418fa395b8a0ef47a4)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (c311241): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
0.9%[0.1%, 9.7%]20
Regressions ❌
(secondary)
0.2%[0.0%, 0.3%]11
Improvements ✅
(primary)
-0.7%[-0.7%, -0.6%]2
Improvements ✅
(secondary)
-0.2%[-0.2%, -0.2%]1
All ❌✅ (primary)0.8%[-0.7%, 9.7%]22

Max RSS (memory usage)

Results (primary 2.9%, secondary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
2.9%[1.5%, 4.9%]3
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-3.2%[-3.2%, -3.2%]1
All ❌✅ (primary)2.9%[1.5%, 4.9%]3

Cycles

Results (primary 3.8%, secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
3.8%[1.4%, 10.1%]5
Regressions ❌
(secondary)
2.1%[2.1%, 2.1%]2
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)3.8%[1.4%, 10.1%]5

Binary size

Results (primary 0.0%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
0.5%[0.1%, 1.8%]28
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.4%[-1.7%, -0.0%]28
Improvements ✅
(secondary)
-0.3%[-0.3%, -0.3%]1
All ❌✅ (primary)0.0%[-1.7%, 1.8%]56

Bootstrap: 470.113s -> 473.879s (0.80%)
Artifact size: 388.98 MiB -> 389.00 MiB (0.01%)

@rustbotrustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 8, 2025
@rust-bors

rust-borsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #161990) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regressionPerformance regression.S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@scottmcm@rust-timer@rustbot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Another attempt at `Vec::extend_with` via `iter::repeat_n` by scottmcm · Pull Request #149751 · rust-lang/rust · GitHub
Skip to content

Another attempt at Vec::extend_with via iter::repeat_n - #149751

Draft
scottmcm wants to merge 1 commit into
rust-lang:mainfrom
scottmcm:spec-repeat-n-fold
Draft

Another attempt at Vec::extend_with via iter::repeat_n#149751
scottmcm wants to merge 1 commit into
rust-lang:mainfrom
scottmcm:spec-repeat-n-fold

Conversation

@scottmcm

@scottmcmscottmcm commented Dec 8, 2025

Copy link
Copy Markdown
Member

This time, try specializing RepeatN::fold instead, since for TrivialClone it can just copy it every time.

Since this hasn't gone well in perf the last few times, start in draft and with
r? ghost

(Inspired by #133662 and #104596 but rather different from both of those)

This time, try specializing `RepeatN::fold` instead, since for `TrivialClone` it can just copy it every time.
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 8, 2025
@scottmcm

Copy link
Copy Markdown
MemberAuthor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-borsBot added a commit that referenced this pull request Dec 8, 2025
Another attempt at `Vec::extend_with` via `iter::repeat_n`
@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 8, 2025
@rust-bors

rust-borsBot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: c311241 (c311241ae75ce3e70730757e2a9b994fb92fe911, parent: ba2142a19c1acabe770433418fa395b8a0ef47a4)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (c311241): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
0.9%[0.1%, 9.7%]20
Regressions ❌
(secondary)
0.2%[0.0%, 0.3%]11
Improvements ✅
(primary)
-0.7%[-0.7%, -0.6%]2
Improvements ✅
(secondary)
-0.2%[-0.2%, -0.2%]1
All ❌✅ (primary)0.8%[-0.7%, 9.7%]22

Max RSS (memory usage)

Results (primary 2.9%, secondary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
2.9%[1.5%, 4.9%]3
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-3.2%[-3.2%, -3.2%]1
All ❌✅ (primary)2.9%[1.5%, 4.9%]3

Cycles

Results (primary 3.8%, secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
3.8%[1.4%, 10.1%]5
Regressions ❌
(secondary)
2.1%[2.1%, 2.1%]2
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)3.8%[1.4%, 10.1%]5

Binary size

Results (primary 0.0%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
0.5%[0.1%, 1.8%]28
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.4%[-1.7%, -0.0%]28
Improvements ✅
(secondary)
-0.3%[-0.3%, -0.3%]1
All ❌✅ (primary)0.0%[-1.7%, 1.8%]56

Bootstrap: 470.113s -> 473.879s (0.80%)
Artifact size: 388.98 MiB -> 389.00 MiB (0.01%)

@rustbotrustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 8, 2025
@rust-bors

rust-borsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #161990) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regressionPerformance regression.S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@scottmcm@rust-timer@rustbot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Another attempt at `Vec::extend_with` via `iter::repeat_n` by scottmcm · Pull Request #149751 · rust-lang/rust · GitHub
Skip to content

Another attempt at Vec::extend_with via iter::repeat_n - #149751

Draft
scottmcm wants to merge 1 commit into
rust-lang:mainfrom
scottmcm:spec-repeat-n-fold
Draft

Another attempt at Vec::extend_with via iter::repeat_n#149751
scottmcm wants to merge 1 commit into
rust-lang:mainfrom
scottmcm:spec-repeat-n-fold

Conversation

@scottmcm

@scottmcmscottmcm commented Dec 8, 2025

Copy link
Copy Markdown
Member

This time, try specializing RepeatN::fold instead, since for TrivialClone it can just copy it every time.

Since this hasn't gone well in perf the last few times, start in draft and with
r? ghost

(Inspired by #133662 and #104596 but rather different from both of those)

This time, try specializing `RepeatN::fold` instead, since for `TrivialClone` it can just copy it every time.
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 8, 2025
@scottmcm

Copy link
Copy Markdown
MemberAuthor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-borsBot added a commit that referenced this pull request Dec 8, 2025
Another attempt at `Vec::extend_with` via `iter::repeat_n`
@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 8, 2025
@rust-bors

rust-borsBot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: c311241 (c311241ae75ce3e70730757e2a9b994fb92fe911, parent: ba2142a19c1acabe770433418fa395b8a0ef47a4)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (c311241): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
0.9%[0.1%, 9.7%]20
Regressions ❌
(secondary)
0.2%[0.0%, 0.3%]11
Improvements ✅
(primary)
-0.7%[-0.7%, -0.6%]2
Improvements ✅
(secondary)
-0.2%[-0.2%, -0.2%]1
All ❌✅ (primary)0.8%[-0.7%, 9.7%]22

Max RSS (memory usage)

Results (primary 2.9%, secondary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
2.9%[1.5%, 4.9%]3
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-3.2%[-3.2%, -3.2%]1
All ❌✅ (primary)2.9%[1.5%, 4.9%]3

Cycles

Results (primary 3.8%, secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
3.8%[1.4%, 10.1%]5
Regressions ❌
(secondary)
2.1%[2.1%, 2.1%]2
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)3.8%[1.4%, 10.1%]5

Binary size

Results (primary 0.0%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
0.5%[0.1%, 1.8%]28
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.4%[-1.7%, -0.0%]28
Improvements ✅
(secondary)
-0.3%[-0.3%, -0.3%]1
All ❌✅ (primary)0.0%[-1.7%, 1.8%]56

Bootstrap: 470.113s -> 473.879s (0.80%)
Artifact size: 388.98 MiB -> 389.00 MiB (0.01%)

@rustbotrustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 8, 2025
@rust-bors

rust-borsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #161990) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regressionPerformance regression.S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@scottmcm@rust-timer@rustbot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Another attempt at `Vec::extend_with` via `iter::repeat_n` by scottmcm · Pull Request #149751 · rust-lang/rust · GitHub
Skip to content

Another attempt at Vec::extend_with via iter::repeat_n - #149751

Draft
scottmcm wants to merge 1 commit into
rust-lang:mainfrom
scottmcm:spec-repeat-n-fold
Draft

Another attempt at Vec::extend_with via iter::repeat_n#149751
scottmcm wants to merge 1 commit into
rust-lang:mainfrom
scottmcm:spec-repeat-n-fold

Conversation

@scottmcm

@scottmcmscottmcm commented Dec 8, 2025

Copy link
Copy Markdown
Member

This time, try specializing RepeatN::fold instead, since for TrivialClone it can just copy it every time.

Since this hasn't gone well in perf the last few times, start in draft and with
r? ghost

(Inspired by #133662 and #104596 but rather different from both of those)

This time, try specializing `RepeatN::fold` instead, since for `TrivialClone` it can just copy it every time.
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 8, 2025
@scottmcm

Copy link
Copy Markdown
MemberAuthor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-borsBot added a commit that referenced this pull request Dec 8, 2025
Another attempt at `Vec::extend_with` via `iter::repeat_n`
@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 8, 2025
@rust-bors

rust-borsBot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: c311241 (c311241ae75ce3e70730757e2a9b994fb92fe911, parent: ba2142a19c1acabe770433418fa395b8a0ef47a4)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (c311241): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
0.9%[0.1%, 9.7%]20
Regressions ❌
(secondary)
0.2%[0.0%, 0.3%]11
Improvements ✅
(primary)
-0.7%[-0.7%, -0.6%]2
Improvements ✅
(secondary)
-0.2%[-0.2%, -0.2%]1
All ❌✅ (primary)0.8%[-0.7%, 9.7%]22

Max RSS (memory usage)

Results (primary 2.9%, secondary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
2.9%[1.5%, 4.9%]3
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-3.2%[-3.2%, -3.2%]1
All ❌✅ (primary)2.9%[1.5%, 4.9%]3

Cycles

Results (primary 3.8%, secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
3.8%[1.4%, 10.1%]5
Regressions ❌
(secondary)
2.1%[2.1%, 2.1%]2
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)3.8%[1.4%, 10.1%]5

Binary size

Results (primary 0.0%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
0.5%[0.1%, 1.8%]28
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.4%[-1.7%, -0.0%]28
Improvements ✅
(secondary)
-0.3%[-0.3%, -0.3%]1
All ❌✅ (primary)0.0%[-1.7%, 1.8%]56

Bootstrap: 470.113s -> 473.879s (0.80%)
Artifact size: 388.98 MiB -> 389.00 MiB (0.01%)

@rustbotrustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 8, 2025
@rust-bors

rust-borsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #161990) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regressionPerformance regression.S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@scottmcm@rust-timer@rustbot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Another attempt at `Vec::extend_with` via `iter::repeat_n` by scottmcm · Pull Request #149751 · rust-lang/rust · GitHub
Skip to content

Another attempt at Vec::extend_with via iter::repeat_n - #149751

Draft
scottmcm wants to merge 1 commit into
rust-lang:mainfrom
scottmcm:spec-repeat-n-fold
Draft

Another attempt at Vec::extend_with via iter::repeat_n#149751
scottmcm wants to merge 1 commit into
rust-lang:mainfrom
scottmcm:spec-repeat-n-fold

Conversation

@scottmcm

@scottmcmscottmcm commented Dec 8, 2025

Copy link
Copy Markdown
Member

This time, try specializing RepeatN::fold instead, since for TrivialClone it can just copy it every time.

Since this hasn't gone well in perf the last few times, start in draft and with
r? ghost

(Inspired by #133662 and #104596 but rather different from both of those)

This time, try specializing `RepeatN::fold` instead, since for `TrivialClone` it can just copy it every time.
@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 8, 2025
@scottmcm

Copy link
Copy Markdown
MemberAuthor

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors

This comment has been minimized.

rust-borsBot added a commit that referenced this pull request Dec 8, 2025
Another attempt at `Vec::extend_with` via `iter::repeat_n`
@rustbotrustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 8, 2025
@rust-bors

rust-borsBot commented Dec 8, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: c311241 (c311241ae75ce3e70730757e2a9b994fb92fe911, parent: ba2142a19c1acabe770433418fa395b8a0ef47a4)

@rust-timer

This comment has been minimized.

@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (c311241): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please do so in sufficient writing along with @rustbot label: +perf-regression-triaged. If not, please fix the regressions and do another perf run. If its results are neutral or positive, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

meanrangecount
Regressions ❌
(primary)
0.9%[0.1%, 9.7%]20
Regressions ❌
(secondary)
0.2%[0.0%, 0.3%]11
Improvements ✅
(primary)
-0.7%[-0.7%, -0.6%]2
Improvements ✅
(secondary)
-0.2%[-0.2%, -0.2%]1
All ❌✅ (primary)0.8%[-0.7%, 9.7%]22

Max RSS (memory usage)

Results (primary 2.9%, secondary -3.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
2.9%[1.5%, 4.9%]3
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
-3.2%[-3.2%, -3.2%]1
All ❌✅ (primary)2.9%[1.5%, 4.9%]3

Cycles

Results (primary 3.8%, secondary 2.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
3.8%[1.4%, 10.1%]5
Regressions ❌
(secondary)
2.1%[2.1%, 2.1%]2
Improvements ✅
(primary)
--0
Improvements ✅
(secondary)
--0
All ❌✅ (primary)3.8%[1.4%, 10.1%]5

Binary size

Results (primary 0.0%, secondary -0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

meanrangecount
Regressions ❌
(primary)
0.5%[0.1%, 1.8%]28
Regressions ❌
(secondary)
--0
Improvements ✅
(primary)
-0.4%[-1.7%, -0.0%]28
Improvements ✅
(secondary)
-0.3%[-0.3%, -0.3%]1
All ❌✅ (primary)0.0%[-1.7%, 1.8%]56

Bootstrap: 470.113s -> 473.879s (0.80%)
Artifact size: 388.98 MiB -> 389.00 MiB (0.01%)

@rustbotrustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Dec 8, 2025
@rust-bors

rust-borsBot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #161990) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

perf-regressionPerformance regression.S-waiting-on-authorStatus: This is awaiting some action (such as code changes or more information) from the author.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@scottmcm@rust-timer@rustbot