Skip to content

add regression test for proc_macro error subdiagnostics - #149883

Merged
bors merged 1 commit into
rust-lang:mainfrom
cyrgani:sub-err-diag
Dec 12, 2025
Merged

add regression test for proc_macro error subdiagnostics#149883
bors merged 1 commit into
rust-lang:mainfrom
cyrgani:sub-err-diag

Conversation

@cyrgani

@cyrganicyrgani commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

The previous ICE was already fixed by #148188, but no test was added at that time.
Closes#145305.

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 11, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

@cyrganicyrgani changed the title add regression test for issue #145305add regression test for proc_macro error subdiagnosticsDec 11, 2025
@Kivooeo

Copy link
Copy Markdown
Member

r? me

@bors r+ rollup

@bors

bors commented Dec 12, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 43fa2a9 has been approved by Kivooeo

It is now in the queue for this repository.

@rustbotrustbot assigned Kivooeo and unassigned davidtwcoDec 12, 2025
@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 12, 2025
add regression test for `proc_macro` error subdiagnostics
The previous ICE was already fixed by rust-lang#148188, but no test was added at that time.
Closesrust-lang#145305.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 12, 2025
add regression test for `proc_macro` error subdiagnostics
The previous ICE was already fixed by rust-lang#148188, but no test was added at that time.
Closesrust-lang#145305.
bors added a commit that referenced this pull request Dec 12, 2025
Rollup of 7 pull requests
Successful merges:
- #149655 (bootstrap: add rustc-dev install target)
- #149789 (Cleanup in the attribute parsers)
- #149791 (Remove uses of `cfg({any()/all()})`)
- #149792 (Suggest `cfg(false)` instead of `cfg(FALSE)`)
- #149883 (add regression test for `proc_macro` error subdiagnostics)
- #149884 (Clippy subtree update)
- #149896 (Add myself(makai410) to the review rotation)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1553fcc into rust-lang:mainDec 12, 2025
11 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Dec 12, 2025
rust-timer added a commit that referenced this pull request Dec 12, 2025
Rollup merge of #149883 - cyrgani:sub-err-diag, r=Kivooeo
add regression test for `proc_macro` error subdiagnostics
The previous ICE was already fixed by #148188, but no test was added at that time.
Closes#145305.
@cyrgani
cyrgani deleted the sub-err-diag branch December 12, 2025 18:06
Kobzol pushed a commit to Kobzol/rustc_codegen_cranelift that referenced this pull request Dec 29, 2025
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#149655 (bootstrap: add rustc-dev install target)
- rust-lang/rust#149789 (Cleanup in the attribute parsers)
- rust-lang/rust#149791 (Remove uses of `cfg({any()/all()})`)
- rust-lang/rust#149792 (Suggest `cfg(false)` instead of `cfg(FALSE)`)
- rust-lang/rust#149883 (add regression test for `proc_macro` error subdiagnostics)
- rust-lang/rust#149884 (Clippy subtree update)
- rust-lang/rust#149896 (Add myself(makai410) to the review rotation)
r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#149655 (bootstrap: add rustc-dev install target)
- rust-lang/rust#149789 (Cleanup in the attribute parsers)
- rust-lang/rust#149791 (Remove uses of `cfg({any()/all()})`)
- rust-lang/rust#149792 (Suggest `cfg(false)` instead of `cfg(FALSE)`)
- rust-lang/rust#149883 (add regression test for `proc_macro` error subdiagnostics)
- rust-lang/rust#149884 (Clippy subtree update)
- rust-lang/rust#149896 (Add myself(makai410) to the review rotation)
r? `@ghost`
`@rustbot` modify labels: rollup
christian-schilling pushed a commit to christian-schilling/rustc_codegen_cranelift that referenced this pull request Jan 27, 2026
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#149655 (bootstrap: add rustc-dev install target)
- rust-lang/rust#149789 (Cleanup in the attribute parsers)
- rust-lang/rust#149791 (Remove uses of `cfg({any()/all()})`)
- rust-lang/rust#149792 (Suggest `cfg(false)` instead of `cfg(FALSE)`)
- rust-lang/rust#149883 (add regression test for `proc_macro` error subdiagnostics)
- rust-lang/rust#149884 (Clippy subtree update)
- rust-lang/rust#149896 (Add myself(makai410) to the review rotation)
r? `@ghost`
`@rustbot` modify labels: rollup
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
Rollup of 7 pull requests
Successful merges:
- rust-lang/rust#149655 (bootstrap: add rustc-dev install target)
- rust-lang/rust#149789 (Cleanup in the attribute parsers)
- rust-lang/rust#149791 (Remove uses of `cfg({any()/all()})`)
- rust-lang/rust#149792 (Suggest `cfg(false)` instead of `cfg(FALSE)`)
- rust-lang/rust#149883 (add regression test for `proc_macro` error subdiagnostics)
- rust-lang/rust#149884 (Clippy subtree update)
- rust-lang/rust#149896 (Add myself(makai410) to the review rotation)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proc-Macro-Diagnostics allow error subdiagnostics

5 participants

@cyrgani@rustbot@Kivooeo@bors@davidtwco