Skip to content

Add dist step for Enzyme - #150071

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
Kobzol:dist-enzyme
Jan 20, 2026
Merged

Add dist step for Enzyme#150071
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
Kobzol:dist-enzyme

Conversation

@Kobzol

@KobzolKobzol commented Dec 16, 2025

Copy link
Copy Markdown
Member

View all comments

Now that Enzyme can be distributed as a separate dylib outside libLLVM.so, we can create a dist step for it. This is the bulk of the work required to make it distributable through rustup, once CI works and we check that the built component works locally, we can add it to Rustup through the manifest.

Note that this PR does not enable Enzyme distribution in CI yet, it just adds the dist step.

r? @ZuseZ4

try-job: dist-x86_64-linux

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 16, 2025
@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors try

rust-borsBot added a commit that referenced this pull request Dec 16, 2025
Add dist step for Enzyme
try-job: dist-x86_64-linux
@rust-bors

This comment has been minimized.

@rust-bors

rust-borsBot commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

💥 Test timed out after 21600s

@ZuseZ4

Copy link
Copy Markdown
Member

@bors try

@rust-bors

This comment has been minimized.

rust-borsBot added a commit that referenced this pull request Dec 17, 2025
Add dist step for Enzyme
try-job: dist-x86_64-linux
@rust-log-analyzer

This comment has been minimized.

@rust-bors

rust-borsBot commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

💔 Test for bf1f04d failed: CI. Failed jobs:

@bors

bors commented Dec 17, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #150079) made this pull request unmergeable. Please resolve the merge conflicts.

@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors try

@rust-bors

This comment has been minimized.

rust-borsBot added a commit that referenced this pull request Dec 17, 2025
Add dist step for Enzyme
try-job: dist-x86_64-linux
@rust-bors

rust-borsBot commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: a568d9b (a568d9bf324e8d69f450caa907dd6bcbd610b825, parent: f2c70877a7dbc51cd98e2d5d25209b24d4a586d5)

builder.compiler(target_compiler.stage - 1, builder.config.host_target);

// Build enzyme
if builder.config.llvm_enzyme && !builder.config.dry_run() {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore if it's just for testing, but the dry_run check was needed as bugfix for something, might have been check builds.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I don't understand why something is in bootstrap, I usually remove it, then wait if something breaks, and if it does, I readd it back with a comment, so that we know why it is there :)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a test which would fail if you hadn't disabled them :P But I can add a note in one of the PRs.

@bors

bors commented Dec 29, 2025

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #150481) made this pull request unmergeable. Please resolve the merge conflicts.

@Kobzol

Copy link
Copy Markdown
MemberAuthor

@bors try

@rust-bors

This comment has been minimized.

rust-borsBot pushed a commit that referenced this pull request Jan 15, 2026
Add dist step for Enzyme
try-job: dist-x86_64-linux
@rust-bors

rust-borsBot commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: b684cce (b684cceece5c21c3b065b21785980d857551ae5f, parent: a6acf0f07f0ed1c12e26dc0db3b9bf1d0504a0bb)

@Kobzol

Copy link
Copy Markdown
MemberAuthor

I removed the last commit that enabled building Enzyme on CI, because @ZuseZ4 told me that he wants to make some improvements to Enzyme before that.

@Kobzol
Kobzol marked this pull request as ready for review January 15, 2026 15:37
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 15, 2026
@ZuseZ4

Copy link
Copy Markdown
Member

I just confirmed that this can be used to build working artifacts for both linux and macos.
As mentioned, there's still a bit of cleanup left to do, so it's good that we don't enable the artifacts yet.

@bors r+

@rust-bors

rust-borsBot commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 85e01e3 has been approved by ZuseZ4

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2026
Zalathar added a commit to Zalathar/rust that referenced this pull request Jan 20, 2026
Add dist step for Enzyme
Now that Enzyme can be distributed as a separate dylib outside libLLVM.so, we can create a dist step for it. This is the bulk of the work required to make it distributable through rustup, once CI works and we check that the built component works locally, we can add it to Rustup through the manifest.
Note that this PR does not enable Enzyme distribution in CI yet, it just adds the dist step.
r? @ZuseZ4
try-job: dist-x86_64-linux
This was referenced Jan 20, 2026
rust-borsBot pushed a commit that referenced this pull request Jan 20, 2026
Rollup of 8 pull requests
Successful merges:
- #149587 (coverage: Sort the expansion tree to help choose a single BCB for child expansions)
- #150071 (Add dist step for Enzyme)
- #150288 (Add scalar support for offload)
- #151091 (Add new "hide deprecated items" setting in rustdoc)
- #151255 (rustdoc: Fix ICE when deprecated note is not resolved on the correct `DefId`)
- #151375 (Fix terminal width dependent tests)
- #151384 (add basic `TokenStream` api tests)
- #151391 (rustc-dev-guide subtree update)
r? @ghost
@rust-bors
rust-borsBot merged commit 02ee05a into rust-lang:mainJan 20, 2026
11 checks passed
@rustbotrustbot added this to the 1.95.0 milestone Jan 20, 2026
@Kobzol
Kobzol deleted the dist-enzyme branch January 20, 2026 12:52
rust-timer added a commit that referenced this pull request Jan 20, 2026
Rollup merge of #150071 - dist-enzyme, r=ZuseZ4
Add dist step for Enzyme
Now that Enzyme can be distributed as a separate dylib outside libLLVM.so, we can create a dist step for it. This is the bulk of the work required to make it distributable through rustup, once CI works and we check that the built component works locally, we can add it to Rustup through the manifest.
Note that this PR does not enable Enzyme distribution in CI yet, it just adds the dist step.
r? @ZuseZ4
try-job: dist-x86_64-linux
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Jan 20, 2026
Rollup of 8 pull requests
Successful merges:
- rust-lang/rust#149587 (coverage: Sort the expansion tree to help choose a single BCB for child expansions)
- rust-lang/rust#150071 (Add dist step for Enzyme)
- rust-lang/rust#150288 (Add scalar support for offload)
- rust-lang/rust#151091 (Add new "hide deprecated items" setting in rustdoc)
- rust-lang/rust#151255 (rustdoc: Fix ICE when deprecated note is not resolved on the correct `DefId`)
- rust-lang/rust#151375 (Fix terminal width dependent tests)
- rust-lang/rust#151384 (add basic `TokenStream` api tests)
- rust-lang/rust#151391 (rustc-dev-guide subtree update)
r? @ghost
@ZuseZ4ZuseZ4 added the F-autodiff `#![feature(autodiff)]` label Mar 28, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CIArea: Our Github Actions CIA-testsuiteArea: The testsuite used to check the correctness of rustcF-autodiff`#![feature(autodiff)]`S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@Kobzol@ZuseZ4@rust-log-analyzer@bors@rustbot