Skip to content

GVN: Adds the insert_unique method - #150223

Merged
bors merged 1 commit into
rust-lang:mainfrom
dianqk:gvn-insert_unique
Dec 22, 2025
Merged

GVN: Adds the insert_unique method#150223
bors merged 1 commit into
rust-lang:mainfrom
dianqk:gvn-insert_unique

Conversation

@dianqk

@dianqkdianqk commented Dec 21, 2025

Copy link
Copy Markdown
Member

The new insert_unique method is used to handle IndexVec<VnIndex, T> such as evaluated and rev_locals.

@rustbot

rustbot commented Dec 21, 2025

Copy link
Copy Markdown
Collaborator

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 21, 2025
@rustbot

rustbot commented Dec 21, 2025

Copy link
Copy Markdown
Collaborator

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@dianqk

dianqk commented Dec 21, 2025

Copy link
Copy Markdown
MemberAuthor

@bors rollup

@dianqkdianqk added A-mir-opt Area: MIR optimizations A-mir-opt-GVN Area: MIR opt Global Value Numbering (GVN) labels Dec 21, 2025
@cjgillot

cjgillot commented Dec 21, 2025

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Dec 21, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 37af3f6 has been approved by cjgillot

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 21, 2025
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 21, 2025
@JonathanBrouwer
Rollup merge ofrust-lang#150223- dianqk:gvn-insert_unique, r=cjgillot
036831e
GVN: Adds the `insert_unique` method
The new `insert_unique` method is used to handle `IndexVec<VnIndex, T>` such as `evaluated` and `rev_locals`.
This was referenced Dec 21, 2025
Closed
Merged
bors added a commit that referenced this pull request Dec 21, 2025
@bors
Auto merge of#150231- JonathanBrouwer:rollup-btei0hm, r=JonathanBro…
f41f404
…uwer
Rollup of 4 pull requests
Successful merges:
- #149512 (Fix d32 usage in Arm target specs )
- #150210 (tests/debuginfo/function-arg-initialization.rs: Stop disabling SingleUseConsts MIR pass)
- #150221 (rustdoc: handle macro expansions in types)
- #150223 (GVN: Adds the `insert_unique` method)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 4b94235 into rust-lang:mainDec 22, 2025
11 checks passed
rust-timer added a commit that referenced this pull request Dec 22, 2025
@rust-timer
Unrolled build for#150223
e60acee
Rollup merge of #150223 - dianqk:gvn-insert_unique, r=cjgillot
GVN: Adds the `insert_unique` method
The new `insert_unique` method is used to handle `IndexVec<VnIndex, T>` such as `evaluated` and `rev_locals`.
@rustbotrustbot added this to the 1.94.0 milestone Dec 22, 2025
@dianqk
dianqk deleted the gvn-insert_unique branch December 22, 2025 02:34
@github-actionsgithub-actionsBot mentioned this pull request Dec 23, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jackh726jackh726

Labels

A-mir-optArea: MIR optimizationsA-mir-opt-GVNArea: MIR opt Global Value Numbering (GVN)S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.94.0

Development

Successfully merging this pull request may close these issues.

5 participants

@dianqk@rustbot@cjgillot@bors@jackh726