Skip to content

Fix compilation error in hermit-abi time.rs - #150295

Merged
bors merged 1 commit into
rust-lang:mainfrom
forkgull:notgull/hermit-fix
Dec 23, 2025
Merged

Fix compilation error in hermit-abi time.rs#150295
bors merged 1 commit into
rust-lang:mainfrom
forkgull:notgull/hermit-fix

Conversation

@notgull

@notgullnotgull commented Dec 23, 2025

Copy link
Copy Markdown
Contributor

Fixes time.rs by updating the MIN and MAX structs appropraitely.

Fixes#150294

@rustbotrustbot added O-hermit Operating System: Hermit S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 23, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

r? @ChrisDenton

rustbot has assigned @ChrisDenton.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

Fixes time.rs by updating the MIN and MAX structs appropriately.
Signed-off-by: John Nunley <dev@notgull.net>
@notgull

Copy link
Copy Markdown
ContributorAuthor

Looks like this was done by accident as part of #148825

@joboet

Copy link
Copy Markdown
Member

Looks that way...
@bors r+ rollup
r? joboet

@bors

bors commented Dec 23, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit 2c0f14c has been approved by joboet

It is now in the queue for this repository.

@rustbotrustbot assigned joboet and unassigned ChrisDentonDec 23, 2025
@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 23, 2025
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Dec 23, 2025
Fix compilation error in hermit-abi time.rs
Fixes time.rs by updating the MIN and MAX structs appropraitely.
Fixesrust-lang#150294
bors added a commit that referenced this pull request Dec 23, 2025
…uwer
Rollup of 3 pull requests
Successful merges:
- #150205 (compiletest: Add `LineNumber` newtype to avoid `+1` magic here and there)
- #150295 (Fix compilation error in hermit-abi time.rs)
- #150301 (std: remove unsupported pipe module from VEXos pal)
r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Dec 23, 2025
…uwer
Rollup of 6 pull requests
Successful merges:
- #150130 (Support syntax for one-line trait reuse)
- #150205 (compiletest: Add `LineNumber` newtype to avoid `+1` magic here and there)
- #150282 (move a ui test to coretests unit test)
- #150295 (Fix compilation error in hermit-abi time.rs)
- #150301 (std: remove unsupported pipe module from VEXos pal)
- #150303 (`target_features::Stability`: tweak docs of `requires_nightly()`)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 6ca7f0d into rust-lang:mainDec 23, 2025
11 checks passed
@rustbotrustbot added this to the 1.94.0 milestone Dec 23, 2025
rust-timer added a commit that referenced this pull request Dec 23, 2025
Rollup merge of #150295 - forkgull:notgull/hermit-fix, r=joboet
Fix compilation error in hermit-abi time.rs
Fixes time.rs by updating the MIN and MAX structs appropraitely.
Fixes#150294
@notgull
notgull deleted the notgull/hermit-fix branch December 23, 2025 18:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

O-hermitOperating System: HermitS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pal::hermit::time::SystemTime is not compiling in libstd for Hermit ABI

5 participants

@notgull@rustbot@joboet@bors@ChrisDenton